Re: [patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-27 Thread Fengguang Wu
Hi Michael, // sorry for the delay... On Mon, Dec 10, 2007 at 06:02:55PM -0800, Michael Rubin wrote: > From: Michael Rubin <[EMAIL PROTECTED]> > > Fixing a bug where writing to large files while concurrently writing to > smaller ones creates a situation where writeback cannot keep up with the >

Re: [patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-27 Thread Fengguang Wu
Hi Michael, // sorry for the delay... On Mon, Dec 10, 2007 at 06:02:55PM -0800, Michael Rubin wrote: From: Michael Rubin [EMAIL PROTECTED] Fixing a bug where writing to large files while concurrently writing to smaller ones creates a situation where writeback cannot keep up with the

Re: [patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-12 Thread Michael Rubin
On Dec 12, 2007 12:55 PM, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > On Mon, 2007-12-10 at 18:02 -0800, Michael Rubin wrote: > > From: Michael Rubin <[EMAIL PROTECTED]> > The part I miss here is the rationale on _how_ you solve the problem. > > The patch itself is simple enough, but I've been

Re: [patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-12 Thread Peter Zijlstra
On Mon, 2007-12-10 at 18:02 -0800, Michael Rubin wrote: > From: Michael Rubin <[EMAIL PROTECTED]> > > Fixing a bug where writing to large files while concurrently writing to > smaller ones creates a situation where writeback cannot keep up with the > traffic and memory baloons until the we hit

Re: [patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-12 Thread Peter Zijlstra
On Mon, 2007-12-10 at 18:02 -0800, Michael Rubin wrote: From: Michael Rubin [EMAIL PROTECTED] Fixing a bug where writing to large files while concurrently writing to smaller ones creates a situation where writeback cannot keep up with the traffic and memory baloons until the we hit the

Re: [patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-12 Thread Michael Rubin
On Dec 12, 2007 12:55 PM, Peter Zijlstra [EMAIL PROTECTED] wrote: On Mon, 2007-12-10 at 18:02 -0800, Michael Rubin wrote: From: Michael Rubin [EMAIL PROTECTED] The part I miss here is the rationale on _how_ you solve the problem. The patch itself is simple enough, but I've been staring at

[patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-10 Thread Michael Rubin
From: Michael Rubin <[EMAIL PROTECTED]> Fixing a bug where writing to large files while concurrently writing to smaller ones creates a situation where writeback cannot keep up with the traffic and memory baloons until the we hit the threshold watermark. This can result in surprising latency

[patch 1/1] Writeback fix for concurrent large and small file writes.

2007-12-10 Thread Michael Rubin
From: Michael Rubin [EMAIL PROTECTED] Fixing a bug where writing to large files while concurrently writing to smaller ones creates a situation where writeback cannot keep up with the traffic and memory baloons until the we hit the threshold watermark. This can result in surprising latency spikes

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-12-04 Thread Michael Rubin
On Nov 29, 2007 5:32 PM, Fengguang Wu <[EMAIL PROTECTED]: > > On Nov 28, 2007 4:34 PM, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > > Could you demonstrate the situation? Or if I guess it right, could it > > > be fixed by the following patch? Feng I am sorry to have been mistaken but I reran my

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-12-04 Thread Michael Rubin
On Nov 29, 2007 5:32 PM, Fengguang Wu [EMAIL PROTECTED]: On Nov 28, 2007 4:34 PM, Fengguang Wu [EMAIL PROTECTED] wrote: Could you demonstrate the situation? Or if I guess it right, could it be fixed by the following patch? Feng I am sorry to have been mistaken but I reran my tests and I

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Fengguang Wu
On Thu, Nov 29, 2007 at 12:16:36PM -0800, Michael Rubin wrote: > Due to my faux pas of top posting (see > http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt) I am > resending this email. > > On Nov 28, 2007 4:34 PM, Fengguang Wu <[EMAIL PROTECTED]> wrote: > > Could you demonstrate

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Michael Rubin
Due to my faux pas of top posting (see http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt) I am resending this email. On Nov 28, 2007 4:34 PM, Fengguang Wu <[EMAIL PROTECTED]> wrote: > Could you demonstrate the situation? Or if I guess it right, could it > be fixed by the following

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Michael Rubin
:21 -0800 > > From: [EMAIL PROTECTED] > > To: [EMAIL PROTECTED] > > Subject: [patch 1/1] Writeback fix for concurrent large and small file > > writes. > > > > From: Michael Rubin <[EMAIL PROTECTED]> > > > > Fixing a bug where writing to large files

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Michael Rubin
PROTECTED] Subject: [patch 1/1] Writeback fix for concurrent large and small file writes. From: Michael Rubin [EMAIL PROTECTED] Fixing a bug where writing to large files while concurrently writing to smaller ones creates a situation where writeback cannot keep up with the Could you

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Michael Rubin
Due to my faux pas of top posting (see http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt) I am resending this email. On Nov 28, 2007 4:34 PM, Fengguang Wu [EMAIL PROTECTED] wrote: Could you demonstrate the situation? Or if I guess it right, could it be fixed by the following

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-29 Thread Fengguang Wu
On Thu, Nov 29, 2007 at 12:16:36PM -0800, Michael Rubin wrote: Due to my faux pas of top posting (see http://www.zip.com.au/~akpm/linux/patches/stuff/top-posting.txt) I am resending this email. On Nov 28, 2007 4:34 PM, Fengguang Wu [EMAIL PROTECTED] wrote: Could you demonstrate the

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Michael Rubin
Thank you. Integrated the fixes in my patch. On Nov 28, 2007 6:13 PM, Frans Pop <[EMAIL PROTECTED]> wrote: > Two typos in comments. > > Cheers, > FJP > > Michael Rubin wrote: > > + * The flush tree organizes the dirtied_when keys with the rb_tree. Any > > + * inodes with a duplicate dirtied_when

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Frans Pop
Two typos in comments. Cheers, FJP Michael Rubin wrote: > + * The flush tree organizes the dirtied_when keys with the rb_tree. Any > + * inodes with a duplicate dirtied_when value are link listed together. > This + * link list is sorted by the inode's i_flushed_when. When both the > + *

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Fengguang Wu
On Wed, Nov 28, 2007 at 11:29:57AM -0800, Michael Rubin wrote: > >From [EMAIL PROTECTED] Wed Nov 28 11:10:06 2007 > Message-Id: <[EMAIL PROTECTED]> > Date: Wed, 28 Nov 2007 11:01:21 -0800 > From: [EMAIL PROTECTED] > To: [EMAIL PROTECTED] > Subject: [patch 1/1] Writeba

[patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Michael Rubin
>From [EMAIL PROTECTED] Wed Nov 28 11:10:06 2007 Message-Id: <[EMAIL PROTECTED]> Date: Wed, 28 Nov 2007 11:01:21 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [patch 1/1] Writeback fix for concurrent large and small file writes. From: Michael Rubin <[EMAIL PROTECTED]>

[patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Michael Rubin
From [EMAIL PROTECTED] Wed Nov 28 11:10:06 2007 Message-Id: [EMAIL PROTECTED] Date: Wed, 28 Nov 2007 11:01:21 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [patch 1/1] Writeback fix for concurrent large and small file writes. From: Michael Rubin [EMAIL PROTECTED] Fixing a bug

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Fengguang Wu
On Wed, Nov 28, 2007 at 11:29:57AM -0800, Michael Rubin wrote: From [EMAIL PROTECTED] Wed Nov 28 11:10:06 2007 Message-Id: [EMAIL PROTECTED] Date: Wed, 28 Nov 2007 11:01:21 -0800 From: [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [patch 1/1] Writeback fix for concurrent large and small

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Frans Pop
Two typos in comments. Cheers, FJP Michael Rubin wrote: + * The flush tree organizes the dirtied_when keys with the rb_tree. Any + * inodes with a duplicate dirtied_when value are link listed together. This + * link list is sorted by the inode's i_flushed_when. When both the + * dirited_when

Re: [patch 1/1] Writeback fix for concurrent large and small file writes

2007-11-28 Thread Michael Rubin
Thank you. Integrated the fixes in my patch. On Nov 28, 2007 6:13 PM, Frans Pop [EMAIL PROTECTED] wrote: Two typos in comments. Cheers, FJP Michael Rubin wrote: + * The flush tree organizes the dirtied_when keys with the rb_tree. Any + * inodes with a duplicate dirtied_when value are