Re: [rfc patch] Re: [patch] PM: suspend/resume debugging should depend on SOFTWARE_SUSPEND

2006-11-29 Thread Mike Galbraith
On Wed, 2006-11-29 at 11:49 -0800, Andrew Morton wrote: > > +#ifdef CONFIG_PM > > +static int serial_pnp_suspend(struct pnp_dev *dev, pm_message_t state) > > +{ > > + long line = (long)pnp_get_drvdata(dev); > > Please avoid adding long lines. (heh, I kill me) Ok. I also changed the place I g

Re: [rfc patch] Re: [patch] PM: suspend/resume debugging should depend on SOFTWARE_SUSPEND

2006-11-29 Thread Andrew Morton
On Wed, 29 Nov 2006 11:30:31 +0100 Mike Galbraith <[EMAIL PROTECTED]> wrote: > On Wed, 2006-11-29 at 11:21 +0100, Mike Galbraith wrote: > > > The serial console appears to be innocent. The suspend/resume methods > > > for my 16550A serial port aren't even being _called_, apparently because > > >

Re: [rfc patch] Re: [patch] PM: suspend/resume debugging should depend on SOFTWARE_SUSPEND

2006-11-29 Thread Pavel Machek
Hi! > On Wed, 2006-11-29 at 11:21 +0100, Mike Galbraith wrote: > > > The serial console appears to be innocent. The suspend/resume methods > > > for my 16550A serial port aren't even being _called_, apparently because > > > pnp swiped ttyS0. > > (ahem, bad aim with mouse, resuming) > > Well, af

[rfc patch] Re: [patch] PM: suspend/resume debugging should depend on SOFTWARE_SUSPEND

2006-11-29 Thread Mike Galbraith
On Wed, 2006-11-29 at 11:21 +0100, Mike Galbraith wrote: > > The serial console appears to be innocent. The suspend/resume methods > > for my 16550A serial port aren't even being _called_, apparently because > > pnp swiped ttyS0. (ahem, bad aim with mouse, resuming) Well, after further rummaging