Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-29 Thread Zhou Ti (x2019cwm)
On Mon 2021-03-29 8:45, Rafael J. Wysocki wrote: > On Fri, Mar 26, 2021 at 11:53 PM Zhou Ti (x2019cwm) wrote: > > > > On Fri, 26 Mar 2021 19:54:26 +0100, Rafael J. Wysocki wrote: > > > On Fri, Mar 26, 2021 at 6:53 PM Zhou Ti (x2019cwm) > > > wrote: > > > > > > > > On Fri, 26 Mar 2021 18:01:47

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-29 Thread Rafael J. Wysocki
On Fri, Mar 26, 2021 at 11:53 PM Zhou Ti (x2019cwm) wrote: > > On Fri, 26 Mar 2021 19:54:26 +0100, Rafael J. Wysocki wrote: > > On Fri, Mar 26, 2021 at 6:53 PM Zhou Ti (x2019cwm) wrote: > > > > > > On Fri, 26 Mar 2021 18:01:47 +0100, Rafael J. Wysocki wrote: > > > > On Thu, Mar 25, 2021 at 9:37

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-26 Thread Zhou Ti (x2019cwm)
On Fri, 26 Mar 2021 19:54:26 +0100, Rafael J. Wysocki wrote: > On Fri, Mar 26, 2021 at 6:53 PM Zhou Ti (x2019cwm) wrote: > > > > On Fri, 26 Mar 2021 18:01:47 +0100, Rafael J. Wysocki wrote: > > > On Thu, Mar 25, 2021 at 9:37 PM Zhou Ti (x2019cwm) > > > wrote: > > > > > > > > On March 25, 2021

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-26 Thread Rafael J. Wysocki
On Fri, Mar 26, 2021 at 6:53 PM Zhou Ti (x2019cwm) wrote: > > On Fri, 26 Mar 2021 18:01:47 +0100, Rafael J. Wysocki wrote: > > On Thu, Mar 25, 2021 at 9:37 PM Zhou Ti (x2019cwm) wrote: > > > > > > On March 25, 2021 15:50, Rafael J. Wysocki wrote: > > > > On Thu, Mar 25, 2021 at 8:18 PM Zhou Ti

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-26 Thread Zhou Ti (x2019cwm)
y understand > > how much of a burden adding an extra branch would impose, so I don't know if > > this tradeoff is worth it. > > It ultimately depends on the governor, which is why I think that the > negative value check should be done by the governor, if needed, and > not by

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-26 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 9:37 PM Zhou Ti (x2019cwm) wrote: > > On March 25, 2021 15:50, Rafael J. Wysocki wrote: > > On Thu, Mar 25, 2021 at 8:18 PM Zhou Ti (x2019cwm) wrote: > > > > > > On March 25, 2021 14:56, Rafael J. Wysocki wrote: > > > > On Thursday, March 25, 2021 2:14:00 PM CET Frederic

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-25 Thread Zhou Ti (x2019cwm)
On March 25, 2021 15:50, Rafael J. Wysocki wrote: > On Thu, Mar 25, 2021 at 8:18 PM Zhou Ti (x2019cwm) wrote: > > > > On March 25, 2021 14:56, Rafael J. Wysocki wrote: > > > On Thursday, March 25, 2021 2:14:00 PM CET Frederic Weisbecker wrote: > > > > On Tue, Mar 16, 2021 at 04:08:08PM +,

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-25 Thread Rafael J. Wysocki
On Thu, Mar 25, 2021 at 8:18 PM Zhou Ti (x2019cwm) wrote: > > On March 25, 2021 14:56, Rafael J. Wysocki wrote: > > On Thursday, March 25, 2021 2:14:00 PM CET Frederic Weisbecker wrote: > > > On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: > > > > But I don't think it's a good

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-25 Thread Zhou Ti (x2019cwm)
On March 25, 2021 14:56, Rafael J. Wysocki wrote: > On Thursday, March 25, 2021 2:14:00 PM CET Frederic Weisbecker wrote: > > On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: > > > But I don't think it's a good idea to handle this in callers, because > > > logically the

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-25 Thread Rafael J. Wysocki
On Thursday, March 25, 2021 2:14:00 PM CET Frederic Weisbecker wrote: > On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: > > But I don't think it's a good idea to handle this in callers, because > > logically the function shouldn't return negative values. Returning 0 > >

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-25 Thread Frederic Weisbecker
On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: > But I don't think it's a good idea to handle this in callers, because > logically the function shouldn't return negative values. Returning 0 directly > would allow idle governors to get another chance to select again. Hmm,

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-17 Thread Zhou Ti (x2019cwm)
On March 16, 2021 12:25, Peter Zijlstra wrote: >On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: >> But I don't think it's a good idea to handle this in callers, because >> logically the function shouldn't return negative values. Returning 0 >> directly would allow idle

Re: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-16 Thread Peter Zijlstra
On Tue, Mar 16, 2021 at 04:08:08PM +, Zhou Ti (x2019cwm) wrote: > But I don't think it's a good idea to handle this in callers, because > logically the function shouldn't return negative values. Returning 0 > directly would allow idle governors to get another chance to select > again. A:

回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-16 Thread Zhou Ti (x2019cwm)
日 3:57 收件人: Rafael J. Wysocki; Frederic Weisbecker; Peter Zijlstra 抄送: Thomas Gleixner; LKML; Yunfeng Ye; Paul E . McKenney; Marcelo Tosatti; Ingo Molnar; raf...@kernel.org 主题: 回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value Yes, the return

回复: [PATCH 01/10] tick/nohz: Prevent tick_nohz_get_sleep_length() from returning negative value

2021-03-16 Thread Zhou Ti (x2019cwm)
Yes, the return of a negative number results in a very large unsigned integer, which idle governors use as a baseline prediction for future interrupts and to correct their own parameters. This problem can lead to the selection of idle states that are too deep, which can be detrimental to both