Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-08 Thread Guillaume Thouvenin
ere are some results when using the process creation tests "lat_proc fork". Test was run ten times thus the average is computed with the ten metrics. with a kernel 2.6.11-rc4-mm1 max value = 164.0588 msec min value = 159.8571 msec average = 161.7012 msec with a ker

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-07 Thread Guillaume Thouvenin
Hello, This patch cannot be apply on a 2.6.11-mm1 because connector is missing in this release. The connector module should be back in the next kernel release. That's why it applies on a 2.6.11-rc4-mm1 tree. Also, there is a problem with the drivers/connector/connector.c file. The

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-07 Thread Jay Lan
The patch i propose is tiny, simple and straight forward. It touches only one file and leaves the CSA code in a configurable loadable module. It broke nobody's code and it does not need to redesign existing BSD kernel code and utilities. If we are to merge the code, there are some detailed discuss

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-04 Thread Tim Schmielau
On Wed, 2 Mar 2005, Guillaume Thouvenin wrote: > Is it possible to merge BSD and CSA? I mean with CSA, there is a part > that does per-process accounting. For exemple in the > linux-2.6.9.acct_mm.patch the two functions update_mem_hiwater() and > csa_update_integrals() update fields in the current

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-03 Thread Jindrich Makovicka
Andrew Morton wrote: (Please do reply-to-all) Jindrich Makovicka <[EMAIL PROTECTED]> wrote: Pavel Machek wrote: Hi! In `subj` kernel, machine no longer powers down at the end of swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. For me, power down stopped working since the introduction of softlo

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-03 Thread Evgeniy Polyakov
eating 10k forks 100 times. > Results on 2-way SMP(1+1HT) Xeon for one fork()+exit(): > > 2.6.11-rc4-mm1 494 usec Actually sometimes it drops to 480 usecs. > 2.6.11-rc4-mm1-fork-connector-no_userspace 509 usec > 2.6.11-rc4-mm1-fork-connector-u

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-03 Thread Evgeniy Polyakov
; diff = (tv1.tv_sec - tv0.tv_sec)*100 + (tv1.tv_usec - tv0.tv_usec); printf("Average per process fork+exit time is %ld usecs [diff=%lu, max=%d].\n", diff/max, diff, max); return 0; } Creating 10k forks 100 times. Results on 2-way SMP(1+1HT) Xeon for on

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 01:18:17PM -0800, Andrew Morton wrote: > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > > > Thing is, CRYPTO_AES on only selectable on x86. > > > > You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, > > the dependencies are a bit weird: > > > > config

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-02 Thread Evgeniy Polyakov
On Thu, Mar 03, 2005 at 12:18:25PM +0900, Kaigai Kohei ([EMAIL PROTECTED]) wrote: > Hello, Guillaume > > I tried to measure the process-creation/destruction performance on > 2.6.11-rc4-mm1 plus > some extensiton(Normal/with PAGG/with Fork-Connector). > But I received a

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 05:41:50PM -0500, Jeff Garzik wrote: > Andrew Morton wrote: > >Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >>>Thing is, CRYPTO_AES on only selectable on x86. > >> > >>You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, > >>the dependencies are a bit weird

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-02 Thread Kaigai Kohei
Hello, Guillaume (B (BI tried to measure the process-creation/destruction performance on (B2.6.11-rc4-mm1 plus (Bsome extensiton(Normal/with PAGG/with Fork-Connector). (BBut I received a following messages endlessly on system console with (BFork-Connector extensiton. (B (B# on IA-64 envir

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-02 Thread Andrew Morton
(Please do reply-to-all) Jindrich Makovicka <[EMAIL PROTECTED]> wrote: > > Pavel Machek wrote: > > Hi! > > > > In `subj` kernel, machine no longer powers down at the end of > > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. > > For me, power down stopped working since the introduction of

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-02 Thread Jindrich Makovicka
Pavel Machek wrote: Hi! In `subj` kernel, machine no longer powers down at the end of swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. For me, power down stopped working since the introduction of softlockup detection. After disabling CONFIG_DETECT_SOFTLOCKUP, powerdown works fine. -- Jindric

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Adrian Bunk wrote: On Wed, Mar 02, 2005 at 05:41:50PM -0500, Jeff Garzik wrote: Andrew Morton wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: Thing is, CRYPTO_AES on only selectable on x86. You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, the dependencies are a bit weird: conf

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Andrew Morton wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: Thing is, CRYPTO_AES on only selectable on x86. You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, the dependencies are a bit weird: config CRYPTO_AES tristate "AES cipher algorithms" depends on CRYPT

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Andrew Morton
Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > Would be better to just do: > > > > config CRYPTO_AES > > select CRYPTO_AES_586 if (X86 && !X86_64) > > select CRYPTO_AES_OTHER if !(X86 && !X86_64) > > > > and hide CRYPTO_AES_586 and CRYPTO_AES_OTHER from the outside world. > > > http://w

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 02:12:04PM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > >On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: > > > >>Adrian Bunk wrote: > >> > >>>+ select CRYPTO > >>> select CRYPTO_AES > >>> ---help--- > >>> Include software based cipher suites in suppor

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Andrew Morton
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > Thing is, CRYPTO_AES on only selectable on x86. > > You're thinking about CRYPTO_AES_586. But looking at crypto/Kconfig, > the dependencies are a bit weird: > > config CRYPTO_AES > tristate "AES cipher algorithms" > depends on

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Andrew Morton wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: Adrian Bunk wrote: On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES ---help--- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Andrew Morton
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Adrian Bunk wrote: > > On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: > > > >>Adrian Bunk wrote: > >> > >>>+ select CRYPTO > >>> select CRYPTO_AES > >>> ---help--- > >>> Include software based cipher suites in support of IEEE 802.11i

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Jeff Garzik
Adrian Bunk wrote: On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES ---help--- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @@ -54,10 +5

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-02 Thread Jay Lan
I did not look into the userspace commands supported in BSD accounting on the dependency on the format of /var/account/pacct file. The accounting exit hook allows BSD/CSA to save accounting data stored in task_struct to internally kept data structure and then writes to their respective accounting f

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-02 Thread Jesse Barnes
On Tuesday, March 1, 2005 11:48 pm, Guillaume Thouvenin wrote: > Is it possible to merge BSD and CSA? I mean with CSA, there is a part > that does per-process accounting. For exemple in the > linux-2.6.9.acct_mm.patch the two functions update_mem_hiwater() and > csa_update_integrals() update fields

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-02 Thread Jesse Barnes
On Wednesday, March 2, 2005 6:51 am, Paul Jackson wrote: > Guillaume wrote: > > I also run the lmbench and results are send in response to another > > thread "A common layer for Accounting packages". When fork connector is > > turned off the overhead is negligible. > > Good. > > If I read this co

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-02 Thread Paul Jackson
In addition to worrying about performance and scaling, with accounting enabled or disabled, one should also try to minimize code clutter in key kernel files, such as fork.c For example, one might, instead of adding 40 lines os fork_connector() code to kernel/fork.c, instead add something like just

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-02 Thread Paul Jackson
Guillaume wrote: > > I also run the lmbench and results are send in response to another > thread "A common layer for Accounting packages". When fork connector is > turned off the overhead is negligible. Good. If I read this code right: > > +static inline void fork_connector(pid_t parent, pid_

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-02 Thread Adrian Bunk
On Wed, Mar 02, 2005 at 01:43:04AM -0500, Jeff Garzik wrote: > Adrian Bunk wrote: > >+select CRYPTO > > select CRYPTO_AES > > ---help--- > > Include software based cipher suites in support of IEEE 802.11i > > (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled > >

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-03-02 Thread Guillaume Thouvenin
insertions(+) diff -uprN -X dontdiff linux-2.6.11-rc4-mm1/drivers/connector/cn_fork.c linux-2.6.11-rc4-mm1-cnfork/drivers/connector/cn_fork.c --- linux-2.6.11-rc4-mm1/drivers/connector/cn_fork.c1970-01-01 01:00:00.00000 +0100 +++ linux-2.6.11-rc4-mm1-cnfork/drivers/connector/cn_fo

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-01 Thread Guillaume Thouvenin
On Tue, 2005-03-01 at 10:06 -0800, Jay Lan wrote: > Sorry I was not clear on my point. > > I was trying to point out that, an exit hook for BSD and CSA is > essential to save accounting data before the data is gone. That > can not be done with a netlink. > > So, my patch was to keep acct_process

Re: [2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-03-01 Thread Jeff Garzik
Adrian Bunk wrote: + select CRYPTO select CRYPTO_AES ---help--- Include software based cipher suites in support of IEEE 802.11i (aka TGi, WPA, WPA2, WPA-PSK, etc.) for use with CCMP enabled networks. @@ -54,10 +55,11 @@ "ieee80211_crypt_ccmp". config IEEE80211_CRYPT_TKIP tristate

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > > > Relocating pagedir | > > > Reading image data (8157 pages): 100% 8157 done. > > > Stopping tasks: | > > > Freeing memory... done (0 pages freed) > > > Freezing CPUs (at 1)...Sleeping in: > > > [] dump_stack+0x19/0x20 > > > [] smp_pause+0x1f/0x54 > >

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Andrew Morton
Pavel Machek <[EMAIL PROTECTED]> wrote: > > I can fix disk going yo-yo without switching pm_message_t to struct, > but will have to back parts of that later. Do you want patch? No thanks, I was just pointing it out. It sounds like you have it under control. - To unsubscribe from this list: send

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Andrew Morton
Pavel Machek <[EMAIL PROTECTED]> wrote: > > Hi! > > > Resume on SMP locks up. > > Does it work on UP kernel on same hardware? yup. > NMI watchdog is problem > for suspend, it takes long to do various phases. Can you disable it > for testing? Will try to remember to do that. > > Relocating pag

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-03-01 Thread Jay Lan
Sorry I was not clear on my point. I was trying to point out that, an exit hook for BSD and CSA is essential to save accounting data before the data is gone. That can not be done with a netlink. So, my patch was to keep acct_process as a wrapper, which would then call do_exit_csa() for CSA and call

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Eric W. Biederman
Pavel Machek <[EMAIL PROTECTED]> writes: > > I threw it together to test a specific code path, and the fact it > > fails in software suspend is actually almost confirmation that I am on > > the right track. This actually fixed the case I was testing. > > > > In this case the failure is simply be

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > btw, suspend is a bit messy. The disk spins down. Then up. Then down > again. And: Here's preview patch to make disk not do stupid yo-yo. Please do not apply (it will probably not apply cleanly anyway). I can fix disk going yo-yo without switching pm_message_t to struct, but will have

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > btw, suspend is a bit messy. The disk spins down. Then up. Then down > again. And: Yes, this is going to be properly solved by switching pm_message_t to struct (preview patch attached, EVENT will become .event, this is just for me). I could do some hack to make disk not go up-down-up (a

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > > > In `subj` kernel, machine no longer powers down at the end of > > > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. > > > > Binary searching indicates that this is due to > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc5/2.6.11-rc5-mm1/broken-out/acpi_p

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > > Yes, the patch is very ugly. If something like this needs to be done, > > then perhaps acpi should properly register into driver model and do > > the work there. This will also mean code will be called consistently. > > I totally agree. Do you have an example of how a non-device > can do

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Eric W. Biederman
Pavel Machek <[EMAIL PROTECTED]> writes: > Yes, the patch is very ugly. If something like this needs to be done, > then perhaps acpi should properly register into driver model and do > the work there. This will also mean code will be called consistently. I totally agree. Do you have an example o

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Eric W. Biederman
Andrew Morton <[EMAIL PROTECTED]> writes: > Pavel Machek <[EMAIL PROTECTED]> wrote: > > > > In `subj` kernel, machine no longer powers down at the end of > > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. > > Binary searching indicates that this is due to > ftp://ftp.kernel.org/pub/linux/

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > Resume on SMP locks up. Does it work on UP kernel on same hardware? NMI watchdog is problem for suspend, it takes long to do various phases. Can you disable it for testing? Pavel > Relocating pagedir | > Reading image data (8

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > > In `subj` kernel, machine no longer powers down at the end of > > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. > > Binary searching indicates that this is due to > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc5/2.6.11-rc5-mm1/broken-out/acpi_power_off-b

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Pavel Machek
Hi! > btw, suspend is a bit messy. The disk spins down. Then up. Then down > again. And: Yes, that's known, pm_message_t needs to become struct to solve disk pingpong properly. > Debug: sleeping function called from invalid context at mm/slab.c:2082 > in_atomic():0, irqs_disabled():1

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Andrew Morton
Resume on SMP locks up. Relocating pagedir | Reading image data (8157 pages): 100% 8157 done. Stopping tasks: | Freeing memory... done (0 pages freed) Freezing CPUs (at 1)...Sleeping in: [] dump_stack+0x19/0x20 [] smp_pause+0x1f/0x54 [] smp_call_function_i

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Andrew Morton
btw, suspend is a bit messy. The disk spins down. Then up. Then down again. And: Stopping tasks: ==| Freeing memory... done (7069 pages freed) swsusp: Need to copy 7847 pages swsusp: critical section/: done (7879 pages copi

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-03-01 Thread Andrew Morton
Pavel Machek <[EMAIL PROTECTED]> wrote: > > In `subj` kernel, machine no longer powers down at the end of > swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. Binary searching indicates that this is due to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc5/2.6.11-rc5-mm1/

Re: 2.6.11-rc4-mm1 - pcmcia weirdness/breakage

2005-03-01 Thread Valdis . Kletnieks
On Mon, 28 Feb 2005 14:48:20 EST, [EMAIL PROTECTED] said: > Symptoms: Running '/etc/init.d/pcmcia start' bombs - cardmgr goes into > a loop spewing repeated 'Common memory region at 0x0: Generic or SRAM' > messages. In the dmesg, we find: > [4294859.369000] cs: unable to map card memory! > [429

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-28 Thread Guillaume Thouvenin
On Mon, 2005-02-28 at 10:56 -0800, Jay Lan wrote: > The exit hook is essential for CSA to save off data before the data > is gone, A netlink type of thing does not help. BSD is in the same > situation. You can not replace the acct_process() call with a netlink. > If ELSA is to use the enhanced acco

Re: 2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-02-28 Thread Laurent Riffard
Le 01.03.2005 00:17, Pavel Machek a écrit : Hi! In `subj` kernel, machine no longer powers down at the end of swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. Pavel Hello, I noticed this behaviour, too. Can't remember if it came with 2.6.11-rc3-mm2 or with 2.6.11-rc4-mm1. Didn&

2.6.11-rc4-mm1: something is wrong with swsusp powerdown

2005-02-28 Thread Pavel Machek
Hi! In `subj` kernel, machine no longer powers down at the end of swsusp. 2.6.11-rc5-pavel works ok, as does 2.6.11-bk. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq g

Re: 2.6.11-rc4-mm1 - pcmcia weirdness/breakage

2005-02-28 Thread Valdis . Kletnieks
On Mon, 28 Feb 2005 21:22:26 +0100, Dominik Brodowski said: > On Mon, Feb 28, 2005 at 02:48:20PM -0500, [EMAIL PROTECTED] wrote: > > A full -rc4-mm1 fails, *as does* a -rc4-mm1 with all the following patches > > -R'ed: ... > > broken-out/pcmcia-bridge-resource-management-fix.patch > > So the

Re: 2.6.11-rc4-mm1 - pcmcia weirdness/breakage

2005-02-28 Thread Dominik Brodowski
On Mon, Feb 28, 2005 at 02:48:20PM -0500, [EMAIL PROTECTED] wrote: > Symptoms: Running '/etc/init.d/pcmcia start' bombs - cardmgr goes into > a loop spewing repeated 'Common memory region at 0x0: Generic or SRAM' > messages. In the dmesg, we find: > > [4294764.989000] <6>cs: IO port probe 0xc00

2.6.11-rc4-mm1 - pcmcia weirdness/breakage

2005-02-28 Thread Valdis . Kletnieks
Symptoms: Running '/etc/init.d/pcmcia start' bombs - cardmgr goes into a loop spewing repeated 'Common memory region at 0x0: Generic or SRAM' messages. In the dmesg, we find: [4294764.989000] <6>cs: IO port probe 0xc00-0xcff: clean. [4294859.195000] cs: IO port probe 0xc00-0xcff: clean. [429485

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-28 Thread Jay Lan
Hi Andrew, You asked: > > In other words: given that ELSA can do its thing via existing accounting > interfaces and a fork notifier, why does CSA need to add lots more kernel > code? And i explained: > Here are some codes from do_exit() starting line 813 (based on > 2.6.11

Re: [2.6.11-rc4-mm1 patch] drivers/scsi/arcmsr/arcmsr.c cleanups

2005-02-27 Thread Christoph Hellwig
On Sun, Feb 27, 2005 at 04:48:10PM +0100, Adrian Bunk wrote: > - aren't the "if defined(__x86_64__)" wrong for other 64bit > architectures? Yes. Having arch or 64bit ifdefs is pretty wrong pretty much always. In one case it's only used to make a typedef a 32bit or 64bit integeger, that should b

[2.6.11-rc4-mm1 patch] drivers/scsi/arcmsr/arcmsr.c cleanups

2005-02-27 Thread Adrian Bunk
the own subdirectory for this driver seems to be overkill - aren't the "if defined(__x86_64__)" wrong for other 64bit architectures? drivers/scsi/arcmsr/arcmsr.c | 110 +++ drivers/scsi/arcmsr/arcmsr.h | 34 -- 2 files changed, 73 insertion

[2.6.11-rc4-mm1 patch] fix buggy IEEE80211_CRYPT_* selects

2005-02-26 Thread Adrian Bunk
defined reference to `crypto_free_tfm' net/built-in.o(.text+0x5c65e): In function `ieee80211_tkip_deinit': : undefined reference to `crypto_free_tfm' net/built-in.o(.text+0x5c665): In function `ieee80211_tkip_deinit': : undefined reference to `crypto_free_tfm' make: *** [.tmp

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-25 Thread Chris Wright
* aq ([EMAIL PROTECTED]) wrote: > Just try something like this: > > +#ifdef CONFIG_FORK_CONNECTOR > + > + fork_connector(current->pid, p->pid); > #endif It's generally preferred to bury this in header files. thanks, -chris -- Linux Security Modules http://lsm.immunix.org

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-25 Thread Tim Schmielau
> > +#ifdef CONFIG_FORK_CONNECTOR [...] > > +static inline void fork_connector(pid_t parent, pid_t child) > > +{ [...] > > +} > > +#else > > +static inline void fork_connector(pid_t parent, pid_t child) > > +{ > > + return; > > +} > > +#endif [...] > > @@ -1238,6 +1281,8 @@ long do_fork(unsig

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-25 Thread aq
On Thu, 24 Feb 2005 11:24:37 +0100, Guillaume Thouvenin <[EMAIL PROTECTED]> wrote: > This patch replaces the relay_fork module and it implements a fork > connector in the kernel/fork.c:do_fork() routine. It applies on a kernel > 2.6.11-rc4-mm1. The connector sends information a

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-24 Thread Guillaume Thouvenin
On Thu, 2005-02-24 at 20:46 -0800, Andrew Morton wrote: > Jay Lan <[EMAIL PROTECTED]> wrote: > > > > Since my idea of providing an accounting framework was considered > > 'overkill', here i submit a tiny patch just to allow CSA to > > handle end-of-process (eop) situation by saving off accounting

Re: [PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-24 Thread Andrew Morton
Jay Lan <[EMAIL PROTECTED]> wrote: > > Since my idea of providing an accounting framework was considered > 'overkill', here i submit a tiny patch just to allow CSA to > handle end-of-process (eop) situation by saving off accounting > data before a task_struct is disposed. > > This patch is to

[PATCH 2.6.11-rc4-mm1] end-of-proces handling for acct-csa

2005-02-24 Thread Jay Lan
Since my idea of providing an accounting framework was considered 'overkill', here i submit a tiny patch just to allow CSA to handle end-of-process (eop) situation by saving off accounting data before a task_struct is disposed. This patch is to modify the acct_process() in acct.c, which is invoked

Re: 2.6.11-rc4-mm1

2005-02-24 Thread Dmitry Torokhov
Andrew Morton wrote: > > > > > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc4/2.6.11-rc4-mm1/ > > > > > > > > > > > > > > > - Various fixes and updates all over the place. Things seem to ha

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-24 Thread Felipe Alfaro Solana
On Wed, 23 Feb 2005 16:25:39 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > Could someone try this? > > Let's turn that into a real patch. > > --- 25/drivers/ide/ide-probe.c~ide_init_disk-fixWed Feb 23 16:24:44 > 2005 > +++ 25-akpm/driv

Re: 2.6.11-rc4-mm1

2005-02-24 Thread J.A. Magallon
ux/kernel/people/akpm/patches/2.6/2.6.11-rc4/2.6.11-rc4-mm1/ > > > > > > > > > > > > - Various fixes and updates all over the place. Things seem to have > > > > slowed > > > > down a bit. > > > > >

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-24 Thread Greg KH
On Thu, Feb 24, 2005 at 09:42:24PM +0100, Laurent Riffard wrote: > I do need device-mapper, since I put /usr and /var on LVM filesystems. I > use ptkcdvd to copy data to CD-RW. I can remove this one. > > Anyway, this patch from Andrew fixed the problem : > http://lkml.org/lkml/2005/2/23/214. Yeah

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-24 Thread Laurent Riffard
Le 24.02.2005 18:18, Greg KH a écrit : On Thu, Feb 24, 2005 at 06:06:39PM +0100, Laurent Riffard wrote: Le 24.02.2005 00:47, Greg KH a ?crit : On Wed, Feb 23, 2005 at 11:36:50PM +0100, Laurent Riffard wrote: hey, what's this /dev/hds ? digging into /sys/block... ~$ ls -l /sys/block/hds/device lr

[PATCH 2.6.11-rc4-mm1] kexec: ppc: fix NORET_TYPE

2005-02-24 Thread Albert Herranz
Hi, On ppc machine_kexec.c, we must apply NORET_TYPE to machine_kexec() as it does not return, and make it noreturn (otherwise compiler complains). NORET_TYPE is in fact not needed for machine_kexec_simple(). Signed-off-by: Albert Herranz Cheers, Albert __

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-24 Thread Greg KH
On Thu, Feb 24, 2005 at 06:06:39PM +0100, Laurent Riffard wrote: > > > Le 24.02.2005 00:47, Greg KH a ?crit : > >On Wed, Feb 23, 2005 at 11:36:50PM +0100, Laurent Riffard wrote: > > > >>hey, what's this /dev/hds ? digging into /sys/block... > >> > >>~$ ls -l /sys/block/hds/device > >>lrwxrwxrwx

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-24 Thread Laurent Riffard
Le 24.02.2005 00:47, Greg KH a écrit : On Wed, Feb 23, 2005 at 11:36:50PM +0100, Laurent Riffard wrote: hey, what's this /dev/hds ? digging into /sys/block... ~$ ls -l /sys/block/hds/device lrwxrwxrwx 1 root root 0 f?v 23 22:45 /sys/block/hds/device -> ../../devices/pci:00/:00:04.1/ide1/

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-24 Thread Laurent Riffard
Le 24.02.2005 00:20, Andrew Morton a écrit : Laurent Riffard <[EMAIL PROTECTED]> wrote: Le 23.02.2005 21:12, Andrew Morton a écrit : Helge Hafting <[EMAIL PROTECTED]> wrote: This kernel came up, but my boot script complained about no /dev/hdb3 when trying to mount /var. (I have two IDE disks on th

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-24 Thread Steven Cole
Matt Mackall wrote: On Wed, Feb 23, 2005 at 03:10:38PM -0700, Steven Cole wrote: Andrew Morton wrote: Steven Cole <[EMAIL PROTECTED]> wrote: I am having trouble getting recent -mm kernels to boot on my test box. For 2.6.11-rc3-mm2 and 2.6.11-rc4-mm1 I get the following: VFS: Cannot ope

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-24 Thread Steven Cole
Matt Mackall wrote: On Wed, Feb 23, 2005 at 03:10:38PM -0700, Steven Cole wrote: Andrew Morton wrote: Steven Cole <[EMAIL PROTECTED]> wrote: I am having trouble getting recent -mm kernels to boot on my test box. For 2.6.11-rc3-mm2 and 2.6.11-rc4-mm1 I get the following: VFS: Cannot ope

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-24 Thread Ryan Anderson
On Thu, Feb 24, 2005 at 02:46:05AM -0800, Andrew Morton wrote: > Guillaume Thouvenin <[EMAIL PROTECTED]> wrote: > > > +spinlock_t fork_cn_lock = SPIN_LOCK_UNLOCKED; > > This should have static scope, and could be local to fork_connector(). > > Please use DEFINE_SPINLOCK(). (There's a reason fo

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-24 Thread Bartlomiej Zolnierkiewicz
On Wed, 23 Feb 2005 16:25:39 -0800, Andrew Morton <[EMAIL PROTECTED]> wrote: > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > Could someone try this? > > Let's turn that into a real patch. > > --- 25/drivers/ide/ide-probe.c~ide_init_disk-fixWed Feb 23 16:24:44 > 2005 > +++ 25-akpm/driv

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-24 Thread Guillaume Thouvenin
On Thu, 2005-02-24 at 13:45 +0300, Evgeniy Polyakov wrote: > > > > Todo: > > > > - Test the performance impact with lmbench > > - Improve the callback that turns on/off the fork connector > > - Create a specific module to register the callback. > > Besides connector.c changes I do

2.6.11-rc4-mm1: infiniband/core/user_mad.c warning

2005-02-24 Thread Adrian Bunk
On Wed, Feb 23, 2005 at 01:42:33AM -0800, Andrew Morton wrote: >... > Changes since 2.6.11-rc3-mm1: >... > bk-driver-core-infiniband-build-fix.patch >... This gives me the following compile error: <-- snip --> ... CC drivers/infiniband/core/user_mad.o drivers/infiniband/core/user_mad.c

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-24 Thread Andrew Morton
Guillaume Thouvenin <[EMAIL PROTECTED]> wrote: > > +#define CN_FORK_MSG_SIZEsizeof(struct cn_msg) + CN_FORK_INFO_SIZE This really should be parenthesized. > +spinlock_t fork_cn_lock = SPIN_LOCK_UNLOCKED; This should have static scope, and could be local to fork_connector(). Please use DEF

Re: [PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-24 Thread Evgeniy Polyakov
On Thu, 2005-02-24 at 11:24 +0100, Guillaume Thouvenin wrote: > This patch replaces the relay_fork module and it implements a fork > connector in the kernel/fork.c:do_fork() routine. It applies on a kernel > 2.6.11-rc4-mm1. The connector sends information about parent PID and > chil

[PATCH 2.6.11-rc4-mm1] connector: Add a fork connector

2005-02-24 Thread Guillaume Thouvenin
This patch replaces the relay_fork module and it implements a fork connector in the kernel/fork.c:do_fork() routine. It applies on a kernel 2.6.11-rc4-mm1. The connector sends information about parent PID and child PID over a netlink interface. It allows to several user space applications to be

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-23 Thread Matt Mackall
> > > > > > > > Yes, that worked. 2.6.11-rc4-mm1 now boots OK, but hdb1 seems to be > > > > > missing. > > > > > > Looking at the IDE update in rc4-mm1: > > > > > > +void ide_init_disk(struct gendisk *disk, ide_drive_t *drive) >

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-23 Thread Benoit Boissinot
On Wed, 23 Feb 2005 16:41:59 -0800, Matt Mackall <[EMAIL PROTECTED]> wrote: > On Wed, Feb 23, 2005 at 04:16:53PM -0800, Andrew Morton wrote: > > Steven Cole <[EMAIL PROTECTED]> wrote: > > > > > > > Yes, that worked. 2.6.11-rc4-mm1 now boot

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-23 Thread Matt Mackall
On Wed, Feb 23, 2005 at 03:10:38PM -0700, Steven Cole wrote: > Andrew Morton wrote: > >Steven Cole <[EMAIL PROTECTED]> wrote: > > >>I am having trouble getting recent -mm kernels to boot on my test box. > >>For 2.6.11-rc3-mm2 and 2.6.11-rc4-mm1 I get the follo

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-23 Thread Andrew Morton
Steven Cole <[EMAIL PROTECTED]> wrote: > > Andrew Morton wrote: > > Steven Cole <[EMAIL PROTECTED]> wrote: > > >> I am having trouble getting recent -mm kernels to boot on my test box. > >> For 2.6.11-rc3-mm2 and 2.6.11-rc4-mm1 I get the following: &g

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-23 Thread Matt Mackall
On Wed, Feb 23, 2005 at 04:16:53PM -0800, Andrew Morton wrote: > Steven Cole <[EMAIL PROTECTED]> wrote: > > > > > Yes, that worked. 2.6.11-rc4-mm1 now boots OK, but hdb1 seems to be > > > missing. > > Looking at the IDE update in rc4-mm1: >

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Ed Tomlinson
; ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc4/2.6.11-rc4-mm1/ > > > > > > > > > > > > - Various fixes and updates all over the place. Things seem to have > > > > slowed > > > > down a bit. > > > > &g

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Fabian Fenaut
Dmitry Torokhov a ecrit le 24.02.2005 00:40: On Wednesday 23 February 2005 18:12, Ed Tomlinson wrote: On Wednesday 23 February 2005 17:38, J.A. Magallon wrote: On 02.23, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc4/2.6.11-rc4-mm1/ - Various fixes

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-23 Thread Andrew Morton
Andrew Morton <[EMAIL PROTECTED]> wrote: > > Could someone try this? Let's turn that into a real patch. --- 25/drivers/ide/ide-probe.c~ide_init_disk-fixWed Feb 23 16:24:44 2005 +++ 25-akpm/drivers/ide/ide-probe.c Wed Feb 23 16:24:55 2005 @@ -1269,7 +1269,7 @@ EXPORT_SYMBOL_GPL(ide_unr

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-23 Thread Matt Mackall
f the usual hdb1 and hda1. > > > > I don't know what could be causing that. Please send .config. If you set > > CONFIG_BASE_FULL=n, try setting it to `y'. > > I've got the same problem here on my box, udev creates hds and hdu > entries when running

Re: 2.6.11-rc4-mm1 (VFS: Cannot open root device "301")

2005-02-23 Thread Andrew Morton
Steven Cole <[EMAIL PROTECTED]> wrote: > > > Yes, that worked. 2.6.11-rc4-mm1 now boots OK, but hdb1 seems to be > > missing. Looking at the IDE update in rc4-mm1: +void ide_init_disk(struct gendisk *disk, ide_drive_t *drive) +{ + ide_hwif_t *hwif = drive->hwif; +

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-23 Thread Greg KH
On Wed, Feb 23, 2005 at 11:36:50PM +0100, Laurent Riffard wrote: > hey, what's this /dev/hds ? digging into /sys/block... > > ~$ ls -l /sys/block/hds/device > lrwxrwxrwx 1 root root 0 f?v 23 22:45 /sys/block/hds/device -> > ../../devices/pci:00/:00:04.1/ide1/1.1/ > > /dev/hdq should be

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Brice Goglin
Dominik Brodowski a écrit : +pcmcia-bridge-resource-management-fix.patch is responsible for this "no resource available" message, because the other ones relate to other areas. This line from dmesg-2.6.11-rc4 is no longer present in -rc4-mm1: PCI: Transparent bridge - :00:1e.0 This is probably d

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Dmitry Torokhov
On Wednesday 23 February 2005 18:12, Ed Tomlinson wrote: > On Wednesday 23 February 2005 17:38, J.A. Magallon wrote: > > > > On 02.23, Andrew Morton wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc4/2.6.11-rc4-mm1/ > &

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-23 Thread Mathieu Segaud
cted. >> >> It may be interesting to note that my root raid-1 came up fine, >> consisting of hdq1 and hda1 instead of the usual hdb1 and hda1. > > I don't know what could be causing that. Please send .config. If you set > CONFIG_BASE_FULL=n, try setting it to `y'

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Ed Tomlinson
On Wednesday 23 February 2005 04:42, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc4/2.6.11-rc4-mm1/ > > > - Various fixes and updates all over the place. Things seem to have slowed > down a bit. > > - Last, final,

Re: 2.6.11-rc4-mm1 : IDE crazy numbers, hdb renumbered to hdq ?

2005-02-23 Thread Andrew Morton
Laurent Riffard <[EMAIL PROTECTED]> wrote: > > Le 23.02.2005 21:12, Andrew Morton a écrit : > > Helge Hafting <[EMAIL PROTECTED]> wrote: > > > >>This kernel came up, but my boot script complained about no /dev/hdb3 > >> when trying to mount /var. > >> (I have two IDE disks on the same cable, and an

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Andrew Morton
Ed Tomlinson <[EMAIL PROTECTED]> wrote: > > It does not seem to be finding the keyboard at all... Can you confirm that Linus's tree is OK? You'd best use the patch at http://www.kernel.org/pub/linux/kernel/v2.5/testing/cset/ to make sure you have the latest stuff. - To unsubscribe from this list:

Re: 2.6.11-rc4-mm1

2005-02-23 Thread Ed Tomlinson
On Wednesday 23 February 2005 17:38, J.A. Magallon wrote: > > On 02.23, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.11-rc4/2.6.11-rc4-mm1/ > > > > > > - Various fixes and updates all over the place. Things

  1   2   >