Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Jens Axboe
On Thu, Oct 04 2007, Don Mullis wrote: > That patch boots without complaint as well. > > BTW, the earlier failure messages did not make it > into /var/log/messages, only the dmesg buffer. > This is with standard Ubuntu Gutsy logging levels. Super, thanks for retesting! -- Jens Axboe - To unsub

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Don Mullis
That patch boots without complaint as well. BTW, the earlier failure messages did not make it into /var/log/messages, only the dmesg buffer. This is with standard Ubuntu Gutsy logging levels. On Thu, 2007-10-04 at 18:42 +0200, Jens Axboe wrote: > On Thu, Oct 04 2007, Pierre Ossman wrote: > > On

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Pierre Ossman
On Thu, 4 Oct 2007 18:42:25 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > diff --git a/drivers/mmc/card/queue.c b/drivers/mmc/card/queue.c > index b0abc7d..a5d0354 100644 > --- a/drivers/mmc/card/queue.c > +++ b/drivers/mmc/card/queue.c Acked-by: Pierre Ossman <[EMAIL PROTECTED]> (Provided it

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Jens Axboe
On Thu, Oct 04 2007, Pierre Ossman wrote: > On Thu, 04 Oct 2007 09:19:40 -0700 > Don Mullis <[EMAIL PROTECTED]> wrote: > > > This patch fixes the boot. > > > > Fantastic. Then will try to get this upstream then. I already put it in the sgchain drivers part. If you could please ack it, that woul

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Pierre Ossman
On Thu, 04 Oct 2007 09:19:40 -0700 Don Mullis <[EMAIL PROTECTED]> wrote: > This patch fixes the boot. > Fantastic. Then will try to get this upstream then. > > > > It looks like missing init of the sg list in mmc, does this work? > > Jens, is this zeroing needed for each invocation, or reall

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Don Mullis
This patch fixes the boot. On Thu, 2007-10-04 at 09:25 +0200, Jens Axboe wrote: > On Wed, Oct 03 2007, Andrew Morton wrote: > > On Wed, 03 Oct 2007 23:11:02 -0700 Don Mullis <[EMAIL PROTECTED]> wrote: > > > > > OOPS followed by a 3 minute timeout, then completion of boot. > > > Not seen if card

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Jens Axboe
On Thu, Oct 04 2007, Pierre Ossman wrote: > On Thu, 4 Oct 2007 12:38:05 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 04 2007, Pierre Ossman wrote: > > > > > > Is that a yes or a no? You said that the ->page field was involved > > > in > > > > It's a conditional yes, re-read it

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Pierre Ossman
On Thu, 4 Oct 2007 12:38:05 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Thu, Oct 04 2007, Pierre Ossman wrote: > > > > Is that a yes or a no? You said that the ->page field was involved > > in > > It's a conditional yes, re-read it :-) > I didn't get the memo about what chained sg entries

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Jens Axboe
On Thu, Oct 04 2007, Pierre Ossman wrote: > On Thu, 4 Oct 2007 11:30:14 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 04 2007, Pierre Ossman wrote: > > > > > > I assume sg_init_one() still can work on an uninitialized sg entry? > > > > Yes, but only if that sg entry is not part

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Pierre Ossman
On Thu, 4 Oct 2007 11:30:14 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Thu, Oct 04 2007, Pierre Ossman wrote: > > > > I assume sg_init_one() still can work on an uninitialized sg entry? > > Yes, but only if that sg entry is not part of a chained list. > Is that a yes or a no? You said th

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Jens Axboe
On Thu, Oct 04 2007, Pierre Ossman wrote: > On Thu, 4 Oct 2007 10:06:32 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 04 2007, Pierre Ossman wrote: > > > > > > Huh? Isn't the block layer supposed to fill in the entire thing? > > > (i.e. current contents shouldn't matter) > > >

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Pierre Ossman
On Thu, 4 Oct 2007 10:06:32 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Thu, Oct 04 2007, Pierre Ossman wrote: > > > > Huh? Isn't the block layer supposed to fill in the entire thing? > > (i.e. current contents shouldn't matter) > > Yeah, but sg chaining requires that ->page be filled in pr

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Jens Axboe
On Thu, Oct 04 2007, Pierre Ossman wrote: > On Thu, 4 Oct 2007 09:25:15 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > It looks like missing init of the sg list in mmc, does this work? > > > > Huh? Isn't the block layer supposed to fill in the entire thing? (i.e. > current contents sho

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Pierre Ossman
On Thu, 4 Oct 2007 09:25:15 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > > It looks like missing init of the sg list in mmc, does this work? > Huh? Isn't the block layer supposed to fill in the entire thing? (i.e. current contents shouldn't matter) Rgds Pierre signature.asc Description: PGP

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Pierre Ossman
On Wed, 3 Oct 2007 23:16:59 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 03 Oct 2007 23:11:02 -0700 Don Mullis <[EMAIL PROTECTED]> wrote: > > > OOPS followed by a 3 minute timeout, then completion of boot. > > Not seen if card (Kingston microSD adapter) is ejected; not seen in > > 2.6

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Jens Axboe
On Wed, Oct 03 2007, Andrew Morton wrote: > On Wed, 03 Oct 2007 23:11:02 -0700 Don Mullis <[EMAIL PROTECTED]> wrote: > > > OOPS followed by a 3 minute timeout, then completion of boot. > > Not seen if card (Kingston microSD adapter) is ejected; not seen in > > 2.6.23-rc8. > > Running on a Dell XP

2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-04 Thread Don Mullis
OOPS followed by a 3 minute timeout, then completion of boot. Not seen if card (Kingston microSD adapter) is ejected; not seen in 2.6.23-rc8. Running on a Dell XPS M1330 laptop. `dmesg` reports: [ 13.695045] mmcblk0: mmc0:e95c SD02G 1966080KiB [ 13.695155] mmcblk0: p1 [ 13.706907] BUG: una

Re: 2.6.23-rc8-mm2: OOPS in mmc on boot

2007-10-03 Thread Andrew Morton
On Wed, 03 Oct 2007 23:11:02 -0700 Don Mullis <[EMAIL PROTECTED]> wrote: > OOPS followed by a 3 minute timeout, then completion of boot. > Not seen if card (Kingston microSD adapter) is ejected; not seen in > 2.6.23-rc8. > Running on a Dell XPS M1330 laptop. > > `dmesg` reports: > > [ 13.6950