Re: Another approach of UFSHPB

2020-05-27 Thread Bean Huo
On Wed, 2020-05-27 at 18:11 +0900, Daejun Park wrote: > > > > I do not agree that the bus model is the best choice for > > > > freeing cache > > > > memory if it is no longer needed. A shrinker is probably a much > > > > better > > > > choice because the callback functions in a shrinker get

Re: Another approach of UFSHPB

2020-05-27 Thread Daejun Park
On 2020-05-26 Bart Van Assche wrote: >On 2020-05-25 23:15, Avri Altman wrote: >>> On 2020-05-24 22:40, Daejun Park wrote: The HPB driver is close to the UFS core function, but it is not essential for operating UFS device. With reference to this article

Re: Another approach of UFSHPB

2020-05-26 Thread Bart Van Assche
On 2020-05-25 23:15, Avri Altman wrote: >> On 2020-05-24 22:40, Daejun Park wrote: >>> The HPB driver is close to the UFS core function, but it is not essential >>> for operating UFS device. With reference to this article >>> (https://lwn.net/Articles/645810/), we implemented extended UFS-feature

RE: Another approach of UFSHPB

2020-05-26 Thread Avri Altman
> On 2020-05-24 22:40, Daejun Park wrote: > > The HPB driver is close to the UFS core function, but it is not essential > > for operating UFS device. With reference to this article > > (https://lwn.net/Articles/645810/), we implemented extended UFS-feature > > as bus model. Because the HPB driver

Re: Another approach of UFSHPB

2020-05-25 Thread Bart Van Assche
On 2020-05-24 22:40, Daejun Park wrote: > The HPB driver is close to the UFS core function, but it is not essential > for operating UFS device. With reference to this article > (https://lwn.net/Articles/645810/), we implemented extended UFS-feature > as bus model. Because the HPB driver consumes

Re: Another approach of UFSHPB

2020-05-24 Thread Daejun Park
I am Daejun Park who is working to patch HPB driver. Thank you for your comment, and the following is our answer. > Splitting the UFS driver into multiple modules would be great if the > interface between these modules can be kept small and elegant. However, > I'm not sure that this approach

Re: Another approach of UFSHPB

2020-05-22 Thread Bart Van Assche
On 2020-05-19 15:31, yongmyung lee wrote: > Currently, UFS driver (usually ufshcd.c) has become bulky and complex. > So, I would like to split these codes into layers > like the works of Bean Huo and Avril Altman. > Especially, I suggest the UFS-Feature Driver model based on Linux Bus-Driver >

Re: Another approach of UFSHPB

2020-05-22 Thread Bart Van Assche
On 2020-05-20 14:19, Bart Van Assche wrote: > On 2020-05-20 10:55, Christoph Hellwig wrote: >> HPB is a completely fucked up concept and we shoud not merge it at all. >> Especially not with a crazy bullshit vendor extension layer that makes >> it even easier for vendors to implement even worse

Re: Another approach of UFSHPB

2020-05-20 Thread Bart Van Assche
On 2020-05-20 10:55, Christoph Hellwig wrote: > HPB is a completely fucked up concept and we shoud not merge it at all. > Especially not with a crazy bullshit vendor extension layer that makes > it even easier for vendors to implement even worse things than the > already horrible spec says. Just

Re: Another approach of UFSHPB

2020-05-20 Thread Christoph Hellwig
Serious, HPB is a completely fucked up concept and we shoud not merge it at all. Especially not with a crazy bullshit vendor extension layer that makes it even easier for vendors to implement even worse things than the already horrible spec says. Just stop this crap and implement sane interfaces

Another approach of UFSHPB

2020-05-19 Thread yongmyung lee
Hello, All! I write this email that is my opinion regard to HPB. This mail is very long. So, summary is ... : [Summary] 1. HPB, Write Booster and other new UFS features would be managed by ufs-extended feature layer (additional LLD layer) 2. Map table of HPB will be managed in LLD (UFS