netdev branch - kernel panic - bug in tcp_time_to_recover ?

Hello List, Today I builded recent git snapshot of netdev tree and after a while i get this (hand noted due to hard lockup - no oops in syslog) Oops: [#1] Modules linked in: CPU: 0 EIP: 0060:[] Not tainted VLI EFLAGS: 00010246 (2.6.13-netdev) EIP is at tcp_time_to_recover+0x62/0xbf eax:

Re: Bug in tcp_time_to_recover

Hello! >/* Not-A-Trick#2 : Classic rule... */ >if (tcp_fackets_out(tp) > tp->reordering) > ^ >return 1; ... > Shouldn't it be a >= instead of > ? No. fackets_out is equivalent of Reno dupacks+1. F.e. look at the most common case, where FACK is equiv

Bug in tcp_time_to_recover

Consider the following code in tcp_input.c - static int tcp_time_to_recover(struct sock *sk, struct tcp_opt *tp) { /* Trick#1: The loss is proven. */ if (tp->lost_out) return 1; /* Not-A-Trick#2 : Classic rule... */