[PATCH v3] pinctrl: rockchip: do coding style for mux route struct

2021-04-20 Thread Jianqun Xu
The mux route tables take many lines for each SoC, and it will be more instances for newly SoC, that makes the file size increase larger. This patch only do coding style for mux route struct, by adding a new definition and replace the structs by script which supplied by huang...@rock-chips.com

Re: [PATCH v2] pinctrl: rockchip: do coding style for mux route struct

2021-04-20 Thread Heiko Stübner
Am Dienstag, 20. April 2021, 11:07:27 CEST schrieb Jianqun Xu: > The mux route tables take many lines for each SoC, and it will be more > instances for newly SoC, that makes the file size increase larger. > > This patch only do coding style for mux route struct, by adding a new >

[PATCH v2] pinctrl: rockchip: do coding style for mux route struct

2021-04-20 Thread Jianqun Xu
The mux route tables take many lines for each SoC, and it will be more instances for newly SoC, that makes the file size increase larger. This patch only do coding style for mux route struct, by adding a new definition and replace the structs by script which supplied by huang...@rock-chips.com

Re: [PATCH] pinctrl: rockchip: do coding style for mux route struct

2021-04-20 Thread Heiko Stübner
ckchip; linux-kernel; Jianqun Xu > Subject: Re: [PATCH] pinctrl: rockchip: do coding style for mux route struct > Hi, > > Am Dienstag, 6. April 2021, 04:53:56 CEST schrieb Jianqun Xu: > > The mux route tables take many lines for each SoC, and it will be more > > instances for

Re: [PATCH] pinctrl: rockchip: do coding style for mux route struct

2021-04-20 Thread Heiko Stübner
Hi, Am Dienstag, 6. April 2021, 04:53:56 CEST schrieb Jianqun Xu: > The mux route tables take many lines for each SoC, and it will be more > instances for newly SoC, that makes the file size increase larger. > > This patch only do coding style for mux route struct, by adding a new

Re: [PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-16 Thread Luiz Sampaio
On Fri, Apr 09, 2021 at 07:40:57AM -0700, Joe Perches wrote: > On Fri, 2021-04-09 at 00:09 -0300, Luiz Sampaio wrote: > > Since there is only one statement inside the if clause, no brackets are > > required. > [] > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c > [] >

[PATCH v7 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-16 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v7 1/6] w1: ds2438: fixed a coding style issue

2021-04-16 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slave

Re: [PATCH] PCI: acpiphp: Fixed coding style

2021-04-16 Thread Bjorn Helgaas
On Mon, Mar 01, 2021 at 12:51:45PM +0530, chakravarthikulkarni wrote: > In this commit fixed coding style for braces and comments. > > Signed-off-by: chakravarthikulkarni Applied to pci/hotplug for v5.13, thanks! I dropped the comment change because it's really one comment that

Re: [PATCH v3 0/5] bug fix and clear coding style

2021-04-16 Thread Herbert Xu
On Fri, Apr 09, 2021 at 05:03:59PM +0800, Kai Ye wrote: > Fixup coding style such as delete unneeded variable > initialization. Add a comment for block size initialization. > Add a data cleared operation in sg buf unmap, and other misc fix. > > v1 -> v2: > 1. fix [PATCH v2]

Re: [PATCH] usb: misc: adutux: fix whitespace coding style issue

2021-04-16 Thread Sergei Shtylyov
On 16.04.2021 11:08, Malte Deiseroth wrote: Correct missing space error ceckpatch.pl is complaining about. It's called checkpatch.pl. :-) Signed-off-by: Malte Deiseroth [...] MBR, Sergei

[PATCH] usb: misc: adutux: fix whitespace coding style issue

2021-04-16 Thread Malte Deiseroth
Correct missing space error ceckpatch.pl is complaining about. Signed-off-by: Malte Deiseroth --- drivers/usb/misc/adutux.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/usb/misc/adutux.c b/drivers/usb/misc/adutux.c index 45a387979935..6d15a097b007 100644 ---

Re: [PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c

2021-04-15 Thread ascordeiro
Em qui, 2021-04-15 às 08:48 +0300, Dan Carpenter escreveu: > On Wed, Apr 14, 2021 at 05:42:44PM -0300, Aline Santana Cordeiro > wrote: > > @@ -90,18 +92,14 @@ struct camera_mipi_info > > *atomisp_to_sensor_mipi_info(struct v4l2_subdev *sd) > > return (struct camera_mipi_info > > *)v4l2_get_

Re: [PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Dan Carpenter
On Wed, Apr 14, 2021 at 05:42:44PM -0300, Aline Santana Cordeiro wrote: > @@ -90,18 +92,14 @@ struct camera_mipi_info > *atomisp_to_sensor_mipi_info(struct v4l2_subdev *sd) > return (struct camera_mipi_info *)v4l2_get_subdev_hostdata(sd); > } > > -/* > - * get struct atomisp_video_pipe fr

[PATCH 2/2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.h

2021-04-14 Thread Aline Santana Cordeiro
Format all comments according to the coding-style. Issue detected by checkpatch.pl. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_cmd.h | 161 +++- 1 file changed, 43 insertions(+), 118 deletions(-) diff --git a/drivers/staging/media

[PATCH 1/2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_acc.c

2021-04-14 Thread Aline Santana Cordeiro
Format all comments according to the coding-style. Issue detected by checkpatch.pl. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_acc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/atomisp/pci

Re: [PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Sakari Ailus
On Wed, Apr 14, 2021 at 05:42:44PM -0300, Aline Santana Cordeiro wrote: > Format all comments according to the coding-style. > Issue detected by checkpatch.pl. > > Signed-off-by: Aline Santana Cordeiro Thanks! Acked-by: Sakari Ailus -- Sakari Ailus

[PATCH v2] staging: media: atomisp: pci: Format comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Aline Santana Cordeiro
Format all comments according to the coding-style. Issue detected by checkpatch.pl. Signed-off-by: Aline Santana Cordeiro --- Changes since v1: - Stantardize all the multi-line and single-line comments drivers/staging/media/atomisp/pci/atomisp_cmd.c | 377 +++- 1 file

Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Sakari Ailus
gt; > Format multi-line comments according to the coding-style. > > > Issue detected by checkpatch.pl. > > > > > > Signed-off-by: Aline Santana Cordeiro < > > > alinesantanacorde...@gmail.com> > > > --- > > >  drivers/staging/medi

Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread ascordeiro
Em qua, 2021-04-14 às 21:33 +0300, Sakari Ailus escreveu: > Hi Aline, > > Thanks for the patch. > > On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro > wrote: > > Format multi-line comments according to the coding-style. > > Issue detected by checkpa

Re: [PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Sakari Ailus
Hi Aline, Thanks for the patch. On Wed, Apr 14, 2021 at 03:27:55PM -0300, Aline Santana Cordeiro wrote: > Format multi-line comments according to the coding-style. > Issue detected by checkpatch.pl. > > Signed-off-by: Aline Santana Cordeiro > --- > drivers/staging

[PATCH] staging: media: atomisp: pci: Format multi-line comments according to coding-style in file atomisp_cmd.c

2021-04-14 Thread Aline Santana Cordeiro
Format multi-line comments according to the coding-style. Issue detected by checkpatch.pl. Signed-off-by: Aline Santana Cordeiro --- drivers/staging/media/atomisp/pci/atomisp_cmd.c | 109 ++-- 1 file changed, 65 insertions(+), 44 deletions(-) diff --git a/drivers/staging

Re: [PATCH] Staging: media: atomisp: pci: fixed a curly bracket coding style issue.

2021-04-13 Thread Sakari Ailus
On Sun, Apr 11, 2021 at 04:48:41PM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Fixed a coding style issue. > > Signed-off-by: Dmitrii Wolf Acked-by: Sakari Ailus -- Sakari Ailus

[PATCH 0/3] staging: rtl8723bs: hal: Rectify with Linux kernel coding style

2021-04-12 Thread Beatriz Martins de Carvalho
This patchset rectifies the file Hal8723BReg.h with Linux kernel coding style. The issues were: - Space before tabs; - Extra blank line; - Indentation problem. Beatriz Martins de Carvalho (3): staging: rtl8723bs: hal: remove space before tabs staging: rtl8723bs: hal

[PATCH] Staging: media: atomisp: pci: fixed a curly bracket coding style issue.

2021-04-11 Thread dev . dragon
From: Dmitrii Wolf Fixed a coding style issue. Signed-off-by: Dmitrii Wolf --- drivers/staging/media/atomisp/pci/atomisp_csi2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/staging/media/atomisp/pci

[PATCH] Staging: media: atomisp: pci: fixed a curly bracket coding style issue.

2021-04-10 Thread dev . dragon
From: Dmitrii Wolf Fixed a coding style issue. --- drivers/staging/media/atomisp/pci/atomisp_csi2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/atomisp/pci/atomisp_csi2.c b/drivers/staging/media/atomisp/pci/atomisp_csi2.c index 060b8765ae96

Re: [PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-10 Thread Greg KH
; > } > > -static BIN_ATTR(iad, S_IRUGO | S_IWUSR | S_IWGRP, iad_read, iad_write, 0); > +static BIN_ATTR_RW(iad, 0664, iad_write, 0); You obviously did not build this commit :( And you did more than just fix a "coding style issue". thanks, greg k-h

Re: [PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-09 Thread Joe Perches
On Fri, 2021-04-09 at 00:09 -0300, Luiz Sampaio wrote: > Since there is only one statement inside the if clause, no brackets are > required. [] > diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c [] > @@ -287,9 +287,9 @@ static ssize_t iad_read(struct file *filp, struct kob

Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

2021-04-09 Thread Dan Carpenter
On Sun, Apr 04, 2021 at 08:15:00AM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Signed-off-by: Dmitrii Wolf > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/rtl8192u/ieee80

Re: [PATCH] drm/ttm: cleanup coding style a bit

2021-04-09 Thread Christian König
Am 01.04.21 um 03:59 schrieb Bernard: From: "Christian König" Date: 2021-03-31 21:15:22 To: Bernard Zhao ,Huang Rui ,David Airlie ,Daniel Vetter ,dri-de...@lists.freedesktop.org,linux-kernel@vger.kernel.org Cc: opensource.ker...@vivo.com Subject: Re: [PATCH] drm/ttm: cleanup codi

Re: [PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-09 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Luiz-Sampaio/w1-ds2438-fixed-a-coding-style-issue/20210409-121608 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 17e7124aad766b3f158943acb51467f86220afe9 config: arm-

Re: [PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-09 Thread kernel test robot
umented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Luiz-Sampaio/w1-ds2438-fixed-a-coding-style-issue/20210409-121608 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 17e7124aad766b3f158943acb51467f86220afe9 config: x86_64-

Re: [PATCH v2] gpio: gpio-104-dio-48e: Fixed coding style issues (revised)

2021-04-09 Thread Bartosz Golaszewski
ff-by: Barney Goette > Acked-by: William Breathitt Gray > --- Changed the commit message to `gpio: 104-dio-48e: Fix coding style issues` and applied, thanks! Bartosz

[PATCH v3 0/5] bug fix and clear coding style

2021-04-09 Thread Kai Ye
Fixup coding style such as delete unneeded variable initialization. Add a comment for block size initialization. Add a data cleared operation in sg buf unmap, and other misc fix. v1 -> v2: 1. fix [PATCH v2] error in v1. 2. v1 use a macro replace of magic number, v2 use a comment for bl

Re: [PATCH] crypto: api - fix coding style

2021-04-09 Thread songzhiqi (A)
On 2021/4/9 15:27, Herbert Xu wrote: > On Thu, Apr 01, 2021 at 03:20:49PM +0800, Zhiqi Song wrote: >> Fixed following checkpatch error: >> - do not use assignment in if condition >> Fixed following checkpatch warning: >> - prefer strscpy over strlcpy >> - delete repeated word >> >> Signed-off-by

Re: [PATCH] crypto: cbc - fix coding style

2021-04-09 Thread Herbert Xu
On Thu, Apr 01, 2021 at 03:31:41PM +0800, Zhiqi Song wrote: > Fixed following checkpatch error: > - do not use assignment in if condition > > Signed-off-by: Zhiqi Song > --- > crypto/cbc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) This patch does not appear to improve the code.

Re: [PATCH] crypto: api - fix coding style

2021-04-09 Thread Herbert Xu
On Thu, Apr 01, 2021 at 03:20:49PM +0800, Zhiqi Song wrote: > Fixed following checkpatch error: > - do not use assignment in if condition > Fixed following checkpatch warning: > - prefer strscpy over strlcpy > - delete repeated word > > Signed-off-by: Zhiqi Song > --- > crypto/api.c | 20 +++

Re: [PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-08 Thread Joe Perches
On Fri, 2021-04-09 at 00:09 -0300, Luiz Sampaio wrote: > Since there is only one statement inside the if clause, no brackets are > required. > > Signed-off-by: Luiz Sampaio > --- >  drivers/w1/slaves/w1_ds2438.c | 16 >  1 file changed, 8 insertions(+), 8 deletions(-) > > diff --

[PATCH v6 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-08 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v6 3/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers/

[PATCH v6 1/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slave

[PATCH v5 1/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slave

[PATCH v5 3/6] w1: ds2438: fixed a coding style issue

2021-04-08 Thread Luiz Sampaio
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers/

[PATCH v5 2/6] w1: ds2438: fixed if brackets coding style issue

2021-04-08 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index

[PATCH v2] gpio: gpio-104-dio-48e: Fixed coding style issues (revised)

2021-04-08 Thread Barney Goette
Fixed multiple bare uses of 'unsigned' without 'int'. Fixed space around "*" operator. Fixed function parameter alignment to opening parenthesis. Reported by checkpatch. Signed-off-by: Barney Goette Acked-by: William Breathitt Gray --- drivers/gpio/gpio-104-dio-48e.c | 50 --

Re: [PATCH v3 00/12] acpi: fix some coding style issues

2021-04-08 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 1:11 PM Xiaofei Tan wrote: > > Fix some coding style issues reported by checkpatch.pl. > Only cleanup and no function changes. > > Differences from v2 to v3: > - Remove the modifications that may cause function change. > > Differences from v1 to v

Re: [PATCH v2] ACPI: AC: fix some coding style issues

2021-04-08 Thread Rafael J. Wysocki
On Sat, Mar 27, 2021 at 4:50 AM Xiaofei Tan wrote: > > Fix some coding style issues reported by checkpatch.pl, including > following types: > > ERROR: "foo * bar" should be "foo *bar" > ERROR: code indent should use tabs where possible > WARNING: Block

Re: [PATCH] gpio: gpio-104-dio-48e: Fixed coding style issues

2021-04-08 Thread William Breathitt Gray
On Wed, Apr 07, 2021 at 09:49:00PM -0500, Barney Goette wrote: > Fixed multiple bare uses of 'unsigned' without 'int'. > Fixed space around '*' operator. > Fixed function parameter alignment to opening parenthesis. > Reported by checkpatch. > > Signed-off-by: Barney Goette Acked-by: William Brea

[PATCH] gpio: gpio-104-dio-48e: Fixed coding style issues

2021-04-07 Thread Barney Goette
Fixed multiple bare uses of 'unsigned' without 'int'. Fixed space around '*' operator. Fixed function parameter alignment to opening parenthesis. Reported by checkpatch. Signed-off-by: Barney Goette --- drivers/gpio/gpio-104-dio-48e.c | 53 + 1 file changed, 27 in

Re: [PATCH] Staging: android: ashmem: Fixed a const coding style issue

2021-04-07 Thread kernel test robot
Hi Barney, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Barney-Goette/Staging-android-ashmem-Fixed-a-const-coding-style-issue/20210407-223721 base: https://git.kernel.org/pub/scm/linux

Re: [PATCH] Staging: android: ashmem: Fixed a const coding style issue

2021-04-07 Thread Greg KH
On Wed, Apr 07, 2021 at 09:35:02AM -0500, Barney Goette wrote: > Fixed a coding style issue. > Reported by checkpatch. > > Signed-off-by: Barney Goette > --- > drivers/staging/android/ashmem.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

[PATCH] Staging: android: ashmem: Fixed a const coding style issue

2021-04-07 Thread Barney Goette
Fixed a coding style issue. Reported by checkpatch. Signed-off-by: Barney Goette --- drivers/staging/android/ashmem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c index d66a64e42273..7854fd410efa 100644

[PATCH v3 08/10] tty: tty_ldisc: Fix coding style issues of block comments

2021-04-07 Thread Xiaofei Tan
Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index df0b589

[PATCH v3 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

2021-04-07 Thread Xiaofei Tan
Fix coding style issues of block comments, reported by checkpatch.pl. Besides, do some expression optimization for the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/tty

[PATCH v3 00/10] tty: Fix some coding style issues

2021-04-07 Thread Xiaofei Tan
Fix some issues reported by checkpatch.pl. All of them are coding style issues, no function changes. Differences from v2 to v3: - Fix the misunderstanding of 'period' for the patch 04/10. Differences from v1 to v2: - Remove one redundant tab for the patch 02/10. - Add some

Re: [PATCH v2 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

2021-04-06 Thread Xiaofei Tan
Hi Jiri, On 2021/4/7 13:26, Jiri Slaby wrote: On 06. 04. 21, 13:24, Xiaofei Tan wrote: Fix coding style issues of block comments, reported by checkpatch.pl. Besides, do some expression optimization for the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16

Re: [PATCH v2 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

2021-04-06 Thread Jiri Slaby
On 06. 04. 21, 13:24, Xiaofei Tan wrote: Fix coding style issues of block comments, reported by checkpatch.pl. Besides, do some expression optimization for the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6

[PATCH v2 08/10] tty: tty_ldisc: Fix coding style issues of block comments

2021-04-06 Thread Xiaofei Tan
Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index df0b589

[PATCH v2 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

2021-04-06 Thread Xiaofei Tan
Fix coding style issues of block comments, reported by checkpatch.pl. Besides, do some expression optimization for the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/tty

[PATCH v2 00/10] tty: Fix some coding style issues

2021-04-06 Thread Xiaofei Tan
Fix some issues reported by checkpatch.pl. All of them are coding style issues, no function changes. Differences from v1 to v2: - Remove one redundant tab for the patch 02/10. - Add some expression optimization for some sentenses following - Jiri's advice for the patch 04/10. Xiaofei Ta

[PATCH 0/4] staging: rtl8712: clean up coding style issues

2021-04-06 Thread Zhansaya Bagdauletkyzy
To fix style issues, this patchset removes blank lines, adds and removes spaces, and matches paretheses alignment. Zhansaya Bagdauletkyzy (4): staging: rtl8712: add spaces around operators staging: rtl8712: match parentheses alignment staging: rtl8712: remove extra blank lines staging: rtl

Re: [PATCH 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

2021-04-05 Thread Xiaofei Tan
Hi Jiri, On 2021/4/6 12:42, Jiri Slaby wrote: On 05. 04. 21, 5:34, Xiaofei Tan wrote: Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions

Re: [PATCH 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

2021-04-05 Thread Jiri Slaby
On 05. 04. 21, 5:34, Xiaofei Tan wrote: Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/tty/tty_jobctrl.c b/drivers

[PATCH] pinctrl: rockchip: do coding style for mux route struct

2021-04-05 Thread Jianqun Xu
The mux route tables take many lines for each SoC, and it will be more instances for newly SoC, that makes the file size increase larger. This patch only do coding style for mux route struct, by adding a new definition and replace the structs by script which supplied by huang...@rock-chips.com

Re: [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style

2021-04-05 Thread Luiz Sampaio
On Mon, Apr 05, 2021 at 12:53:22PM +0200, Greg KH wrote: > On Mon, Apr 05, 2021 at 07:50:06AM -0300, Luiz Sampaio wrote: > > Changed the permissions to preferred octal style. > > > > Signed-off-by: Luiz Sampaio > > --- > > drivers/w1/slaves/w1_ds2438.c | 2 +- > > 1 file changed, 1 insertion(+),

Re: [PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 07:50:06AM -0300, Luiz Sampaio wrote: > Changed the permissions to preferred octal style. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/w1/slaves/w1_ds2438.c b/driver

Re: [PATCH v4 2/9] w1: ds2438: fixed a coding style issue in iad_read

2021-04-05 Thread Greg KH
On Mon, Apr 05, 2021 at 07:50:02AM -0300, Luiz Sampaio wrote: > Since there is only one statement inside the if clause, no brackets > are required. > > Signed-off-by: Luiz Sampaio > --- > drivers/w1/slaves/w1_ds2438.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) As this does the

[PATCH v4 6/9] w1: ds2438: fixed a coding style issue to preferred octal style

2021-04-05 Thread Luiz Sampaio
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers/

[PATCH v4 5/9] w1: ds2438: fixed a coding style issue in vdd_read

2021-04-05 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index eeb593294fbd

[PATCH v4 3/9] w1: ds2438: fixed a coding style issue in temperature_read

2021-04-05 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index a5bb53042c93

[PATCH v4 2/9] w1: ds2438: fixed a coding style issue in iad_read

2021-04-05 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 148921fb9702

[PATCH v4 4/9] w1: ds2438: fixed a coding style issue in vad_read

2021-04-05 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index eca50cec304f

[PATCH v4 1/9] w1: ds2438: fixed a coding style issue after return

2021-04-05 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slave

[PATCH 08/10] tty: tty_ldisc: Fix coding style issues of block comments

2021-04-04 Thread Xiaofei Tan
Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_ldisc.c | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/drivers/tty/tty_ldisc.c b/drivers/tty/tty_ldisc.c index df0b589

[PATCH 04/10] tty: tty_jobctrl: Fix coding style issues of block comments

2021-04-04 Thread Xiaofei Tan
Fix coding style issues of block comments, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/tty_jobctrl.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/tty/tty_jobctrl.c b/drivers/tty/tty_jobctrl.c index 86070f7..4d78422

[PATCH 00/10] tty: Fix some coding style issues

2021-04-04 Thread Xiaofei Tan
Fix some issues reported by checkpatch.pl. All of them are coding style issues, no function changes. Xiaofei Tan (10): tty/sysrq: Add a blank line after declarations tty/sysrq: Fix issues of code indent should use tabs tty: tty_jobctrl: Add a blank line after declarations tty: tty_jobctrl

Re: [PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

2021-04-04 Thread Greg KH
On Sun, Apr 04, 2021 at 08:15:00AM +0300, dev.dra...@bk.ru wrote: > From: Dmitrii Wolf > > Signed-off-by: Dmitrii Wolf > --- > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Hi, This is the friendly patch-bot of Greg K

[PATCH] Staging: rtl8192u: ieee80211: fixed a trailing statements coding style issue.

2021-04-03 Thread dev . dragon
From: Dmitrii Wolf Signed-off-by: Dmitrii Wolf --- drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c

[PATCH v3 6/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers/

[PATCH v3 5/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index eeb593294fbd

[PATCH v3 4/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index eca50cec304f

[PATCH v3 3/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index a5bb53042c93

[PATCH v3 1/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slave

[PATCH v3 2/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 148921fb9702

Re: [PATCH v2 6/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread kernel test robot
Hi Luiz, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in htt

Re: [PATCH v2 6/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread kernel test robot
Hi Luiz, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.12-rc5 next-20210401] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in htt

[PATCH v2 6/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Changed the permissions to preferred octal style. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 56e53a748059..ccb06b8c2d78 100644 --- a/drivers/

[PATCH v2 2/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index 148921fb9702

[PATCH v2 5/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index eeb593294fbd

[PATCH v2 4/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index eca50cec304f

[PATCH v2 3/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
Since there is only one statement inside the if clause, no brackets are required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slaves/w1_ds2438.c index a5bb53042c93

[PATCH v2 1/9] w1: ds2438: fixed a coding style issue

2021-04-02 Thread Luiz Sampaio
There is an if statement and, if the function goes into it, it returns. So, the next else is not required. Signed-off-by: Luiz Sampaio --- drivers/w1/slaves/w1_ds2438.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2438.c b/drivers/w1/slave

Re: [PATCH 0/2] net/Blutooth - Coding style fix

2021-04-02 Thread Marcel Holtmann
Hi Meng, > Remove 'return' in void function and fix some coding style > > Meng Yu (2): > Bluetooth: Remove 'return' in void function > Bluetooth: Coding style fix > > net/bluetooth/6lowpan.c | 5 + > net/bluetooth/hci_debugfs.c | 8 ---

[PATCH] drm/kmb: cleanup coding style a bit

2021-04-02 Thread Bernard Zhao
Fix coccicheck warning: drivers/gpu/drm/kmb/kmb_dsi.c:284:3-4: Unneeded semicolon drivers/gpu/drm/kmb/kmb_dsi.c:304:3-4: Unneeded semicolon drivers/gpu/drm/kmb/kmb_dsi.c:321:3-4: Unneeded semicolon drivers/gpu/drm/kmb/kmb_dsi.c:340:3-4: Unneeded semicolon drivers/gpu/drm/kmb/kmb_dsi.c:364:2-3: Unne

[PATCH] drm/gud: cleanup coding style a bit

2021-04-02 Thread Bernard Zhao
Fix coccicheck warning: drivers/gpu/drm/gud/gud_internal.h:89:2-3: Unneeded semicolon drivers/gpu/drm/gud/gud_internal.h:107:2-3: Unneeded semicolon Signed-off-by: Bernard Zhao --- drivers/gpu/drm/gud/gud_internal.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH] drm/amd: cleanup coding style a bit

2021-04-01 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Mar 31, 2021 at 9:36 AM Bernard Zhao wrote: > > Fix patch check warning: > WARNING: suspect code indent for conditional statements (8, 17) > + if (obj && obj->use < 0) { > +DRM_ERROR("RAS ERROR: Unbalance obj(%s) use\n", > obj->head.name); >

[PATCH] crypto: cbc - fix coding style

2021-04-01 Thread Zhiqi Song
Fixed following checkpatch error: - do not use assignment in if condition Signed-off-by: Zhiqi Song --- crypto/cbc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/crypto/cbc.c b/crypto/cbc.c index 6c03e96..152d48d 100644 --- a/crypto/cbc.c +++ b/crypto/cbc.c @@ -140,7 +14

[PATCH] crypto: api - fix coding style

2021-04-01 Thread Zhiqi Song
Fixed following checkpatch error: - do not use assignment in if condition Fixed following checkpatch warning: - prefer strscpy over strlcpy - delete repeated word Signed-off-by: Zhiqi Song --- crypto/api.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/

[PATCH 2/2] Bluetooth: Coding style fix

2021-03-31 Thread Meng Yu
1. Add space when needed; 2. Block comments style fix; 3. Move open brace '{' following function definitions to the next line; 4. Remove unnecessary braces '{}' for single statement blocks. Signed-off-by: Meng Yu --- net/bluetooth/6lowpan.c | 3 +-- net/bluetooth/hci_debugfs.c | 8

[PATCH 0/2] net/Blutooth - Coding style fix

2021-03-31 Thread Meng Yu
Remove 'return' in void function and fix some coding style Meng Yu (2): Bluetooth: Remove 'return' in void function Bluetooth: Coding style fix net/bluetooth/6lowpan.c | 5 + net/bluetooth/hci_debugfs.c | 8 net/bluetooth/hci_event.c | 2 +- net/blu

  1   2   3   4   5   6   7   8   9   10   >