On Sun, Dec 16, 2018 at 08:57:25AM -0800, Amir Mahdi Ghorbanian wrote:
> Fixed a coding style issue.
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
> drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
You already sent this p
On Thu, Dec 13, 2018 at 08:53:17AM -0800, Amir Mahdi Ghorbanian wrote:
> From: Amir Mahdi Ghorbanian
>
> Fixed a coding style issue.
>
> Signed-off-by: Amir Mahdi Ghorbanian
> ---
> drivers/staging/comedi/drivers/8255.h | 2 +-
> 1 file changed, 1 insertion(+), 1 del
Fixed a coding style issue.
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c
b/drivers/staging/comedi/drivers/cb_pcidas.c
index 8429d57..02ae00c
Cleanup brace coding style issues reported by checkpatch.
ERROR: space required before the open brace '{'
WARNING: braces {} are not necessary for single statement blocks
CHECK: Unbalanced braces around else statement
Signed-off-by: Michael Straube
---
drivers/staging/rtl8188eu/core/rtw_cmd.c
Please read the guideline as well before sending patch.
you need to maintain patchset version as well, e.g: in which patchset
what is changed on whose comments.
-Mukesh
On 12/14/2018 3:49 PM, jotun9...@gmail.com wrote:
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off-by: Sungkyung Kim
---
block/partitions/osf.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/block/partitions/osf.c b/block/partitions/osf.c
index 4b873973d6c0..19f8e91979f0 100644
--- a/block/partitions
On 12/14/2018 12:34 PM, jotun9...@gmail.com wrote:
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off-by: Sungkyung Kim
---
block/partitions/osf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/partitions/osf.c b/block/partitions/osf.c
index
From: Sungkyung Kim
Fix coding style of osf.c
Signed-off-by: Sungkyung Kim
---
block/partitions/osf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/partitions/osf.c b/block/partitions/osf.c
index 4b873973d6c0..96921a1e31ce 100644
--- a/block/partitions
Fixed a coding style issue.
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/comedi/drivers/cb_pcidas.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c
b/drivers/staging/comedi/drivers/cb_pcidas.c
index 8429d57..02ae00c
From: Amir Mahdi Ghorbanian
Fixed a coding style issue.
Signed-off-by: Amir Mahdi Ghorbanian
---
drivers/staging/comedi/drivers/8255.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/8255.h
b/drivers/staging/comedi/drivers/8255.h
index
This patch fixes the coding style problem reported
by checkpatch.pl as below:
ERROR: foo* bar should be "foo *bar"
Signed-off-by: Hardik Singh Rathore
---
v3:
- v2 was depends on v1 so it didn't solve the issue.
drivers/input/touchscreen/ad7879.c | 2 +-
drivers/input/touchscreen/
4.14-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
4.14-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
4.9-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
4.9-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
4.4-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
4.4-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
3.18-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
3.18-stable review patch. If anyone has any objections, please let me know.
--
[ Upstream commit 68c78d0155e37992268664e134996d2b140ddf38 ]
Fix some coding style issues reported by checkpatch.pl. Mostly brackets
in macros, spacing and comment style.
Signed-off-by: Leo Sperling
On Tue, Nov 13, 2018 at 10:06:13PM +0800, Kevin Dou wrote:
> follow the linux coding style, rename the variable
> shortGIrate to short_gi_rate.
>
> Signed-off-by: Kevin Dou
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 8
> 1 file changed, 4 insertions(+
On Tue, Nov 13, 2018 at 10:06:13PM +0800, Kevin Dou wrote:
> follow the linux coding style, rename the variable
> shortGIrate to short_gi_rate.
>
> Signed-off-by: Kevin Dou
> ---
> drivers/staging/rtl8188eu/core/rtw_ap.c | 8
> 1 file changed, 4 insertions(+
follow the linux coding style, rename the variable
shortGIrate to short_gi_rate.
Signed-off-by: Kevin Dou
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu
follow the linux coding style, rename the variable
shortGIrate to short_gi_rate.
Signed-off-by: Kevin Dou
---
drivers/staging/rtl8188eu/core/rtw_ap.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c
b/drivers/staging/rtl8188eu
On Sun, Nov 11, 2018 at 08:36:03AM +0800, hmsjwzb wrote:
> Possible unwrapped commit description (prefer a maximum 75 chars per line)
NACK. Our preference is (and always has been) for comments to fill
the entire 80 columns, just like the rest of the kernel. I have no
idea who told you "75 columns
On Sun, Nov 11, 2018 at 08:36:03AM +0800, hmsjwzb wrote:
> Possible unwrapped commit description (prefer a maximum 75 chars per line)
NACK. Our preference is (and always has been) for comments to fill
the entire 80 columns, just like the rest of the kernel. I have no
idea who told you "75 columns
On Sun, 2018-11-11 at 08:36 +0800, hmsjwzb wrote:
> Possible unwrapped commit description (prefer a maximum 75 chars per line)
This commit message makes no sense.
Do say what you do to the code in the commit description.
> Signed-off-by: hmsjwzb
> ---
> fs/xfs/xfs_acl.c | 4 +--
>
On Sun, 2018-11-11 at 08:36 +0800, hmsjwzb wrote:
> Possible unwrapped commit description (prefer a maximum 75 chars per line)
This commit message makes no sense.
Do say what you do to the code in the commit description.
> Signed-off-by: hmsjwzb
> ---
> fs/xfs/xfs_acl.c | 4 +--
>
Possible unwrapped commit description (prefer a maximum 75 chars per line)
Signed-off-by: hmsjwzb
---
fs/xfs/xfs_acl.c | 4 +--
fs/xfs/xfs_aops.c | 73 ---
2 files changed, 39 insertions(+), 38 deletions(-)
diff --git a/fs/xfs/xfs_acl.c
Possible unwrapped commit description (prefer a maximum 75 chars per line)
Signed-off-by: hmsjwzb
---
fs/xfs/xfs_acl.c | 4 +--
fs/xfs/xfs_aops.c | 73 ---
2 files changed, 39 insertions(+), 38 deletions(-)
diff --git a/fs/xfs/xfs_acl.c
As the patch says "extern" with function prototypes makes lines longer
and creates more characters on the screen.
Do not bug people with checkpatch.pl warnings for now as fallout can be
devastating.
Signed-off-by: Alexey Dobriyan
---
Documentation/process/coding-style.rst |3 +++
1 file
As the patch says "extern" with function prototypes makes lines longer
and creates more characters on the screen.
Do not bug people with checkpatch.pl warnings for now as fallout can be
devastating.
Signed-off-by: Alexey Dobriyan
---
Documentation/process/coding-style.rst |3 +++
1 file
Hi,
This is my first series of patches for the Linux kernel.
I started by familiarizing myself with coding style and
satisfying my inner OCD by cleaning the 1-wire subsystem.
Cheers,
Steffen
---
Changes since v1:
- addressed comments from Joe Perches:
- re-ran checkpatch.pl in --strict
Hi,
This is my first series of patches for the Linux kernel.
I started by familiarizing myself with coding style and
satisfying my inner OCD by cleaning the 1-wire subsystem.
Cheers,
Steffen
---
Changes since v1:
- addressed comments from Joe Perches:
- re-ran checkpatch.pl in --strict
These changes fix several warnings emitted by the checkpatch tool.
Signed-off-by: Steffen Vogel
---
drivers/w1/w1.c | 38 +++---
drivers/w1/w1_family.c | 2 +-
drivers/w1/w1_io.c | 40 +---
These changes fix several warnings emitted by the checkpatch tool.
Signed-off-by: Steffen Vogel
---
drivers/w1/w1.c | 38 +++---
drivers/w1/w1_family.c | 2 +-
drivers/w1/w1_io.c | 40 +---
On Sun, Oct 28, 2018 at 5:30 PM Steffen Vogel wrote:
>
> For those who are interested. Rspamd, by default, includes the sender
> address into the list of signed headers:
Ugh. That's just broken.
> There is RFC6377 which discusses this problem. On possible solution is
> a mailing list service
On Sun, Oct 28, 2018 at 5:30 PM Steffen Vogel wrote:
>
> For those who are interested. Rspamd, by default, includes the sender
> address into the list of signed headers:
Ugh. That's just broken.
> There is RFC6377 which discusses this problem. On possible solution is
> a mailing list service
rvalds wrote:
> [ This is not about your patch series per se, only about your email settings ]
>
> On Sun, Oct 28, 2018 at 3:20 PM Steffen Vogel wrote:
> >
> > This is my first series of patches for the Linux kernel.
> > I started by familiarizing myself with coding style and
> &
rvalds wrote:
> [ This is not about your patch series per se, only about your email settings ]
>
> On Sun, Oct 28, 2018 at 3:20 PM Steffen Vogel wrote:
> >
> > This is my first series of patches for the Linux kernel.
> > I started by familiarizing myself with coding style and
> &
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote:
> This satisfies a checkpatch warning
Perhaps run your patches through checkpatch with --strict
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
[]
> @@ -85,7 +85,8 @@ static void w1_slave_release(struct device *dev)
>
On Sun, 2018-10-28 at 23:09 +0100, Steffen Vogel wrote:
> This satisfies a checkpatch warning
Perhaps run your patches through checkpatch with --strict
> diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
[]
> @@ -85,7 +85,8 @@ static void w1_slave_release(struct device *dev)
>
[ This is not about your patch series per se, only about your email settings ]
On Sun, Oct 28, 2018 at 3:20 PM Steffen Vogel wrote:
>
> This is my first series of patches for the Linux kernel.
> I started by familiarizing myself with coding style and
> satisfying my inner OCD by cl
[ This is not about your patch series per se, only about your email settings ]
On Sun, Oct 28, 2018 at 3:20 PM Steffen Vogel wrote:
>
> This is my first series of patches for the Linux kernel.
> I started by familiarizing myself with coding style and
> satisfying my inner OCD by cl
These changes fix several warnings emitted by the checkpatch tool.
Signed-off-by: Steffen Vogel
---
drivers/w1/w1.c | 20 +---
drivers/w1/w1_family.c | 2 +-
drivers/w1/w1_io.c | 17 +
drivers/w1/w1_netlink.c | 2 +-
4 files changed, 20
This satisfies a checkpatch warning
Signed-off-by: Steffen Vogel
---
drivers/w1/w1.c | 56 +
drivers/w1/w1_int.c | 3 ++-
drivers/w1/w1_io.c | 29 +++--
drivers/w1/w1_netlink.c | 16 +-
4 files
These changes fix several warnings emitted by the checkpatch tool.
Signed-off-by: Steffen Vogel
---
drivers/w1/w1.c | 20 +---
drivers/w1/w1_family.c | 2 +-
drivers/w1/w1_io.c | 17 +
drivers/w1/w1_netlink.c | 2 +-
4 files changed, 20
This satisfies a checkpatch warning
Signed-off-by: Steffen Vogel
---
drivers/w1/w1.c | 56 +
drivers/w1/w1_int.c | 3 ++-
drivers/w1/w1_io.c | 29 +++--
drivers/w1/w1_netlink.c | 16 +-
4 files
Hi,
This is my first series of patches for the Linux kernel.
I started by familiarizing myself with coding style and
satisfying my inner OCD by cleaning the 1-wire subsystem.
Steffen
Hi,
This is my first series of patches for the Linux kernel.
I started by familiarizing myself with coding style and
satisfying my inner OCD by cleaning the 1-wire subsystem.
Steffen
* Jordan Borgner wrote:
> Added missing parentheses to sizeof() function in detect_memory_e820().
>
> Removed unnecessary braces in detect_memory_e801().
>
> Replaced three if-statements with a ternary if-statement and
> removed an unnecessary integer variable in detect_memory().
>
> This
* Jordan Borgner wrote:
> Added missing parentheses to sizeof() function in detect_memory_e820().
>
> Removed unnecessary braces in detect_memory_e801().
>
> Replaced three if-statements with a ternary if-statement and
> removed an unnecessary integer variable in detect_memory().
>
> This
On Sat, 2018-10-27 at 23:32 +0100, Jordan Borgner wrote:
> Added missing parentheses to sizeof() function in detect_memory_e820().
>
> Removed unnecessary braces in detect_memory_e801().
>
> Replaced three if-statements with a ternary if-statement and
> removed an unnecessary integer variable
On Sat, 2018-10-27 at 23:32 +0100, Jordan Borgner wrote:
> Added missing parentheses to sizeof() function in detect_memory_e820().
>
> Removed unnecessary braces in detect_memory_e801().
>
> Replaced three if-statements with a ternary if-statement and
> removed an unnecessary integer variable
Added missing parentheses to sizeof() function in detect_memory_e820().
Removed unnecessary braces in detect_memory_e801().
Replaced three if-statements with a ternary if-statement and
removed an unnecessary integer variable in detect_memory().
This is my first patch I hope it is okay.
Added missing parentheses to sizeof() function in detect_memory_e820().
Removed unnecessary braces in detect_memory_e801().
Replaced three if-statements with a ternary if-statement and
removed an unnecessary integer variable in detect_memory().
This is my first patch I hope it is okay.
On 08/24/2018 02:49 PM, Mehdi Bounya wrote:
> Removed a space between function name and open parant.
>
> Signed-off-by: Mehdi Bounya
Patch queued for 4.20, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics
On 08/24/2018 02:49 PM, Mehdi Bounya wrote:
> Removed a space between function name and open parant.
>
> Signed-off-by: Mehdi Bounya
Patch queued for 4.20, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R Institute Poland
Samsung Electronics
Just a number of simple coding style changes in the file
ieee80211_module.c
John Whitmore (11):
staging:rtl8192u: Add missing SPDX-License-Identifier - Style
staging:rtl8192u: Removed commented out include - Style
staging:rtl8192u: Clear error with line ending ( - Style
staging:rtl8192u
Just a number of simple coding style changes in the file
ieee80211_module.c
John Whitmore (11):
staging:rtl8192u: Add missing SPDX-License-Identifier - Style
staging:rtl8192u: Removed commented out include - Style
staging:rtl8192u: Clear error with line ending ( - Style
staging:rtl8192u
Hi,
On 9/29/18 4:03 AM, Maxime Desroches wrote:
> Fixed multiple coding style issues
>
What kind of style issues are you trying to fix?
Please, always be specific about what you are trying to fix. This makes
it easier for the maintainers to review your patch and give you feedback.
Hi,
On 9/29/18 4:03 AM, Maxime Desroches wrote:
> Fixed multiple coding style issues
>
What kind of style issues are you trying to fix?
Please, always be specific about what you are trying to fix. This makes
it easier for the maintainers to review your patch and give you feedback.
Don't just add a 4/4 after a 3/3. Send it as a new series instead.
Also the patch discription and sign off are missing.
regards,
dan carpenter
Don't just add a 4/4 after a 3/3. Send it as a new series instead.
Also the patch discription and sign off are missing.
regards,
dan carpenter
On Sat, Sep 29, 2018 at 12:44:31AM -0400, Maxime Desroches wrote:
> Fixed multiple coding style issues
>
Too vague. Also inaccurate.
regards,
dan carpenter
On Sat, Sep 29, 2018 at 12:44:31AM -0400, Maxime Desroches wrote:
> Fixed multiple coding style issues
>
Too vague. Also inaccurate.
regards,
dan carpenter
You can't have two patches with the same subject.
On Sat, Sep 29, 2018 at 12:43:54AM -0400, Maxime Desroches wrote:
> Fixed multiple braces issues
> Signed-off-by: Maxime Desroches
Put a blank line between the patch description and the Signed-off-by
regards,
dan careptner
You can't have two patches with the same subject.
On Sat, Sep 29, 2018 at 12:43:54AM -0400, Maxime Desroches wrote:
> Fixed multiple braces issues
> Signed-off-by: Maxime Desroches
Put a blank line between the patch description and the Signed-off-by
regards,
dan careptner
On Fri, Sep 28, 2018 at 10:03:00PM -0400, Maxime Desroches wrote:
> Fixed multiple coding style issues
>
> Signed-off-by: Maxime Desroches
> ---
> drivers/staging/rts5208/rtsx_card.c | 96 +++--
> 1 file changed, 37 insertions(+), 5
On Fri, Sep 28, 2018 at 10:03:00PM -0400, Maxime Desroches wrote:
> Fixed multiple coding style issues
>
> Signed-off-by: Maxime Desroches
> ---
> drivers/staging/rts5208/rtsx_card.c | 96 +++--
> 1 file changed, 37 insertions(+), 5
---
drivers/staging/rts5208/sd.c | 704 +--
1 file changed, 268 insertions(+), 436 deletions(-)
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index e7efa34195c7..930c61ccb047 100644
--- a/drivers/staging/rts5208/sd.c
+++
---
drivers/staging/rts5208/sd.c | 704 +--
1 file changed, 268 insertions(+), 436 deletions(-)
diff --git a/drivers/staging/rts5208/sd.c b/drivers/staging/rts5208/sd.c
index e7efa34195c7..930c61ccb047 100644
--- a/drivers/staging/rts5208/sd.c
+++
---
drivers/staging/rts5208/rtsx_scsi.c | 108 ++--
1 file changed, 36 insertions(+), 72 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c
b/drivers/staging/rts5208/rtsx_scsi.c
index c9a6d97938f6..9c594a778425 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
---
drivers/staging/rts5208/rtsx_scsi.c | 108 ++--
1 file changed, 36 insertions(+), 72 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_scsi.c
b/drivers/staging/rts5208/rtsx_scsi.c
index c9a6d97938f6..9c594a778425 100644
--- a/drivers/staging/rts5208/rtsx_scsi.c
Fixed multiple coding style issues
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_card.c | 96 +++--
1 file changed, 37 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_card.c
b/drivers/staging/rts5208/rtsx_card.c
index
Fixed multiple coding style issues
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_card.c | 96 +++--
1 file changed, 37 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_card.c
b/drivers/staging/rts5208/rtsx_card.c
index
Fixed multiple braces issues
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_chip.c | 463
1 file changed, 199 insertions(+), 264 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers/staging/rts5208/rtsx_chip.c
index
Fixed multiple braces issues
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_chip.c | 463
1 file changed, 199 insertions(+), 264 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_chip.c
b/drivers/staging/rts5208/rtsx_chip.c
index
Fixed multiple coding style issues
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_card.c | 96 +++--
1 file changed, 37 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_card.c
b/drivers/staging/rts5208/rtsx_card.c
index
Fixed multiple coding style issues
Signed-off-by: Maxime Desroches
---
drivers/staging/rts5208/rtsx_card.c | 96 +++--
1 file changed, 37 insertions(+), 59 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx_card.c
b/drivers/staging/rts5208/rtsx_card.c
index
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote:
> fixed some "Alignment should match open parenthesis" checks.
> Signing up for the kernel clean up crew while I learn C
>
> Signed-off-by: Aaron Williams
> ---
> drivers/staging/greybus/control.c | 39
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote:
> fixed some "Alignment should match open parenthesis" checks.
> Signing up for the kernel clean up crew while I learn C
>
> Signed-off-by: Aaron Williams
> ---
> drivers/staging/greybus/control.c | 39
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote:
> fixed some "Alignment should match open parenthesis" checks.
Note that this is not something that is mandated by the kernel coding
style, but rather a preference of the authors of checkpatch (and the
check is only
On Thu, Sep 20, 2018 at 10:38:28PM +1000, Aaron Williams wrote:
> fixed some "Alignment should match open parenthesis" checks.
Note that this is not something that is mandated by the kernel coding
style, but rather a preference of the authors of checkpatch (and the
check is only
fixed some "Alignment should match open parenthesis" checks.
Signing up for the kernel clean up crew while I learn C
Signed-off-by: Aaron Williams
---
drivers/staging/greybus/control.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git
fixed some "Alignment should match open parenthesis" checks.
Signing up for the kernel clean up crew while I learn C
Signed-off-by: Aaron Williams
---
drivers/staging/greybus/control.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git
On Sun, Sep 16, 2018 at 04:39:11PM -0300, Pablo Pellecchia wrote:
> Solved parenthesis alignment issues throw by checkpatch.pl
>
> Signed-off-by: Pablo Pellecchia
> ---
> drivers/staging/wlan-ng/cfg80211.c | 40
> ++
> 1 file changed, 19 insertions(+), 21
On Sun, Sep 16, 2018 at 04:39:11PM -0300, Pablo Pellecchia wrote:
> Solved parenthesis alignment issues throw by checkpatch.pl
>
> Signed-off-by: Pablo Pellecchia
> ---
> drivers/staging/wlan-ng/cfg80211.c | 40
> ++
> 1 file changed, 19 insertions(+), 21
evel,
+ data);
if (result) {
err = -EFAULT;
--
2.14.1
>From 16682e3ba99b18e6ecead3865ce2d06459281887 Mon Sep 17 00:00:00 2001
From: Pablo Pellecchia
Date: Sun, 16 Sep 2018 15:56:36 -0300
Subject: [PATCH 2/4] Staging: wlan-ng: Solved coding st
evel,
+ data);
if (result) {
err = -EFAULT;
--
2.14.1
>From 16682e3ba99b18e6ecead3865ce2d06459281887 Mon Sep 17 00:00:00 2001
From: Pablo Pellecchia
Date: Sun, 16 Sep 2018 15:56:36 -0300
Subject: [PATCH 2/4] Staging: wlan-ng: Solved coding st
On Sun, Sep 16, 2018 at 01:23:26AM -0300, Pablo Pellecchia wrote:
> Fixed coding style issues on wlan-ng directory.
>
> Changes include:
> - Parenthesis alignment
> - Wrong casting issues
> - Adding comments
> - Lines ending with '('
>
> Sign
On Sun, Sep 16, 2018 at 01:23:26AM -0300, Pablo Pellecchia wrote:
> Fixed coding style issues on wlan-ng directory.
>
> Changes include:
> - Parenthesis alignment
> - Wrong casting issues
> - Adding comments
> - Lines ending with '('
>
> Sign
Fixed coding style issues on wlan-ng directory.
Changes include:
- Parenthesis alignment
- Wrong casting issues
- Adding comments
- Lines ending with '('
Signed-off-by: Pablo Pellecchia
---
drivers/staging/wlan-ng/cfg80211.c | 40
Fixed coding style issues on wlan-ng directory.
Changes include:
- Parenthesis alignment
- Wrong casting issues
- Adding comments
- Lines ending with '('
Signed-off-by: Pablo Pellecchia
---
drivers/staging/wlan-ng/cfg80211.c | 40
Fixed coding style issue.
Signed-off-by: Pablo Pellecchia
---
lib/rbtree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rbtree.c b/lib/rbtree.c
index d3ff682fd4b8..c47745c39671 100644
--- a/lib/rbtree.c
+++ b/lib/rbtree.c
@@ -539,7 +539,7 @@ struct rb_node *rb_next
Fixed coding style issue.
Signed-off-by: Pablo Pellecchia
---
lib/rbtree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rbtree.c b/lib/rbtree.c
index d3ff682fd4b8..c47745c39671 100644
--- a/lib/rbtree.c
+++ b/lib/rbtree.c
@@ -539,7 +539,7 @@ struct rb_node *rb_next
From: Romain Aviolat
Date: Fri, 14 Sep 2018 22:25:40 +0200
> Fixing multiple coding style issues:
> * prohibited spaces before that ','
> * spaces before tabs
>
> Signed-off-by: Romain Aviolat
This kind of coding style fix has very little value for a subsystem
which
From: Romain Aviolat
Date: Fri, 14 Sep 2018 22:25:40 +0200
> Fixing multiple coding style issues:
> * prohibited spaces before that ','
> * spaces before tabs
>
> Signed-off-by: Romain Aviolat
This kind of coding style fix has very little value for a subsystem
which
Fixing multiple coding style issues:
* prohibited spaces before that ','
* spaces before tabs
Signed-off-by: Romain Aviolat
---
drivers/ide/ide-dma.c | 74 +--
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/ide/ide
Fixing multiple coding style issues:
* prohibited spaces before that ','
* spaces before tabs
Signed-off-by: Romain Aviolat
---
drivers/ide/ide-dma.c | 74 +--
1 file changed, 37 insertions(+), 37 deletions(-)
diff --git a/drivers/ide/ide
Fixed coding style issue.
Signed-off-by: Pablo Pellecchia
---
lib/rbtree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/rbtree.c b/lib/rbtree.c
index d3ff682fd4b8..c47745c39671 100644
--- a/lib/rbtree.c
+++ b/lib/rbtree.c
@@ -539,7 +539,7 @@ struct rb_node *rb_next
801 - 900 of 9509 matches
Mail list logo
