Re: [PATCH] gpio/grgpio: fix deadlock in grgpio_irq_unmap()

2015-08-17 Thread Linus Walleij
On Mon, Aug 17, 2015 at 10:23 AM, Alexandre Courbot wrote: > As reported by Alexey Khoroshilov: > > grgpio_irq_unmap() code looks quite suspicious regarding usage of > priv->bgc.lock spinlock. > > It locks the spinlock in line 310: > > spin_lock_irqsave(&priv->bgc.lock, flags)

[PATCH] gpio/grgpio: fix deadlock in grgpio_irq_unmap()

2015-08-17 Thread Alexandre Courbot
As reported by Alexey Khoroshilov: grgpio_irq_unmap() code looks quite suspicious regarding usage of priv->bgc.lock spinlock. It locks the spinlock in line 310: spin_lock_irqsave(&priv->bgc.lock, flags); and then it can call grgpio_set_imask() in line 317: grgpi

Re: Deadlock in grgpio_irq_unmap()

2015-08-17 Thread Alexandre Courbot
On Mon, Aug 3, 2015 at 1:15 AM, Alexey Khoroshilov wrote: > Dear colleagus, > > grgpio_irq_unmap() code looks quite suspicious regarding usage of > priv->bgc.lock spinlock. > > It locks the spinlock in line 310: > spin_lock_irqsave(&priv->bgc.lock, flags); > and then it can call grgpio_set

Deadlock in grgpio_irq_unmap()

2015-08-02 Thread Alexey Khoroshilov
Dear colleagus, grgpio_irq_unmap() code looks quite suspicious regarding usage of priv->bgc.lock spinlock. It locks the spinlock in line 310: spin_lock_irqsave(&priv->bgc.lock, flags); and then it can call grgpio_set_imask() in line 317: grgpio_set_imask(priv, i, 0); But grgpio_s