Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

2013-07-18 Thread Greg Kroah-Hartman
On Thu, Jul 18, 2013 at 04:54:17PM -0700, Guenter Roeck wrote: > On Sun, Jul 14, 2013 at 04:05:50PM -0700, Greg Kroah-Hartman wrote: > > Hi all, > > > > Here is the third iteration of the patchset to add better attribute > > group support to the driver core and sysfs. > > > > Others have now test

Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

2013-07-18 Thread Guenter Roeck
On Sun, Jul 14, 2013 at 04:05:50PM -0700, Greg Kroah-Hartman wrote: > Hi all, > > Here is the third iteration of the patchset to add better attribute > group support to the driver core and sysfs. > > Others have now tested it, and we got 3 more patches fixing a warning > that was showing up when

Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

2013-07-15 Thread Ian Abbott
On 2013-07-15 10:41, Ian Abbott wrote: On 2013-07-15 00:05, Greg Kroah-Hartman wrote: Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later. I considered it, but that would also mean a BUS_PATTR() and the like, which I guess works, but I hate even a _hint_ of "Hungarian" notation, w

Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

2013-07-15 Thread Ian Abbott
On 2013-07-15 00:05, Greg Kroah-Hartman wrote: Ian, I didn't add a DEVICE_PATTR() macro yet, that can come later. I considered it, but that would also mean a BUS_PATTR() and the like, which I guess works, but I hate even a _hint_ of "Hungarian" notation, which this implies. Anyone else have a b

Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

2013-07-14 Thread Greg Kroah-Hartman
On Mon, Jul 15, 2013 at 10:27:00AM +1000, Stephen Rothwell wrote: > Hi Greg, > > On Sun, 14 Jul 2013 16:05:50 -0700 Greg Kroah-Hartman > wrote: > > > > Anyone else have a better name for this macro: > > #define DEVICE_PATTR(_name) &dev_attr_##_name.attr > > that they can think of? It wi

Re: [PATCH v3 01/10] Driver core and sysfs changes for attribute groups

2013-07-14 Thread Stephen Rothwell
Hi Greg, On Sun, 14 Jul 2013 16:05:50 -0700 Greg Kroah-Hartman wrote: > > Anyone else have a better name for this macro: > #define DEVICE_PATTR(_name) &dev_attr_##_name.attr > that they can think of? It will cut down on the typing done for > attribute lists. Just one small peeve I ha

[PATCH v3 01/10] Driver core and sysfs changes for attribute groups

2013-07-14 Thread Greg Kroah-Hartman
Hi all, Here is the third iteration of the patchset to add better attribute group support to the driver core and sysfs. Others have now tested it, and we got 3 more patches fixing a warning that was showing up when binary attributes were in a group with no "normal" attributes, and some more helpe

Re: [PATCH v2 0/7] Driver core and sysfs changes for attribute groups

2013-07-14 Thread Guenter Roeck
On Sun, Jul 14, 2013 at 10:32:58AM -0700, Greg Kroah-Hartman wrote: > On Sun, Jul 14, 2013 at 10:27:03AM -0700, Guenter Roeck wrote: > > On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote: > > > Hi all, > > > > > > Here's the second iteration of the patchset to add better attribute

Re: [PATCH v2 0/7] Driver core and sysfs changes for attribute groups

2013-07-14 Thread Greg Kroah-Hartman
On Sun, Jul 14, 2013 at 10:27:03AM -0700, Guenter Roeck wrote: > On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote: > > Hi all, > > > > Here's the second iteration of the patchset to add better attribute > > group support to the driver core and sysfs. > > > > I've tested these (s

Re: [PATCH v2 0/7] Driver core and sysfs changes for attribute groups

2013-07-14 Thread Guenter Roeck
On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote: > Hi all, > > Here's the second iteration of the patchset to add better attribute > group support to the driver core and sysfs. > > I've tested these (shocker!) and everything works fine with them (I'm > sending this from Linus's

Re: [PATCH v2 0/7] Driver core and sysfs changes for attribute groups

2013-07-11 Thread Oliver Schinagl
On 11-07-13 08:28, Greg Kroah-Hartman wrote: On Wed, Jul 10, 2013 at 10:23:57PM -0700, Guenter Roeck wrote: On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote: Hi all, Here's the second iteration of the patchset to add better attribute group support to the driver core and sysfs

Re: [PATCH v2 0/7] Driver core and sysfs changes for attribute groups

2013-07-10 Thread Greg Kroah-Hartman
On Wed, Jul 10, 2013 at 10:23:57PM -0700, Guenter Roeck wrote: > On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote: > > Hi all, > > > > Here's the second iteration of the patchset to add better attribute > > group support to the driver core and sysfs. > > > > I've tested these (s

Re: [PATCH v2 0/7] Driver core and sysfs changes for attribute groups

2013-07-10 Thread Guenter Roeck
On Wed, Jul 10, 2013 at 05:35:58PM -0700, Greg Kroah-Hartman wrote: > Hi all, > > Here's the second iteration of the patchset to add better attribute > group support to the driver core and sysfs. > > I've tested these (shocker!) and everything works fine with them (I'm > sending this from Linus's

[PATCH v2 0/7] Driver core and sysfs changes for attribute groups

2013-07-10 Thread Greg Kroah-Hartman
Hi all, Here's the second iteration of the patchset to add better attribute group support to the driver core and sysfs. I've tested these (shocker!) and everything works fine with them (I'm sending this from Linus's latest kernel with these 7 on top of it.) I'd like to send these to Linus for 3.

Re: Driver core and sysfs changes for attribute groups

2013-07-10 Thread Guenter Roeck
On Wed, Jul 10, 2013 at 03:23:37PM -0700, Greg Kroah-Hartman wrote: > On Wed, Jul 10, 2013 at 03:04:41PM -0700, Guenter Roeck wrote: > > On Wed, Jul 10, 2013 at 01:05:08PM -0700, Greg Kroah-Hartman wrote: > > > Hi all, > > > > > > Guenter and Oliver have been pointing out a few limitations of the

Re: Driver core and sysfs changes for attribute groups

2013-07-10 Thread Greg Kroah-Hartman
On Wed, Jul 10, 2013 at 03:04:41PM -0700, Guenter Roeck wrote: > On Wed, Jul 10, 2013 at 01:05:08PM -0700, Greg Kroah-Hartman wrote: > > Hi all, > > > > Guenter and Oliver have been pointing out a few limitations of the > > driver core's ability to create files properly (i.e. in a way that > > doe

Re: Driver core and sysfs changes for attribute groups

2013-07-10 Thread Guenter Roeck
On Wed, Jul 10, 2013 at 01:05:08PM -0700, Greg Kroah-Hartman wrote: > Hi all, > > Guenter and Oliver have been pointing out a few limitations of the > driver core's ability to create files properly (i.e. in a way that > doesn't race with userspace.) The driver core allows this, but it > doesn't e

Re: Driver core and sysfs changes for attribute groups

2013-07-10 Thread Oliver Schinagl
On 07/10/13 22:05, Greg Kroah-Hartman wrote: Hi all, Hey Greg, Guenter and Oliver have been pointing out a few limitations of the driver core's ability to create files properly (i.e. in a way that doesn't race with userspace.) The driver core allows this, but it doesn't export that ability t

Driver core and sysfs changes for attribute groups

2013-07-10 Thread Greg Kroah-Hartman
Hi all, Guenter and Oliver have been pointing out a few limitations of the driver core's ability to create files properly (i.e. in a way that doesn't race with userspace.) The driver core allows this, but it doesn't export that ability to drivers very easily, and for binary files, not at all. So