3.18-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
3.18-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.4-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.4-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.18-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.18-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.14-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.14-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.9-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
4.9-stable review patch. If anyone has any objections, please let me know.
--
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: Akinobu Mita
[ Upstream commit 30ed2b83343bd1e07884ca7355dac70d25ffc158 ]
When the subdevice doesn't provide s_power core ops callback, the
v4l2_subdev_call for s_power returns -ENOIOCTLCMD. If the subdevice
doesn't have the special handling for its power saving mode, the s_power
isn't
From: David Daney
The Linux Way is to return -ENOIOCTLCMD to the vfs when an
unimplemented ioctl is requested. Do this in kvm_mips instead of a
random mixture of -ENOTSUPP and -EINVAL.
Signed-off-by: David Daney
Acked-by: Sanjay Lal
---
arch/mips/kvm/kvm_mips.c | 18 +-
1
From: David Daney david.da...@cavium.com
The Linux Way is to return -ENOIOCTLCMD to the vfs when an
unimplemented ioctl is requested. Do this in kvm_mips instead of a
random mixture of -ENOTSUPP and -EINVAL.
Signed-off-by: David Daney david.da...@cavium.com
Acked-by: Sanjay Lal sanj
From: David Daney
The Linux Way is to return -ENOIOCTLCMD to the vfs when an
unimplemented ioctl is requested. Do this in kvm_mips instead of a
random mixture of -ENOTSUPP and -EINVAL.
Signed-off-by: David Daney
---
arch/mips/kvm/kvm_mips.c | 18 +-
1 file changed, 9
From: David Daney david.da...@cavium.com
The Linux Way is to return -ENOIOCTLCMD to the vfs when an
unimplemented ioctl is requested. Do this in kvm_mips instead of a
random mixture of -ENOTSUPP and -EINVAL.
Signed-off-by: David Daney david.da...@cavium.com
---
arch/mips/kvm/kvm_mips.c | 18
From: David Daney
The Linux Way is to return -ENOIOCTLCMD to the vfs when an
unimplemented ioctl is requested. Do this in kvm_mips instead of a
random mixture of -ENOTSUPP and -EINVAL.
Signed-off-by: David Daney
---
arch/mips/kvm/kvm_mips.c | 18 +-
1 file changed, 9
From: David Daney david.da...@cavium.com
The Linux Way is to return -ENOIOCTLCMD to the vfs when an
unimplemented ioctl is requested. Do this in kvm_mips instead of a
random mixture of -ENOTSUPP and -EINVAL.
Signed-off-by: David Daney david.da...@cavium.com
---
arch/mips/kvm/kvm_mips.c | 18
On 09/13/2012 12:03 PM, Laurent Pinchart wrote:
> Hi Wanlong,
>
> Thanks for the patch.
>
> On Monday 27 August 2012 15:23:15 Wanlong Gao wrote:
>> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
>> translated as ENOTTY to user mode.
>>
>
Hi Wanlong,
Thanks for the patch.
On Monday 27 August 2012 15:23:15 Wanlong Gao wrote:
> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> translated as ENOTTY to user mode.
>
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: linux-me...@vger.kerne
Hi Wanlong,
Thanks for the patch.
On Monday 27 August 2012 15:23:15 Wanlong Gao wrote:
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
On 09/13/2012 12:03 PM, Laurent Pinchart wrote:
Hi Wanlong,
Thanks for the patch.
On Monday 27 August 2012 15:23:15 Wanlong Gao wrote:
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Laurent Pinchart laurent.pinch
From: Wanlong Gao
Date: Mon, 27 Aug 2012 15:23:13 +0800
> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> translated as ENOTTY to user mode.
>
> Cc: "David S. Miller"
> Cc: net...@vger.kernel.org
> Signed-off-by: Wanlong Gao
Applied to net-nex
From: Wanlong Gao gaowanl...@cn.fujitsu.com
Date: Mon, 27 Aug 2012 15:23:13 +0800
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: David S. Miller da...@davemloft.net
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl
On Mon, 27 Aug 2012 15:23:12 +0800
Wanlong Gao wrote:
> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> translated as ENOTTY to user mode.
> For example:
> fd = open("/dev/tty", O_RDWR);
> ioctl(fd, -1, );
>
> then the errno
0/block/dasd_eckd.c
> @@ -3804,7 +3804,7 @@ dasd_eckd_ioctl(struct dasd_block *block,
> unsigned int cmd, void __user *argp)
> case BIODASDSYMMIO:
>return dasd_symm_io(device, argp);
> default:
> - return -ENOIOCTLCMD;
> + return -ENOTTY;
> }
> }
On Mon, Aug 27, 2012 at 03:23:16PM +0800, Wanlong Gao wrote:
> At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
> translated as ENOTTY to user mode.
>
[...]
> Signed-off-by: Wanlong Gao
> ---
> drivers/s390/block/dasd_ioctl.c | 2 +-
> 1 file changed, 1 ins
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
For example:
fd = open("/dev/tty", O_RDWR);
ioctl(fd, -1, );
then the errno should be ENOTTY but not EINVAL.
Cc: Greg Kroah-Hartman
Signed-off-by: Wanlong Gao
---
d
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/media/dvb/dvb-core/dvbdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Laurent Pinchart
Cc: Mauro Carvalho Chehab
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
drivers/media/video/omap3isp/ispvideo.c | 10 +-
1 file changed, 5
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Martin Schwidefsky
Cc: Heiko Carstens
Cc: linux...@de.ibm.com
Cc: linux-s...@vger.kernel.org (open list:S390)
Signed-off-by: Wanlong Gao
---
drivers/s390/block/dasd_ioctl.c | 2 +-
1 file
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: "David S. Miller"
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao
---
net/atm/resources.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/atm/resourc
At this commit,
Cc: Linus Torvalds
commit 07d106d0a33d6063d2061305903deb02489eba20
Author: Linus Torvalds
Date: Thu Jan 5 15:40:12 2012 -0800
vfs: fix up ENOIOCTLCMD error handling
We're doing some odd things there, which already messes up various users
(see the net/socket.c
At this commit,
Cc: Linus Torvalds torva...@linux-foundation.org
commit 07d106d0a33d6063d2061305903deb02489eba20
Author: Linus Torvalds torva...@linux-foundation.org
Date: Thu Jan 5 15:40:12 2012 -0800
vfs: fix up ENOIOCTLCMD error handling
We're doing some odd things there, which
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: David S. Miller da...@davemloft.net
Cc: net...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
net/atm/resources.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Martin Schwidefsky schwidef...@de.ibm.com
Cc: Heiko Carstens heiko.carst...@de.ibm.com
Cc: linux...@de.ibm.com
Cc: linux-s...@vger.kernel.org (open list:S390)
Signed-off-by: Wanlong Gao gaowanl
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
Cc: Mauro Carvalho Chehab mche...@infradead.org
Cc: linux-me...@vger.kernel.org
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/media/dvb/dvb-core/dvbdev.c | 2 +-
1 file changed
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
For example:
fd = open(/dev/tty, O_RDWR);
ioctl(fd, -1, argp);
then the errno should be ENOTTY but not EINVAL.
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off
On Mon, Aug 27, 2012 at 03:23:16PM +0800, Wanlong Gao wrote:
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
[...]
Signed-off-by: Wanlong Gao gaowanl...@cn.fujitsu.com
---
drivers/s390/block/dasd_ioctl.c | 2 +-
1 file changed, 1
@@ -3804,7 +3804,7 @@ dasd_eckd_ioctl(struct dasd_block *block,
unsigned int cmd, void __user *argp)
case BIODASDSYMMIO:
return dasd_symm_io(device, argp);
default:
- return -ENOIOCTLCMD;
+ return -ENOTTY;
}
}
diff --git a/drivers/s390/block/dasd_ioctl.c
On Mon, 27 Aug 2012 15:23:12 +0800
Wanlong Gao gaowanl...@cn.fujitsu.com wrote:
At commit 07d106d0, Linus pointed out that ENOIOCTLCMD should be
translated as ENOTTY to user mode.
For example:
fd = open(/dev/tty, O_RDWR);
ioctl(fd, -1, argp);
then the errno should be ENOTTY
At 5:45 PM +0100 2001-05-13, Alan Cox wrote:
> > What I was arguing (conceptually) is that something like
>> #define ENOIOCTLCMD ENOTTY
>> or preferably but more invasively s/ENOIOCTLCMD/ENOTTY/ (mutatis mutandis)
>>
>> would result in no loss of funct
> What I was arguing (conceptually) is that something like
> #define ENOIOCTLCMD ENOTTY
> or preferably but more invasively s/ENOIOCTLCMD/ENOTTY/ (mutatis mutandis)
>
> would result in no loss of function. I assert that ENOIOCTLCMD is
> redundant, pending a speci
t; one wants.
>
>It allows driver specific code to override generic code, including
>by reporting
>that a given feature is not available/appropriate.
>
>Alan
What I was arguing (conceptually) is that something like
#define ENOIOCTLCMD ENOTTY
or preferably but more invasively s/
At 3:27 PM -0700 2001-05-12, Shane Wegner wrote:
> >int err = dev->ioctlfunc(dev, op, arg);
>> if( err != -ENOIOCTLCMD)
>> return err;
>>
>> /* Driver specific code does not support this ioctl */
>
>I noticed this return coming
At 3:27 PM -0700 2001-05-12, Shane Wegner wrote:
int err = dev-ioctlfunc(dev, op, arg);
if( err != -ENOIOCTLCMD)
return err;
/* Driver specific code does not support this ioctl */
I noticed this return coming out of the watchdog driver a
while ago when I
code to override generic code, including
by reporting
that a given feature is not available/appropriate.
Alan
What I was arguing (conceptually) is that something like
#define ENOIOCTLCMD ENOTTY
or preferably but more invasively s/ENOIOCTLCMD/ENOTTY/ (mutatis mutandis)
would result in no loss
What I was arguing (conceptually) is that something like
#define ENOIOCTLCMD ENOTTY
or preferably but more invasively s/ENOIOCTLCMD/ENOTTY/ (mutatis mutandis)
would result in no loss of function. I assert that ENOIOCTLCMD is
redundant, pending a specific counterexample.
On the contrary
At 5:45 PM +0100 2001-05-13, Alan Cox wrote:
What I was arguing (conceptually) is that something like
#define ENOIOCTLCMD ENOTTY
or preferably but more invasively s/ENOIOCTLCMD/ENOTTY/ (mutatis mutandis)
would result in no loss of function. I assert that ENOIOCTLCMD is
redundant
On Sat, May 12, 2001 at 12:16:09PM +0100, Alan Cox wrote:
> > Can somebody explain the use of ENOIOCTLCMD? There are order of 170
> > uses in the kernel, but I don't see any guidelines for that use (nor
> > what prevents it from being seen by user programs).
>
> It shou
> That's what's confusing me: why the distinction? It's true that the
> current scheme allows the dev->ioctlfunc() call below to force ENOTTY
> to be returned, bypassing the switch, but presumably that's not what
> one wants.
It allows driver specific code to override generic code, including
At 12:16 PM +0100 2001-05-12, Alan Cox wrote:
> > Can somebody explain the use of ENOIOCTLCMD? There are order of 170
>> uses in the kernel, but I don't see any guidelines for that use (nor
>> what prevents it from being seen by user programs).
>
>It should never be
On Sat, 12 May 2001, Alan Cox wrote:
> > Can somebody explain the use of ENOIOCTLCMD? There are order of 170
> > uses in the kernel, but I don't see any guidelines for that use (nor
> > what prevents it from being seen by user programs).
>
> It should never be
> Can somebody explain the use of ENOIOCTLCMD? There are order of 170
> uses in the kernel, but I don't see any guidelines for that use (nor
> what prevents it from being seen by user programs).
It should never be seen by apps. If it can be then it is wrong code.
Basically you use it
On Fri, May 11, 2001 at 10:01:50PM -0700, Jonathan Lundell wrote:
> Can somebody explain the use of ENOIOCTLCMD? There are order of 170
> uses in the kernel, but I don't see any guidelines for that use (nor
> what prevents it from being seen by user programs).
The idea with EN
On Fri, May 11, 2001 at 10:01:50PM -0700, Jonathan Lundell wrote:
Can somebody explain the use of ENOIOCTLCMD? There are order of 170
uses in the kernel, but I don't see any guidelines for that use (nor
what prevents it from being seen by user programs).
The idea with ENOIOCTLCMD
Can somebody explain the use of ENOIOCTLCMD? There are order of 170
uses in the kernel, but I don't see any guidelines for that use (nor
what prevents it from being seen by user programs).
It should never be seen by apps. If it can be then it is wrong code.
Basically you use it in things
On Sat, 12 May 2001, Alan Cox wrote:
Can somebody explain the use of ENOIOCTLCMD? There are order of 170
uses in the kernel, but I don't see any guidelines for that use (nor
what prevents it from being seen by user programs).
It should never be seen by apps. If it can be then it is wrong
At 12:16 PM +0100 2001-05-12, Alan Cox wrote:
Can somebody explain the use of ENOIOCTLCMD? There are order of 170
uses in the kernel, but I don't see any guidelines for that use (nor
what prevents it from being seen by user programs).
It should never be seen by apps. If it can
That's what's confusing me: why the distinction? It's true that the
current scheme allows the dev-ioctlfunc() call below to force ENOTTY
to be returned, bypassing the switch, but presumably that's not what
one wants.
It allows driver specific code to override generic code, including by
On Sat, May 12, 2001 at 12:16:09PM +0100, Alan Cox wrote:
Can somebody explain the use of ENOIOCTLCMD? There are order of 170
uses in the kernel, but I don't see any guidelines for that use (nor
what prevents it from being seen by user programs).
It should never be seen by apps
Can somebody explain the use of ENOIOCTLCMD? There are order of 170
uses in the kernel, but I don't see any guidelines for that use (nor
what prevents it from being seen by user programs).
Thanks.
errno.h:
>/* Should never be seen by user programs */
>#define ERESTARTSYS512
&g
Can somebody explain the use of ENOIOCTLCMD? There are order of 170
uses in the kernel, but I don't see any guidelines for that use (nor
what prevents it from being seen by user programs).
Thanks.
errno.h:
/* Should never be seen by user programs */
#define ERESTARTSYS512
#define
72 matches
Mail list logo
