Re: Extend clear_page by an order parameter

2005-01-24 Thread Christoph Lameter
On Mon, 24 Jan 2005, David S. Miller wrote: > On Mon, 24 Jan 2005 08:37:15 -0800 (PST) > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > Then it may also be better to pass the page struct to clear_pages > > instead of a memory address. > > What is more generally available at the call sites at t

Re: Extend clear_page by an order parameter

2005-01-24 Thread David S. Miller
On Mon, 24 Jan 2005 08:37:15 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > Then it may also be better to pass the page struct to clear_pages > instead of a memory address. What is more generally available at the call sites at this time? Consider both HIGHMEM and non-HIGHMEM setups in

Re: Extend clear_page by an order parameter

2005-01-24 Thread Christoph Lameter
On Sat, 22 Jan 2005, Andrew Morton wrote: > Christoph Lameter <[EMAIL PROTECTED]> wrote: > > > > The zeroing of a page of a arbitrary order in page_alloc.c and in hugetlb.c > > may benefit from a > > clear_page that is capable of zeroing multiple pages at once (and scrubd > > too but that is no

Re: Extend clear_page by an order parameter

2005-01-22 Thread Andrew Morton
Christoph Lameter <[EMAIL PROTECTED]> wrote: > > The zeroing of a page of a arbitrary order in page_alloc.c and in hugetlb.c > may benefit from a > clear_page that is capable of zeroing multiple pages at once (and scrubd > too but that is now an independent patch). The following patch extends >

Re: Extend clear_page by an order parameter

2005-01-21 Thread Paul Mackerras
Christoph Lameter writes: > I had the name "zero_page" in V1 and V2 of the patch where it was > separate. Then someone complained about code duplication. Well, if you duplicated each arch's clear_page implementation in zero_page, then yes, that would be unnecessary code duplication. I would sugg

Re: Extend clear_page by an order parameter

2005-01-21 Thread Christoph Lameter
On Sat, 22 Jan 2005, Paul Mackerras wrote: > Christoph's patch is bigger than it needs to be because he has to > change all the occurrences of clear_page(x) to clear_page(x, 0), and > then he has to change a lot of architectures' clear_page functions to > be called _clear_page instead. If he pick

Re: Extend clear_page by an order parameter

2005-01-21 Thread Paul Mackerras
Andrew Morton writes: > It is, actually, from the POV of the page allocator. It's a "higher order > page" and is controlled by a struct page*, just like a zero-order page... So why is the function that gets me one of these "higher order pages" called "get_free_pages" with an "s"? :) Christoph's

Re: Extend clear_page by an order parameter

2005-01-21 Thread Roman Zippel
Hi, On Fri, 21 Jan 2005, Andrew Morton wrote: > Paul Mackerras <[EMAIL PROTECTED]> wrote: > > > > A cluster of 2^n contiguous pages > > isn't one page by any normal definition. > > It is, actually, from the POV of the page allocator. It's a "higher order > page" and is controlled by a struct p

Re: Extend clear_page by an order parameter

2005-01-21 Thread Paul Mackerras
Andrew Morton writes: > It is, actually, from the POV of the page allocator. It's a "higher order > page" and is controlled by a struct page*, just like a zero-order page... OK. I still reckon it's confusing terminology for the rest of us who don't have our heads deep in the page allocator code

Re: Extend clear_page by an order parameter

2005-01-21 Thread Andrew Morton
Paul Mackerras <[EMAIL PROTECTED]> wrote: > > A cluster of 2^n contiguous pages > isn't one page by any normal definition. It is, actually, from the POV of the page allocator. It's a "higher order page" and is controlled by a struct page*, just like a zero-order page... - To unsubscribe from thi

Re: Extend clear_page by an order parameter

2005-01-21 Thread Paul Mackerras
Christoph Lameter writes: > clear_page clears one page of the specified order. Now you're really being confusing. A cluster of 2^n contiguous pages isn't one page by any normal definition. Call it "clear_page_cluster" or "clear_page_order" or something, but not "clear_page". Paul. - To unsubsc

Re: Extend clear_page by an order parameter

2005-01-21 Thread Christoph Lameter
On Sat, 22 Jan 2005, Paul Mackerras wrote: > Christoph Lameter writes: > > > The zeroing of a page of a arbitrary order in page_alloc.c and in hugetlb.c > > may benefit from a > > clear_page that is capable of zeroing multiple pages at once (and scrubd > > too but that is now an independent patch

Re: Extend clear_page by an order parameter

2005-01-21 Thread Paul Mackerras
Christoph Lameter writes: > The zeroing of a page of a arbitrary order in page_alloc.c and in hugetlb.c > may benefit from a > clear_page that is capable of zeroing multiple pages at once (and scrubd > too but that is now an independent patch). The following patch extends > clear_page with a seco

Extend clear_page by an order parameter

2005-01-21 Thread Christoph Lameter
The zeroing of a page of a arbitrary order in page_alloc.c and in hugetlb.c may benefit from a clear_page that is capable of zeroing multiple pages at once (and scrubd too but that is now an independent patch). The following patch extends clear_page with a second parameter specifying the order of