Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-02-16 Thread Heiner Kallweit
On 15.02.2019 01:31, Frederic Weisbecker wrote: > On Thu, Feb 14, 2019 at 11:33:44PM +0100, Heiner Kallweit wrote: >> On 14.02.2019 22:47, Thomas Gleixner wrote: >>> On Thu, 14 Feb 2019, Heiner Kallweit wrote: On 24.01.2019 20:37, Heiner Kallweit wrote: >> > Hi Frederic, > is the u

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-02-14 Thread Frederic Weisbecker
On Thu, Feb 14, 2019 at 11:33:44PM +0100, Heiner Kallweit wrote: > On 14.02.2019 22:47, Thomas Gleixner wrote: > > On Thu, 14 Feb 2019, Heiner Kallweit wrote: > >> On 24.01.2019 20:37, Heiner Kallweit wrote: > > >>> Hi Frederic, > >>> is the update debug patch still to come? > > > > Heiner, t

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-02-14 Thread Heiner Kallweit
On 14.02.2019 22:47, Thomas Gleixner wrote: > On Thu, 14 Feb 2019, Heiner Kallweit wrote: >> On 24.01.2019 20:37, Heiner Kallweit wrote: >>> Hi Frederic, >>> is the update debug patch still to come? > > Heiner, there is a related fix queued in > >git://git.kernel.org/pub/scm/linux/kernel

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-02-14 Thread Thomas Gleixner
On Thu, 14 Feb 2019, Heiner Kallweit wrote: > On 24.01.2019 20:37, Heiner Kallweit wrote: > >> > > Hi Frederic, > > is the update debug patch still to come? Heiner, there is a related fix queued in git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git irq/core See also: https://lkml.k

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-02-14 Thread Heiner Kallweit
On 24.01.2019 20:37, Heiner Kallweit wrote: > On 16.01.2019 07:24, Frederic Weisbecker wrote: >> On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: >>> >>> # tracer: nop >>> # >>> # _-=> irqs-off >>> # / _=> need-resched

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-01-24 Thread Heiner Kallweit
On 16.01.2019 07:24, Frederic Weisbecker wrote: > On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: >> >> # tracer: nop >> # >> # _-=> irqs-off >> # / _=> need-resched >> #| / _---=> hardirq/

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-01-16 Thread Heiner Kallweit
On 16.01.2019 07:24, Frederic Weisbecker wrote: > On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: >> >> # tracer: nop >> # >> # _-=> irqs-off >> # / _=> need-resched >> #| / _---=> hardirq/

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-01-15 Thread Frederic Weisbecker
On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: > > # tracer: nop > # > # _-=> irqs-off > # / _=> need-resched > #| / _---=> hardirq/softirq > #|| / _--=> preem

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-01-11 Thread Frederic Weisbecker
On Wed, Jan 09, 2019 at 11:20:50PM +0100, Heiner Kallweit wrote: > On 28.12.2018 07:39, Heiner Kallweit wrote: > > On 28.12.2018 07:34, Heiner Kallweit wrote: > >> On 28.12.2018 02:31, Frederic Weisbecker wrote: > >>> On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: > > >> [...

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2019-01-09 Thread Heiner Kallweit
On 28.12.2018 07:39, Heiner Kallweit wrote: > On 28.12.2018 07:34, Heiner Kallweit wrote: >> On 28.12.2018 02:31, Frederic Weisbecker wrote: >>> On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: >> [...] >>> >>> Interesting, the softirq is raised from hardirq but it's not handle

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-12-27 Thread Heiner Kallweit
On 28.12.2018 07:34, Heiner Kallweit wrote: > On 28.12.2018 02:31, Frederic Weisbecker wrote: >> On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: >>> > [...] >> >> Interesting, the softirq is raised from hardirq but it's not handled in the >> end of >> the IRQ. Are you running thre

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-12-27 Thread Heiner Kallweit
On 28.12.2018 02:31, Frederic Weisbecker wrote: > On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: >> [...] > > Interesting, the softirq is raised from hardirq but it's not handled in the > end of > the IRQ. Are you running threaded IRQS by any chance? If so I would expect > ksof

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-12-27 Thread Frederic Weisbecker
On Fri, Dec 28, 2018 at 12:11:12AM +0100, Heiner Kallweit wrote: > > OK, did as you advised and here comes the trace. That's the related dmesg > part: > > [ 1479.025092] x86: Booting SMP configuration: > [ 1479.025129] smpboot: Booting Node 0 Processor 1 APIC 0x2 > [ 1479.094715] NOHZ: local_sof

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-12-27 Thread Heiner Kallweit
On 27.12.2018 07:53, Frederic Weisbecker wrote: > On Mon, Oct 15, 2018 at 10:58:54PM +0200, Heiner Kallweit wrote: >> On 28.09.2018 15:18, Frederic Weisbecker wrote: >>> On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: On Tue, 28 Aug 2018, Frederic Weisbecker wrote: > On Fr

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-12-26 Thread Frederic Weisbecker
On Mon, Oct 15, 2018 at 10:58:54PM +0200, Heiner Kallweit wrote: > On 28.09.2018 15:18, Frederic Weisbecker wrote: > > On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: > >> On Tue, 28 Aug 2018, Frederic Weisbecker wrote: > >>> On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallwei

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-12-24 Thread Heiner Kallweit
On 15.10.2018 22:58, Heiner Kallweit wrote: > On 28.09.2018 15:18, Frederic Weisbecker wrote: >> On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: >>> On Tue, 28 Aug 2018, Frederic Weisbecker wrote: On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: > I tested

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-10-15 Thread Heiner Kallweit
On 28.09.2018 15:18, Frederic Weisbecker wrote: > On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: >> On Tue, 28 Aug 2018, Frederic Weisbecker wrote: >>> On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: I tested it and Frederic is right, it doesn't help. Can it

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-09-28 Thread Heiner Kallweit
On 28.09.2018 15:18, Frederic Weisbecker wrote: > On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: >> On Tue, 28 Aug 2018, Frederic Weisbecker wrote: >>> On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: I tested it and Frederic is right, it doesn't help. Can it

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-09-28 Thread Frederic Weisbecker
On Thu, Sep 27, 2018 at 06:05:46PM +0200, Thomas Gleixner wrote: > On Tue, 28 Aug 2018, Frederic Weisbecker wrote: > > On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: > > > I tested it and Frederic is right, it doesn't help. Can it be somehow > > > related to > > > the cpu being b

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-09-27 Thread Thomas Gleixner
On Tue, 28 Aug 2018, Frederic Weisbecker wrote: > On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: > > I tested it and Frederic is right, it doesn't help. Can it be somehow > > related to > > the cpu being brought down during suspend? Because I get the warning only > > during > >

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-27 Thread Frederic Weisbecker
On Fri, Aug 24, 2018 at 07:06:32PM +0200, Heiner Kallweit wrote: > On 24.08.2018 16:30, Frederic Weisbecker wrote: > >> Can you try the one I posted in this thread: > >> > >> > >> https://lkml.kernel.org/r/alpine.deb.2.21.1808240851420.1...@nanos.tec.linutronix.de > >> > >> Also below for referen

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-24 Thread Heiner Kallweit
On 24.08.2018 16:30, Frederic Weisbecker wrote: > On Fri, Aug 24, 2018 at 10:01:35AM +0200, Thomas Gleixner wrote: >> On Fri, 24 Aug 2018, Heiner Kallweit wrote: >>> On 24.08.2018 06:12, Frederic Weisbecker wrote: On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner Kallweit wrote: > Recently

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-24 Thread Frederic Weisbecker
On Fri, Aug 24, 2018 at 10:01:35AM +0200, Thomas Gleixner wrote: > On Fri, 24 Aug 2018, Heiner Kallweit wrote: > > On 24.08.2018 06:12, Frederic Weisbecker wrote: > > > On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner Kallweit wrote: > > >> Recently I started to get warning "NOHZ: local_softirq_pen

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-24 Thread Thomas Gleixner
On Fri, 24 Aug 2018, Heiner Kallweit wrote: > On 24.08.2018 06:12, Frederic Weisbecker wrote: > > On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner Kallweit wrote: > >> Recently I started to get warning "NOHZ: local_softirq_pending 202" and > >> I think it's related to mentioned commit (didn't bisec

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-23 Thread Heiner Kallweit
On 24.08.2018 06:12, Frederic Weisbecker wrote: > On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner Kallweit wrote: >> Recently I started to get warning "NOHZ: local_softirq_pending 202" and >> I think it's related to mentioned commit (didn't bisect it yet). >> See log from suspending. >> >> I have

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-23 Thread Frederic Weisbecker
On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner Kallweit wrote: > Recently I started to get warning "NOHZ: local_softirq_pending 202" and > I think it's related to mentioned commit (didn't bisect it yet). > See log from suspending. > > I have no reason to think the fix is wrong, it may just have

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-18 Thread Heiner Kallweit
On 18.08.2018 13:26, Thomas Gleixner wrote: > On Thu, 16 Aug 2018, Heiner Kallweit wrote: > >> Recently I started to get warning "NOHZ: local_softirq_pending 202" and >> I think it's related to mentioned commit (didn't bisect it yet). >> See log from suspending. >> >> I have no reason to think the

Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-18 Thread Thomas Gleixner
On Thu, 16 Aug 2018, Heiner Kallweit wrote: > Recently I started to get warning "NOHZ: local_softirq_pending 202" and > I think it's related to mentioned commit (didn't bisect it yet). > See log from suspending. > > I have no reason to think the fix is wrong, it may just have revealed > another i

Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem

2018-08-15 Thread Heiner Kallweit
Recently I started to get warning "NOHZ: local_softirq_pending 202" and I think it's related to mentioned commit (didn't bisect it yet). See log from suspending. I have no reason to think the fix is wrong, it may just have revealed another issue which existed before and was hidden by the bug. Rgd