Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread Michal Ostrowski
Isn't the extra space there because you've included it in the definition of "test"? The attempt at introducing indentation introduces the extra space character. Defining test without the internal indentation should produce the results you are looking for. -- Michal Ostrowski <[EMAIL

final (Re: Kbuild change breaks the ppc64 build)

2007-02-08 Thread Oleg Verych
Date: Feb 08, 2007 at 05:17:06AM -0800 From: David Miller > From: Oleg Verych <[EMAIL PROTECTED]> > Date: Thu, 8 Feb 2007 13:47:56 +0100 > [] > > As i have refactored some CC checking code in Kbuild.include, it > > turned, that some versions of `make' after calling nested functions, > > add (or

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread David Miller
From: Oleg Verych <[EMAIL PROTECTED]> Date: Thu, 8 Feb 2007 13:47:56 +0100 > On Thu, Feb 08, 2007 at 10:10:54PM +1100, Paul Mackerras wrote: > > Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on > > 64-bit powerpc because we no longer get the -m64 flag passed to gcc. > > There

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 10:10:54PM +1100, Paul Mackerras wrote: > Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on > 64-bit powerpc because we no longer get the -m64 flag passed to gcc. > There is code in arch/powerpc/Makefile which adds (or used to add) > -m64 to AS, LD and CC

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 04:00:03AM -0800, David Miller wrote: > From: Paul Mackerras <[EMAIL PROTECTED]> > Date: Thu, 8 Feb 2007 22:10:54 +1100 [] > Linus and Oleg tried to fix it with various subsequent changes > to scripts/Kbuild.include, but it's still broken. And Roland McGrath, but it turned

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread David Miller
From: Paul Mackerras <[EMAIL PROTECTED]> Date: Thu, 8 Feb 2007 22:10:54 +1100 > Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on > 64-bit powerpc because we no longer get the -m64 flag passed to gcc. > There is code in arch/powerpc/Makefile which adds (or used to add) > -m64 to

Kbuild change breaks the ppc64 build

2007-02-08 Thread Paul Mackerras
Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on 64-bit powerpc because we no longer get the -m64 flag passed to gcc. There is code in arch/powerpc/Makefile which adds (or used to add) -m64 to AS, LD and CC if we are running on a 64-bit machine (which I am) and have a biarch

Kbuild change breaks the ppc64 build

2007-02-08 Thread Paul Mackerras
Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on 64-bit powerpc because we no longer get the -m64 flag passed to gcc. There is code in arch/powerpc/Makefile which adds (or used to add) -m64 to AS, LD and CC if we are running on a 64-bit machine (which I am) and have a biarch

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread David Miller
From: Paul Mackerras [EMAIL PROTECTED] Date: Thu, 8 Feb 2007 22:10:54 +1100 Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on 64-bit powerpc because we no longer get the -m64 flag passed to gcc. There is code in arch/powerpc/Makefile which adds (or used to add) -m64 to AS,

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 04:00:03AM -0800, David Miller wrote: From: Paul Mackerras [EMAIL PROTECTED] Date: Thu, 8 Feb 2007 22:10:54 +1100 [] Linus and Oleg tried to fix it with various subsequent changes to scripts/Kbuild.include, but it's still broken. And Roland McGrath, but it turned to be

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread Oleg Verych
On Thu, Feb 08, 2007 at 10:10:54PM +1100, Paul Mackerras wrote: Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on 64-bit powerpc because we no longer get the -m64 flag passed to gcc. There is code in arch/powerpc/Makefile which adds (or used to add) -m64 to AS, LD and CC if

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread David Miller
From: Oleg Verych [EMAIL PROTECTED] Date: Thu, 8 Feb 2007 13:47:56 +0100 On Thu, Feb 08, 2007 at 10:10:54PM +1100, Paul Mackerras wrote: Commit 5de043f4bd11a9e0a3e8daec7d1905da575a76b7 breaks the build on 64-bit powerpc because we no longer get the -m64 flag passed to gcc. There is code in

final (Re: Kbuild change breaks the ppc64 build)

2007-02-08 Thread Oleg Verych
Date: Feb 08, 2007 at 05:17:06AM -0800 From: David Miller From: Oleg Verych [EMAIL PROTECTED] Date: Thu, 8 Feb 2007 13:47:56 +0100 [] As i have refactored some CC checking code in Kbuild.include, it turned, that some versions of `make' after calling nested functions, add (or leave)

Re: Kbuild change breaks the ppc64 build

2007-02-08 Thread Michal Ostrowski
Isn't the extra space there because you've included it in the definition of test? The attempt at introducing indentation introduces the extra space character. Defining test without the internal indentation should produce the results you are looking for. -- Michal Ostrowski [EMAIL PROTECTED]