Re: [PATCH 05/10] staging: rtl8192: remove unused legacy ioctl handlers

2023-10-09 Thread Greg Kroah-Hartman
On Mon, Oct 09, 2023 at 04:19:03PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The .ndo_do_ioctl functions are never called, and can just be removed, > especially since this is a staging driver. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/rtl8192u/ieee80211/dot11d.c |

Re: [PATCH 06/10] staging: rtl8712: remove unused legacy ioctl handlers

2023-10-09 Thread Greg Kroah-Hartman
On Mon, Oct 09, 2023 at 04:19:04PM +0200, Arnd Bergmann wrote: > From: Arnd Bergmann > > The .ndo_do_ioctl functions are never called, and can just be removed, > especially since this is a staging driver. > > Signed-off-by: Arnd Bergmann > --- > drivers/staging/rtl8712/os_intfs.c|

[PATCH 06/10] staging: rtl8712: remove unused legacy ioctl handlers

2023-10-09 Thread Arnd Bergmann
From: Arnd Bergmann The .ndo_do_ioctl functions are never called, and can just be removed, especially since this is a staging driver. Signed-off-by: Arnd Bergmann --- drivers/staging/rtl8712/os_intfs.c| 1 - drivers/staging/rtl8712/osdep_intf.h | 2 - drivers/staging/r

[PATCH 05/10] staging: rtl8192: remove unused legacy ioctl handlers

2023-10-09 Thread Arnd Bergmann
From: Arnd Bergmann The .ndo_do_ioctl functions are never called, and can just be removed, especially since this is a staging driver. Signed-off-by: Arnd Bergmann --- drivers/staging/rtl8192u/ieee80211/dot11d.c | 41 -- drivers/staging/rtl8192u/ieee80211/dot11d.h | 2 - .../staging/rtl8

[PATCH v5] mm: multi-gen LRU: reuse some legacy trace events

2023-10-03 Thread Jaewon Kim
As the legacy lru provides, the mglru needs some trace events for debugging. Let's reuse following legacy events for the mglru. trace_mm_vmscan_lru_isolate trace_mm_vmscan_lru_shrink_inactive Here's an example mm_vmscan_lru_isolate: classzone=2 order=0 nr_requested=4096 nr_

Re: [PATCH 10/19] USB: gadget/legacy: remove sb_mutex

2023-09-14 Thread Sergey Shtylyov
On 9/13/23 2:10 PM, Christoph Hellwig wrote: > Creating new a new super_block vs freeing the old one for single instance ^ I can't parse that. :-) > file systems is serialized by the wait for SB_DEAD. > > Remove the superfluous sb_mutex. > > Signed-off-by: Christoph Hellwi

Re: [PATCH 10/19] USB: gadget/legacy: remove sb_mutex

2023-09-13 Thread Alan Stern
-- You might mention that this is essentially a reversion of commit d18dcfe9860e ("USB: gadgetfs: Fix race between mounting and unmounting"). Alan Stern > drivers/usb/gadget/legacy/inode.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/drivers/usb/ga

[PATCH 10/19] USB: gadget/legacy: remove sb_mutex

2023-09-13 Thread Christoph Hellwig
Creating new a new super_block vs freeing the old one for single instance file systems is serialized by the wait for SB_DEAD. Remove the superfluous sb_mutex. Signed-off-by: Christoph Hellwig --- drivers/usb/gadget/legacy/inode.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers

Re: [PATCH] MIPS: pci-legacy: revert "use generic pci_enable_resources"

2021-04-20 Thread Guenter Roeck
On Mon, Apr 19, 2021 at 11:39:43PM -0700, Ilya Lipnitskiy wrote: > This mostly reverts commit 99bca615d895 ("MIPS: pci-legacy: use generic > pci_enable_resources"). Fixes regressions such as: > ata_piix :00:0a.1: can't enable device: BAR 0 [io 0x01f0-0x01f7] not >

[PATCH] MIPS: pci-legacy: revert "use generic pci_enable_resources"

2021-04-19 Thread Ilya Lipnitskiy
This mostly reverts commit 99bca615d895 ("MIPS: pci-legacy: use generic pci_enable_resources"). Fixes regressions such as: ata_piix :00:0a.1: can't enable device: BAR 0 [io 0x01f0-0x01f7] not claimed ata_piix: probe of :00:0a.1 failed with error -22 The only c

Re: [PATCH v2 8/8] MIPS: pci-legacy: use generic pci_enable_resources

2021-04-19 Thread Guenter Roeck
quot; to check for resource collisions > instead of "!r->start && r->end". > > That should have no effect on any pci-legacy driver. > Unfortunately it does. With this patch in place, all my mips qemu emulations fail to boot from ide/ata drive; the drive

[PATCH AUTOSEL 4.14 11/11] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 ] This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

[PATCH AUTOSEL 4.19 12/12] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 ] This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

[PATCH AUTOSEL 5.4 14/14] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 ] This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

[PATCH AUTOSEL 5.10 21/21] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 ] This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

[PATCH AUTOSEL 5.11 23/23] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Sasha Levin
From: Linus Torvalds [ Upstream commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 ] This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

[PATCH 5.4 44/73] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Greg Kroah-Hartman
From: Linus Torvalds commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 upstream. This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

[PATCH 5.10 051/103] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Greg Kroah-Hartman
From: Linus Torvalds commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 upstream. This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

[PATCH 5.11 060/122] readdir: make sure to verify directory entry for legacy interfaces too

2021-04-19 Thread Greg Kroah-Hartman
From: Linus Torvalds commit 0c93ac69407d63a85be0129aa55ffaec27ffebd3 upstream. This does the directory entry name verification for the legacy "fillonedir" (and compat) interface that goes all the way back to the dark ages before we had a proper dirent, and the readdir() system cal

Re: [PATCH 2/3] habanalabs: support legacy and new pll indexes

2021-04-17 Thread Oded Gabbay
> + bool dynamic_pll; > > + > > + if (input_pll_index >= PLL_MAX) { > > + dev_err(hdev->dev, "PLL index %d is out of range\n", > > + input_pll_index); > > + return -EINVAL; > > +

Re: [PATCH v2 5/8] MIPS: pci-legacy: stop using of_pci_range_to_resource

2021-04-16 Thread Liviu Dudau
ddress_to_pio(). Moreover, IO_SPACE_LIMIT is 0x for most MIPS > platforms. of_pci_range_to_resource passes the _start address_ of the IO > range into pci_address_to_pio, which then checks it against > IO_SPACE_LIMIT and fails, because for MIPS platforms that use > pci-legacy (pci-lantiq, pci-rt38

Re: [PATCH v2 0/8] MIPS: fixes for PCI legacy drivers (rt2880, rt3883)

2021-04-16 Thread Thomas Bogendoerfer
8): > MIPS: pci-rt2880: fix slot 0 configuration > MIPS: pci-rt2880: remove unneeded locks > MIPS: pci-rt3883: trivial: remove unused variable > MIPS: pci-rt3883: more accurate DT error messages > MIPS: pci-legacy: stop using of_pci_range_to_resource > MIPS: pci-legacy: remov

Re: [PATCH 2/3] habanalabs: support legacy and new pll indexes

2021-04-15 Thread Nathan Chancellor
gt; + dev_err(hdev->dev, "PLL index %d is out of range\n", > + input_pll_index); > + return -EINVAL; > + } > + > + dynamic_pll = prop->fw_security_status_valid && > +

Re: [-next] serial: 8250: Match legacy NS16550A UARTs

2021-04-15 Thread Andy Shevchenko
On Wed, Apr 14, 2021 at 7:13 PM Al Cooper wrote: > > From: Florian Fainelli > > Older 32-bit only Broadcom STB chips used a NS16550A compatible UART, > the 8250_bcm7271.c driver can drive those UARTs just fine provided that > we let it match the appropriate compatible string. This sounds not cor

Re: [-next] serial: 8250: Match legacy NS16550A UARTs

2021-04-15 Thread Greg Kroah-Hartman
On Wed, Apr 14, 2021 at 09:45:39AM -0400, Al Cooper wrote: > From: Florian Fainelli > > Older 32-bit only Broadcom STB chips used a NS16550A compatible UART, > the 8250_bcm7271.c driver can drive those UARTs just fine provided that > we let it match the appropriate compatible string. > > Signed-

[-next] serial: 8250: Match legacy NS16550A UARTs

2021-04-14 Thread Al Cooper
From: Florian Fainelli Older 32-bit only Broadcom STB chips used a NS16550A compatible UART, the 8250_bcm7271.c driver can drive those UARTs just fine provided that we let it match the appropriate compatible string. Signed-off-by: Florian Fainelli Reviewed-by: Al Cooper --- drivers/tty/serial

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

2021-04-14 Thread Lee Jones
On Wed, 31 Mar 2021, Andy Shevchenko wrote: > Platform data is a legacy interface to supply device properties > to the driver. In this case we don't have anymore in-kernel users > for it. Just remove it for good. > > Signed-off-by: Andy Shevchenko > --- > drivers

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

2021-04-14 Thread Wolfram Sang
> > > Platform data is a legacy interface to supply device properties > > > to the driver. In this case we don't have anymore in-kernel users > > > for it. Just remove it for good. > > > > > > Signed-off-by: Andy Shevchenko > > >

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

2021-04-14 Thread Lee Jones
On Tue, 06 Apr 2021, Wolfram Sang wrote: > On Wed, Mar 31, 2021 at 06:48:51PM +0300, Andy Shevchenko wrote: > > Platform data is a legacy interface to supply device properties > > to the driver. In this case we don't have anymore in-kernel users > > for i

[PATCH v2 6/8] MIPS: pci-legacy: remove redundant info messages

2021-04-13 Thread Ilya Lipnitskiy
Remove the following pci-legacy message: PCI host bridge /pci@44/host-bridge ranges: MEM 0x2000..0x2fff IO 0x0046..0x0046 It is followed shortly by the same data from pci_register_host_bridge: PCI host bridge to bus :00 pci_bus

[PATCH v2 8/8] MIPS: pci-legacy: use generic pci_enable_resources

2021-04-13 Thread Ilya Lipnitskiy
d". That should have no effect on any pci-legacy driver. Suggested-by: Bjorn Helgaas Signed-off-by: Ilya Lipnitskiy --- arch/mips/pci/pci-legacy.c | 40 ++ 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/arch/mips/pci/pci-legacy.c

[PATCH v2 7/8] MIPS: pci-legacy: remove busn_resource field

2021-04-13 Thread Ilya Lipnitskiy
No drivers set the busn_resource field in the pci_controller struct. Commit 7ee214b540d9 ("MIPS: PCI: Remove unused busn_offset") almost removed it over 3 years ago. Remove it for good to free up memory and eliminate messages like: pci_bus :00: root bus resource [??? 0x flags 0x0] Si

[PATCH v2 5/8] MIPS: pci-legacy: stop using of_pci_range_to_resource

2021-04-13 Thread Ilya Lipnitskiy
the _start address_ of the IO range into pci_address_to_pio, which then checks it against IO_SPACE_LIMIT and fails, because for MIPS platforms that use pci-legacy (pci-lantiq, pci-rt3883, pci-mt7620), IO ranges start much higher than 0x. In fact, pci-mt7621 in staging already works around this pr

[PATCH v2 0/8] MIPS: fixes for PCI legacy drivers (rt2880, rt3883)

2021-04-13 Thread Ilya Lipnitskiy
variable MIPS: pci-rt3883: more accurate DT error messages MIPS: pci-legacy: stop using of_pci_range_to_resource MIPS: pci-legacy: remove redundant info messages MIPS: pci-legacy: remove busn_resource field MIPS: pci-legacy: use generic pci_enable_resources arch/mips/include/asm/pci.h

[PATCH 5/8] MIPS: pci-legacy: stop using of_pci_range_to_resource

2021-04-12 Thread Ilya Lipnitskiy
the _start address_ of the IO range into pci_address_to_pio, which then checks it against IO_SPACE_LIMIT and fails, because for MIPS platforms that use pci-legacy (pci-lantiq, pci-rt3883, pci-mt7620), IO ranges start much higher than 0x. In fact, pci-mt7621 in staging already works around this pr

[PATCH 8/8] MIPS: pci-legacy: use generic pci_enable_resources

2021-04-12 Thread Ilya Lipnitskiy
d". That should have no effect on any pci-legacy driver. Suggested-by: Bjorn Helgaas Signed-off-by: Ilya Lipnitskiy --- arch/mips/pci/pci-legacy.c | 40 ++ 1 file changed, 2 insertions(+), 38 deletions(-) diff --git a/arch/mips/pci/pci-legacy.c

[PATCH 7/8] MIPS: pci-legacy: remove busn_resource field

2021-04-12 Thread Ilya Lipnitskiy
No drivers set the busn_resource field in the pci_controller struct. Commit 7ee214b540d9 ("MIPS: PCI: Remove unused busn_offset") almost removed it over 3 years ago. Remove it for good to free up memory and eliminate messages like: pci_bus :00: root bus resource [??? 0x flags 0x0] Si

[PATCH 6/8] MIPS: pci-legacy: remove redundant info messages

2021-04-12 Thread Ilya Lipnitskiy
Remove the following pci-legacy message: PCI host bridge /pci@44/host-bridge ranges: MEM 0x2000..0x2fff IO 0x0046..0x0046 It is followed shortly by the same data from pci_register_host_bridge: PCI host bridge to bus :00 pci_bus

[PATCH 0/8] MIPS: Fixes for PCI legacy drivers (rt2880, rt3883)

2021-04-12 Thread Ilya Lipnitskiy
configuration MIPS: pci-rt2880: remove unneeded locks MIPS: pci-rt3883: trivial: remove unused variable MIPS: pci-rt3883: more accurate DT error messages MIPS: pci-legacy: stop using of_pci_range_to_resource MIPS: pci-legacy: remove redundant info messages MIPS: pci-legacy: remove busn_resource

Re: [PATCH] PCI: dwc/intel-gw: Fix enabling the legacy PCI interrupt lines

2021-04-09 Thread Lorenzo Pieralisi
gt; > > > > > On Wed, Jan 06, 2021 at 02:55:40PM +0100, Martin Blumenstingl wrote: > > > > The legacy PCI interrupt lines need to be enabled using PCIE_APP_IRNEN > > > > bits 13 (INTA), 14 (INTB), 15 (INTC) and 16 (INTD). The old code > &g

Re: [PATCH] PCI: dwc/intel-gw: Fix enabling the legacy PCI interrupt lines

2021-04-09 Thread Rahul Tanwar
On 9/4/2021 4:40 am, Martin Blumenstingl wrote: > This email was sent from outside of MaxLinear. > > Hi Lorenzo, > > On Tue, Mar 23, 2021 at 12:36 PM Lorenzo Pieralisi > wrote: > > > > On Wed, Jan 06, 2021 at 02:55:40PM +0100, Martin Blumenstingl wrote: > &

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-08 Thread Stephen Boyd
Quoting Stephan Gerhold (2021-04-08 00:19:44) > Personally, I think it would be best to introduce a new, SMC64 only > compatible (e.g. "qcom,scm-64" like I mentioned). Then you can skip the > detection check for the boards that opt-in by adding the compatible. > You can then use it on all newer boa

Re: [PATCH] PCI: dwc/intel-gw: Fix enabling the legacy PCI interrupt lines

2021-04-08 Thread Martin Blumenstingl
Hi Lorenzo, On Tue, Mar 23, 2021 at 12:36 PM Lorenzo Pieralisi wrote: > > On Wed, Jan 06, 2021 at 02:55:40PM +0100, Martin Blumenstingl wrote: > > The legacy PCI interrupt lines need to be enabled using PCIE_APP_IRNEN > > bits 13 (INTA), 14 (INTB), 15 (INTC) and 16 (INTD). Th

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-08 Thread Stephan Gerhold
etection so far. I suppose you could do the opposite, > > add an optional qcom,scm-64 to skip the detection step and force SMC64. > > Isn't SMC64 going to be the overall majority going forward? Legacy > convention is for sure limited to CONFIG_ARM so I'll send another &

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-07 Thread Stephen Boyd
94 also uses SMC32 from what I heard. Overall it's > probably quite hard to get that right now since all boards were tested > with the dynamic detection so far. I suppose you could do the opposite, > add an optional qcom,scm-64 to skip the detection step and force SMC64. Isn't SMC6

[PATCH 21/24] USB: serial: stop reporting legacy UART types

2021-04-07 Thread Johan Hovold
The TIOCGSERIAL ioctl can be used to set and retrieve the UART type for legacy UARTs, but some USB serial drivers have been reporting back random types in order to "make user-space happy". Some applications have historically expected TIOCGSERIAL to be implemented, but judging from

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

2021-04-06 Thread Jarkko Nikula
On 4/6/21 1:49 PM, Wolfram Sang wrote: On Wed, Mar 31, 2021 at 06:48:51PM +0300, Andy Shevchenko wrote: Platform data is a legacy interface to supply device properties to the driver. In this case we don't have anymore in-kernel users for it. Just remove it for good. Signed-off-by:

Re: [PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

2021-04-06 Thread Wolfram Sang
On Wed, Mar 31, 2021 at 06:48:51PM +0300, Andy Shevchenko wrote: > Platform data is a legacy interface to supply device properties > to the driver. In this case we don't have anymore in-kernel users > for it. Just remove it for good. > > Signed-off-by: Andy Shevchenko Ac

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-05 Thread Stephan Gerhold
source and force > > > arm64 calling convention to be safe? I'm thinking of this patch, but it > > > could be even more fine tuned and probably the sc7180 check could be > > > removed in the process if the rest of this email makes sense. > > > > > > If I u

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-02 Thread Stephen Boyd
D(CONFIG_ARM), and the corresponding ones in > > > qcom_scm_call_atomic: > > > > > >case SMC_CONVENTION_LEGACY: > > >return scm_legacy_call(dev, desc, res); > > > > > > If something is wrong with loaded firmware and LEGAC

Re: [PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-04-02 Thread Marc Zyngier
On Thu, 25 Mar 2021 09:00:25 +, Kishon Vijay Abraham I wrote: > > Add PCI legacy interrupt support for AM654. AM654 has a single HW > interrupt line for all the four legacy interrupts INTA/INTB/INTC/INTD. > The HW interrupt line connected to GIC is a pulse interrupt whereas

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-02 Thread Stephan Gerhold
mic: > > > >case SMC_CONVENTION_LEGACY: > >return scm_legacy_call(dev, desc, res); > > > > If something is wrong with loaded firmware and LEGACY convention is > > incorrectly selected, you would get a better hint about the problem: > > "U

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-01 Thread Stephen Boyd
esc, res); > > If something is wrong with loaded firmware and LEGACY convention is > incorrectly selected, you would get a better hint about the problem: > "Unknown current SCM calling convention." You would still get the hint > earlier from __get_convention, but that may n

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-04-01 Thread Elliot Berman
On 3/23/2021 3:43 PM, Stephen Boyd wrote: These scm calls are never used outside of legacy ARMv7 based platforms. That's because PSCI, mandated on arm64, implements them for modern SoCs via the PSCI spec. Let's move them to the legacy file and only compile the legacy file into the k

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-31 Thread Bjorn Andersson
On Tue 23 Mar 17:43 CDT 2021, Stephen Boyd wrote: > These scm calls are never used outside of legacy ARMv7 based platforms. > That's because PSCI, mandated on arm64, implements them for modern SoCs > via the PSCI spec. Let's move them to the legacy file and only compile > th

Re: [PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-31 Thread Stephen Boyd
Quoting Stephen Boyd (2021-03-23 15:43:36) > These scm calls are never used outside of legacy ARMv7 based platforms. > That's because PSCI, mandated on arm64, implements them for modern SoCs > via the PSCI spec. Let's move them to the legacy file and only compile > the legac

[PATCH v1 2/2] i2c: designware: Get rid of legacy platform data

2021-03-31 Thread Andy Shevchenko
Platform data is a legacy interface to supply device properties to the driver. In this case we don't have anymore in-kernel users for it. Just remove it for good. Signed-off-by: Andy Shevchenko --- drivers/i2c/busses/i2c-designware-platdrv.c | 7 +-- include/linux/platform_dat

[PATCH 5.11 108/254] ARM: OMAP2+: Fix smartreflex init regression after dropping legacy data

2021-03-29 Thread Greg Kroah-Hartman
From: Tony Lindgren [ Upstream commit fbfa463be8dc7957ee4f81556e9e1ea2a951807d ] When I dropped legacy data for omap4 and dra7 smartreflex in favor of device tree based data, it seems I only testd for the "SmartReflex Class3 initialized" line in dmesg. I missed the fact that the

[PATCH 5.10 092/221] ARM: OMAP2+: Fix smartreflex init regression after dropping legacy data

2021-03-29 Thread Greg Kroah-Hartman
From: Tony Lindgren [ Upstream commit fbfa463be8dc7957ee4f81556e9e1ea2a951807d ] When I dropped legacy data for omap4 and dra7 smartreflex in favor of device tree based data, it seems I only testd for the "SmartReflex Class3 initialized" line in dmesg. I missed the fact that the

Re: [PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-03-26 Thread Krzysztof Wilczyński
Hi Kishon, [...] > + if (!legacy_irq_domain) { > + dev_err(dev, "Failed to add irq domain for legacy irqs\n"); > + return -EINVAL; > + } [...] It would be "IRQ" and "IRQs" in the message above. [...] > - ret = k

Re: [PATCH 4/6] PCI: keystone: Convert to using hierarchy domain for legacy interrupts

2021-03-25 Thread Krzysztof Wilczyński
Hi Kishon, Thank you for sending the series over! A few small nitpick, so feel free to ignore it. [...] > + ret = irq_domain_alloc_irqs_parent(domain, virq, 1, &parent_fwspec); > + if (ret < 0) { > + pr_err("Failed to allocate parent irq %u: %d\n", > +pare

[PATCH 02/18] KVM: x86/mmu: Move flushing for "slot" handlers to caller for legacy MMU

2021-03-25 Thread Sean Christopherson
Place the onus on the caller of slot_handle_*() to flush the TLB, rather than handling the flush in the helper, and rename parameters accordingly. This will allow future patches to coalesce flushes between address spaces and between the legacy and TDP MMUs. No functional change intended. Signed

Re: [PATCH 2/4] PCI: j721e: Add PCI legacy interrupt support for J721E

2021-03-25 Thread Bjorn Helgaas
I'd promote J721E earlier in subject so it doesn't get truncated, e.g., PCI: j721e: Add J721E PCI legacy interrupt support On Thu, Mar 25, 2021 at 02:39:34PM +0530, Kishon Vijay Abraham I wrote: > +static void j721e_pcie_legacy_irq_handler(struct irq_desc *desc) >

Re: [PATCH 1/4] dt-bindings: PCI: ti, j721e: Add bindings to specify legacy interrupts

2021-03-25 Thread Rob Herring
On Thu, 25 Mar 2021 14:39:33 +0530, Kishon Vijay Abraham I wrote: > Add bindings to specify interrupt controller for legacy interrupts. > > Signed-off-by: Kishon Vijay Abraham I > --- > .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 13 + > 1 file chan

[PATCH 2/4] PCI: j721e: Add PCI legacy interrupt support for J721E

2021-03-25 Thread Kishon Vijay Abraham I
Add PCI legacy interrupt support for J721E. J721E has a single HW interrupt line for all the four legacy interrupts INTA/INTB/INTC/INTD. The HW interrupt line connected to GIC is a pulse interrupt whereas the legacy interrupts by definition is level interrupt. In order to provide level interrupt

[PATCH 0/4] PCI: Add legacy interrupt support in pci-j721e

2021-03-25 Thread Kishon Vijay Abraham I
Patch series adds support for legacy interrupt in pci-j721e. There are two HW implementations of legacy interrupt controller, one specific to J721E and the other for J7200/AM64. In both these implementations, the legacy interrupt is connect to pulse interrupt of GIC and level to pulse is handled

[PATCH 1/4] dt-bindings: PCI: ti,j721e: Add bindings to specify legacy interrupts

2021-03-25 Thread Kishon Vijay Abraham I
Add bindings to specify interrupt controller for legacy interrupts. Signed-off-by: Kishon Vijay Abraham I --- .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b

[PATCH 4/6] PCI: keystone: Convert to using hierarchy domain for legacy interrupts

2021-03-25 Thread Kishon Vijay Abraham I
K2G provides separate IRQ lines for each of the four legacy interrupts. Model this using hierarchy domain instead of linear domain with chained IRQ handler. Signed-off-by: Kishon Vijay Abraham I --- drivers/pci/controller/dwc/pci-keystone.c | 214 -- 1 file changed, 120

[PATCH 5/6] PCI: keystone: Add PCI legacy interrupt support for AM654

2021-03-25 Thread Kishon Vijay Abraham I
Add PCI legacy interrupt support for AM654. AM654 has a single HW interrupt line for all the four legacy interrupts INTA/INTB/INTC/INTD. The HW interrupt line connected to GIC is a pulse interrupt whereas the legacy interrupts by definition is level interrupt. In order to provide level interrupt

[PATCH 0/6] PCI: Add legacy interrupt support in Keystone

2021-03-25 Thread Kishon Vijay Abraham I
Keystone driver is used by K2G and AM65 and the interrupt handling of both of them is different. Add support to handle legacy interrupt for both K2G and AM65 here. Some discussions regarding this was already done here [1] and it was around having pulse interrupt for legacy interrupt. The HW

[RFC Part2 PATCH 12/30] crypto ccp: handle the legacy SEV command when SNP is enabled

2021-03-24 Thread Brijesh Singh
The behavior of the SEV-legacy commands is altered when the SNP firmware is in the INIT state. When SNP is in INIT state, all the SEV-legacy commands that cause the firmware to write to memory must be in the firmware state before issuing the command.. See SEV-SNP spec section 5.3.7 for more

Re: [PATCH 05/10] MIPS: switch workpad_defconfig from legacy IDE to libata

2021-03-24 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:01AM +0100, Christoph Hellwig wrote: > Use libata instead of the deprecated legacy ide driver in > workpad_defconfig. > > Signed-off-by: Christoph Hellwig > --- > arch/mips/configs/workpad_defconfig | 9 ++--- > 1 file changed, 6 inser

[PATCH v2] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-23 Thread Stephen Boyd
These scm calls are never used outside of legacy ARMv7 based platforms. That's because PSCI, mandated on arm64, implements them for modern SoCs via the PSCI spec. Let's move them to the legacy file and only compile the legacy file into the kernel when CONFIG_ARM=y. Otherwise provide stub

Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-23 Thread Bjorn Andersson
On Tue 23 Mar 13:27 CDT 2021, Elliot Berman wrote: > On 3/22/2021 8:36 PM, Stephen Boyd wrote: > > Quoting Bjorn Andersson (2021-03-07 09:42:45) > > > On Sat 06 Mar 00:18 CST 2021, Stephen Boyd wrote: > > > > > > > Quoting Elliot Berman (2021-03-05 10:18:09) > > > > > On 3/3/2021 10:14 PM, Stephe

Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-23 Thread Elliot Berman
On 3/22/2021 8:36 PM, Stephen Boyd wrote: Quoting Bjorn Andersson (2021-03-07 09:42:45) On Sat 06 Mar 00:18 CST 2021, Stephen Boyd wrote: Quoting Elliot Berman (2021-03-05 10:18:09) On 3/3/2021 10:14 PM, Stephen Boyd wrote: Quoting Elliot Berman (2021-03-03 19:35:08) > +desc.args[0]

[PATCH v2] usb: gadget: legacy: fix error return code of msg_bind()

2021-03-23 Thread Jia-Ju Bai
. --- drivers/usb/gadget/legacy/mass_storage.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/legacy/mass_storage.c b/drivers/usb/gadget/legacy/mass_storage.c index 9ed22c5fb7fe..ac1741126619 100644 --- a/drivers/usb/gadget/legacy/mass_storage.c +++ b/drivers/usb

Re: [PATCH] usb: gadget: legacy: fix error return code of msg_bind()

2021-03-23 Thread Jia-Ju Bai
On 2021/3/23 19:35, Greg KH wrote: On Sun, Mar 07, 2021 at 12:49:15AM -0800, Jia-Ju Bai wrote: When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error return code of msg_bind() is assigned. To fix this bug, status is assigned with -ENOMEM in this case. Reported-by: TOTE Robot > T

Re: [PATCH] PCI: dwc/intel-gw: Fix enabling the legacy PCI interrupt lines

2021-03-23 Thread Lorenzo Pieralisi
On Wed, Jan 06, 2021 at 02:55:40PM +0100, Martin Blumenstingl wrote: > The legacy PCI interrupt lines need to be enabled using PCIE_APP_IRNEN > bits 13 (INTA), 14 (INTB), 15 (INTC) and 16 (INTD). The old code however > was taking (for example) "13" as raw value instead of takin

Re: [PATCH resend] usb: gadget: legacy: fix error return code of msg_bind()

2021-03-23 Thread Greg KH
On Sun, Mar 07, 2021 at 12:52:19AM -0800, Jia-Ju Bai wrote: > When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error > return code of msg_bind() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot > You have 2 '>' on the end of thi

Re: [PATCH] usb: gadget: legacy: fix error return code of msg_bind()

2021-03-23 Thread Greg KH
On Sun, Mar 07, 2021 at 12:49:15AM -0800, Jia-Ju Bai wrote: > When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error > return code of msg_bind() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot Reported-by: TOTE Robot > These l

[PATCH] USB: gadget: legacy: remove left-over __ref annotations

2021-03-23 Thread Rasmus Villemoes
it is safe. Signed-off-by: Rasmus Villemoes --- drivers/usb/gadget/legacy/multi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/legacy/multi.c b/drivers/usb/gadget/legacy/multi.c index ec9749845660..f6d0782e6fc3 100644 --- a/drivers/usb/gadg

Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM

2021-03-22 Thread Stephen Boyd
Quoting Bjorn Andersson (2021-03-07 09:42:45) > On Sat 06 Mar 00:18 CST 2021, Stephen Boyd wrote: > > > Quoting Elliot Berman (2021-03-05 10:18:09) > > > On 3/3/2021 10:14 PM, Stephen Boyd wrote: > > > > Quoting Elliot Berman (2021-03-03 19:35:08) > > > > > > > +desc.args[0] = flags; > > >

[PATCH 2/3] habanalabs: support legacy and new pll indexes

2021-03-21 Thread Oded Gabbay
d && + (prop->fw_app_security_map & CPU_BOOT_DEV_STS0_DYN_PLL_EN); + + if (!dynamic_pll) { + /* + * in case we are working with legacy FW (each asic has unique + * PLL numbering) extract the legacy numbering +*/ +

Re: remove the legacy ide driver

2021-03-21 Thread John Paul Adrian Glaubitz
Hello Christoph! On 3/18/21 5:56 AM, Christoph Hellwig wrote: > libata mostly covers all hardware supported by the legacy ide driver. > There are three mips drivers that are not supported, but the linux-mips > list could not identify any users of those. There also are two m68k > dri

Re: [PATCH 10/10] ide: remove the legacy ide driver

2021-03-19 Thread Maciej W. Rozycki
On Sat, 20 Mar 2021, Maciej W. Rozycki wrote: > > been scheduled for removal for a while. Finally kill it off so that we > > can start cleaning up various bits of cruft it forced on the block layer. > > You need to adjust Documentation/admin-guide/kernel-parameters.txt too, > i.e. remove all t

Re: [PATCH 10/10] ide: remove the legacy ide driver

2021-03-19 Thread Maciej W. Rozycki
On Thu, 18 Mar 2021, Christoph Hellwig wrote: > The legay ide driver has been replace with libata startin in 2003 and has s/legay/legacy/;s/replace/replaced/;s/startin/startin/ (though I'd say "back in" instead in the latter case). > been scheduled for removal for a wh

[RFC 4/6] RISC-V: Add a simple platform driver for RISC-V legacy perf

2021-03-19 Thread Atish Patra
provides an easy way out in future where we can remove the legacy driver. Signed-off-by: Atish Patra --- drivers/perf/Kconfig| 9 drivers/perf/Makefile | 3 ++ drivers/perf/riscv_pmu.c| 2 + drivers/perf/riscv_pmu_legacy.c | 88

Re: remove the legacy ide driver

2021-03-19 Thread Maciej W. Rozycki
On Thu, 18 Mar 2021, Christoph Hellwig wrote: > we've been trying to get rid of the legacy ide driver for a while now, > and finally scheduled a removal for 2021, which is three month old now. Hmm, there's still a regression in that pata_legacy unconditionally pokes at

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-19 Thread Serge Belyshev
Al Viro writes: > ... > > Do you have reports of libata variants of drivers actually tested on > those? PATA_CMD64X works fine on my 164LX for many years, last tested with 5.12-rc3. (with a caveat: in my setup with CF card DMA is broken, but it is broken with BLK_DEV_CMD64X as well).

Re: remove the legacy ide driver

2021-03-18 Thread Christoph Hellwig
On Fri, Mar 19, 2021 at 12:43:48PM +1100, Finn Thain wrote: > A few months ago I wrote another patch to move some more platforms away > from macide but it has not been tested yet. That is not to say you should > wait. However, my patch does have some changes that are missing from your > patch se

Re: remove the legacy ide driver

2021-03-18 Thread Finn Thain
On Thu, 18 Mar 2021, Christoph Hellwig wrote: > Hi all, > > we've been trying to get rid of the legacy ide driver for a while now, > and finally scheduled a removal for 2021, which is three month old now. > > In general distros and most defconfigs have switched to libat

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-18 Thread Måns Rullgård
Måns Rullgård writes: > Christoph Hellwig writes: > >> On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: >>> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >>> > Switch the alpha defconfig from the legacy ide driver to libata. >

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-18 Thread Måns Rullgård
Christoph Hellwig writes: > On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: >> On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> > Switch the alpha defconfig from the legacy ide driver to libata. >> >> Umm... I don't have an IDE a

[PATCH v2 4/7] pps: clients: gpio: Get rid of legacy platform data

2021-03-18 Thread Andy Shevchenko
Platform data is a legacy interface to supply device properties to the driver. In this case we even don't have in-kernel users for it. Just remove it for good. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 17 +++-- include/linu

Re: [PATCH RFC 1/2] x86/apic: Do not make an exception for PIC_CASCADE_IR when marking legacy irqs in irq_matrix

2021-03-18 Thread Thomas Gleixner
On Thu, Mar 18 2021 at 09:29, Vitaly Kuznetsov wrote: > Thomas Gleixner writes: >> Out of paranoia I'd rather ignore that IO/APIC pin completely if it >> claims to be IRQ2. I assume there is no device connected to it at all, >> right? > > The original issue was observed on Amazon's r5d.xlarge inst

Re: [PATCH RFC 1/2] x86/apic: Do not make an exception for PIC_CASCADE_IR when marking legacy irqs in irq_matrix

2021-03-18 Thread Vitaly Kuznetsov
Thomas Gleixner writes: > On Wed, Mar 17 2021 at 22:40, Thomas Gleixner wrote: >> af174783b925 ("x86: I/O APIC: Never configure IRQ2") >> >> has a very nice explanation why. >> >> Back then the logic was quite different. All legacy PIC interrupts &g

Re: [PATCH RFC 1/2] x86/apic: Do not make an exception for PIC_CASCADE_IR when marking legacy irqs in irq_matrix

2021-03-18 Thread Vitaly Kuznetsov
located in irq_matrix and think that >> there are too many vectors require re-assigning. >> >> The problem turns to be: lapic_assign_system_vectors() called from >> native_init_IRQ() makes an exception for PIC_CASCADE_IR and doesn't >> mark it in irq_matrix. Later,

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-18 Thread John Paul Adrian Glaubitz
Hi Al! On 3/18/21 6:54 AM, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: >> Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU module shat themsel

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-17 Thread Christoph Hellwig
On Thu, Mar 18, 2021 at 05:54:55AM +, Al Viro wrote: > On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: > > Switch the alpha defconfig from the legacy ide driver to libata. > > Umm... I don't have an IDE alpha box in a usable shape (fans on > CPU

Re: [PATCH 01/10] alpha: use libata instead of the legacy ide driver

2021-03-17 Thread Al Viro
On Thu, Mar 18, 2021 at 05:56:57AM +0100, Christoph Hellwig wrote: > Switch the alpha defconfig from the legacy ide driver to libata. Umm... I don't have an IDE alpha box in a usable shape (fans on CPU module shat themselves), and it would take a while to resurrect it, but I remember th

  1   2   3   4   5   6   7   8   9   10   >