Re: xfs mount opts (was: More better in mount(2))

2001-01-07 Thread Nathan Scott
hi, On Jan 5, 3:51pm, Daniel Phillips wrote: > Subject: Re: More better in mount(2) > Nathan Scott wrote: > > On Jan 5, 3:26am, Daniel Phillips wrote: > > > ... > > > This filesystem mount option parsing code is completely ad hoc, and uses > > > strtok

Re: xfs mount opts (was: More better in mount(2))

2001-01-07 Thread Nathan Scott
hi, On Jan 5, 3:51pm, Daniel Phillips wrote: Subject: Re: More better in mount(2) Nathan Scott wrote: On Jan 5, 3:26am, Daniel Phillips wrote: ... This filesystem mount option parsing code is completely ad hoc, and uses strtok which is horribly horribly broken. (Do man strtok

Re: More better in mount(2)

2001-01-05 Thread Andreas Dilger
Daniel writes: > [re strtok for mount option parsing] > > BUGSNever use this function. If you do, note that: > This function modifies its first argument. > The identity of the delimiting character is lost. > This functions cannot be used on

Re: More better in mount(2)

2001-01-05 Thread Daniel Phillips
Nathan Scott wrote: > On Jan 5, 3:26am, Daniel Phillips wrote: > > ... > > This filesystem mount option parsing code is completely ad hoc, and uses > > strtok which is horribly horribly broken. (Do man strtok and read the > > 'Bugs' section.) > > > > It would be worth thinking about how to do

Re: More better in mount(2)

2001-01-05 Thread Daniel Phillips
Nathan Scott wrote: On Jan 5, 3:26am, Daniel Phillips wrote: ... This filesystem mount option parsing code is completely ad hoc, and uses strtok which is horribly horribly broken. (Do man strtok and read the 'Bugs' section.) It would be worth thinking about how to do this better.