Re: [PATCH 1/2] arm64: dts: juno: Describe PCI dma-ranges

2021-03-23 Thread Sudeep Holla
/juno), thanks! [1/2] arm64: dts: juno: Describe PCI dma-ranges https://git.kernel.org/sudeep.holla/c/4ac4d146cb [2/2] arm64: dts: juno: Enable more SMMUs https://git.kernel.org/sudeep.holla/c/d9df28ba58 -- Regards, Sudeep

[PATCH] parisc: pci-dma: fix warning unused-function

2020-11-26 Thread Anders Roxell
When building tinyconfig on parisc the following warnign shows up: /tmp/arch/parisc/kernel/pci-dma.c:338:12: warning: 'proc_pcxl_dma_show' defined but not used [-Wunused-function] static int proc_pcxl_dma_show(struct seq_file *m, void *v) ^~ Mark the function as __ma

Re: [PATCH 5/6] x86/apic/msi: Use Real PCI DMA device when configuring IRTE

2020-10-21 Thread Derrick, Jonathan
On Tue, 2020-10-20 at 21:21 -0500, Bjorn Helgaas wrote: > On Wed, Oct 21, 2020 at 01:20:24AM +, Derrick, Jonathan wrote: > > On Tue, 2020-10-20 at 15:26 -0500, Bjorn Helgaas wrote: > > > On Tue, Jul 28, 2020 at 01:49:44PM -0600, Jon Derrick wrote: > > > > VMD retransmits child device MSI/X with

Re: [PATCH 5/6] x86/apic/msi: Use Real PCI DMA device when configuring IRTE

2020-10-20 Thread Bjorn Helgaas
On Wed, Oct 21, 2020 at 01:20:24AM +, Derrick, Jonathan wrote: > On Tue, 2020-10-20 at 15:26 -0500, Bjorn Helgaas wrote: > > On Tue, Jul 28, 2020 at 01:49:44PM -0600, Jon Derrick wrote: > > > VMD retransmits child device MSI/X with the VMD endpoint's requester-id. > > > In order to support dire

Re: [PATCH 5/6] x86/apic/msi: Use Real PCI DMA device when configuring IRTE

2020-10-20 Thread Derrick, Jonathan
On Tue, 2020-10-20 at 15:26 -0500, Bjorn Helgaas wrote: > On Tue, Jul 28, 2020 at 01:49:44PM -0600, Jon Derrick wrote: > > VMD retransmits child device MSI/X with the VMD endpoint's requester-id. > > In order to support direct interrupt remapping of VMD child devices, > > ensure that the IRTE is pr

Re: [PATCH 5/6] x86/apic/msi: Use Real PCI DMA device when configuring IRTE

2020-10-20 Thread Bjorn Helgaas
On Tue, Jul 28, 2020 at 01:49:44PM -0600, Jon Derrick wrote: > VMD retransmits child device MSI/X with the VMD endpoint's requester-id. > In order to support direct interrupt remapping of VMD child devices, > ensure that the IRTE is programmed with the VMD endpoint's requester-id > using pci_real_d

Re: [PATCH 5/6] x86/apic/msi: Use Real PCI DMA device when configuring IRTE

2020-09-28 Thread Thomas Gleixner
On Mon, Sep 07 2020 at 15:32, Lorenzo Pieralisi wrote: > On Tue, Jul 28, 2020 at 01:49:44PM -0600, Jon Derrick wrote: >> VMD retransmits child device MSI/X with the VMD endpoint's requester-id. >> In order to support direct interrupt remapping of VMD child devices, >> ensure that the IRTE is progr

Re: [PATCH 5/6] x86/apic/msi: Use Real PCI DMA device when configuring IRTE

2020-09-07 Thread Lorenzo Pieralisi
On Tue, Jul 28, 2020 at 01:49:44PM -0600, Jon Derrick wrote: > VMD retransmits child device MSI/X with the VMD endpoint's requester-id. > In order to support direct interrupt remapping of VMD child devices, > ensure that the IRTE is programmed with the VMD endpoint's requester-id > using pci_real_d

Re: [PATCH 0/7] scsi: Remove pci-dma-compat wrapper APIs.

2020-08-31 Thread Martin K. Petersen
On Wed, 29 Jul 2020 23:35:29 +0530, Suraj Upadhyay wrote: > Hii Maintainers, > This patchset replaces the pci-dma-compat wrappers with their > dma-mapping counterparts. Thus, removing possible midlayering and > unnecessary legacy code and API. > > Most of the task i

Re: [PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-24 Thread Jason Gunthorpe
On Sun, Aug 09, 2020 at 12:54:28PM +0530, Suraj Upadhyay wrote: > Hii Developers, > > This patch series will replace all the legacy pci-dma-compat wrappers > with the dma-mapping APIs directly in the INFINIBAND Subsystem. > > This task is done through a coccinelle script

Re: [PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-09 Thread Suraj Upadhyay
On Sun, Aug 09, 2020 at 11:35:51AM +0300, Gal Pressman wrote: > On 09/08/2020 10:24, Suraj Upadhyay wrote: > > Hii Developers, > > > > This patch series will replace all the legacy pci-dma-compat wrappers > > with the dma-mapping APIs directly in the INFINIBAND Su

Re: [PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-09 Thread Gal Pressman
On 09/08/2020 10:24, Suraj Upadhyay wrote: > Hii Developers, > > This patch series will replace all the legacy pci-dma-compat wrappers > with the dma-mapping APIs directly in the INFINIBAND Subsystem. > > This task is done through a coccinelle script which is described

Re: [PATCH 5/4] RDMA/efa : Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Joe Perches
On Sun, 2020-08-09 at 13:15 +0530, Suraj Upadhyay wrote: > The legacy API wrappers in include/linux/pci-dma-compat.h > should go away as it creates unnecessary midlayering > for include/linux/dma-mapping.h APIs. > > Instead use dma-mapping.h APIs directly. > > The patch ha

[PATCH 5/4] RDMA/efa : Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH 4/4] RDMA/pvrdma: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH 3/4] RDMA/qib: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH 2/4] IB/mthca: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH 1/4] IB/hfi1: Remove pci-dma-compat wrapper APIs

2020-08-09 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH 0/4] Infiniband Subsystem: Remove pci-dma-compat wrapper APIs.

2020-08-09 Thread Suraj Upadhyay
Hii Developers, This patch series will replace all the legacy pci-dma-compat wrappers with the dma-mapping APIs directly in the INFINIBAND Subsystem. This task is done through a coccinelle script which is described in each commit message. The changes are compile tested. Thanks, Suraj

Re: [PATCH RESEND 1/2] scsi: megaraid: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
On Tue, Jul 28, 2020 at 11:40:12PM -0400, Martin K. Petersen wrote: > > Hello Suraj! > > > The legacy API wrappers in include/linux/pci-dma-compat.h > > should go away as it creates unnecessary midlayering > > for include/linux/dma-mapping.h APIs, instead use dma-

[PATCH 7/7] scsi: megaraid: Remove pci-dma-compat wrapper APIs

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. And has been hand modified to replace each

[PATCH 6/7] scsi: qla2xxx: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested

[PATCH 5/7] scsi: hpsa: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested

[PATCH 4/7] scsi: mpt3sas: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested

[PATCH 3/7] scsi: dc395x: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile tested

[PATCH 2/7] scsi: aic7xxx: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. And has been hand modified to replace each

[PATCH 1/7] scsi: aacraid: Remove pci-dma-compat wrapper APIs

2020-07-29 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs. Instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below. Compile-tested

[PATCH 0/7] scsi: Remove pci-dma-compat wrapper APIs.

2020-07-29 Thread Suraj Upadhyay
Hii Maintainers, This patchset replaces the pci-dma-compat wrappers with their dma-mapping counterparts. Thus, removing possible midlayering and unnecessary legacy code and API. Most of the task is fairly trivially scriptable and done with coccinelle. But the handling of pci_z

Re: [PATCH RESEND 1/2] scsi: megaraid: Remove pci-dma-compat wrapper APIs.

2020-07-28 Thread Martin K. Petersen
Hello Suraj! > The legacy API wrappers in include/linux/pci-dma-compat.h > should go away as it creates unnecessary midlayering > for include/linux/dma-mapping.h APIs, instead use dma-mapping.h > APIs directly. Instead of all these individual patches, please submit a combined patc

[PATCH 5/6] x86/apic/msi: Use Real PCI DMA device when configuring IRTE

2020-07-28 Thread Jon Derrick
VMD retransmits child device MSI/X with the VMD endpoint's requester-id. In order to support direct interrupt remapping of VMD child devices, ensure that the IRTE is programmed with the VMD endpoint's requester-id using pci_real_dma_dev(). Reviewed-by: Andy Shevchenko Signed-off-by: Jon Derrick

[PATCH RESEND] scsi: mpt3sas: Remove pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH RESEND] scsi: qla2xxx: Remove pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH RESEND 1/2] scsi: megaraid: Remove pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

[PATCH RESEND 2/2] scsi: megaraid: Remove remaining pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

[PATCH RESEND] scsi: aic7xxx: Remove pci-dma-compat wrapper APIs.

2020-07-27 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

[PATCH 2/2] scsi: megaraid: Remove remaining pci-dma-compat wrapper APIs.

2020-07-18 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

[PATCH 1/2] scsi: megaraid: Remove pci-dma-compat wrapper APIs.

2020-07-18 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

[PATCH] scsi: qla2xxx: Remove pci-dma-compat wrapper APIs.

2020-07-18 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH] scsi: mpt3sas: Remove pci-dma-compat wrapper APIs.

2020-07-18 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH] scsi: aic7xxx: Remove pci-dma-compat wrapper APIs.

2020-07-18 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and has been hand modified to replace GFP_

[PATCH] scsi: aacraid: Remove pci-dma-compat wrapper APIs.

2020-07-18 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH] USB: Remove pci-dma-compat wrapper APIs.

2020-07-14 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

Re: [PATCH v2] staging: comedi: s626: Remove pci-dma-compat wrapper APIs.

2020-07-14 Thread Ian Abbott
On 13/07/2020 15:32, Suraj Upadhyay wrote: The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below

[PATCH v2] staging: comedi: s626: Remove pci-dma-compat wrapper APIs.

2020-07-13 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

Re: [PATCH] staging: comedi: s626: Remove pci-dma-compat wrapper APIs.

2020-07-13 Thread Ian Abbott
On 11/07/2020 14:38, Christophe JAILLET wrote: Le 11/07/2020 à 14:35, Suraj Upadhyay a écrit : The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch

Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-12 Thread Benjamin Poirier
On 2020-07-13 11:14 +0530, Suraj Upadhyay wrote: > On Mon, Jul 13, 2020 at 01:59:59PM +0900, Benjamin Poirier wrote: > > On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > > > The legacy API wrappers in include/linux/pci-dma-compat.h > > > should go away as it crea

Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-12 Thread Suraj Upadhyay
On Mon, Jul 13, 2020 at 01:59:59PM +0900, Benjamin Poirier wrote: > On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > > The legacy API wrappers in include/linux/pci-dma-compat.h > > should go away as it creates unnecessary midlayering > > for include/linux/dma-mapping.h

Re: [PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-12 Thread Benjamin Poirier
On 2020-07-11 18:16 +0530, Suraj Upadhyay wrote: > The legacy API wrappers in include/linux/pci-dma-compat.h > should go away as it creates unnecessary midlayering > for include/linux/dma-mapping.h APIs, instead use dma-mapping.h > APIs directly. > > The patch has been

Re: [PATCH] staging: comedi: s626: Remove pci-dma-compat wrapper APIs.

2020-07-11 Thread Christophe JAILLET
Le 11/07/2020 à 14:35, Suraj Upadhyay a écrit : The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script

[PATCH] staging: rtl8192e: rtl_core: Remove pci-dma-compat wrapper APIs.

2020-07-11 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH] staging: rtl8192e: rtl8192E_dev: Remove pci-dma-compat wrapper APIs.

2020-07-11 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH] staging: qlge: Remove pci-dma-compat wrapper APIs.

2020-07-11 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

[PATCH] staging: comedi: s626: Remove pci-dma-compat wrapper APIs.

2020-07-11 Thread Suraj Upadhyay
The legacy API wrappers in include/linux/pci-dma-compat.h should go away as it creates unnecessary midlayering for include/linux/dma-mapping.h APIs, instead use dma-mapping.h APIs directly. The patch has been generated with the coccinelle script below and compile-tested

Re: [PATCH v3 0/3] MIPS: SiByte: Handle PCI DMA with 64-bit memory addressing

2018-11-19 Thread Paul Burton
Hello, Maciej W. Rozycki wrote: > Hi, > > This mini patch series enables correct support for DMA in the presence of > memory outside the 32-bit address range with the Broadcom SiByte SOCs and > the relevant development boards. > > There is a quirk in the BCM1250, BCM1125 and BCM1125H SOCs in tha

[PATCH v3 0/3] MIPS: SiByte: Handle PCI DMA with 64-bit memory addressing

2018-11-13 Thread Maciej W. Rozycki
Hi, This mini patch series enables correct support for DMA in the presence of memory outside the 32-bit address range with the Broadcom SiByte SOCs and the relevant development boards. There is a quirk in the BCM1250, BCM1125 and BCM1125H SOCs in that their onchip 32-bit PCI host bridge does

[PATCH v2 0/2] MIPS: SiByte: Handle PCI DMA with 64-bit memory addressing

2018-11-12 Thread Maciej W. Rozycki
Hi, This mini patch series enables correct support for DMA in the presence of memory outside the 32-bit address range with the Broadcom SiByte SOCs and the relevant development boards. There is a quirk in the BCM1250, BCM1125 and BCM1125H SOCs in that their onchip 32-bit PCI host bridge does

[PATCH 0/2] MIPS: SiByte: Handle PCI DMA with 64-bit memory addressing

2018-11-06 Thread Maciej W. Rozycki
Hi, This mini patch series enables correct support for DMA in the presence of memory outside the 32-bit address range with the Broadcom SiByte SOCs and the relevant development boards. There is a quirk in the BCM1250, BCM1125 and BCM1125H SOCs in that their onchip 32-bit PCI host bridge does

Re: [PATCH v1] arch/x86/kernel/pci-dma: Remove useless parameter of arch_dma_alloc_attrs

2018-05-25 Thread Christoph Hellwig
Thanks, applied to the dma-mapping tree.

[PATCH v1] arch/x86/kernel/pci-dma: Remove useless parameter of arch_dma_alloc_attrs

2018-05-24 Thread Huaisheng Ye
From: Huaisheng Ye arch_dma_alloc_attrs has parameter gfp which is not used at all. Remove it. Signed-off-by: Huaisheng Ye Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: Christoph Hellwig Cc: Marek Szyprowski Cc: Robin Murphy Cc: Konrad Rzeszutek Wilk Cc: Andrew Morton Cc:

Re: PCI: Regression in remove NULL device handling from PCI DMA API

2018-05-09 Thread tedheadster
Christoph, that patch fixed the panic. Thank you for the fix. Please submit them to the netdev mailing list. - Matthew

Re: PCI: Regression in remove NULL device handling from PCI DMA API

2018-05-07 Thread Christoph Hellwig
Does it work with this patch applied? --- >From 564da7415bbd43457561b1e4c4cf07d1c7e20d44 Mon Sep 17 00:00:00 2001 From: Christoph Hellwig Date: Mon, 7 May 2018 12:11:49 +0200 Subject: 3c59x: convert to generic DMA API Signed-off-by: Christoph Hellwig --- drivers/net/ethernet/3com/3c59x.c | 104

PCI: Regression in remove NULL device handling from PCI DMA API

2018-05-05 Thread tedheadster
Christoph, I bisected the following kernel panic to the patch "PCI: Remove NULL device handling from PCI DMA API". It seems we still need NULL checking for some older drivers, in my case the 3c59x driver for PCI/EISA cards. I am pretty sure the panic arises in the driver here (d

[PATCH 4/4] PCI: Remove NULL device handling from PCI DMA API

2018-01-10 Thread Christoph Hellwig
Historically some ISA drivers used the old PCI DMA API with a NULL pdev argument, but these days this isn't used and not too useful due to the per-device DMA ops, so remove it. Signed-off-by: Christoph Hellwig --- include/linux/pci-dma-compat.h | 27 +-- 1 file ch

Re: [PATCH 3/3] pci-dma-compat: remove handling of NULL pdev arguments

2018-01-10 Thread Christoph Hellwig
On Tue, Jan 09, 2018 at 06:25:44PM -0600, Bjorn Helgaas wrote: > It looks like "pci_free_consistent(NULL" is still used in > drivers/net/ethernet/tundra/tsi108_eth.c. Yikes. That one needs to pass the device is the platform dev to the dma_map_* routines to start with, and mixing that with PCI is

Re: [PATCH 3/3] pci-dma-compat: remove handling of NULL pdev arguments

2018-01-09 Thread Bjorn Helgaas
s/pci-dma-compat: remove handling of NULL pdev /PCI: Remove NULL device handling from DMA API/ On Tue, Jan 09, 2018 at 09:39:39PM +0100, Christoph Hellwig wrote: > Historically some ISA drivers used the old pci DMA API with a NULL pdev > argument, but these days this isn't used

[PATCH 3/3] pci-dma-compat: remove handling of NULL pdev arguments

2018-01-09 Thread Christoph Hellwig
Historically some ISA drivers used the old pci DMA API with a NULL pdev argument, but these days this isn't used and not too useful due to the per-device DMA ops, so remove it. Signed-off-by: Christoph Hellwig --- include/linux/pci-dma-compat.h | 27 +-- 1 file ch

Re: [PATCH v6 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-22 Thread Oza Oza
On Thu, May 18, 2017 at 12:43 AM, Arnd Bergmann wrote: > On Tue, May 16, 2017 at 7:22 AM, Oza Pawandeep wrote: >> current device framework and OF framework integration assumes >> dma-ranges in a way where memory-mapped devices define their >> dma-ranges. (child-bus-address, parent-bus-address, le

Re: [PATCH v6 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-18 Thread Oza Oza
On Thu, May 18, 2017 at 12:43 AM, Arnd Bergmann wrote: > On Tue, May 16, 2017 at 7:22 AM, Oza Pawandeep wrote: >> current device framework and OF framework integration assumes >> dma-ranges in a way where memory-mapped devices define their >> dma-ranges. (child-bus-address, parent-bus-address, le

Re: [PATCH v6 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-18 Thread Oza Oza
On Wed, May 17, 2017 at 10:40 PM, Bjorn Helgaas wrote: > On Tue, May 16, 2017 at 10:52:05AM +0530, Oza Pawandeep wrote: >> current device framework and OF framework integration assumes > > s/current/The current/ > >> dma-ranges in a way where memory-mapped devices define their >> dma-ranges. (chil

Re: [PATCH v6 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-17 Thread Arnd Bergmann
On Tue, May 16, 2017 at 7:22 AM, Oza Pawandeep wrote: > current device framework and OF framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_configure is specifically written to take c

Re: [PATCH v6 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-17 Thread Bjorn Helgaas
On Tue, May 16, 2017 at 10:52:05AM +0530, Oza Pawandeep wrote: > current device framework and OF framework integration assumes s/current/The current/ > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_configure

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-15 Thread Oza Oza
On Sat, May 6, 2017 at 11:00 AM, Oza Oza wrote: > On Fri, May 5, 2017 at 8:55 PM, Robin Murphy wrote: >> On 04/05/17 19:41, Oza Oza wrote: >> [...] > 5) leaves scope of adding PCI flag handling for inbound memory > by the new function. Which flags would ever actually matter? DMA

[PATCH v6 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-15 Thread Oza Pawandeep
current device framework and OF framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for p

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Oza Oza
On Fri, May 5, 2017 at 8:55 PM, Robin Murphy wrote: > On 04/05/17 19:41, Oza Oza wrote: > [...] 5) leaves scope of adding PCI flag handling for inbound memory by the new function. >>> >>> Which flags would ever actually matter? DMA windows aren't going to be >>> to config or I/O space, s

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Robin Murphy
On 04/05/17 19:41, Oza Oza wrote: [...] >>> 5) leaves scope of adding PCI flag handling for inbound memory >>> by the new function. >> >> Which flags would ever actually matter? DMA windows aren't going to be >> to config or I/O space, so the memory type can be assumed, and the >> 32/64-bit distinc

[PATCH v5 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Oza Pawandeep
current device framework and OF framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for p

[PATCH v4 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Oza Pawandeep
current device framework and OF framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for p

[PATCH v3 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Oza Pawandeep
current device framework and OF framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for p

[PATCH v2 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Oza Pawandeep
current device framework and OF framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for p

[PATCH v2 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-05 Thread Oza Pawandeep
current device framework and OF framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for p

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-04 Thread Oza Oza
On Thu, May 4, 2017 at 11:32 PM, Robin Murphy wrote: > [apologies for the silence - I've been on holiday] > > On 03/05/17 05:46, Oza Pawandeep wrote: >> current device framework and of framework integration assumes >> dma-ranges in a way where memory-mapped devices define their >> dma-ranges. (chi

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-04 Thread Oza Oza
On Thu, May 4, 2017 at 11:32 PM, Robin Murphy wrote: > [apologies for the silence - I've been on holiday] > > On 03/05/17 05:46, Oza Pawandeep wrote: >> current device framework and of framework integration assumes >> dma-ranges in a way where memory-mapped devices define their >> dma-ranges. (chi

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-04 Thread Robin Murphy
[apologies for the silence - I've been on holiday] On 03/05/17 05:46, Oza Pawandeep wrote: > current device framework and of framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). Well, yes, that

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-03 Thread Rob Herring
On Tue, May 2, 2017 at 11:46 PM, Oza Pawandeep wrote: > current device framework and of framework integration assumes > dma-ranges in a way where memory-mapped devices define their > dma-ranges. (child-bus-address, parent-bus-address, length). > > of_dma_configure is specifically written to take c

Re: [PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-02 Thread Oza Oza
I will send v2 after removing GERRIT details from commit message. My apologies for the noise. Regards, Oza

Re: [RFC PATH] of/pci/dma: fix DMA configruation for PCI masters

2017-05-02 Thread Oza Oza
(!node) >> return -EINVAL; >> >> + if (strcmp(np->name, "pci")) { > > Using the name is not reliable though I did recently add a dtc check > for this. Of course, 'pcie' is valid too (and probably should be used > for what you

[PATCH 1/3] of/pci/dma: fix DMA configuration for PCI masters

2017-05-02 Thread Oza Pawandeep
current device framework and of framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. (child-bus-address, parent-bus-address, length). of_dma_configure is specifically written to take care of memory mapped devices. but no implementation exists for p

Re: [RFC PATH] of/pci/dma: fix DMA configruation for PCI masters

2017-04-24 Thread Rob Herring
On Sat, Apr 22, 2017 at 3:08 AM, Oza Pawandeep wrote: > current device frmework and of framework integration assumes dma-ranges > in a way where memory-mapped devices define their dma-ranges. > dma-ranges: (child-bus-address, parent-bus-address, length). > > but iproc based SOCs and other SOCs(suc

[RFC PATH] of/pci/dma: fix DMA configruation for PCI masters

2017-04-22 Thread Oza Pawandeep
current device frmework and of framework integration assumes dma-ranges in a way where memory-mapped devices define their dma-ranges. dma-ranges: (child-bus-address, parent-bus-address, length). but iproc based SOCs and other SOCs(suc as rcar) have PCI world dma-ranges. dma-ranges = <0x4300 0x

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-30 Thread Oza Oza
On Tue, Mar 28, 2017 at 7:43 PM, Rob Herring wrote: > On Tue, Mar 28, 2017 at 12:27 AM, Oza Oza wrote: >> On Mon, Mar 27, 2017 at 8:16 PM, Rob Herring wrote: >>> On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep >>> wrote: it is possible that PCI device supports 64-bit DMA addressing,

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-29 Thread Oza Oza
/linux/pci.h >> @@ -2086,6 +2086,7 @@ void pci_release_of_node(struct pci_dev *dev); >> void pci_set_bus_of_node(struct pci_bus *bus); >> void pci_release_bus_of_node(struct pci_bus *bus); >> struct irq_domain *pci_host_bridge_of_msi_domain(struct pci_bus *bus); >> +stru

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-28 Thread Oza Oza
line struct device_node * > pci_device_to_OF_node(const struct pci_dev *pdev) { return NULL; } > static inline struct irq_domain * > pci_host_bridge_of_msi_domain(struct pci_bus *bus) { return NULL; } > +static inline struct device_node * > +pci_dev_get_dma_of_node(struct pci_dev *dev) { return NULL; } > #endif /* CONFIG_OF */ > > #ifdef CONFIG_ACPI > pci and memory mapped device world is different. of course if you talk from iommu perspective, all the master are same for IOMMU but the original intention of the patch is to try to solve 2 problems. 1) expose generic API for pci world clients to configure their dma-ranges. right now there is none. 2) same API can be used by IOMMU to derive dma_mask. the implementation tries to handle dma-ranges for both memory mapped and pci devices, which I think is overkill. besides we have different configuration of dma-ranges based on iommu is enabled or not enabled. #define PCIE_DMA_RANGES dma-ranges = <0x4300 0x00 0x8000 0x00 0x8000 0x00 0x8000 \ 0x4300 0x08 0x 0x08 0x 0x08 0x \ 0x4300 0x80 0x 0x80 0x 0x40 0x>; the of_dma_get_range is written with respect to traditional memory ranges, they were not meant for pci dma-ranges. Regards, Oza.

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-28 Thread Robin Murphy
On 28/03/17 06:27, Oza Oza wrote: > On Mon, Mar 27, 2017 at 8:16 PM, Rob Herring wrote: >> On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep wrote: >>> it is possible that PCI device supports 64-bit DMA addressing, >>> and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), >>> however PCI

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-28 Thread Rob Herring
On Tue, Mar 28, 2017 at 12:27 AM, Oza Oza wrote: > On Mon, Mar 27, 2017 at 8:16 PM, Rob Herring wrote: >> On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep wrote: >>> it is possible that PCI device supports 64-bit DMA addressing, >>> and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64),

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-27 Thread Oza Oza
On Mon, Mar 27, 2017 at 8:16 PM, Rob Herring wrote: > On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep wrote: >> it is possible that PCI device supports 64-bit DMA addressing, >> and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), >> however PCI host bridge may have limitations on the

Re: [RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-27 Thread Rob Herring
On Sat, Mar 25, 2017 at 12:31 AM, Oza Pawandeep wrote: > it is possible that PCI device supports 64-bit DMA addressing, > and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), > however PCI host bridge may have limitations on the inbound > transaction addressing. As an example, consider

[RFC PATCH 1/3] of/pci: dma-ranges to account highest possible host bridge dma_mask

2017-03-24 Thread Oza Pawandeep
it is possible that PCI device supports 64-bit DMA addressing, and thus it's driver sets device's dma_mask to DMA_BIT_MASK(64), however PCI host bridge may have limitations on the inbound transaction addressing. As an example, consider NVME SSD device connected to iproc-PCIe controller. Currently,

[PATCH v2 0/2] Add (PCI) DMA support to MCB.

2016-08-29 Thread Michael Moese
This is v2 of this patch series. The first series had missing commit logs and named the dma_dev differently in include/linux/mcb.h and drivers/mcb/mcb-core.c. This small series of two patches enable (PCI) DMA support in MCB. The first patch enables PCI bus mastering by default for all PCI

Re: [Add PCI DMA support to MCB 0/2]

2016-08-29 Thread michael.moese
I'm sorry for the errors in the patches. I'll correct them and resend everything. On Mon, Aug 29, 2016 at 02:08:21PM +0200, Michael Moese wrote: > This small series of two patches enable (PCI) DMA support in MCB. > > The first patch enables PCI bus mastering by default for

[Add PCI DMA support to MCB 0/2]

2016-08-29 Thread Michael Moese
This small series of two patches enable (PCI) DMA support in MCB. The first patch enables PCI bus mastering by default for all PCI-based MCB devices. The second patch adds a dma_device to the mcb_device for all devices as a shortcut to mcb_device->bus->carrier. Michael Moese (2): Enab

  1   2   >