From: Heiner Kallweit
[ Upstream commit e80bd76fbf563cc7ed8c9e9f3bbcdf59b0897f69 ]
A user reported failing network with RTL8168dp (a quite rare chip
version). Realtek confirmed that few chip versions suffer from a PLL
power-down hw bug.
Fixes: 07df5bd874f0 ("r8169: power down chip in probe")
Si
From: Heiner Kallweit
[ Upstream commit e80bd76fbf563cc7ed8c9e9f3bbcdf59b0897f69 ]
A user reported failing network with RTL8168dp (a quite rare chip
version). Realtek confirmed that few chip versions suffer from a PLL
power-down hw bug.
Fixes: 07df5bd874f0 ("r8169: power down chip in probe")
Si
From: Heiner Kallweit
[ Upstream commit e80bd76fbf563cc7ed8c9e9f3bbcdf59b0897f69 ]
A user reported failing network with RTL8168dp (a quite rare chip
version). Realtek confirmed that few chip versions suffer from a PLL
power-down hw bug.
Fixes: 07df5bd874f0 ("r8169: power down chip in probe")
Si
On Wed, Sep 16, 2020 at 08:32:26AM -0500, Bjorn Helgaas wrote:
> > So is it ok to take this patch now, or does it need to be changed any?
>
> Yes, it's OK with me if you take this patch.
>
> The ASPM hardware feature is designed to work without any driver
> support. It does need to be configured
t; > linux-kernel@vger.kernel.org;
> > > > puranja...@gmail.com; linux-...@vger.kernel.org;
> > > > vailbhavgupt...@gamail.com
> > > > Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and
> > > > fix driving
> > > > par
gt; > > To: 吳昊澄 Ricky
> > > Cc: a...@arndb.de; gre...@linuxfoundation.org; bhelg...@google.com;
> > > ulf.hans...@linaro.org; rui_f...@realsil.com.cn;
> > > linux-kernel@vger.kernel.org;
> > > puranja...@gmail.com; linux-...@vger.kernel.org;
> > > vailb
lg...@google.com;
> > ulf.hans...@linaro.org; rui_f...@realsil.com.cn;
> > linux-kernel@vger.kernel.org;
> > puranja...@gmail.com; linux-...@vger.kernel.org;
> > vailbhavgupt...@gamail.com
> > Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix
>
el@vger.kernel.org;
> puranja...@gmail.com; linux-...@vger.kernel.org;
> vailbhavgupt...@gamail.com
> Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix
> driving
> parameter
>
> On Fri, Sep 11, 2020 at 08:18:22AM +, 吳昊澄 Ricky wrote:
> > >
lg...@google.com;
> > ulf.hans...@linaro.org; rui_f...@realsil.com.cn;
> > linux-kernel@vger.kernel.org;
> > puranja...@gmail.com; linux-...@vger.kernel.org;
> > vailbhavgupt...@gamail.com
> > Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix
>
el@vger.kernel.org;
> puranja...@gmail.com; linux-...@vger.kernel.org;
> vailbhavgupt...@gamail.com
> Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix
> driving
> parameter
>
> On Wed, Sep 09, 2020 at 07:10:19AM +, 吳昊澄 Ricky wrote:
> > >
lg...@google.com;
> > ulf.hans...@linaro.org; rui_f...@realsil.com.cn;
> > linux-kernel@vger.kernel.org;
> > puranja...@gmail.com; linux-...@vger.kernel.org;
> > vailbhavgupt...@gamail.com
> > Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix
>
el@vger.kernel.org;
> puranja...@gmail.com; linux-...@vger.kernel.org;
> vailbhavgupt...@gamail.com
> Subject: Re: [PATCH v5 2/2] misc: rtsx: Add power saving functions and fix
> driving
> parameter
>
> On Mon, Sep 07, 2020 at 06:07:31PM +0800, ricky...@realtek.com wrote:
> >
On Mon, Sep 07, 2020 at 06:07:31PM +0800, ricky...@realtek.com wrote:
> From: Ricky Wu
>
> v4:
> split power down flow and power saving function to two patch
>
> v5:
> fix up modified change under the --- line
Hehe, this came out *above* the "---" line :)
>
From: Ricky Wu
v4:
split power down flow and power saving function to two patch
v5:
fix up modified change under the --- line
Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260
Fix rts5260 driving parameter
Signed-off-by: Ricky Wu
---
drivers/misc/cardreader
From: Ricky Wu
Add rts522a L1 sub-state support
Save more power on rts5227 rts5249 rts525a rts5260
Fix rts5260 driving parameter
Signed-off-by: Ricky Wu
---
drivers/misc/cardreader/rts5227.c | 112 +-
drivers/misc/cardreader/rts5249.c | 145 -
> > > From: Ricky Wu
> > >
> > > Added rts5227 rts5249 rts5260 rts5228 power saving functions,
> > > added BIOS guide MMC funciton and U_d3_en register support and
> > > fixed rts5260 driving parameter
> >
> > This should be split into
amail.com;
> linux-...@vger.kernel.org; puranja...@gmail.com; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3] misc: rtsx: add power saving function and bios guide
> options
>
> On Tue, Sep 01, 2020 at 05:51:18PM +0800, ricky...@realtek.com wrote:
> > From: Ricky Wu
On Tue, Sep 01, 2020 at 05:51:18PM +0800, ricky...@realtek.com wrote:
> From: Ricky Wu
>
> v2 v3:
> fixed build WARNING
>
> v1:
> Added rts5227 rts5249 rts5260 rts5228 power saving functions,
> added BIOS guide MMC funciton and U_d3_en register support and
> fixe
From: Ricky Wu
v2 v3:
fixed build WARNING
v1:
Added rts5227 rts5249 rts5260 rts5228 power saving functions,
added BIOS guide MMC funciton and U_d3_en register support and
fixed rts5260 driving parameter
Signed-off-by: Ricky Wu
---
drivers/misc/cardreader/rts5227.c | 115
.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/ricky_wu-realtek-com/misc-rtsx-add-power-saving-function-and-bios-guide-options/20200901-145147
base: https://git.kernel.o
From: Ricky Wu
v2:
fixed build WARNING
v1:
Added rts5227 rts5249 rts5260 rts5228 power saving functions,
added BIOS guide MMC funciton and U_d3_en register support and
fixed rts5260 driving parameter
Signed-off-by: Ricky Wu
---
drivers/misc/cardreader/rts5227.c | 115
From: Ricky Wu
v2:
fixed build WARNING
v1:
Added rts5227 rts5249 rts5260 rts5228 power saving functions,
added BIOS guide MMC funciton and U_d3_en register support and
fixed rts5260 driving parameter
Signed-off-by: Ricky Wu
---
drivers/misc/cardreader/rts5227.c | 115
.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url:
https://github.com/0day-ci/linux/commits/ricky_wu-realtek-com/misc-rtsx-add-power-saving-function-and-bios-guide-options/20200901-103534
base: https://git.kernel.o
From: Ricky Wu
Added rts5227 rts5249 rts5260 rts5228 power saving functions,
added BIOS guide MMC funciton and U_d3_en register support and
fixed rts5260 driving parameter
Signed-off-by: Ricky Wu
---
drivers/misc/cardreader/rts5227.c | 115 +-
drivers/misc/cardreader
From: Ricky Wu
Added rts5227 rts5249 rts5260 rts5228 power saving functions,
added BIOS guide MMC funciton and U_d3_en register support and
fixed rts5260 driving parameter
Signed-off-by: Ricky Wu
---
drivers/misc/cardreader/rts5227.c | 115 +-
drivers/misc/cardreader
From: RickyWu
this patch fixes rts5260 power saving parameter
make power saving function work on L1.1, L1.2
Signed-off-by: RickyWu
---
drivers/misc/cardreader/rts5260.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/cardreader/rts5260.c
b/drivers/misc
at 16:56, ricky...@realtek.com wrote:
From: RickyWu
this patch fixes rts5260 power saving parameter
make power saving function work on L1.1, L1.2
Signed-off-by: RickyWu
---
drivers/misc/cardreader/rts5260.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff
From: RickyWu
this patch fixes rts5260 power saving parameter
make power saving function work on L1.1, L1.2
Signed-off-by: RickyWu
---
drivers/misc/cardreader/rts5260.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/drivers/misc/cardreader/rts5260
/commits/Hugues-Fruchet/media-stm32-dcmi-add-power-saving-support/20180611-174016
base: git://linuxtv.org/media_tree.git master
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget
https://raw.githubusercontent.com/intel
/commits/Hugues-Fruchet/media-stm32-dcmi-add-power-saving-support/20180611-174016
base: git://linuxtv.org/media_tree.git master
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH
Implements runtime & system sleep power management ops.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 80 ---
1 file changed, 64 insertions(+), 16 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/pla
3.18-stable review patch. If anyone has any objections, please let me know.
--
From: Lenny Szubowicz
[ Upstream commit 8b29d29abc484d638213dd79a18a95ae7e5bb402 ]
Fix once per second (round_robin_time) memory leak of about 1 KB in
each acpi_pad kernel idling thread that is acti
4.4-stable review patch. If anyone has any objections, please let me know.
--
From: Lenny Szubowicz
[ Upstream commit 8b29d29abc484d638213dd79a18a95ae7e5bb402 ]
Fix once per second (round_robin_time) memory leak of about 1 KB in
each acpi_pad kernel idling thread that is activ
4.9-stable review patch. If anyone has any objections, please let me know.
--
From: Lenny Szubowicz
[ Upstream commit 8b29d29abc484d638213dd79a18a95ae7e5bb402 ]
Fix once per second (round_robin_time) memory leak of about 1 KB in
each acpi_pad kernel idling thread that is activ
4.14-stable review patch. If anyone has any objections, please let me know.
--
From: Lenny Szubowicz
[ Upstream commit 8b29d29abc484d638213dd79a18a95ae7e5bb402 ]
Fix once per second (round_robin_time) memory leak of about 1 KB in
each acpi_pad kernel idling thread that is acti
4.16-stable review patch. If anyone has any objections, please let me know.
--
From: Lenny Szubowicz
[ Upstream commit 8b29d29abc484d638213dd79a18a95ae7e5bb402 ]
Fix once per second (round_robin_time) memory leak of about 1 KB in
each acpi_pad kernel idling thread that is acti
On Tuesday, March 27, 2018 3:56:40 PM CEST Lenny Szubowicz wrote:
> Fix once per second (round_robin_time) memory leak of about 1 KB in
> each acpi_pad kernel idling thread that is activated.
>
> Found by testing with kmemleak.
>
> Signed-off-by: Lenny Szubowicz
> ---
> drivers/acpi/acpi_pad.c
Fix once per second (round_robin_time) memory leak of about 1 KB in
each acpi_pad kernel idling thread that is activated.
Found by testing with kmemleak.
Signed-off-by: Lenny Szubowicz
---
drivers/acpi/acpi_pad.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/acpi/acpi_pad.c b/d
Kai Heng Feng wrote:
Hopefully Hayes (or Realtek) can shed more lights on the issue. Apparently
ALDPS and ASPM for r8169 is enabled in different commercial products, just
not in Linux mainline.
Hayes and Realtek folks,
How do we make this patch going forward?
Do you find the root cause that
4.14-stable review patch. If anyone has any objections, please let me know.
--
From: Loic Poulain
[ Upstream commit 0856655a25476d4431005e39d606e349050066b0 ]
Since driver does not report hardware dynamic power saving cap,
this is up to the mac80211 to manage power saving
Devices that support locality has failed to transmit due to
reserved order of locality request and cmdReady/goIdle handshake.
The cmdReady/goIdle should be performed on the requested locality.
The first patch corrects the locality and power-save order,
adds required polling for completion of goIdl
From: Loic Poulain
[ Upstream commit 0856655a25476d4431005e39d606e349050066b0 ]
Since driver does not report hardware dynamic power saving cap,
this is up to the mac80211 to manage power saving timeout and
state machine, using the ieee80211 config callback to report
PS changes. This patch
apabilites registers, right? If so, why isn't the
> > > > > > > > existing PCI core ASPM support sufficient?
> > > > > > > >
> > > > > > > When L1SS is configured, the device(hardware) can't enter
> > > > >
> PCI core ASPM support sufficient?
> > > > > > >
> > > > > > When L1SS is configured, the device(hardware) can't enter L1SS
> > > > > > status automatically, it need driver(software) to do some work
> > > > > > to
Devices that support locality has failed to transmit due to
reserved order of locality request and cmdReady/goIdle handshake.
The cmdReady/goIdle should be performed on the requested locality.
The first patch corrects the locality and power-save order,
adds required polling for completion of goIdl
#x27;t enter L1SS
> > > > > status automatically, it need driver(software) to do some work
> > > > > to achieve the
> > > > function.
> > > >
> > > > So this is a hardware defect in the device? As far as I know,
>
isn't the existing PCI
> > > > > core ASPM support sufficient?
> > > > >
> > > > When L1SS is configured, the device(hardware) can't enter L1SS status
> > > > automatically, it need driver(software) to do some work to achieve the
>
device(hardware) can't enter L1SS status
> > > automatically, it need driver(software) to do some work to achieve the
> > function.
> >
> > So this is a hardware defect in the device? As far as I know, ASPM and L1SS
> > are specified such that they sho
function.
>
> So this is a hardware defect in the device? As far as I know, ASPM and L1SS
> are specified such that they should work without special driver support.
>
Yes, you can say that.
> > > > Enable power saving for RTS5250S as following steps:
> > > > 1.Set
core ASPM support
> > sufficient?
> >
> When L1SS is configured, the device(hardware) can't enter L1SS status
> automatically,
> it need driver(software) to do some work to achieve the function.
So this is a hardware defect in the device? As far as I know, ASPM
and L1SS a
verlap and
conflict with PCI core management of ASPM.
I assume these devices advertise ASPM support in their Link
Capabilites registers, right? If so, why isn't the existing
PCI core ASPM support sufficient?
Enable power saving for RTS5250S as following steps:
1.Set 0xFE58 to enable clock p
I assume these devices advertise ASPM support in their Link
Capabilites registers, right? If so, why isn't the existing
PCI core ASPM support sufficient?
> Enable power saving for RTS5250S as following steps:
> 1.Set 0xFE58 to enable clock power management.
Is this clock power management
> On 15 Nov 2017, at 6:53 PM, David Miller wrote:
>
> From: Kai-Heng Feng
> Date: Wed, 15 Nov 2017 04:00:18 -0500
>
>> Commit ("r8169: enable ALDPS for power saving") caused a regression on
>> RTL8168evl/8111evl [1], so it got reverted.
>>
>
David Miller :
[...]
> The amount of coverage this change is going to get is very small as
> well, meaning an even greater chance of regressions.
Yes.
> Therefore the only acceptable way to handle this is to have
> a white-list, specific chips that have been explicitly tested
> and are known to
From: Kai-Heng Feng
Date: Wed, 15 Nov 2017 04:00:18 -0500
> Commit ("r8169: enable ALDPS for power saving") caused a regression on
> RTL8168evl/8111evl [1], so it got reverted.
>
> Instead of reverting the whole commit, let's reinstate ALDPS for all
> models
Commit ("r8169: enable ALDPS for power saving") caused a regression on
RTL8168evl/8111evl [1], so it got reverted.
Instead of reverting the whole commit, let's reinstate ALDPS for all
models other than RTL8168evl/8111evl.
[1] https://lkml.org/lkml/2013/1/5/36
Cc: Francois Romieu
4.9-stable review patch. If anyone has any objections, please let me know.
--
From: Emmanuel Grumbach
[ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ]
iwlwifi now supports RSS and can't let mac80211 track the
PS state based on the Rx frames since they can come out
4.4-stable review patch. If anyone has any objections, please let me know.
--
From: Emmanuel Grumbach
[ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ]
iwlwifi now supports RSS and can't let mac80211 track the
PS state based on the Rx frames since they can come out
From: Emmanuel Grumbach
[ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ]
iwlwifi now supports RSS and can't let mac80211 track the
PS state based on the Rx frames since they can come out of
order. iwlwifi is now advertising AP_LINK_PS, and uses
explicit notifications to teach mac8021
From: Emmanuel Grumbach
[ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ]
iwlwifi now supports RSS and can't let mac80211 track the
PS state based on the Rx frames since they can come out of
order. iwlwifi is now advertising AP_LINK_PS, and uses
explicit notifications to teach mac8021
From: Emmanuel Grumbach
[ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ]
iwlwifi now supports RSS and can't let mac80211 track the
PS state based on the Rx frames since they can come out of
order. iwlwifi is now advertising AP_LINK_PS, and uses
explicit notifications to teach mac8021
From: Emmanuel Grumbach
[ Upstream commit d98937f4ea713d21e0fcc345919f86c877dd8d6f ]
iwlwifi now supports RSS and can't let mac80211 track the
PS state based on the Rx frames since they can come out of
order. iwlwifi is now advertising AP_LINK_PS, and uses
explicit notifications to teach mac8021
On Thu, 07 Sep 2017, rui_f...@realsil.com.cn wrote:
> From: Rui Feng
>
> Enable power saving for RTS5250S as following steps:
> 1.Set 0xFE58 to enable clock power management.
> 2.Check cfg space whether support L1SS or not.
> 3.If support L1SS, set 0xFF03 to free clkreq.
>
From: Rui Feng
Enable power saving for RTS5250S as following steps:
1.Set 0xFE58 to enable clock power management.
2.Check cfg space whether support L1SS or not.
3.If support L1SS, set 0xFF03 to free clkreq.
4.When entering idle status, enable aspm
and set parameters for L1SS and LTR.
5.Wnen
On Tue, 05 Sep 2017, Lee Jones wrote:
> On Tue, 05 Sep 2017, 冯锐 wrote:
>
> > > > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int
> > > > +active) {
> > > > + struct rtsx_cr_option *option = &(pcr->option);
> > > > +
> > > > + u32 interrupt = rtsx_pci_readl(pcr, RTS
From: Rui Feng
Enable power saving for RTS5250S as following steps:
1.Set 0xFE58 to enable clock power management.
2.Check cfg space whether support L1SS or not.
3.If support L1SS, set 0xFF03 to free clkreq.
4.When entering idle status, enable aspm
and set parameters for L1SS and LTR.
5.Wnen
On Tue, 05 Sep 2017, 冯锐 wrote:
> > > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int
> > > +active) {
> > > + struct rtsx_cr_option *option = &(pcr->option);
> > > +
> > > + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR);
> > > + int card_exist = (interrupt & SD_EXIST) | (inter
> > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int
> > +active) {
> > + struct rtsx_cr_option *option = &(pcr->option);
> > +
> > + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR);
> > + int card_exist = (interrupt & SD_EXIST) | (interrupt & MS_EXIST);
> > + int aspm_L1_
On Tue, 05 Sep 2017, 冯锐 wrote:
> Dear Jones,
>
> > +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int
> > +active) {
> > + struct rtsx_cr_option *option = &(pcr->option);
> > +
> > + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR);
> > + int card_exist = (interrupt & SD_EXI
Dear Jones,
> +static void rts5250_set_l1off_cfg_sub_d0(struct rtsx_pcr *pcr, int
> +active) {
> + struct rtsx_cr_option *option = &(pcr->option);
> +
> + u32 interrupt = rtsx_pci_readl(pcr, RTSX_BIPR);
> + int card_exist = (interrupt & SD_EXIST) | (interrupt & MS_EXIST);
> + int
On Thu, 24 Aug 2017, rui_f...@realsil.com.cn wrote:
> From: rui_feng
>
> Signed-off-by: Rui Feng
> ---
> drivers/mfd/rts5249.c| 154 +
> drivers/mfd/rtsx_pcr.c | 177
> +--
> drivers/mfd/rtsx_pcr.h
On Thu, 24 Aug 2017, rui_f...@realsil.com.cn wrote:
> From: rui_feng
You need to write a commit log here.
Why is this change required? What does it achieve? Why have you done
it this way? What effect does it have? Etc ...
> Signed-off-by: Rui Feng
> ---
> drivers/mfd/rts5249.c| 1
From: rui_feng
Signed-off-by: Rui Feng
---
drivers/mfd/rts5249.c| 154 +
drivers/mfd/rtsx_pcr.c | 177 +--
drivers/mfd/rtsx_pcr.h | 12 +++
include/linux/mfd/rtsx_pci.h | 85 +
ngle
> statement; in the latter case use braces in both branches:
>
> .. code-block:: c
>
> if (condition) {
> do_this();
> do_that();
> } else {
> otherwise();
> }
Ah, I thought that was only for Zepher
Never mind then. Keep tha
On Tue, 22 Aug 2017, rui_f...@realsil.com.cn wrote:
> From: Rui Feng
>
> Signed-off-by: Rui Feng
> ---
> drivers/mfd/rts5249.c| 195
> drivers/mfd/rtsx_pcr.c | 205
> +--
> drivers/mfd/rtsx_pcr.h
From: Rui Feng
Signed-off-by: Rui Feng
---
drivers/mfd/rts5249.c| 195
drivers/mfd/rtsx_pcr.c | 205 +--
drivers/mfd/rtsx_pcr.h | 11 +++
include/linux/mfd/rtsx_pci.h | 60 +
4 fil
On Mon, 21 Aug 2017, rui_f...@realsil.com.cn wrote:
> From: rui_feng
Please use the format "First Last" for you name.
> Signed-off-by: rui_feng
Same.
You should also send patches using `git format patch` and `git send-email`.
> ---
> drivers/mfd/rts5249.c| 183 +
From: rui_feng
Signed-off-by: rui_feng
---
drivers/mfd/rts5249.c| 183 ++
drivers/mfd/rtsx_pcr.c | 206 +--
drivers/mfd/rtsx_pcr.h | 2 +
include/linux/mfd/rtsx_pci.h | 47 ++
4 files chan
-support-for-RTS5250S-power-saving/20170820-102051
base: https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git for-mfd-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
From: rui_feng
Signed-off-by: rui_feng
---
drivers/mfd/rts5249.c| 139 +
drivers/mfd/rtsx_pcr.c | 206 +--
drivers/mfd/rtsx_pcr.h | 2 +
include/linux/mfd/rtsx_pci.h | 47 ++
4 files changed, 389
John Heenan writes:
> Barry Day has submitted real world reports for the 8192eu and 8192cu.
> This needs to be acknowledged. I have submitted real world reports for
> the 8723bu.
Lets get this a little more clear - first of all, I have asked you to
investigate which part resolves the problem. Rat
Barry Day has submitted real world reports for the 8192eu and 8192cu.
This needs to be acknowledged. I have submitted real world reports for
the 8723bu.
When it comes down to it, it looks like the kernel code changes are
really going to be very trivial to fix this problem and we need to
take the f
On 1 November 2016 at 08:24, John Heenan wrote:
> @@ -5779,6 +5779,12 @@ static int rtl8xxxu_start(struct ieee80211_hw *hw)
>
> ret = 0;
>
> + if(priv->fops == &rtl8723bu_fops) {
OK, let me be the first. Documentation/CodingStyle also says to use
space between "if" and "(" ;)
> @@
The rtl8723bu wireless IC shows evidence of a more agressive approach to
power saving, powering down its RF side when there is no wireless
interfacing but leaving USB interfacing intact. This makes the wireless
IC more suitable for use in devices which need to keep their power use
as low as
I have a prepared another patch that is not USB VID/PID dependent for
rtl8723bu devices. It is more elegant. I will send it after this
email.
If I have more patches is it preferable I just put them on github only
and notify a link address until there might be some resolution?
What I meant below a
On Tue, 2016-11-01 at 08:15 +1000, John Heenan wrote:
> > On 1 November 2016 at 07:25, Jes Sorensen wrote:
> > > > John Heenan writes:
> > > The rtl8723bu wireless IC shows evidence of a more agressive approach to
> > > power saving, powering down i
On Mon, Oct 31, 2016 at 05:25:12PM -0400, Jes Sorensen wrote:
> As mentioned previously, if this is to be changed here, it has to be
> matched in the _stop section too. It also has to be investigated exactly
> why this matters for 8723bu. It is possible this matters for other
> devices, but we need
On 1 November 2016 at 07:25, Jes Sorensen wrote:
> John Heenan writes:
>> The rtl8723bu wireless IC shows evidence of a more agressive approach to
>> power saving, powering down its RF side when there is no wireless
>> interfacing but leaving USB interfacing intact. This mak
John Heenan writes:
> The rtl8723bu wireless IC shows evidence of a more agressive approach to
> power saving, powering down its RF side when there is no wireless
> interfacing but leaving USB interfacing intact. This makes the wireless
> IC more suitable for use in devices which
The rtl8723bu wireless IC shows evidence of a more agressive approach to
power saving, powering down its RF side when there is no wireless
interfacing but leaving USB interfacing intact. This makes the wireless
IC more suitable for use in devices which need to keep their power use
as low as
On Thu, Oct 27, 2016 at 05:06:16PM -0700, Andy Lutomirski wrote:
> It looks like there is at least one NVMe disk in existence (a
> different Samsung device) that sporadically dies when APST is on.
> This device appears to also sporadically die when APST is off, but it
> lasts considerably longer be
Here's v4 of the APST patch set. The biggest bikesheddable
>>> > > > thing (I
>>> > > > think) is the scaling factor. I currently have it hardcoded so
>>> > > > that
>>> > > > we wait 50x the total latency before entering a
On 09/23/2016 05:42 PM, Christoph Hellwig wrote:
Jens,
can we at least get patches 1 and 2 in while pondering the fate
of the right interface for patch 3?
Yes definitely, I have no beef with the first two patches. I'll add them
for 4.9.
--
Jens Axboe
Jens,
can we at least get patches 1 and 2 in while pondering the fate
of the right interface for patch 3?
gt;> > > On 09/16/2016 12:16 PM, Andy Lutomirski wrote:
>> > > >
>> > > >
>> > > > Hi all-
>> > > >
>> > > > Here's v4 of the APST patch set. The biggest bikesheddable
>> > > > thing (I
>> >
On 09/22/2016 04:16 PM, Keith Busch wrote:
On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote:
...and some SSDs don't even support this feature yet, so the number of
different NVMe devices available to test initially will most likely be
small (like the Fultondales I have, all I could ch
On Thu, Sep 22, 2016 at 02:33:36PM -0700, J Freyensee wrote:
> ...and some SSDs don't even support this feature yet, so the number of
> different NVMe devices available to test initially will most likely be
> small (like the Fultondales I have, all I could check is to see if the
> code broke anythi
> > >
> > > > Hi all-
> > > >
> > > > Here's v4 of the APST patch set. The biggest bikesheddable
> > > > thing (I
> > > > think) is the scaling factor. I currently have it hardcoded so
> > > > that
> >
that
we wait 50x the total latency before entering a power saving state.
On my Samsung 950, this means we enter state 3 (70mW, 0.5ms entry
latency, 5ms exit latency) after 275ms and state 4 (5mW, 2ms entry
latency, 22ms exit latency) after 1200ms. I have the default max
latency set to 25ms.
FWI
so that
>> we wait 50x the total latency before entering a power saving state.
>> On my Samsung 950, this means we enter state 3 (70mW, 0.5ms entry
>> latency, 5ms exit latency) after 275ms and state 4 (5mW, 2ms entry
>> latency, 22ms exit latency) after 1200ms. I have the
1 - 100 of 319 matches
Mail list logo
