s Brezillon
> ; linux-...@lists.infradead.org;
> nagasures...@gmail.com;
> Michal Simek ; computersforpe...@gmail.com;
> dw...@infradead.org;
> marek.va...@gmail.com
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan NAND
> Flash Controller
>
Hi Naga,
Naga Sureshkumar Relli wrote on Tue,
18 Jun 2019 22:44:24 -0600:
> On Mon, Jan 28, 2019 at 10:27:39AM +0100, Miquel Raynal wrote:
> Hi Miquel,
>
> > Hi Naga,
> >
> > Naga Sureshkumar Relli wrote on Mon, 28 Jan 2019
> > 06:04:53 +:
> >
> > > Hi Boris & Miquel,
> > >
> > > Coul
On Mon, Jan 28, 2019 at 10:27:39AM +0100, Miquel Raynal wrote:
Hi Miquel,
> Hi Naga,
>
> Naga Sureshkumar Relli wrote on Mon, 28 Jan 2019
> 06:04:53 +:
>
> > Hi Boris & Miquel,
> >
> > Could you please provide your thoughts on this driver to support HW-ECC?
> > As I said previously, there
ernel@vger.kernel.org; Boris Brezillon
> ;
> linux-...@lists.infradead.org; nagasures...@gmail.com; Michal Simek
> ; computersforpe...@gmail.com; dw...@infradead.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
&g
Hi Naga,
Naga Sureshkumar Relli wrote on Mon, 28 Jan 2019
06:04:53 +:
> Hi Boris & Miquel,
>
> Could you please provide your thoughts on this driver to support HW-ECC?
> As I said previously, there is no way to detect errors beyond N bit.
> I am ok to update the driver based on your inputs.
ger.kernel.org; Boris Brezillon
> ;
> linux-...@lists.infradead.org; nagasures...@gmail.com; Michal Simek
> ; computersforpe...@gmail.com; dw...@infradead.org
> Subject: RE: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> Hi Miq
.@gmail.com;
> linux-...@lists.infradead.org;
> nagasures...@gmail.com; Michal Simek ;
> computersforpe...@gmail.com; dw...@infradead.org;
> martin.l...@keep-it-simple.com
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Contro
i
> > Cc: Boris Brezillon ; r...@kernel.org;
> > rich...@nod.at; linux-
> > ker...@vger.kernel.org; marek.va...@gmail.com;
> > linux-...@lists.infradead.org;
> > nagasures...@gmail.com; Michal Simek ;
> > computersforpe...@gmail.com; dw...@infradead.org
> &
a...@gmail.com; linux-...@lists.infradead.org;
> nagasures...@gmail.com; Michal Simek ;
> computersforpe...@gmail.com; dw...@infradead.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> Hi Naga,
>
> [...]
Hi Naga,
[...]
> Inserted biterror @ 48/7
> Successfully corrected 25 bit errors per subpage
> Inserted biterror @ 50/7
> ECC failure, invalid data despite read success
> root@xilinx-zc1751-dc2-2018_1:~#
>
> But even in this case also, driver is saying ECC failure but read success.
> That means
a...@gmail.com; linux-...@lists.infradead.org;
> nagasures...@gmail.com; Michal Simek ;
> computersforpe...@gmail.com; dw...@infradead.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> Hi Naga,
>
> Naga Sure
> > > rich...@nod.at; linux- ker...@vger.kernel.org;
> > > > marek.va...@gmail.com; linux-...@lists.infradead.org;
> > > > nagasures...@gmail.com; Michal Simek ;
> > > > computersforpe...@gmail.com; dw...@infradead.org
> > > > Subject: Re:
a...@gmail.com; linux-...@lists.infradead.org;
> nagasures...@gmail.com; Michal Simek ;
> computersforpe...@gmail.com; dw...@infradead.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> Hi Naga,
>
> Naga Sure
i
> > Cc: Boris Brezillon ; r...@kernel.org;
> > rich...@nod.at; linux-
> > ker...@vger.kernel.org; marek.va...@gmail.com;
> > linux-...@lists.infradead.org;
> > nagasures...@gmail.com; Michal Simek ;
> > computersforpe...@gmail.com; dw...@infradead.org
> >
a...@gmail.com; linux-...@lists.infradead.org;
> nagasures...@gmail.com; Michal Simek ;
> computersforpe...@gmail.com; dw...@infradead.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> Hi Naga,
>
> Naga Sure
Hi Naga,
Naga Sureshkumar Relli wrote on Wed, 12 Dec 2018
05:27:03 +:
> Hi Boris & Miquel,
>
> An update to my comments on thread https://lkml.org/lkml/2018/11/15/656.
> In this I said, will take a default error count value as 16 and during page
> read, will check the error count
> Registe
mek
> ; computersforpe...@gmail.com; dw...@infradead.org
> Subject: RE: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> Hi Boris & Miquel,
>
> > -Original Message-
> > From: Miquel Raynal [mailto:miquel.ra
ek.va...@gmail.com; Michal Simek
> ; nagasures...@gmail.com; linux-...@lists.infradead.org;
> linux-
> ker...@vger.kernel.org; r...@kernel.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> On Fri, 9 Nov 20
marek.va...@gmail.com;
> linux-
> m...@lists.infradead.org; linux-kernel@vger.kernel.org;
> nagasures...@gmail.com;
> r...@kernel.org; Michal Simek
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan
> NAND Flash Controller
>
> Hi Naga,
>
On Fri, 9 Nov 2018 10:30:41 +0530
Naga Sureshkumar Relli wrote:
> +static int anfc_setup_data_interface(struct nand_chip *chip, int csline,
> + const struct nand_data_interface *conf)
> +{
> + struct anfc_nand_controller *nfc = to_anfc(chip->controller);
> +
Hi Naga,
Boris Brezillon wrote on Tue, 20 Nov 2018
12:02:44 +0100:
> On Tue, 20 Nov 2018 07:02:08 +
> Naga Sureshkumar Relli wrote:
>
>
> > >
> > > Can you please run nandbiterrs (availaible in mtd-utils). I fear your
> > > device won't pass the test.
> > Yes, nandbiterror test is pa
On Tue, 20 Nov 2018 07:02:08 +
Naga Sureshkumar Relli wrote:
> >
> > Can you please run nandbiterrs (availaible in mtd-utils). I fear your
> > device won't pass the test.
> Yes, nandbiterror test is passing till 24bit, after that it is failing.
Can you paste the output of nandbiterrs ple
ek.va...@gmail.com;
> linux-...@lists.infradead.org; linux-
> ker...@vger.kernel.org; nagasures...@gmail.com; r...@kernel.org; Michal Simek
>
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan NAND
> Flash Controller
>
> On Mon, 19 Nov 20
Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org;
> > computersforpe...@gmail.com; marek.va...@gmail.com;
> > linux-...@lists.infradead.org; linux-
> > ker...@vger.kernel.org; nagasures...@gmail.com; r...@kernel.org; Michal
> > Simek
> >
> >
ek.va...@gmail.com;
> linux-...@lists.infradead.org; linux-
> ker...@vger.kernel.org; nagasures...@gmail.com; r...@kernel.org; Michal Simek
>
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan NAND
> Flash Controller
>
> On Thu, 15 Nov 20
On Thu, 15 Nov 2018 09:34:16 +
Naga Sureshkumar Relli wrote:
> Hi Boris & Miquel,
>
> I am updating the driver by addressing your comments, and I have one concern,
> especially in anfc_read_page_hwecc(),
> there I am checking for erased pages bit flips.
> Since Arasan NAND controller does
Hi Naga,
Naga Sureshkumar Relli wrote on Thu, 15 Nov 2018
09:34:16 +:
> Hi Boris & Miquel,
>
> I am updating the driver by addressing your comments, and I have one concern,
> especially in anfc_read_page_hwecc(),
> there I am checking for erased pages bit flips.
> Since Arasan NAND contr
Hi Naga,
Thank you for the patch! Perhaps something to improve:
url:
https://github.com/0day-ci/linux/commits/Naga-Sureshkumar-Relli/dt-bindings-mtd-arasan-Add-device-tree-binding-documentation/20181110-034106
base: git://git.infradead.org/linux-mtd.git nand/next
smatch warnings:
drivers/m
Hi Boris & Miquel,
I am updating the driver by addressing your comments, and I have one concern,
especially in anfc_read_page_hwecc(),
there I am checking for erased pages bit flips.
Since Arasan NAND controller doesn't have multibit error detection beyond
24-bit( it can correct up to 24 bit),
tersforpe...@gmail.com;
> marek.va...@gmail.com; Michal Simek ;
> nagasures...@gmail.com;
> linux-...@lists.infradead.org; linux-kernel@vger.kernel.org; r...@kernel.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan NAND
> Flash Controller
Hi Naga,
Just a few review comments for the v12 version.
On Fri, Nov 9, 2018 at 6:00 AM Naga Sureshkumar Relli
wrote:
> +#define PKT_OFST 0x00
> +#define PKT_CNT_SHIFT 12
> +
> +#define MEM_ADDR1_OFST 0x04
> +#define MEM_ADDR2_OFST 0x08
For the sake of rea
On Mon, 12 Nov 2018 11:55:36 +0100
Martin Lund wrote:
> Hi Naga,
>
> Just a few review comments for the v12 version.
>
> On Fri, Nov 9, 2018 at 6:00 AM Naga Sureshkumar Relli
> wrote:
> > +#define PKT_OFST 0x00
> > +#define PKT_CNT_SHIFT 12
> > +
> > +#define MEM_ADDR1_O
Hi Naga,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mtd/nand/next]
[also build test WARNING on v4.20-rc1 next-20181109]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/
ek.va...@gmail.com; Michal Simek
> ; linux-...@lists.infradead.org;
> linux-kernel@vger.kernel.org;
> nagasures...@gmail.com; r...@kernel.org
> Subject: Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for
> Arasan NAND
> Flash Controller
>
> Hi Naga,
>
>
Hi Naga,
Just a preliminary review. I still think we have problems with how you
execute NAND operations. You seem to assume that read/write operation
are always page write/read operation with a size aligned on a page
size. This is wrong, either the controller is able to execute the exact
operation
35 matches
Mail list logo
