On Fri, Apr 04, 2014 at 05:12:10PM -0700, Arun Shamanna Lakshmi wrote:
> 1. Modify soc_enum struct to handle pointers for reg and mask
> 2. Add dapm get and put APIs for multi register one hot encoded mux
> 3. Update snd_soc_dapm_update struct to support multiple reg update
> If you've got
On Fri, Apr 04, 2014 at 05:12:10PM -0700, Arun Shamanna Lakshmi wrote:
> 1. Modify soc_enum struct to handle pointers for reg and mask
> 2. Add dapm get and put APIs for multi register one hot encoded mux
> 3. Update snd_soc_dapm_update struct to support multiple reg update
If you've got several
On Fri, Apr 04, 2014 at 05:12:10PM -0700, Arun Shamanna Lakshmi wrote:
1. Modify soc_enum struct to handle pointers for reg and mask
2. Add dapm get and put APIs for multi register one hot encoded mux
3. Update snd_soc_dapm_update struct to support multiple reg update
If you've got several
On Fri, Apr 04, 2014 at 05:12:10PM -0700, Arun Shamanna Lakshmi wrote:
1. Modify soc_enum struct to handle pointers for reg and mask
2. Add dapm get and put APIs for multi register one hot encoded mux
3. Update snd_soc_dapm_update struct to support multiple reg update
If you've got several
At Mon, 07 Apr 2014 14:54:11 +0200,
Lars-Peter Clausen wrote:
>
> On 04/05/2014 02:12 AM, Arun Shamanna Lakshmi wrote:
> > 1. Modify soc_enum struct to handle pointers for reg and mask
> > 2. Add dapm get and put APIs for multi register one hot encoded mux
> > 3. Update snd_soc_dapm_update struct
On 04/05/2014 02:12 AM, Arun Shamanna Lakshmi wrote:
1. Modify soc_enum struct to handle pointers for reg and mask
2. Add dapm get and put APIs for multi register one hot encoded mux
3. Update snd_soc_dapm_update struct to support multiple reg update
Signed-off-by: Arun S L
Signed-off-by:
On 04/05/2014 02:12 AM, Arun Shamanna Lakshmi wrote:
1. Modify soc_enum struct to handle pointers for reg and mask
2. Add dapm get and put APIs for multi register one hot encoded mux
3. Update snd_soc_dapm_update struct to support multiple reg update
Signed-off-by: Arun S L ar...@nvidia.com
At Mon, 07 Apr 2014 14:54:11 +0200,
Lars-Peter Clausen wrote:
On 04/05/2014 02:12 AM, Arun Shamanna Lakshmi wrote:
1. Modify soc_enum struct to handle pointers for reg and mask
2. Add dapm get and put APIs for multi register one hot encoded mux
3. Update snd_soc_dapm_update struct to
; alsa-
de...@alsa-project.org; linux-kernel@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: dapm: Add support for multi register mux
On 04/03/2014 10:11 PM, Arun Shamanna Lakshmi wrote:
[...]
Here as well, default for bit_pos should be 0.
This means when 'None' of the options are selected
ect.org; linux-kernel@vger.kernel.org; Songhee Baek
> Subject: Re: [PATCH] ASoC: dapm: Add support for multi register mux
>
> On 04/03/2014 10:11 PM, Arun Shamanna Lakshmi wrote:
> [...]
> >> Here as well, default for bit_pos should be 0.
> >
> > This mea
On 04/03/2014 10:11 PM, Arun Shamanna Lakshmi wrote:
[...]
Here as well, default for bit_pos should be 0.
This means when 'None' of the options are selected, by default, it
enumerates to 0. Since we are using __ffs, BIT(0) of Register-0 also
enumerates to 0. That's the reason why I used just
On 04/03/2014 10:11 PM, Arun Shamanna Lakshmi wrote:
[...]
Here as well, default for bit_pos should be 0.
This means when 'None' of the options are selected, by default, it
enumerates to 0. Since we are using __ffs, BIT(0) of Register-0 also
enumerates to 0. That's the reason why I used just
@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: dapm: Add support for multi register mux
On 04/03/2014 10:11 PM, Arun Shamanna Lakshmi wrote:
[...]
Here as well, default for bit_pos should be 0.
This means when 'None' of the options are selected, by default, it
enumerates to 0. Since
; alsa-
de...@alsa-project.org; linux-kernel@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: dapm: Add support for multi register mux
On 04/03/2014 10:11 PM, Arun Shamanna Lakshmi wrote:
[...]
Here as well, default for bit_pos should be 0.
This means when 'None' of the options are selected
oject.org;
> linux-kernel@vger.kernel.org; Songhee Baek
> Subject: Re: [PATCH] ASoC: dapm: Add support for multi register mux
>
> On 04/03/2014 05:11 AM, Arun Shamanna Lakshmi wrote:
>
> This looks essentially good to me. A few minor issues, once those are
> fixed things should
On Thu, Apr 03, 2014 at 05:06:28PM +0200, Takashi Iwai wrote:
> Lars-Peter Clausen wrote:
> > It would be nice, but it also requires some slight restructuring. The issue
> > we have right now is that there is strictly speaking a bit of a layering
> > violation. The DAPM widgets should not need
At Thu, 03 Apr 2014 15:31:58 +0200,
Lars-Peter Clausen wrote:
>
> On 04/03/2014 11:53 AM, Mark Brown wrote:
> > On Thu, Apr 03, 2014 at 11:47:15AM +0200, Takashi Iwai wrote:
> >
> >> I'm a bit late in the game, but I feel a bit uneasy through looking
> >> at the whole changes. My primary
On 04/03/2014 11:53 AM, Mark Brown wrote:
On Thu, Apr 03, 2014 at 11:47:15AM +0200, Takashi Iwai wrote:
I'm a bit late in the game, but I feel a bit uneasy through looking
at the whole changes. My primary question is, whether do we really
need to share the same struct soc_enum for the onehot
On Thu, Apr 03, 2014 at 11:47:15AM +0200, Takashi Iwai wrote:
> I'm a bit late in the game, but I feel a bit uneasy through looking
> at the whole changes. My primary question is, whether do we really
> need to share the same struct soc_enum for the onehot type? What
> makes hard to use a
At Wed, 2 Apr 2014 20:11:50 -0700,
Arun Shamanna Lakshmi wrote:
>
> - Modify soc_enum struct to handle pointers for reg and mask
> - Add dapm get and put APIs for multi register mux with one hot encoding
> - Update snd_soc_dapm_update struct to support multiple reg update
>
> Signed-off-by: Arun
On Thu, Apr 03, 2014 at 10:27:17AM +0200, Lars-Peter Clausen wrote:
> On 04/03/2014 05:11 AM, Arun Shamanna Lakshmi wrote:
> >+enum snd_soc_enum_type {
> >+SND_SOC_ENUM_NONE = 0,
> I'm not sure if NONE is the right term. Maybe BINARY is better.
Yes, it's definitely not none.
signature.asc
On 04/03/2014 05:11 AM, Arun Shamanna Lakshmi wrote:
This looks essentially good to me. A few minor issues, once those are fixed
things should be good to go.
[...]
struct snd_soc_dapm_update {
struct snd_kcontrol *kcontrol;
- int reg;
- int mask;
- int val;
+
On 04/03/2014 11:53 AM, Mark Brown wrote:
On Thu, Apr 03, 2014 at 11:47:15AM +0200, Takashi Iwai wrote:
I'm a bit late in the game, but I feel a bit uneasy through looking
at the whole changes. My primary question is, whether do we really
need to share the same struct soc_enum for the onehot
At Thu, 03 Apr 2014 15:31:58 +0200,
Lars-Peter Clausen wrote:
On 04/03/2014 11:53 AM, Mark Brown wrote:
On Thu, Apr 03, 2014 at 11:47:15AM +0200, Takashi Iwai wrote:
I'm a bit late in the game, but I feel a bit uneasy through looking
at the whole changes. My primary question is,
On Thu, Apr 03, 2014 at 05:06:28PM +0200, Takashi Iwai wrote:
Lars-Peter Clausen wrote:
It would be nice, but it also requires some slight restructuring. The issue
we have right now is that there is strictly speaking a bit of a layering
violation. The DAPM widgets should not need to
@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: dapm: Add support for multi register mux
On 04/03/2014 05:11 AM, Arun Shamanna Lakshmi wrote:
This looks essentially good to me. A few minor issues, once those are
fixed things should be good to go.
[...]
@@ -2984,6 +3002,112 @@ int
On 04/03/2014 05:11 AM, Arun Shamanna Lakshmi wrote:
This looks essentially good to me. A few minor issues, once those are fixed
things should be good to go.
[...]
struct snd_soc_dapm_update {
struct snd_kcontrol *kcontrol;
- int reg;
- int mask;
- int val;
+
On Thu, Apr 03, 2014 at 10:27:17AM +0200, Lars-Peter Clausen wrote:
On 04/03/2014 05:11 AM, Arun Shamanna Lakshmi wrote:
+enum snd_soc_enum_type {
+SND_SOC_ENUM_NONE = 0,
I'm not sure if NONE is the right term. Maybe BINARY is better.
Yes, it's definitely not none.
signature.asc
At Wed, 2 Apr 2014 20:11:50 -0700,
Arun Shamanna Lakshmi wrote:
- Modify soc_enum struct to handle pointers for reg and mask
- Add dapm get and put APIs for multi register mux with one hot encoding
- Update snd_soc_dapm_update struct to support multiple reg update
Signed-off-by: Arun
On Thu, Apr 03, 2014 at 11:47:15AM +0200, Takashi Iwai wrote:
I'm a bit late in the game, but I feel a bit uneasy through looking
at the whole changes. My primary question is, whether do we really
need to share the same struct soc_enum for the onehot type? What
makes hard to use a struct
...@suse.de; alsa-
de...@alsa-project.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/02/2014 08:56 AM, Songhee Baek wrote:
-Original Message-
From: Lars-Peter Clausen [mailto:l...@metafoo.de]
Sent: Tuesday, April 01, 2014 11:47 PM
alsa-
> de...@alsa-project.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
>
> On 04/02/2014 08:56 AM, Songhee Baek wrote:
> >
> >
> >> -Original Message-
> >> From: Lars-Peter Clausen [mailto:
alsa-
> de...@alsa-project.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
>
> On 04/02/2014 08:56 AM, Songhee Baek wrote:
> >
> >
> >> -Original Message-
> >> From: Lars-Peter Clausen [mailto:
...@suse.de; alsa-
de...@alsa-project.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/02/2014 08:17 AM, Songhee Baek wrote:
-Original Message-
From: Lars-Peter Clausen [mailto:l...@metafoo.de]
Sent: Tuesday, April 01, 2014 11:00 PM
alsa-
> de...@alsa-project.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
>
> On 04/02/2014 08:17 AM, Songhee Baek wrote:
> >> -Original Message-
> >> From: Lars-Peter Clausen [mailto:l...@metafoo.de]
> >
...@alsa-project.org; linux-
ker...@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/01/2014 08:26 PM, Arun Shamanna Lakshmi wrote:
[...]
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index
c8a780d..4d2b35c 100644
--- a/sound/soc/soc
.org; linux-
> ker...@vger.kernel.org; Songhee Baek
> Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
>
> On 04/01/2014 08:26 PM, Arun Shamanna Lakshmi wrote:
> [...]
> >>> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index
> >>>
On 04/01/2014 08:26 PM, Arun Shamanna Lakshmi wrote:
[...]
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index
c8a780d..4d2b35c 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -514,9 +514,9 @@ static int dapm_connect_mux(struct
snd_soc_dapm_context *dapm,
On 04/01/2014 08:26 PM, Arun Shamanna Lakshmi wrote:
[...]
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index
c8a780d..4d2b35c 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -514,9 +514,9 @@ static int dapm_connect_mux(struct
snd_soc_dapm_context *dapm,
...@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/01/2014 08:26 PM, Arun Shamanna Lakshmi wrote:
[...]
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index
c8a780d..4d2b35c 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc
...@alsa-project.org; linux-
ker...@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/01/2014 08:26 PM, Arun Shamanna Lakshmi wrote:
[...]
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index
c8a780d..4d2b35c 100644
--- a/sound/soc/soc
; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/02/2014 08:17 AM, Songhee Baek wrote:
-Original Message-
From: Lars-Peter Clausen [mailto:l...@metafoo.de]
Sent: Tuesday, April 01, 2014 11:00 PM
To: Arun Shamanna Lakshmi
Cc
...@suse.de; alsa-
de...@alsa-project.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/02/2014 08:17 AM, Songhee Baek wrote:
-Original Message-
From: Lars-Peter Clausen [mailto:l...@metafoo.de]
Sent: Tuesday, April 01, 2014 11:00 PM
; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/02/2014 08:56 AM, Songhee Baek wrote:
-Original Message-
From: Lars-Peter Clausen [mailto:l...@metafoo.de]
Sent: Tuesday, April 01, 2014 11:47 PM
To: Songhee Baek
Cc: Arun
; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/02/2014 08:56 AM, Songhee Baek wrote:
-Original Message-
From: Lars-Peter Clausen [mailto:l...@metafoo.de]
Sent: Tuesday, April 01, 2014 11:47 PM
To: Songhee Baek
Cc: Arun
...@suse.de; alsa-
de...@alsa-project.org; linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/02/2014 08:56 AM, Songhee Baek wrote:
-Original Message-
From: Lars-Peter Clausen [mailto:l...@metafoo.de]
Sent: Tuesday, April 01, 2014 11:47 PM
rg;
> linux-kernel@vger.kernel.org; Songhee Baek
> Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
>
> On 04/01/2014 08:21 AM, Arun Shamanna Lakshmi wrote:
> > Modify soc_enum struct to handle pointers for reg and mask. Add
dapm
> > get and put APIs fo
On 04/01/2014 08:21 AM, Arun Shamanna Lakshmi wrote:
Modify soc_enum struct to handle pointers for reg and mask. Add
dapm get and put APIs for multi register mux with one hot encoding.
Signed-off-by: Arun Shamanna Lakshmi
Signed-off-by: Songhee Baek
Looks in my opinion much better than the
On 04/01/2014 08:21 AM, Arun Shamanna Lakshmi wrote:
Modify soc_enum struct to handle pointers for reg and mask. Add
dapm get and put APIs for multi register mux with one hot encoding.
Signed-off-by: Arun Shamanna Lakshmi ar...@nvidia.com
Signed-off-by: Songhee Baek sb...@nvidia.com
Looks in
@vger.kernel.org; Songhee Baek
Subject: Re: [PATCH] ASoC: DAPM: Add support for multi register mux
On 04/01/2014 08:21 AM, Arun Shamanna Lakshmi wrote:
Modify soc_enum struct to handle pointers for reg and mask. Add
dapm
get and put APIs for multi register mux with one hot encoding.
Signed-off
50 matches
Mail list logo
