RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
ernel.org >Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp >reset > >On Mon, Nov 26, 2018 at 06:46:05PM +, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- > >This really needs a changelog to explain what is going on here, and we need >

RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
ernel.org >Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp >reset > >On Mon, Nov 26, 2018 at 06:46:05PM +, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- > >This really needs a changelog to explain what is going on here, and we need >

RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
imoto >; Benson Leung >; alsa-de...@alsa-project.org; LKML ker...@vger.kernel.org> >Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp >reset > >EXTERNAL EMAIL > > > >Hi Ryan! > >Just some questions inline - in general I like the reset fu

RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
imoto >; Benson Leung >; alsa-de...@alsa-project.org; LKML ker...@vger.kernel.org> >Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp >reset > >EXTERNAL EMAIL > > > >Hi Ryan! > >Just some questions inline - in general I like the reset fu

RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
>Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp >reset > >EXTERNAL EMAIL > > > >I just realized I had one more question... > >On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler >wrote: >> >> Hi Ryan! >> >> Just some

RE: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
>Subject: Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp >reset > >EXTERNAL EMAIL > > > >I just realized I had one more question... > >On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler >wrote: >> >> Hi Ryan! >> >> Just some

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Mark Brown
On Mon, Nov 26, 2018 at 06:46:05PM +, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- This really needs a changelog to explain what is going on here, and we need some more documentation in the code. It is *extremely* unusual to have to poll for reset like this, and if the failure mode is

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Mark Brown
On Mon, Nov 26, 2018 at 06:46:05PM +, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- This really needs a changelog to explain what is going on here, and we need some more documentation in the code. It is *extremely* unusual to have to poll for reset like this, and if the failure mode is

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
I just realized I had one more question... On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler wrote: > > Hi Ryan! > > Just some questions inline - in general I like the reset function. > > On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee > wrote: > > > > Signed-off-by: Ryan Lee > > --- > > Changes :

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
I just realized I had one more question... On Mon, Nov 26, 2018 at 6:24 PM Grant Grundler wrote: > > Hi Ryan! > > Just some questions inline - in general I like the reset function. > > On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee > wrote: > > > > Signed-off-by: Ryan Lee > > --- > > Changes :

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
Hi Ryan! Just some questions inline - in general I like the reset function. On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee wrote: > > Signed-off-by: Ryan Lee > --- > Changes : Created max98373_reset function to minimize code duplication. >Changed regmap_write to regmap_update_bits.

Re: [PATCH] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-26 Thread Grant Grundler
Hi Ryan! Just some questions inline - in general I like the reset function. On Mon, Nov 26, 2018 at 10:46 AM Ryan Lee wrote: > > Signed-off-by: Ryan Lee > --- > Changes : Created max98373_reset function to minimize code duplication. >Changed regmap_write to regmap_update_bits.