RE: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-21 Thread Srikanth Thokala
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, May 21, 2014 1:23 PM > To: Srikanth Thokala > Cc: Bjorn Helgaas; will.dea...@arm.com; Michal Simek; linux- > ker...@vger.kernel.org; linux-...@vger.kernel.org > Subject: Re:

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-21 Thread Arnd Bergmann
On Tuesday 20 May 2014 20:01:01 Srikanth Thokala wrote: > On Mon, May 19, 2014 at 10:33 PM, Arnd Bergmann wrote: > > On Sunday 18 May 2014 19:38:45 Srikanth Thokala wrote: > >> + > >> + if (cfg->ops->is_valid_cfg_access) { > >> + if (!cfg->ops->is_valid_cfg_access(bus, devfn)) { >

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-21 Thread Arnd Bergmann
On Tuesday 20 May 2014 20:01:01 Srikanth Thokala wrote: On Mon, May 19, 2014 at 10:33 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 18 May 2014 19:38:45 Srikanth Thokala wrote: + + if (cfg-ops-is_valid_cfg_access) { + if (!cfg-ops-is_valid_cfg_access(bus, devfn)) { +

RE: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-21 Thread Srikanth Thokala
-Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Wednesday, May 21, 2014 1:23 PM To: Srikanth Thokala Cc: Bjorn Helgaas; will.dea...@arm.com; Michal Simek; linux- ker...@vger.kernel.org; linux-...@vger.kernel.org Subject: Re: [PATCH] PCI: Generic Configuration

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-20 Thread Srikanth Thokala
Hi Arnd, On Mon, May 19, 2014 at 10:33 PM, Arnd Bergmann wrote: > On Sunday 18 May 2014 19:38:45 Srikanth Thokala wrote: >> + >> + if (cfg->ops->is_valid_cfg_access) { >> + if (!cfg->ops->is_valid_cfg_access(bus, devfn)) { >> + *val = PCI_CFG_INVALID_DEVFN; >>

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-20 Thread Srikanth Thokala
Hi Arnd, On Mon, May 19, 2014 at 10:33 PM, Arnd Bergmann a...@arndb.de wrote: On Sunday 18 May 2014 19:38:45 Srikanth Thokala wrote: + + if (cfg-ops-is_valid_cfg_access) { + if (!cfg-ops-is_valid_cfg_access(bus, devfn)) { + *val = PCI_CFG_INVALID_DEVFN; +

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-19 Thread Arnd Bergmann
On Sunday 18 May 2014 19:38:45 Srikanth Thokala wrote: > + > + if (cfg->ops->is_valid_cfg_access) { > + if (!cfg->ops->is_valid_cfg_access(bus, devfn)) { > + *val = PCI_CFG_INVALID_DEVFN; > + return PCIBIOS_DEVICE_NOT_FOUND; > + }

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-19 Thread Arnd Bergmann
On Monday 19 May 2014 17:32:23 Will Deacon wrote: > On Sun, May 18, 2014 at 03:08:45PM +0100, Srikanth Thokala wrote: > > This patch adds support for a generic CAM and ECAM configuration > > space accesses. > > Looks good to me, thanks Srikanth! > > Arnd: is this the sort of thing you were

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-19 Thread Will Deacon
On Sun, May 18, 2014 at 03:08:45PM +0100, Srikanth Thokala wrote: > This patch adds support for a generic CAM and ECAM configuration > space accesses. Looks good to me, thanks Srikanth! Arnd: is this the sort of thing you were expecting? The ->is_valid_cfg_access callback is a bit horrible, but

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-19 Thread Will Deacon
On Sun, May 18, 2014 at 03:08:45PM +0100, Srikanth Thokala wrote: This patch adds support for a generic CAM and ECAM configuration space accesses. Looks good to me, thanks Srikanth! Arnd: is this the sort of thing you were expecting? The -is_valid_cfg_access callback is a bit horrible, but I

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-19 Thread Arnd Bergmann
On Monday 19 May 2014 17:32:23 Will Deacon wrote: On Sun, May 18, 2014 at 03:08:45PM +0100, Srikanth Thokala wrote: This patch adds support for a generic CAM and ECAM configuration space accesses. Looks good to me, thanks Srikanth! Arnd: is this the sort of thing you were expecting? The

Re: [PATCH] PCI: Generic Configuration Access Mechanism support

2014-05-19 Thread Arnd Bergmann
On Sunday 18 May 2014 19:38:45 Srikanth Thokala wrote: + + if (cfg-ops-is_valid_cfg_access) { + if (!cfg-ops-is_valid_cfg_access(bus, devfn)) { + *val = PCI_CFG_INVALID_DEVFN; + return PCIBIOS_DEVICE_NOT_FOUND; + } + }