Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread David E. Box
> > sasha.nef...@intel.com; platform-driver-...@vger.kernel.org; linux- > > ker...@vger.kernel.org; intel-wired-...@lists.osuosl.org > > Subject: Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on > > Tiger Lake > > platforms > > > > > > [EX

RE: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread Limonciello, Mario
rnel.org; intel-wired-...@lists.osuosl.org > Subject: Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake > platforms > > > [EXTERNAL EMAIL] > > On Mon, Mar 8, 2021 at 12:20 PM Limonciello, Mario > wrote: > > > > > > > > [EXTERNAL EMAIL] >

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread Rajneesh Bhardwaj
On Mon, Mar 8, 2021 at 12:20 PM Limonciello, Mario wrote: > > > > > [EXTERNAL EMAIL] > > > > Due to a HW limitation, the Latency Tolerance Reporting (LTR) value > > programmed in the Tiger Lake GBE controller is not large enough to allow > > the platform to enter Package C10, which in turn prevent

RE: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread Limonciello, Mario
> > [EXTERNAL EMAIL] > > Due to a HW limitation, the Latency Tolerance Reporting (LTR) value > programmed in the Tiger Lake GBE controller is not large enough to allow > the platform to enter Package C10, which in turn prevents the platform from > achieving its low power target during suspend-to-

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread David E. Box
Hi Rajneesh, On Mon, 2021-03-08 at 09:04 -0500, Rajneesh Bhardwaj wrote: > Hi David > > Overall, it looks like the right thing to do but i have a few > comments. See below. > > On Fri, Mar 5, 2021 at 2:07 PM David E. Box < > david.e@linux.intel.com> wrote: > > > > Due to a HW limitation, th

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread Rajneesh Bhardwaj
On Mon, Mar 8, 2021 at 9:04 AM Rajneesh Bhardwaj wrote: > > Hi David > > Overall, it looks like the right thing to do but i have a few > comments. See below. > > On Fri, Mar 5, 2021 at 2:07 PM David E. Box > wrote: > > > > Due to a HW limitation, the Latency Tolerance Reporting (LTR) value > > p

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-08 Thread Rajneesh Bhardwaj
Hi David Overall, it looks like the right thing to do but i have a few comments. See below. On Fri, Mar 5, 2021 at 2:07 PM David E. Box wrote: > > Due to a HW limitation, the Latency Tolerance Reporting (LTR) value > programmed in the Tiger Lake GBE controller is not large enough to allow > the

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-07 Thread Hans de Goede
Hi, On 3/7/21 9:39 AM, Neftin, Sasha wrote: > On 3/5/2021 21:06, David E. Box wrote: >> Due to a HW limitation, the Latency Tolerance Reporting (LTR) value >> programmed in the Tiger Lake GBE controller is not large enough to allow >> the platform to enter Package C10, which in turn prevents the p

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-07 Thread David E. Box
Hi Sasha, On Sun, 2021-03-07 at 10:39 +0200, Neftin, Sasha wrote: > On 3/5/2021 21:06, David E. Box wrote: > > Due to a HW limitation, the Latency Tolerance Reporting (LTR) value > > programmed in the Tiger Lake GBE controller is not large enough to > > allow > > the platform to enter Package C10,

Re: [PATCH] platform/x86: intel_pmc: Ignore GBE LTR on Tiger Lake platforms

2021-03-07 Thread Neftin, Sasha
On 3/5/2021 21:06, David E. Box wrote: Due to a HW limitation, the Latency Tolerance Reporting (LTR) value programmed in the Tiger Lake GBE controller is not large enough to allow the platform to enter Package C10, which in turn prevents the platform from achieving its low power target during sus