Re: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-30 Thread Kumar Gala
Tony, I'm going to assume that I only need the following lines: 0, /* EXT 3 */ - 0, /* EXT 4 */ - 0, /* EXT 5 */ - 0, /* EXT 6 */ - 0, /* EXT 7 */ + IRQ_SENSE_LEVEL, /* EXT 4 */ + IRQ_SENSE_LEVEL, /* EXT 5 */ + IRQ_SENSE_LEVEL, /* EXT 6 */ + IRQ_SENSE_LEVEL, /* EXT 7 */ P

Re: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-30 Thread Dan Malek
On Aug 29, 2005, at 11:02 PM, Li Tony-r64360 wrote: I think it is OK. The external interrupt can be edged. And it works well in my board. No, it can't. PCI interrupts must be level sensitive because multiple slots can share an interrupt. Thanks. -- Dan - To unsubscribe from this l

RE: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-30 Thread Li Tony-r64360
t; > Tony Li > > -Original Message- > From: Gala Kumar K.-galak > Sent: Tuesday, August 30, 2005 1:43 AM > To: Li Tony-r64360 > Cc: linuxppc-embedded; linux-kernel@vger.kernel.org; Gala Kumar > K.-galak; Chu hanjin-r52514 > Subject: Re: [PATCH] ppc32 :Added PCI su

Re: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-29 Thread Kumar Gala
: Gala Kumar K.-galak Sent: Tuesday, August 30, 2005 1:43 AM To: Li Tony-r64360 Cc: linuxppc-embedded; linux-kernel@vger.kernel.org; Gala Kumar K.-galak; Chu hanjin-r52514 Subject: Re: [PATCH] ppc32 :Added PCI support for MPC83xx I noticed that you aren't updating the senses arr

RE: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-29 Thread Li Tony-r64360
-r52514 Subject: Re: [PATCH] ppc32 :Added PCI support for MPC83xx I noticed that you aren't updating the senses array in mpc834x_sys_init_IRQ for the PCI interrupt lines, is this correct? Should they not be IRQ_SENSE_LEVEL? Also, I've done a bit of cosmetic cleanup to the patch, take

Re: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-29 Thread Kumar Gala
On Aug 29, 2005, at 1:07 PM, Dan Malek wrote: On Aug 29, 2005, at 1:42 PM, Kumar Gala wrote: diff --git a/arch/ppc/platforms/83xx/mpc834x_sys.c b/arch/ppc/platforms/83xx/mpc834x_sys.c --- a/arch/ppc/platforms/83xx/mpc834x_sys.c +++ b/arch/ppc/platforms/83xx/mpc834x_sys.c @@ -62,9 +62,29 @@

Re: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-29 Thread Dan Malek
On Aug 29, 2005, at 1:42 PM, Kumar Gala wrote: diff --git a/arch/ppc/platforms/83xx/mpc834x_sys.c b/arch/ppc/platforms/83xx/mpc834x_sys.c --- a/arch/ppc/platforms/83xx/mpc834x_sys.c +++ b/arch/ppc/platforms/83xx/mpc834x_sys.c @@ -62,9 +62,29 @@ extern unsigned long total_memory; /* in unsig

Re: [PATCH] ppc32 :Added PCI support for MPC83xx

2005-08-29 Thread Kumar Gala
I noticed that you aren't updating the senses array in mpc834x_sys_init_IRQ for the PCI interrupt lines, is this correct? Should they not be IRQ_SENSE_LEVEL? Also, I've done a bit of cosmetic cleanup to the patch, take a look and let me know if it works. Once we close on the IRQ sense issue I