Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

2020-06-29 Thread Martin K. Petersen
On Fri, 26 Jun 2020 13:51:33 +0300, Dan Carpenter wrote: > The "head" pointer can't be NULL because it points to an address in > the middle of a ufs_hba struct. Looking at this code, probably someone > would wonder if the intent was to check whether "hba" is NULL, but "hba" > isn't NULL and the c

RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

2020-06-27 Thread Alim Akhtar
Hi Dan, > -Original Message- > From: Dan Carpenter > On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote: > > Hi Dan > > > > > -Original Message- > > > The "head" pointer can't be NULL because it points to an address in the > > middle > > > of a ufs_hba struct. Looking at

Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

2020-06-27 Thread Dan Carpenter
On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote: > Hi Dan > > > -Original Message- > > The "head" pointer can't be NULL because it points to an address in the > middle > > of a ufs_hba struct. Looking at this code, probably someone would wonder > if > > the intent was to check

RE: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check

2020-06-27 Thread Alim Akhtar
Hi Dan > -Original Message- > The "head" pointer can't be NULL because it points to an address in the middle > of a ufs_hba struct. Looking at this code, probably someone would wonder if > the intent was to check whether "hba" is NULL, but "hba" > isn't NULL and the check can just be remo