Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-08-11 Thread mika.westerb...@linux.intel.com
On Thu, May 25, 2017 at 03:03:07PM +0300, mika.westerb...@linux.intel.com wrote: > On Thu, May 25, 2017 at 11:04:08AM +0300, mika.westerb...@linux.intel.com > wrote: > > On Thu, May 25, 2017 at 10:20:10AM +0300, mika.westerb...@linux.intel.com > > wrote: > > > On Wed, May 24, 2017 at 07:32:45PM +

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-25 Thread mika.westerb...@linux.intel.com
On Thu, May 25, 2017 at 11:04:08AM +0300, mika.westerb...@linux.intel.com wrote: > On Thu, May 25, 2017 at 10:20:10AM +0300, mika.westerb...@linux.intel.com > wrote: > > On Wed, May 24, 2017 at 07:32:45PM +, Jamet, Michael wrote: > > > I talked to our BIOS expert today. Here is his advice to d

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-25 Thread mika.westerb...@linux.intel.com
On Thu, May 25, 2017 at 10:20:10AM +0300, mika.westerb...@linux.intel.com wrote: > On Wed, May 24, 2017 at 07:32:45PM +, Jamet, Michael wrote: > > I talked to our BIOS expert today. Here is his advice to debugging further: > > > > It looks like something may have been wrong from system (BIOS,

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-25 Thread mika.westerb...@linux.intel.com
On Wed, May 24, 2017 at 07:32:45PM +, Jamet, Michael wrote: > I talked to our BIOS expert today. Here is his advice to debugging further: > > It looks like something may have been wrong from system (BIOS, FW, others...) > perspective. > On reboot need to enter EFI shell and check resources of

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-25 Thread Mika Westerberg
nuxfoundation.org; andreas.noe...@gmail.com; > > michael.ja...@intel.com; yehezkel.ber...@intel.com; lu...@wunner.de; > > amir.jer.l...@intel.com; l...@kernel.org; Dominguez, Jared > > ; andriy.shevche...@linux.intel.com; linux- > > ker...@vger.kernel.org > > Subject: Re

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-24 Thread Jamet, Michael
lu...@wunner.de; Levy, Amir (Jer) > ; l...@kernel.org; jared.doming...@dell.com; > andriy.shevche...@linux.intel.com; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware > upgrade > > > -Original Message- >

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-24 Thread Mario.Limonciello
m; lu...@wunner.de; > amir.jer.l...@intel.com; l...@kernel.org; Dominguez, Jared > ; andriy.shevche...@linux.intel.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware > upgrade > > On Tue, May 23, 2017 at 05:30:43PM

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-24 Thread Mika Westerberg
On Tue, May 23, 2017 at 05:30:43PM +, mario.limoncie...@dell.com wrote: > (Sorry my email client is not going to wrap these at 80 columns)o That's fine. It is more readable this way :) > [0.467319] pci :00:1c.0: [8086:9d10] type 01 class 0x060400 > [0.467389] pci :00:1c.0: PME

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-23 Thread Mario.Limonciello
m; lu...@wunner.de; > amir.jer.l...@intel.com; l...@kernel.org; Dominguez, Jared > ; andriy.shevche...@linux.intel.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware > upgrade > > On Mon, May 22, 2017 at 08:07:54PM +, mario.

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-23 Thread Andy Shevchenko
On Thu, 2017-05-18 at 17:38 +0300, Mika Westerberg wrote: > Hi all, > > This patch series adds support for Thunderbolt security levels, which > were > first introduced in Intel Falcon Ridge Thunderbolt controller, to > prevent > DMA attacks when PCIe is tunneled over Thunderbolt fabric. This is >

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-22 Thread Mario.Limonciello
r.de; Levy, Amir (Jer) > ; l...@kernel.org; Dominguez, Jared > ; andriy.shevche...@linux.intel.com; linux- > ker...@vger.kernel.org > Subject: RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware > upgrade > > > > > -Original Message- > >

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-22 Thread Mika Westerberg
On Mon, May 22, 2017 at 08:07:54PM +, mario.limoncie...@dell.com wrote: > I was 1 version behind, but I double checked with the latest version (1.1.15) > and the same behavior exists on Linux (still works properly on Win10). > > If you have some more details about what the FW guys changed, I c

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-22 Thread Bernat, Yehezkel
lu...@wunner.de; Levy, Amir (Jer) > ; l...@kernel.org; jared.doming...@dell.com; > andriy.shevche...@linux.intel.com; linux-kernel@vger.kernel.org > Subject: RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware > upgrade > > > -Original Message- >

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-22 Thread Mario.Limonciello
m; lu...@wunner.de; > amir.jer.l...@intel.com; l...@kernel.org; Dominguez, Jared > ; andriy.shevche...@linux.intel.com; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware > upgrade > > On Sat, May 20, 2017 at 11:24:12AM +0300, Mi

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-22 Thread Mika Westerberg
On Sat, May 20, 2017 at 11:24:12AM +0300, Mika Westerberg wrote: > On Fri, May 19, 2017 at 05:54:37PM +, mario.limoncie...@dell.com wrote: > > > > > > It happens occasionally when you reboot the machine when a device is > > > connected but seems to be dependent on the BIOS version. Since it is

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-21 Thread mika.westerb...@linux.intel.com
On Sat, May 20, 2017 at 09:15:17AM +, Levy, Amir (Jer) wrote: > > I created a udev rule that will automatically authorize the dock and cable. > > #dell cable > > ACTION=="add", SUBSYSTEM=="thunderbolt", ATTR{authorized}=="0", > > ATTR{vendor}=="0xd4", ATTR{device}=="0xb051", ATTR{authorized}="1

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-20 Thread Levy, Amir (Jer)
On Fri, May 19 2017, 07:35 PM, mario.limoncie...@dell.com wrote: > Here's my setup: > System: I'm using is an XPS 9350 (Has Alpine Ridge). It's got NVM 16.0. BIOS > 1.4.13 TBT Device: Dell TB16 (which has AR in the cable and in dock - both > NVM 16.0). > Is it BIOS assist or native enumeration?

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-20 Thread Mika Westerberg
On Fri, May 19, 2017 at 05:54:37PM +, mario.limoncie...@dell.com wrote: > > > > It happens occasionally when you reboot the machine when a device is > > connected but seems to be dependent on the BIOS version. Since it is the > > BIOS who is supposed to enumerated these devices, I suspect that

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-19 Thread Mika Westerberg
On Fri, May 19, 2017 at 08:19:48PM +0300, Mika Westerberg wrote: > These two I've seen before. > > > [7.428503] pcieport :02:02.0: PCI bridge to [bus 39] > > [7.428512] pcieport :02:02.0: bridge window [mem > > 0xd9f0-0xd9ff] > > [7.428519] pci_bus :39: [bus 39]

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-19 Thread Mario.Limonciello
> > It happens occasionally when you reboot the machine when a device is > connected but seems to be dependent on the BIOS version. Since it is the > BIOS who is supposed to enumerated these devices, I suspect that it is > either problem in BIOS or our PCI enumeration code does something wrong. >

Re: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-19 Thread Mika Westerberg
On Fri, May 19, 2017 at 04:35:01PM +, mario.limoncie...@dell.com wrote: > Mika, > > Thanks for submitting this series. > I've tested security level stuff a little bit, > but I'm running into what I think is some odd behavior. Thanks for testing. > Here's my setup: > System: I'm using is a

RE: [PATCH 00/24] Thunderbolt security levels and NVM firmware upgrade

2017-05-19 Thread Mario.Limonciello
> -Original Message- > From: Mika Westerberg [mailto:mika.westerb...@linux.intel.com] > Sent: Thursday, May 18, 2017 9:39 AM > To: Greg Kroah-Hartman > Cc: Andreas Noever ; Michael Jamet > ; Yehezkel Bernat ; Lukas > Wunner ; Amir Levy ; Andy > Lutomirski ; Limonciello, Mario ; > Dominguez