RE: [PATCH 00/83] staging: comedi: rtd520: initial cleanup

2012-07-11 Thread H Hartley Sweeten
On Wednesday, July 11, 2012 3:20 AM, Ian Abbott wrote: > On 2012-07-11 00:36, H Hartley Sweeten wrote: >> The 'devpriv' macro usage in this driver is holding up other cleanup >> of the comedi drivers. >> >> This patch series removes all the macros used to read/write the >> hardware registers. All

Re: [PATCH 00/83] staging: comedi: rtd520: initial cleanup

2012-07-11 Thread Ian Abbott
On 2012-07-11 11:20, Ian Abbott wrote: On 2012-07-11 00:36, H Hartley Sweeten wrote: My main concern with this series of patches is they make it harder to determine what the register accesses actually do, mainly due to the removal of useful comments. For example: - RtdPacerStart(dev);

Re: [PATCH 00/83] staging: comedi: rtd520: initial cleanup

2012-07-11 Thread Ian Abbott
On 2012-07-11 00:36, H Hartley Sweeten wrote: The 'devpriv' macro usage in this driver is holding up other cleanup of the comedi drivers. This patch series removes all the macros used to read/write the hardware registers. All of them are simple wrappers around standard {read,write}[rwl] calls

Re: [PATCH 00/83] staging: comedi: rtd520: initial cleanup

2012-07-11 Thread Ian Abbott
On 2012-07-11 00:36, H Hartley Sweeten wrote: The 'devpriv' macro usage in this driver is holding up other cleanup of the comedi drivers. This patch series removes all the macros used to read/write the hardware registers. All of them are simple wrappers around standard {read,write}[rwl] calls

Re: [PATCH 00/83] staging: comedi: rtd520: initial cleanup

2012-07-11 Thread Ian Abbott
On 2012-07-11 11:20, Ian Abbott wrote: On 2012-07-11 00:36, H Hartley Sweeten wrote: My main concern with this series of patches is they make it harder to determine what the register accesses actually do, mainly due to the removal of useful comments. For example: - RtdPacerStart(dev);

RE: [PATCH 00/83] staging: comedi: rtd520: initial cleanup

2012-07-11 Thread H Hartley Sweeten
On Wednesday, July 11, 2012 3:20 AM, Ian Abbott wrote: On 2012-07-11 00:36, H Hartley Sweeten wrote: The 'devpriv' macro usage in this driver is holding up other cleanup of the comedi drivers. This patch series removes all the macros used to read/write the hardware registers. All of them are