Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-03-06 Thread Linus Walleij
On Fri, Feb 28, 2014 at 1:38 AM, Gross, Mark wrote: > So if you have the luxury of being able to influence (file bugs against or > write) > the platform enumeration ABI then with ACPI you can have a named gpio today. > Note: there is an expectation that the _PRP feature to go into the next > ve

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-03-06 Thread Linus Walleij
On Wed, Feb 26, 2014 at 1:35 AM, Stephen Warren wrote: > On 02/25/2014 02:13 AM, Linus Walleij wrote: >> So it is basically there to satisfy the habit in some device >> tree bindings to name gpio arrays instead of just passing gpios = <...>; >> (The latter should be encouraged going forward.) > >

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-27 Thread mark gross
yland > >> Klein; linux-wireless; netdev; linux-kernel; Arnd Bergmann; Gross, Mark > >> Subject: Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names > >> > >> On Fri, Feb 21, 2014 at 6:35 AM, Stephen Warren > >> wrote: > >>> On 02/20/2014 06:55

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-27 Thread Stephen Warren
To: Stephen Warren; Alexandre Courbot; Grant Likely; >> devicet...@vger.kernel.org >> Cc: Chen-Yu Tsai; Heikki Krogerus; Johannes Berg; David S. Miller; Rhyland >> Klein; linux-wireless; netdev; linux-kernel; Arnd Bergmann; Gross, Mark >> Subject: Re: [PATCH 2/4] net: rfkill: g

RE: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-27 Thread Gross, Mark
en-Yu Tsai; Heikki Krogerus; Johannes Berg; David S. Miller; Rhyland > Klein; linux-wireless; netdev; linux-kernel; Arnd Bergmann; Gross, Mark > Subject: Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names > > On Fri, Feb 21, 2014 at 6:35 AM, Stephen Warren > wrote: > > On

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-25 Thread Stephen Warren
On 02/25/2014 02:13 AM, Linus Walleij wrote: > On Fri, Feb 21, 2014 at 6:35 AM, Stephen Warren wrote: >> On 02/20/2014 06:55 PM, Chen-Yu Tsai wrote: > >>> That's correct. However using con_id to pass this results in different >>> behavior across DT and ACPI. A better way is to export the labeling

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-25 Thread Linus Walleij
On Fri, Feb 21, 2014 at 6:35 AM, Stephen Warren wrote: > On 02/20/2014 06:55 PM, Chen-Yu Tsai wrote: >> That's correct. However using con_id to pass this results in different >> behavior across DT and ACPI. A better way is to export the labeling >> function so consumers can set meaningful labels

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-20 Thread Stephen Warren
On 02/20/2014 06:55 PM, Chen-Yu Tsai wrote: > Hi, > > On Fri, Feb 21, 2014 at 12:38 AM, Stephen Warren > wrote: >> On 02/20/2014 05:51 AM, Heikki Krogerus wrote: >>> There is no use for them in this driver. This will fix a >>> static checker warning.. >> >> Didn't you remove the use: >> >> -

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-20 Thread Chen-Yu Tsai
Hi, On Fri, Feb 21, 2014 at 12:38 AM, Stephen Warren wrote: > On 02/20/2014 05:51 AM, Heikki Krogerus wrote: >> There is no use for them in this driver. This will fix a >> static checker warning.. > > Didn't you remove the use: > > - gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_nam

Re: [PATCH 2/4] net: rfkill: gpio: remove gpio names

2014-02-20 Thread Stephen Warren
On 02/20/2014 05:51 AM, Heikki Krogerus wrote: > There is no use for them in this driver. This will fix a > static checker warning.. Didn't you remove the use: - gpio = devm_gpiod_get_index(&pdev->dev, rfkill->reset_name, 0); + gpio = devm_gpiod_get_index(&pdev->dev, NULL, 0); doesn'