Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

2020-07-24 Thread Robert Hancock
On 2020-07-23 12:03 p.m., Andy Shevchenko wrote: +/** + * xgpio_xlate - Translate gpio_spec to the GPIO number and flags + * @gc: Pointer to gpio_chip device structure. + * @gpiospec: gpio specifier as found in the device tree + * @flags: A flags pointer based on binding + * + * Return: + * irq

Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

2020-07-24 Thread Andy Shevchenko
On Fri, Jul 24, 2020 at 8:15 PM Srinivas Neeli wrote: ... > > > +#include > > > > Not sure I see a user of it. > > > > ... > we are using chained_irq_enter() and chained_irq_exit() > APIs , so need "chained_irq.h" I see. But gpio/driver.h does it for you. ... > > > + for (index = 0; i

RE: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

2020-07-24 Thread Srinivas Neeli
gt; ; Michal Simek ; > Shubhrajyoti Datta ; Srinivas Goud > ; open list:GPIO SUBSYSTEM g...@vger.kernel.org>; linux-arm Mailing List ker...@lists.infradead.org>; Linux Kernel Mailing List ker...@vger.kernel.org>; git > Subject: Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

RE: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

2020-07-24 Thread Srinivas Neeli
s.01.org; open list:GPIO SUBSYSTEM > ; Linux ARM ker...@lists.infradead.org>; linux-kernel@vger.kernel.org; git > > Subject: Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support > > On Fri, Jul 24, 2020 at 6:12 AM kernel test robot wrote: > > >drivers/gpio/gpio-xilin

Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

2020-07-24 Thread Linus Walleij
On Fri, Jul 24, 2020 at 6:12 AM kernel test robot wrote: >drivers/gpio/gpio-xilinx.c: In function 'xgpio_probe': >drivers/gpio/gpio-xilinx.c:638:10: error: 'struct gpio_chip' has no member > named 'of_gpio_n_cells' > 638 | chip->gc.of_gpio_n_cells = cells; > | ^ >

Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

2020-07-23 Thread kernel test robot
Hi Srinivas, Thank you for the patch! Yet something to improve: [auto build test ERROR on gpio/for-next] [also build test ERROR on linus/master v5.8-rc6 next-20200723] [cannot apply to xlnx/master] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch,

Re: [PATCH V2 2/3] gpio: xilinx: Add interrupt support

2020-07-23 Thread Andy Shevchenko
On Thu, Jul 23, 2020 at 5:08 PM Srinivas Neeli wrote: > > Adds interrupt support to the Xilinx GPIO driver so that rising and > falling edge line events can be supported. Since interrupt support is > an optional feature in the Xilinx IP, the driver continues to support > devices which have no inte