Re: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-22 Thread Marc Kleine-Budde
On 11/22/18 12:01 PM, Aisheng DONG wrote: > [...] @@ -1437,10 +1552,18 @@ static int __maybe_unused flexcan_suspend(struct device *device) int err = 0; if (netif_running(dev)) { - err = flexcan_chip_disable(priv); - if (err) -

Re: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-22 Thread Marc Kleine-Budde
On 11/22/18 12:01 PM, Aisheng DONG wrote: > [...] @@ -1437,10 +1552,18 @@ static int __maybe_unused flexcan_suspend(struct device *device) int err = 0; if (netif_running(dev)) { - err = flexcan_chip_disable(priv); - if (err) -

RE: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-22 Thread Aisheng DONG
[...] > >> @@ > >> -1437,10 +1552,18 @@ static int __maybe_unused flexcan_suspend(struct > >> device *device) > >>int err = 0; > >> > >>if (netif_running(dev)) { > >> - err = flexcan_chip_disable(priv); > >> - if (err) > >> - return err; > >> -

RE: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-22 Thread Aisheng DONG
[...] > >> @@ > >> -1437,10 +1552,18 @@ static int __maybe_unused flexcan_suspend(struct > >> device *device) > >>int err = 0; > >> > >>if (netif_running(dev)) { > >> - err = flexcan_chip_disable(priv); > >> - if (err) > >> - return err; > >> -

Re: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-22 Thread Marc Kleine-Budde
On 11/21/18 4:34 AM, Aisheng DONG wrote: >> -Original Message- >> From: Joakim Zhang > [...] >> >> If wakeup is enabled, enter stop mode, else enter disabled mode.Self wake can >> only work on stop mode. >> >> Starting from IMX6, the flexcan stop mode control bits is SoC specific, move >>

Re: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-22 Thread Marc Kleine-Budde
On 11/21/18 4:34 AM, Aisheng DONG wrote: >> -Original Message- >> From: Joakim Zhang > [...] >> >> If wakeup is enabled, enter stop mode, else enter disabled mode.Self wake can >> only work on stop mode. >> >> Starting from IMX6, the flexcan stop mode control bits is SoC specific, move >>

RE: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-20 Thread Aisheng DONG
> -Original Message- > From: Joakim Zhang [...] > > If wakeup is enabled, enter stop mode, else enter disabled mode.Self wake can > only work on stop mode. > > Starting from IMX6, the flexcan stop mode control bits is SoC specific, move > it > out of IP driver and parse it from

RE: [PATCH V3 1/1] can: flexcan: Add self wakeup support

2018-11-20 Thread Aisheng DONG
> -Original Message- > From: Joakim Zhang [...] > > If wakeup is enabled, enter stop mode, else enter disabled mode.Self wake can > only work on stop mode. > > Starting from IMX6, the flexcan stop mode control bits is SoC specific, move > it > out of IP driver and parse it from