Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-16 Thread Dmitry Torokhov
On Mon, Sep 16, 2019 at 07:45:37AM +, Robin Gong wrote: > On 2019/9/13 15:31 robin wrote:> > > Hi Dmitry, > > > > On 2019-09-12 22:13, Dmitry Torokhov wrote: > > > Hi Robin, > > > > > > On Wed, Sep 04, 2019 at 06:23:29AM +, Robin van der Gracht wrote: > > >> The first generation i.MX6 pr

RE: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-16 Thread Robin Gong
On 2019/9/13 15:31 robin wrote:> > Hi Dmitry, > > On 2019-09-12 22:13, Dmitry Torokhov wrote: > > Hi Robin, > > > > On Wed, Sep 04, 2019 at 06:23:29AM +, Robin van der Gracht wrote: > >> The first generation i.MX6 processors does not send an interrupt when > >> the power key is pressed. It s

Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-13 Thread robin
On 2019-09-04 08:52, Marco Felsch wrote: Hi Robin, thanks for the patch it looks quite good, just two minor nitpicks. On 19-09-04 06:23, Robin van der Gracht wrote: The first generation i.MX6 processors does not send an interrupt when the power key is pressed. It sends a power down request int

Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-13 Thread robin
Hi Dmitry, On 2019-09-12 22:13, Dmitry Torokhov wrote: Hi Robin, On Wed, Sep 04, 2019 at 06:23:29AM +, Robin van der Gracht wrote: The first generation i.MX6 processors does not send an interrupt when the power key is pressed. It sends a power down request interrupt if the key is release

Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-12 Thread Dmitry Torokhov
Hi Robin, On Wed, Sep 04, 2019 at 06:23:29AM +, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before a hard shutdown (5 second press). This should

Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-03 Thread Marco Felsch
Hi Robin, thanks for the patch it looks quite good, just two minor nitpicks. On 19-09-04 06:23, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before a