Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-10 Thread Jeffrey Hugo
On 2/9/2019 1:42 AM, Alim Akhtar wrote: On 08/02/19 8:29 PM, Jeffrey Hugo wrote: On 2/8/2019 2:09 AM, Alim Akhtar wrote: Hi Jeffrey, On 07/02/19 8:22 PM, Jeffrey Hugo wrote: On 2/7/2019 1:50 AM, Alim Akhtar wrote: Hi Marc, On 06/02/19 9:22 PM, Marc Gonzalez wrote: On 06/02/2019 16:27, Al

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-09 Thread Marc Gonzalez
Adding DT & regulator maintainers. FTR, we are discussing the revert of patch 60f0187031c0 in the UFSHC driver. On 09/02/2019 09:42, Alim Akhtar wrote: > On 08/02/19 8:29 PM, Jeffrey Hugo wrote: > >> The evidence seems simple.  We have properly described in DT all the >> regulators that are con

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-09 Thread Alim Akhtar
On 08/02/19 8:29 PM, Jeffrey Hugo wrote: > On 2/8/2019 2:09 AM, Alim Akhtar wrote: >> Hi Jeffrey, >> >> On 07/02/19 8:22 PM, Jeffrey Hugo wrote: >>> On 2/7/2019 1:50 AM, Alim Akhtar wrote: Hi Marc, On 06/02/19 9:22 PM, Marc Gonzalez wrote: > On 06/02/2019 16:27, Alim Akhtar wr

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-08 Thread Jeffrey Hugo
On 2/8/2019 2:09 AM, Alim Akhtar wrote: Hi Jeffrey, On 07/02/19 8:22 PM, Jeffrey Hugo wrote: On 2/7/2019 1:50 AM, Alim Akhtar wrote: Hi Marc, On 06/02/19 9:22 PM, Marc Gonzalez wrote: On 06/02/2019 16:27, Alim Akhtar wrote: On 06/02/19 8:29 PM, Marc Gonzalez wrote: [    2.405734] regulat

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-08 Thread Marc Gonzalez
+ Yaniv (just in case) + Hannes (if he remembers) We're discussing commit 60f0187031c05e04cbadffb62f557d0ff3564490 On 08/02/2019 10:09, Alim Akhtar wrote: > On 07/02/19 8:22 PM, Jeffrey Hugo wrote: > >> Did you see https://lkml.org/lkml/2019/2/5/659 where I indicated VCCQ >> powers components

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-08 Thread Alim Akhtar
Hi Jeffrey, On 07/02/19 8:22 PM, Jeffrey Hugo wrote: > On 2/7/2019 1:50 AM, Alim Akhtar wrote: >> Hi Marc, >> >> On 06/02/19 9:22 PM, Marc Gonzalez wrote: >>> On 06/02/2019 16:27, Alim Akhtar wrote: >>> On 06/02/19 8:29 PM, Marc Gonzalez wrote: > [    2.405734] regulator_disable: ENT

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-07 Thread Jeffrey Hugo
On 2/7/2019 1:50 AM, Alim Akhtar wrote: Hi Marc, On 06/02/19 9:22 PM, Marc Gonzalez wrote: On 06/02/2019 16:27, Alim Akhtar wrote: On 06/02/19 8:29 PM, Marc Gonzalez wrote: [2.405734] regulator_disable: ENTER vdd_l26 [2.405958] regulator_disable: EXIT vdd_l26 [2.406032] regula

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-07 Thread Alim Akhtar
Hi Marc, On 06/02/19 9:22 PM, Marc Gonzalez wrote: > On 06/02/2019 16:27, Alim Akhtar wrote: > >> On 06/02/19 8:29 PM, Marc Gonzalez wrote: >> >>> [2.405734] regulator_disable: ENTER vdd_l26 >>> [2.405958] regulator_disable: EXIT vdd_l26 >>> [2.406032] regulator_set_load: vdd_l26 =

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-06 Thread Marc Gonzalez
On 06/02/2019 16:27, Alim Akhtar wrote: > On 06/02/19 8:29 PM, Marc Gonzalez wrote: > >> [2.405734] regulator_disable: ENTER vdd_l26 >> [2.405958] regulator_disable: EXIT vdd_l26 >> [2.406032] regulator_set_load: vdd_l26 = 0 uA >> [3.930447] ufshcd-qcom 1da4000.ufshc: ufshcd_que

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-06 Thread Alim Akhtar
Hi Marc, On 06/02/19 8:29 PM, Marc Gonzalez wrote: > [ Google, stop making email so hard. No, this is not spam, you twat of a > Bayesian filter ] > > On 05/02/2019 18:51, Marc Gonzalez wrote: > >> On 05/02/2019 18:24, Marc Gonzalez wrote: >> >> Silly me. The system crashes in ufshcd_dump_regs()

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-06 Thread Alim Akhtar
On 06/02/19 1:16 AM, Bjorn Andersson wrote: > On Tue 05 Feb 02:52 PST 2019, Alim Akhtar wrote: > >> Hi Bjorn, >> >> On 05/02/19 11:57 AM, Bjorn Andersson wrote: >>> On Mon 04 Feb 20:58 PST 2019, Alim Akhtar wrote: >>> Hi Marc, On 04/02/19 11:12 PM, Marc Gonzalez wrote: > This

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-06 Thread Marc Gonzalez
[ Google, stop making email so hard. No, this is not spam, you twat of a Bayesian filter ] On 05/02/2019 18:51, Marc Gonzalez wrote: > On 05/02/2019 18:24, Marc Gonzalez wrote: > > Silly me. The system crashes in ufshcd_dump_regs() which is a bug > I fixed myself. Once I cherry-pick the appropr

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-06 Thread Marc Gonzalez
On 05/02/2019 18:51, Marc Gonzalez wrote: > On 05/02/2019 18:24, Marc Gonzalez wrote: > > Silly me. The system crashes in ufshcd_dump_regs() which is a bug > I fixed myself. Once I cherry-pick the appropriate fix, the board > no longer reboots, but UFS init does fail. > > Full boot log here: > h

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Bjorn Andersson
On Tue 05 Feb 02:52 PST 2019, Alim Akhtar wrote: > Hi Bjorn, > > On 05/02/19 11:57 AM, Bjorn Andersson wrote: > > On Mon 04 Feb 20:58 PST 2019, Alim Akhtar wrote: > > > >> Hi Marc, > >> > >> On 04/02/19 11:12 PM, Marc Gonzalez wrote: > >>> This reverts commit 60f0187031c05e04cbadffb62f557d0ff356

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Jeffrey Hugo
On 2/5/2019 11:19 AM, Evan Green wrote: On Tue, Feb 5, 2019 at 9:52 AM Marc Gonzalez wrote: On 05/02/2019 18:24, Marc Gonzalez wrote: /*** system hangs here for several seconds, then reboots ***/ Silly me. The system crashes in ufshcd_dump_regs() which is a bug I fixed myself. Once I cherr

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Evan Green
On Tue, Feb 5, 2019 at 9:52 AM Marc Gonzalez wrote: > > On 05/02/2019 18:24, Marc Gonzalez wrote: > > > /*** system hangs here for several seconds, then reboots ***/ > > Silly me. The system crashes in ufshcd_dump_regs() which is a bug > I fixed myself. Once I cherry-pick the appropriate fix, the

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Marc Gonzalez
On 05/02/2019 18:24, Marc Gonzalez wrote: > /*** system hangs here for several seconds, then reboots ***/ Silly me. The system crashes in ufshcd_dump_regs() which is a bug I fixed myself. Once I cherry-pick the appropriate fix, the board no longer reboots, but UFS init does fail. Full boot log h

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Marc Gonzalez
On 05/02/2019 05:58, Alim Akhtar wrote: > On 04/02/19 11:12 PM, Marc Gonzalez wrote: > >> This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. >> >> Calling ufshcd_set_vccq_rail_unused hangs my system. >> It seems vccq is not *not* needed. > > AFAIK Samsung and Toshiba UFS devices does n

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-05 Thread Alim Akhtar
Hi Bjorn, On 05/02/19 11:57 AM, Bjorn Andersson wrote: > On Mon 04 Feb 20:58 PST 2019, Alim Akhtar wrote: > >> Hi Marc, >> >> On 04/02/19 11:12 PM, Marc Gonzalez wrote: >>> This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. >>> >>> Calling ufshcd_set_vccq_rail_unused hangs my system. >

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-04 Thread Bjorn Andersson
On Mon 04 Feb 20:58 PST 2019, Alim Akhtar wrote: > Hi Marc, > > On 04/02/19 11:12 PM, Marc Gonzalez wrote: > > This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. > > > > Calling ufshcd_set_vccq_rail_unused hangs my system. > > It seems vccq is not *not* needed. > > > > Signed-off-by:

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-04 Thread Alim Akhtar
Hi Marc, On 04/02/19 11:12 PM, Marc Gonzalez wrote: > This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. > > Calling ufshcd_set_vccq_rail_unused hangs my system. > It seems vccq is not *not* needed. > > Signed-off-by: Marc Gonzalez > --- AFAIK Samsung and Toshiba UFS devices does no

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-04 Thread Bjorn Andersson
On Mon 04 Feb 11:51 PST 2019, Avri Altman wrote: > > > This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. > > > > Calling ufshcd_set_vccq_rail_unused hangs my system. > > It seems vccq is not *not* needed. > This patch essentially implements the UFS_DEVICE_NO_VCCQ quirk, > Which is ne

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-04 Thread Jeffrey Hugo
On 2/4/2019 12:51 PM, Avri Altman wrote: This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. Calling ufshcd_set_vccq_rail_unused hangs my system. It seems vccq is not *not* needed. This patch essentially implements the UFS_DEVICE_NO_VCCQ quirk, Which is needed for both Samsung and H

RE: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-04 Thread Avri Altman
> This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. > > Calling ufshcd_set_vccq_rail_unused hangs my system. > It seems vccq is not *not* needed. This patch essentially implements the UFS_DEVICE_NO_VCCQ quirk, Which is needed for both Samsung and Hynix devices. Once acked by those ven

Re: [PATCH v3 5/5] Revert "scsi: ufs: disable vccq if it's not needed by UFS device"

2019-02-04 Thread Jeffrey Hugo
On 2/4/2019 10:42 AM, Marc Gonzalez wrote: This reverts commit 60f0187031c05e04cbadffb62f557d0ff3564490. Calling ufshcd_set_vccq_rail_unused hangs my system. It seems vccq is not *not* needed. Signed-off-by: Marc Gonzalez --- Reviewed-by: Jeffrey Hugo drivers/scsi/ufs/ufs.h| 1 -