p.com;
> sudeep.ho...@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controll
p.com;
> sudeep.ho...@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controll
p.com;
> sudeep.ho...@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controller
>
p.com;
> sudeep.ho...@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controller
>
There's more:
I said:
> > @@ -370,12 +398,12 @@ static int synps_edac_init_csrows(struct mem_ctl_info
> > *mci)
> That function returns 0 unconditionally. Make it a void in a prepatch.
But you've lumped this change together with a bunch more. Maybe my
request wasn't clear so let me rephrase
There's more:
I said:
> > @@ -370,12 +398,12 @@ static int synps_edac_init_csrows(struct mem_ctl_info
> > *mci)
> That function returns 0 unconditionally. Make it a void in a prepatch.
But you've lumped this change together with a bunch more. Maybe my
request wasn't clear so let me rephrase
On Wed, Sep 19, 2018 at 01:33:58PM +, Manish Narani wrote:
> Apart from this one, I have covered all the comments from the previous review.
Are you sure?
Let's see. I said:
| Kill all that "function pointer" fluff. Here's how I've changed it:
|
| /**
| * struct synps_platform_data -
On Wed, Sep 19, 2018 at 01:33:58PM +, Manish Narani wrote:
> Apart from this one, I have covered all the comments from the previous review.
Are you sure?
Let's see. I said:
| Kill all that "function pointer" fluff. Here's how I've changed it:
|
| /**
| * struct synps_platform_data -
.@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controller
>
> On Wed, Sep 19,
.@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc controller
>
> On Wed, Sep 19,
On Wed, Sep 19, 2018 at 05:14:51AM +, Manish Narani wrote:
> > So I'm going to stop reviewing this patchset until you go through the old
> > review
> > round again and make sure you've incorporated *all* review feedback and
> > haven't forgotten some, like the one above.
> >
> Okay, I will
On Wed, Sep 19, 2018 at 05:14:51AM +, Manish Narani wrote:
> > So I'm going to stop reviewing this patchset until you go through the old
> > review
> > round again and make sure you've incorporated *all* review feedback and
> > haven't forgotten some, like the one above.
> >
> Okay, I will
leoyang...@nxp.com;
> sudeep.ho...@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc con
leoyang...@nxp.com;
> sudeep.ho...@arm.com; amit.kuche...@linaro.org;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; linux-
> e...@vger.kernel.org; linux-arm-ker...@lists.infradead.org
> Subject: Re: [PATCH v7 2/7] edac: synps: Add platform specific structures for
> ddrc con
On Mon, Sep 17, 2018 at 07:55:00PM +0530, Manish Narani wrote:
> Add platform specific structures, so that we can add different IP
> support later using quirks.
>
> Signed-off-by: Manish Narani
> ---
> drivers/edac/synopsys_edac.c | 91
> +++-
> 1 file
On Mon, Sep 17, 2018 at 07:55:00PM +0530, Manish Narani wrote:
> Add platform specific structures, so that we can add different IP
> support later using quirks.
>
> Signed-off-by: Manish Narani
> ---
> drivers/edac/synopsys_edac.c | 91
> +++-
> 1 file
16 matches
Mail list logo
