RE: [RFC 0/7] Add support to process rx packets in thread

2020-07-28 Thread Rakesh Pillai
el.org; ath...@lists.infradead.org; > diand...@chromium.org; Markus Elfring ; > evgr...@chromium.org; k...@kernel.org; johan...@sipsolutions.net; > da...@davemloft.net; kv...@codeaurora.org > Subject: RE: [RFC 0/7] Add support to process rx packets in thread > > From: Sebastian Gottsc

RE: [RFC 0/7] Add support to process rx packets in thread

2020-07-26 Thread David Laight
From: Sebastian Gottschall > Sent: 25 July 2020 16:42 > >> i agree. i just can say that i tested this patch recently due this > >> discussion here. and it can be changed by sysfs. but it doesnt work for > >> wifi drivers which are mainly using dummy netdev devices. for this i > >> made a small pat

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-26 Thread Felix Fietkau
On 2020-07-26 10:32, Hillf Danton wrote: > > On Sun, 26 Jul 2020 10:10:15 +0200 Felix Fietkau wrote: >> On 2020-07-26 03:22, Hillf Danton wrote: >> > >> > Feel free to do that. Is it likely for me to select a Cc? >> > >> Shall I use Signed-off-by: Hillf Danton ? > > s/Signed-off-by/Cc/ > >> Wh

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-26 Thread Felix Fietkau
On 2020-07-26 03:22, Hillf Danton wrote: >> - add a state bit for threaded NAPI >> - make netif_threaded_napi_add inline >> - run queue_work outside of local_irq_save/restore (it does that >> internally already) >> >> If you don't mind, I'd like to propose this to netdev soon. Can I have >> your Si

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Felix Fietkau
On 2020-07-25 10:16, Hillf Danton wrote: > Hi folks > > Below is a minimunm poc implementation I can imagine on top of workqueue > to make napi threaded. Thoughts are appreciated. Hi Hillf, For some reason I don't see your mails on linux-wireless/netdev. I've cleaned up your implementation a bit

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
i agree. i just can say that i tested this patch recently due this discussion here. and it can be changed by sysfs. but it doesnt work for wifi drivers which are mainly using dummy netdev devices. for this i made a small patch to get them working using napi_set_threaded manually hardcoded in th

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
Am 25.07.2020 um 14:25 schrieb Hillf Danton: On Sat, 25 Jul 2020 12:38:00 +0200 Sebastian Gottschall wrote: you may consider this https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html Thanks v

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
you may consider this https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html years ago someone already wanted to bring this feature upstream, but it was denied. i already tested this patch the last

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-24 Thread Florian Fainelli
ger.kernel.org; linux- >> ker...@vger.kernel.org; kv...@codeaurora.org; johan...@sipsolutions.net; >> da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org; >> diand...@chromium.org; evgr...@chromium.org >> Subject: Re: [RFC 0/7] Add support to process rx packets in threa

RE: [RFC 0/7] Add support to process rx packets in thread

2020-07-23 Thread Rakesh Pillai
johan...@sipsolutions.net; > da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org; > diand...@chromium.org; evgr...@chromium.org > Subject: Re: [RFC 0/7] Add support to process rx packets in thread > > On 7/23/20 11:21 AM, Rakesh Pillai wrote: > > > > > >> -Or

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-23 Thread Florian Fainelli
linux- >> ker...@vger.kernel.org; kv...@codeaurora.org; johan...@sipsolutions.net; >> da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org; >> diand...@chromium.org; evgr...@chromium.org >> Subject: Re: [RFC 0/7] Add support to process rx packets in thread >> >> On 7/2

RE: [RFC 0/7] Add support to process rx packets in thread

2020-07-23 Thread Rakesh Pillai
olutions.net; > da...@davemloft.net; k...@kernel.org; net...@vger.kernel.org; > diand...@chromium.org; evgr...@chromium.org > Subject: Re: [RFC 0/7] Add support to process rx packets in thread > > On 7/21/20 10:25 AM, Andrew Lunn wrote: > > On Tue, Jul 21, 2020 at 10:44:19PM +0530, Rakesh

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-22 Thread Jakub Kicinski
On Tue, 21 Jul 2020 19:25:14 +0200 Andrew Lunn wrote: > On Tue, Jul 21, 2020 at 10:44:19PM +0530, Rakesh Pillai wrote: > > NAPI gets scheduled on the CPU core which got the > > interrupt. The linux scheduler cannot move it to a > > different core, even if the CPU on which NAPI is running > > is hea

RE: [RFC 0/7] Add support to process rx packets in thread

2020-07-22 Thread David Laight
From: Andrew Lunn > Sent: 21 July 2020 18:25 > > On Tue, Jul 21, 2020 at 10:44:19PM +0530, Rakesh Pillai wrote: > > NAPI gets scheduled on the CPU core which got the > > interrupt. The linux scheduler cannot move it to a > > different core, even if the CPU on which NAPI is running > > is heavily l

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-21 Thread Florian Fainelli
On 7/21/20 10:25 AM, Andrew Lunn wrote: > On Tue, Jul 21, 2020 at 10:44:19PM +0530, Rakesh Pillai wrote: >> NAPI gets scheduled on the CPU core which got the >> interrupt. The linux scheduler cannot move it to a >> different core, even if the CPU on which NAPI is running >> is heavily loaded. This

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-21 Thread Andrew Lunn
On Tue, Jul 21, 2020 at 10:44:19PM +0530, Rakesh Pillai wrote: > NAPI gets scheduled on the CPU core which got the > interrupt. The linux scheduler cannot move it to a > different core, even if the CPU on which NAPI is running > is heavily loaded. This can lead to degraded wifi > performance when r