Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-07 Thread Konrad Rzeszutek Wilk
On Wed, Nov 07, 2012 at 04:52:50PM +, Liu, Jinsong wrote: > Konrad Rzeszutek Wilk wrote: > > On Wed, Nov 07, 2012 at 12:58:19PM +, Liu, Jinsong wrote: > > > > If it is generic ACPI code, than it can depend only on ACPI. > > If it is ACPI code that contains X86 specific info, th

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-07 Thread Liu, Jinsong
Konrad Rzeszutek Wilk wrote: > On Wed, Nov 07, 2012 at 12:58:19PM +, Liu, Jinsong wrote: > > If it is generic ACPI code, than it can depend only on ACPI. > If it is ACPI code that contains X86 specific info, than it needs > to depend on X86 too. No x86 specific so le

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-07 Thread Konrad Rzeszutek Wilk
On Wed, Nov 07, 2012 at 12:58:19PM +, Liu, Jinsong wrote: > >>> > >>> If it is generic ACPI code, than it can depend only on ACPI. > >>> If it is ACPI code that contains X86 specific info, than it needs to > >>> depend on X86 too. > >> > >> No x86 specific so let's depend on ACPI. > > > > Hu

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-07 Thread Liu, Jinsong
>>> >>> If it is generic ACPI code, than it can depend only on ACPI. >>> If it is ACPI code that contains X86 specific info, than it needs to >>> depend on X86 too. >> >> No x86 specific so let's depend on ACPI. > > Huh? This feature is x86 specific isn't it? I mean it is in the ACPI > spec, but

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-06 Thread Konrad Rzeszutek Wilk
On Tue, Nov 06, 2012 at 04:23:57PM +, Liu, Jinsong wrote: > Stefano Stabellini wrote: > > On Tue, 6 Nov 2012, Liu, Jinsong wrote: > >> Liu, Jinsong wrote: > >>> Stefano Stabellini wrote: > >> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > >> index 0e86370..a2af622 100644 > >

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-06 Thread Liu, Jinsong
Stefano Stabellini wrote: > On Tue, 6 Nov 2012, Liu, Jinsong wrote: >> Liu, Jinsong wrote: >>> Stefano Stabellini wrote: >> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile >> index 0e86370..a2af622 100644 >> --- a/drivers/xen/Makefile >> +++ b/drivers/xen/Makefile >> @@

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-06 Thread Stefano Stabellini
On Tue, 6 Nov 2012, Liu, Jinsong wrote: > Liu, Jinsong wrote: > > Stefano Stabellini wrote: > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > index 0e86370..a2af622 100644 > --- a/drivers/xen/Makefile > +++ b/drivers/xen/Makefile > @@ -29,6 +29,7 @@ obj-$(CONFIG_

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-05 Thread Liu, Jinsong
Liu, Jinsong wrote: > Stefano Stabellini wrote: diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 0e86370..a2af622 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -29,6 +29,7 @@ obj-$(CONFIG_XEN_MCE_LOG) += mcelog.o obj-$(CONFIG_

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-05 Thread Liu, Jinsong
Stefano Stabellini wrote: >>> diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile >>> index 0e86370..a2af622 100644 >>> --- a/drivers/xen/Makefile >>> +++ b/drivers/xen/Makefile >>> @@ -29,6 +29,7 @@ obj-$(CONFIG_XEN_MCE_LOG) += mcelog.o >>> obj-$(CONFIG_XEN_PCIDEV_BACKEND) += x

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-05 Thread Stefano Stabellini
> > diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile > > index 0e86370..a2af622 100644 > > --- a/drivers/xen/Makefile > > +++ b/drivers/xen/Makefile > > @@ -29,6 +29,7 @@ obj-$(CONFIG_XEN_MCE_LOG) += mcelog.o > > obj-$(CONFIG_XEN_PCIDEV_BACKEND) += xen-pciback/ > > obj-$(CON

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-05 Thread Jan Beulich
>>> On 03.11.12 at 13:16, "Liu, Jinsong" wrote: > Konrad Rzeszutek Wilk wrote: From f514b97628945cfac00efb0d456f133d44754c9d Mon Sep 17 00:00:00 2001 >>> From: Liu, Jinsong >>> Date: Thu, 1 Nov 2012 21:02:36 +0800 >>> Subject: [PATCH 1/2] Xen acpi pad implement >>> >>> PAD is acpi Pro

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-03 Thread Liu, Jinsong
Konrad Rzeszutek Wilk wrote: >>> From f514b97628945cfac00efb0d456f133d44754c9d Mon Sep 17 00:00:00 >>> 2001 >> From: Liu, Jinsong >> Date: Thu, 1 Nov 2012 21:02:36 +0800 >> Subject: [PATCH 1/2] Xen acpi pad implement >> >> PAD is acpi Processor Aggregator Device which provides a control >> point

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-11-02 Thread Konrad Rzeszutek Wilk
On Thu, Nov 01, 2012 at 06:34:45AM +, Liu, Jinsong wrote: > Thanks! updated as attached. > > Jinsong > > = > >From f514b97628945cfac00efb0d456f133d44754c9d Mon Sep 17 00:00:00 2001 > From: Liu, Jinsong > Date: Thu, 1 Nov 2012 21:02:36 +0800 > Subject: [PATCH 1/2] Xen acpi

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-31 Thread Liu, Jinsong
Thanks! updated as attached. Jinsong = >From f514b97628945cfac00efb0d456f133d44754c9d Mon Sep 17 00:00:00 2001 From: Liu, Jinsong Date: Thu, 1 Nov 2012 21:02:36 +0800 Subject: [PATCH 1/2] Xen acpi pad implement PAD is acpi Processor Aggregator Device which provides a control

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-31 Thread Liu, Jinsong
Konrad Rzeszutek Wilk wrote: > On Tue, Oct 30, 2012 at 03:18:59PM +, Liu, Jinsong wrote: >> Konrad Rzeszutek Wilk wrote: > +config XEN_ACPI_PAD_STUB > + bool > + depends on XEN_DOM0 && X86_64 && ACPI > + default n > + This Kconfig is pointless, if CONFIG_XEN_ACPI_

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-31 Thread Konrad Rzeszutek Wilk
On Tue, Oct 30, 2012 at 03:18:59PM +, Liu, Jinsong wrote: > Konrad Rzeszutek Wilk wrote: > >>> +config XEN_ACPI_PAD_STUB > >>> + bool > >>> + depends on XEN_DOM0 && X86_64 && ACPI > >>> + default n > >>> + > >> > >> This Kconfig is pointless, if CONFIG_XEN_ACPI_PAD_STUB = n, native > >> pad wo

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-30 Thread Liu, Jinsong
Konrad Rzeszutek Wilk wrote: >>> +config XEN_ACPI_PAD_STUB >>> + bool >>> + depends on XEN_DOM0 && X86_64 && ACPI >>> + default n >>> + >> >> This Kconfig is pointless, if CONFIG_XEN_ACPI_PAD_STUB = n, native >> pad would successfully registerred, and then mwait #UD (we would >> revert df88b

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-30 Thread Konrad Rzeszutek Wilk
> > +config XEN_ACPI_PAD_STUB > > + bool > > + depends on XEN_DOM0 && X86_64 && ACPI > > + default n > > + > > This Kconfig is pointless, if CONFIG_XEN_ACPI_PAD_STUB = n, native pad would > successfully registerred, and then mwait #UD (we would revert > df88b2d96e36d9a9e325bfcd12eb45671cbb

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-30 Thread Liu, Jinsong
Konrad Rzeszutek Wilk wrote: > On Mon, Oct 29, 2012 at 03:38:14AM +, Liu, Jinsong wrote: >> It's doable to register a stub for xen. However, it's not preferred, >> say, to make xen pad as module, considering the case 'rmmod >> xen_acpi_pad' then 'insmod acpi_pad'? Under such case there is risk

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-29 Thread Konrad Rzeszutek Wilk
On Mon, Oct 29, 2012 at 03:38:14AM +, Liu, Jinsong wrote: > It's doable to register a stub for xen. However, it's not preferred, say, to > make xen pad as module, considering the case 'rmmod xen_acpi_pad' then > 'insmod acpi_pad'? Under such case there is risk of mwait #UD, if we want to > r

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-28 Thread Liu, Jinsong
It's doable to register a stub for xen. However, it's not preferred, say, to make xen pad as module, considering the case 'rmmod xen_acpi_pad' then 'insmod acpi_pad'? Under such case there is risk of mwait #UD, if we want to remove mwait check as 'patch 2/2: Revert-pad-config-check-in-xen_check_

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-26 Thread Konrad Rzeszutek Wilk
On Fri, Oct 26, 2012 at 02:00:36PM +, Liu, Jinsong wrote: > Updated per Jan's comments. > > Thanks, > Jinsong > > === > > >From e6d4eceba9538c6873f9c970425e65e257fd9bf0 Mon Sep 17 00:00:00 2001 > From: Liu, Jinsong > Date: Sat, 27 Oct 2012 05:34:50 +0800 > Subject: [PATCH 1/2] X

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-26 Thread Liu, Jinsong
Updated per Jan's comments. Thanks, Jinsong === >From e6d4eceba9538c6873f9c970425e65e257fd9bf0 Mon Sep 17 00:00:00 2001 From: Liu, Jinsong Date: Sat, 27 Oct 2012 05:34:50 +0800 Subject: [PATCH 1/2] Xen acpi pad implement PAD is acpi Processor Aggregator Device which provides a cont

Re: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-26 Thread Jan Beulich
>>> On 25.10.12 at 14:19, "Liu, Jinsong" wrote: > --- /dev/null > +++ b/drivers/xen/xen_acpi_pad.c > @@ -0,0 +1,173 @@ > +/* > + * xen_acpi_pad.c - Xen pad interface > + * > + * Copyright (c) 2012, Intel Corporation. > + *Author: Liu, Jinsong > + * > + * This program is free software; you can

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-26 Thread Liu, Jinsong
] [PATCH 1/2] Xen acpi pad implement >>> "Liu, Jinsong" 10/26/12 8:18 AM >>> >> +static struct acpi_driver xen_acpi_pad_driver = { >> +.name = "processor_aggregator", >> +.class = ACPI_PROCESSOR_AGGREGATOR_CLASS, >>

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-26 Thread Jan Beulich
>>> "Liu, Jinsong" 10/26/12 8:18 AM >>> >> +static struct acpi_driver xen_acpi_pad_driver = { >> +.name = "processor_aggregator", >> +.class = ACPI_PROCESSOR_AGGREGATOR_CLASS, >> +.ids = pad_device_ids, >> +.ops = { >> +.add = xen_acpi_pad_add, > >.remove? > >[Jinsong] .rem

RE: [Xen-devel] [PATCH 1/2] Xen acpi pad implement

2012-10-25 Thread Liu, Jinsong
Thanks! updated accordingly, w/ 2 comments left as below: > +static const struct acpi_device_id pad_device_ids[] = { > + {"ACPI000C", 0}, > + {"", 0}, > +}; > + > +static struct acpi_driver xen_acpi_pad_driver = { > + .name = "processor_aggregator", > + .class = ACPI_PROCESSOR_AGGR