Re: rtc: rtc-m48t59: rtc-m48t59.0: IRQ index 0 not found

2021-03-11 Thread Alexandre Belloni
Hello, On 10/03/2021 10:53:34+0100, Corentin Labbe wrote: > Hello > > On my SPARC sunblade 100, I got this: > [ 13.613727] rtc-m48t59 rtc-m48t59.0: IRQ index 0 not found > [ 13.805777] rtc-m48t59 rtc-m48t59.0: registered as rtc0 > [ 14.385092] rtc-m48t59 rtc-m48t59.0: setting system clock t

RE: [EXT] Re: rtc: fsl-ftm-alarm: add shutdown interface

2020-09-15 Thread Biwen Li
> > Hi, > > On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote: > > On 30/03/2020 20:26:16+0800, Biwen Li wrote: > > > From: Biwen Li > > > > > > Add shutdown interface > > > > > > Signed-off-by: Biwen Li > > > --- > > > drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++ > > > 1 file changed,

Re: rtc: fsl-ftm-alarm: add shutdown interface

2020-09-15 Thread Alexandre Belloni
Hi, On 30/03/2020 18:44:01+0200, Alexandre Belloni wrote: > On 30/03/2020 20:26:16+0800, Biwen Li wrote: > > From: Biwen Li > > > > Add shutdown interface > > > > Signed-off-by: Biwen Li > > --- > > drivers/rtc/rtc-fsl-ftm-alarm.c | 10 ++ > > 1 file changed, 10 insertions(+) > > > >

RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-15 Thread Biwen Li
> > > > Subject: rtc: pcf85363/pcf85263: fix error that failed to run > > > > hwclock -w > > > > > > > > Issue: > > > > # hwclock -w > > > > hwclock: RTC_SET_TIME: Invalid argument > > > > > > > > The patch fixes error when run command hwclock -w with rtc > > > > pcf85363/pcf85263 > > > > >

RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-15 Thread Leo Li
> -Original Message- > From: Biwen Li > Sent: Wednesday, August 14, 2019 11:15 PM > To: Leo Li ; a.zu...@towertech.it; > alexandre.bell...@bootlin.com > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: RE: rtc: pcf85363/pcf85263: fix err

RE: [EXT] Re: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-14 Thread Biwen Li
> Caution: EXT Email > > Hi, > > On 14/08/2019 17:32:49+0800, Biwen Li wrote: > > Issue: > > # hwclock -w > > hwclock: RTC_SET_TIME: Invalid argument > > > > The patch fixes error when run command hwclock -w with rtc > > pcf85363/pcf85263 > > > > Could you describe a bit more the issue a

RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-14 Thread Biwen Li
> > Subject: rtc: pcf85363/pcf85263: fix error that failed to run hwclock > > -w > > > > Issue: > > # hwclock -w > > hwclock: RTC_SET_TIME: Invalid argument > > > > The patch fixes error when run command hwclock -w with rtc > > pcf85363/pcf85263 > > Can you explain a little bit more in the

RE: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-14 Thread Leo Li
> -Original Message- > From: Biwen Li > Sent: Wednesday, August 14, 2019 4:33 AM > To: a.zu...@towertech.it; alexandre.bell...@bootlin.com; Leo Li > > Cc: linux-...@vger.kernel.org; linux-kernel@vger.kernel.org; Biwen Li > > Subject: rtc: pcf85363/pcf85263: fix error that failed to ru

Re: rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-14 Thread Alexandre Belloni
Hi, On 14/08/2019 17:32:49+0800, Biwen Li wrote: > Issue: > # hwclock -w > hwclock: RTC_SET_TIME: Invalid argument > > The patch fixes error when run command hwclock -w > with rtc pcf85363/pcf85263 > Could you describe a bit more the issue and what causes it? IIRC I wrote that code and

Re: rtc: zynqmp: One function call less in xlnx_rtc_alarm_irq_enable()

2019-07-05 Thread Markus Elfring
> Unless you use an upstream coccinelle script or you share the one you > are using, this is not a useful information. How do you think about to extend a software development discussion on a topic like “Pretty-printing of code for ternary operators?”? https://systeme.lip6.fr/pipermail/cocci/2019-J

Re: [rtc] Re: BUG: workqueue lockup (4)

2019-06-11 Thread Alexandre Belloni
On 10/06/2019 16:49:59-0700, Eric Biggers wrote: > On Sun, Oct 07, 2018 at 09:39:18PM +0200, Alexandre Belloni wrote: > > Hi, > > > > On 07/10/2018 14:18:31+0200, Dmitry Vyukov wrote: > > > On Sun, Oct 7, 2018 at 2:15 PM, syzbot > > > wrote: > > > > Hello, > > > > > > > > syzbot found the followi

Re: rtc: isl1208: avoid possible sysfs race

2018-09-25 Thread Alexandre Belloni
On 25/09/2018 06:46:24+, Denis OSTERLAND wrote: > Hi, > > just for clarification: > This changes user-space representation from > /sys/class/rtc/rtcN/device/{atrim,dtrim,usr} > to > /sys/class/rtc/rtcN/{atrim,dtrim,usr} > and fixes the "mistake made back in 2006" you mention in > https://patch

Re: rtc: isl1208: avoid possible sysfs race

2018-09-24 Thread Denis OSTERLAND
Hi, just for clarification: This changes user-space representation from /sys/class/rtc/rtcN/device/{atrim,dtrim,usr} to /sys/class/rtc/rtcN/{atrim,dtrim,usr} and fixes the "mistake made back in 2006" you mention in https://patchwork.ozlabs.org/patch/881397/ correct? Regards Denis Am Samstag, den

Re: rtc: fix chardev initialization races

2018-05-22 Thread Jiri Kosina
On Tue, 22 May 2018, Uwe Kleine-König wrote: > [adding linux-rtc ML and Alexandre to Cc:] > > Hello, > > On Tue, May 22, 2018 at 02:09:36PM +0200, Jiri Kosina wrote: > > On Mon, 21 May 2018, Uwe Kleine-König wrote: > > > > > > The race looks like that (thanks Jiri): > > > > > > > > CPU0:

Re: rtc: fix chardev initialization races

2018-05-22 Thread Uwe Kleine-König
[adding linux-rtc ML and Alexandre to Cc:] Hello, On Tue, May 22, 2018 at 02:09:36PM +0200, Jiri Kosina wrote: > On Mon, 21 May 2018, Uwe Kleine-König wrote: > > > > The race looks like that (thanks Jiri): > > > > > > CPU0:CPU1: > > > sys_load_module() > > > do_

Re: rtc: fix chardev initialization races

2018-05-22 Thread Jiri Kosina
On Mon, 21 May 2018, Uwe Kleine-König wrote: > > The race looks like that (thanks Jiri): > > > > CPU0:CPU1: > > sys_load_module() > > do_init_module() > > do_one_initcall() > >cmos_do_probe() > > rtc_device_register() > > __register_chrdev() > >

Re: rtc: fix chardev initialization races

2018-05-21 Thread Uwe Kleine-König
On Wed, Feb 26, 2014 at 11:33:13AM +0100, Ales Novak wrote: > In many rtc modules, the chardevice file in rtc module probe is > being created prematurely. If the probe fails after the chardevice > file has been created (e.g. after rtc_device_register), it's possible > for a program to open() it, wh

Re: rtc: sysfs: move sysfs interface to Documentation/ABI

2017-12-28 Thread Ozgur
28.12.2017, 18:00, "Aishwarya Pant" : > On Thu, Dec 28, 2017 at 05:23:33PM +0300, Ozgur wrote: >>  28.12.2017, 17:22, "Ozgur" : >>  > 28.12.2017, 16:31, "Aishwarya Pant" : >>  >>  Hi >> >>   Hello, >> >>  >>  In Documentation/rtc.txt, there is a description of the sysfs >>  >>  interface which co

Re: rtc: sysfs: move sysfs interface to Documentation/ABI

2017-12-28 Thread Aishwarya Pant
On Thu, Dec 28, 2017 at 05:23:33PM +0300, Ozgur wrote: > > > 28.12.2017, 17:22, "Ozgur" : > > 28.12.2017, 16:31, "Aishwarya Pant" : > >>  Hi > > Hello, > > >>  In Documentation/rtc.txt, there is a description of the sysfs > >>  interface which could be moved to Documentation/ABI. > >> > >>  Wo

Re: rtc: sysfs: move sysfs interface to Documentation/ABI

2017-12-28 Thread Ozgur
28.12.2017, 17:22, "Ozgur" : > 28.12.2017, 16:31, "Aishwarya Pant" : >>  Hi Hello, >>  In Documentation/rtc.txt, there is a description of the sysfs >>  interface which could be moved to Documentation/ABI. >> >>  Would such a change be useful? >> >>  The ABI documentation format looks like the

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-18 Thread Alexandre Belloni
On 13/12/2017 at 07:55:35 +, Lee Jones wrote: > On Tue, 12 Dec 2017, Alexandre Belloni wrote: > > > On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > > > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > > > + Alessandro Zummo > > > > + Alexandre Belloni > > > > >

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-12 Thread Lee Jones
On Tue, 12 Dec 2017, Alexandre Belloni wrote: > On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > > + Alessandro Zummo > > > + Alexandre Belloni > > > > > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > > > : >

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

2017-12-12 Thread Alexandre Belloni
On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > + Alessandro Zummo > > + Alexandre Belloni > > > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > > : > > > Dear all, > > > > > > This is an attempt to revive some

Re: [rtc-linux] Re: [PATCH] RTC: Add functionality to read/write rtc scratch registers

2017-07-16 Thread Keerthy
On Friday 14 July 2017 02:13 AM, Alexandre Belloni wrote: > Hi, > > On 05/05/2017 at 00:38:27 +0200, Alexandre Belloni wrote: >> Hi, >> >> On 03/05/2017 at 11:39:34 +0530, Keerthy wrote: >>> On Tuesday 18 April 2017 10:50 AM, Keerthy wrote: From: Russ Dill Many RTCs provide scrat

Re: [rtc-linux] Re: [PATCH] RTC: Add functionality to read/write rtc scratch registers

2017-07-13 Thread Alexandre Belloni
Hi, On 05/05/2017 at 00:38:27 +0200, Alexandre Belloni wrote: > Hi, > > On 03/05/2017 at 11:39:34 +0530, Keerthy wrote: > > On Tuesday 18 April 2017 10:50 AM, Keerthy wrote: > > > From: Russ Dill > > > > > > Many RTCs provide scratch registers that are maintained so long as the RTC > > > has po

Re: rtc: ds3232: add temperature support

2017-06-22 Thread Kirill Esipov
2017-06-22 16:44 GMT+03:00 Guenter Roeck : > On 06/22/2017 05:07 AM, Kirill Esipov wrote: >> >> >> >> 2017-06-22 1:24 GMT+03:00 Guenter Roeck > >: >> >> On Wed, Jun 21, 2017 at 05:49:43PM +0300, Kirill Esipov wrote: >> > DS3232/DS3234 has the temperature register

Re: rtc: ds3232: add temperature support

2017-06-22 Thread Guenter Roeck
On 06/22/2017 05:07 AM, Kirill Esipov wrote: 2017-06-22 1:24 GMT+03:00 Guenter Roeck mailto:li...@roeck-us.net>>: On Wed, Jun 21, 2017 at 05:49:43PM +0300, Kirill Esipov wrote: > DS3232/DS3234 has the temperature registers with a resolution of > 0.25 degree celsius. This enables

Re: rtc: ds3232: add temperature support

2017-06-22 Thread Kirill Esipov
2017-06-22 1:24 GMT+03:00 Guenter Roeck : > On Wed, Jun 21, 2017 at 05:49:43PM +0300, Kirill Esipov wrote: >> DS3232/DS3234 has the temperature registers with a resolution of >> 0.25 degree celsius. This enables to get the value through hwmon. >> >> # cat /sys/class/hwmon/hwmon0/temp1_input >

Re: rtc: ds3232: add temperature support

2017-06-21 Thread Guenter Roeck
On Wed, Jun 21, 2017 at 05:49:43PM +0300, Kirill Esipov wrote: > DS3232/DS3234 has the temperature registers with a resolution of > 0.25 degree celsius. This enables to get the value through hwmon. > > # cat /sys/class/hwmon/hwmon0/temp1_input > 37250 > > Signed-off-by: Kirill Esipov

Re: [rtc-linux] [PATCH 12/51] rtc: coh901331: stop using rtc deprecated functions

2017-06-20 Thread Linus Walleij
On Tue, Jun 20, 2017 at 11:35 AM, Benjamin Gaignard wrote: > rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they > rely on 32bits variables and that will make rtc break in y2038/2016. > Stop using those two functions to safer 64bits ones. > > Signed-off-by: Benjamin Gaignard > CC:

Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put

2017-03-16 Thread Greg Kroah-Hartman
On Fri, Mar 17, 2017 at 03:11:37PM +0900, Greg Kroah-Hartman wrote: > On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote: > > Hey, > > > > I think I see the issue here: in a couple of error conditions, the RTC > > code will not initialize and ask for the cdev. However, my change will

Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put

2017-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 16, 2017 at 11:23:26PM -0600, Logan Gunthorpe wrote: > Hey, > > I think I see the issue here: in a couple of error conditions, the RTC > code will not initialize and ask for the cdev. However, my change will > always call cdev_add and cdev_del even though the rtc code did not call > cd

Re: [rtc] 4cd8adb100: WARNING: CPU: 0 PID: 1 at lib/kobject.c:690 kobject_put

2017-03-16 Thread Logan Gunthorpe
Hey, I think I see the issue here: in a couple of error conditions, the RTC code will not initialize and ask for the cdev. However, my change will always call cdev_add and cdev_del even though the rtc code did not call cdev_init. I'll have to add a guard around dev->devt in the new cdev_device fun

Re: [rtc-linux] Re: [PATCH] rtc: max77683: avoid regmap bulk write for max77620

2016-12-12 Thread Krzysztof Kozlowski
On Mon, Dec 12, 2016 at 02:28:11PM +0100, Bartlomiej Zolnierkiewicz wrote: > > @@ -259,6 +262,32 @@ static const struct max77686_rtc_driver_data > > max77802_drv_data = { > > .rtc_irq_chip = &max77802_rtc_irq_chip, > > }; > > > > +static inline int _regmap_bulk_write(struct max77686_rtc_inf

Re: [rtc-linux] Re: [RFC PATCH 2/3] rtc: Add Amlogic Virtual Wake RTC

2016-11-30 Thread Alexandre Belloni
On 03/11/2016 at 15:36:48 +, Mark Rutland wrote : > > In order to be able to reuse the RTC wakealarm feature, this > > driver implements a fake RTC device which uses the system time > > to deduce a suspend delay. > > This sounds like an always-on oneshot timer device, not an RTC. > > > +stati

Re: [rtc-linux] [PATCH] rtc: Add support for maxim dallas rtc max-6917

2016-10-12 Thread Alexandre Belloni
Hi, Seeing this has the same register map as max6916, please use regmap to abstract the accesses and handle both with the same driver. You can have a look at rtc-ds3232.c for an example. On 12/10/2016 at 01:33:32 -0700, VENKAT PRASHANTH B U wrote : > This is a patch to add support for > maxim dal

Re: [rtc-linux] Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register.

2016-08-11 Thread Alexandre Belloni
On 11/08/2016 at 07:56:03 -0700, danielrom...@gmail.com wrote : > > > Den torsdag 11 augusti 2016 kl. 15:42:58 UTC+2 skrev alexandre.belloni: > > > > On 11/08/2016 at 13:31:43 +0200, Daniel Romell wrote : > > > From: Jan Östlund > > > > > > > The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both

Re: rtc regression [463a86304cae ("char/genrtc: x86: remove remnants of asm/rtc.h")]

2016-08-09 Thread Ville Syrjälä
On Tue, Aug 09, 2016 at 06:09:27PM +0200, Arnd Bergmann wrote: > On Tuesday, August 9, 2016 6:56:49 PM CEST Ville Syrjälä wrote: > > Hi, > > > > commit 463a86304cae ("char/genrtc: x86: remove remnants of asm/rtc.h") > > broke rtc for me. Neither hwclock or rtcwake work anymore. This is just > > a

Re: rtc regression [463a86304cae ("char/genrtc: x86: remove remnants of asm/rtc.h")]

2016-08-09 Thread Arnd Bergmann
On Tuesday, August 9, 2016 6:56:49 PM CEST Ville Syrjälä wrote: > Hi, > > commit 463a86304cae ("char/genrtc: x86: remove remnants of asm/rtc.h") > broke rtc for me. Neither hwclock or rtcwake work anymore. This is just > a very standard x86-64 IVB box, and it was reported that machines in > our i9

Re: [rtc-linux] Re: [PATCH] rtc: pcf2123: Add missing error code assignment before test

2016-08-09 Thread Alexandre Belloni
On 09/08/2016 at 14:03:35 +0200, Julia Lawall wrote : > > > On Tue, 9 Aug 2016, Christophe JAILLET wrote: > > > It is likely that checking the result of 'pcf2123_write_reg' is expected > > here. > > Also fix a small style issue. The '{' at the beginning of the function > > is misplaced. > > The

Re: rtc-palmas: correct for bcd year

2016-07-08 Thread Alexandre Belloni
On 05/01/2016 at 08:08:50 -0800, Mark Salyzyn wrote : > On 01/04/2016 04:00 PM, Alexandre Belloni wrote: > > I'd say that the proper course of action is to refuse to set dates > > before 2000 and after 2100. See > > http://patchwork.ozlabs.org/patch/541037/ > Got it. > > We have an issue though, A

Re: [rtc-linux] [PATCH] rtc: add support for Maxim rtc max6916 v3.0

2016-05-13 Thread Krzysztof Kozlowski
On Fri, May 13, 2016 at 8:14 AM, wrote: > From: venkat-prashanth > > This is a patch to add support > for Maxim rtc max6916 Please fix line wrapping (around 72 characters). Also please follow patch submission rules. Look at other patches with versions - how "v4" is added (not to title) and pre

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

2016-04-21 Thread Alexandre Belloni
On 21/04/2016 at 08:46:33 -0400, Javier Martinez Canillas wrote : > Hello Alexandre, > > On 03/28/2016 06:19 PM, Alexandre Belloni wrote: > > On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote : > >> The S3C binding doc says that the RTC and RTC source clocks are required > >> but the

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

2016-04-21 Thread Javier Martinez Canillas
Hello Alexandre, On 03/28/2016 06:19 PM, Alexandre Belloni wrote: > On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote : >> The S3C binding doc says that the RTC and RTC source clocks are required >> but the S3C driver supports different HW IP and only the s3c6410 needs a >> source cl

RE: rtc ds3232 call trace in kernel

2016-04-18 Thread Qianyu Gong
> -Original Message- > From: Akinobu Mita [mailto:akinobu.m...@gmail.com] > Sent: Tuesday, April 19, 2016 11:58 AM > To: Qianyu Gong > Cc: alexandre.bell...@free-electrons.com; Mingkai Hu ; > rtc-li...@googlegroups.com; linux-kernel@vger.kernel.org > Subject: Re: rtc

Re: rtc ds3232 call trace in kernel

2016-04-18 Thread Akinobu Mita
tc-li...@googlegroups.com; linux-kernel@vger.kernel.org >> Subject: Re: rtc ds3232 call trace in kernel >> >> 2016-04-18 15:15 GMT+09:00 Qianyu Gong : >> > Hi Akinobu, >> > >> > >> > >> > I got an rtc call trace when booting 4.6

RE: rtc ds3232 call trace in kernel

2016-04-18 Thread Qianyu Gong
> -Original Message- > From: Alexandre Belloni [mailto:alexandre.bell...@free-electrons.com] > Sent: Tuesday, April 19, 2016 12:22 AM > To: Qianyu Gong > Cc: akinobu.m...@gmail.com; Mingkai Hu ; rtc- > li...@googlegroups.com; linux-kernel@vger.kernel.org > Subject

RE: rtc ds3232 call trace in kernel

2016-04-18 Thread Qianyu Gong
> -Original Message- > From: Akinobu Mita [mailto:akinobu.m...@gmail.com] > Sent: Monday, April 18, 2016 9:02 PM > To: Qianyu Gong > Cc: alexandre.bell...@free-electrons.com; Mingkai Hu ; > rtc-li...@googlegroups.com; linux-kernel@vger.kernel.org > Subject: Re: rtc

Re: rtc ds3232 call trace in kernel

2016-04-18 Thread Alexandre Belloni
On 18/04/2016 at 06:15:40 +, Qianyu Gong wrote : > Hi Akinobu, > > I got an rtc call trace when booting 4.6 kernel on our board and I found it > was caused by this patch: > > commit fc1dcb0b39dbb10d3290f2fcd6e154670f699166 > Author: Akinobu Mita > Date: Mon Mar 7 00:27:53 2016 +0900 > >

Re: rtc ds3232 call trace in kernel

2016-04-18 Thread Akinobu Mita
2016-04-18 15:15 GMT+09:00 Qianyu Gong : > Hi Akinobu, > > > > I got an rtc call trace when booting 4.6 kernel on our board and I found it > > was caused by this patch: > > > > commit fc1dcb0b39dbb10d3290f2fcd6e154670f699166 > > Author: Akinobu Mita > > Date: Mon Mar 7 00:27:53 2016 +0900 > > >

Re: [rtc-linux] [PATCH v2] rtc: s3c: Document in binding that only s3c6410 needs a src clk

2016-03-28 Thread Alexandre Belloni
On 15/02/2016 at 11:11:06 -0300, Javier Martinez Canillas wrote : > The S3C binding doc says that the RTC and RTC source clocks are required > but the S3C driver supports different HW IP and only the s3c6410 needs a > source clock. > > Fix the binding explaining that the source clock is only neede

Re: [rtc-linux] [PATCH] drivers/rtc/rtc-mcp795.c: add devicetree support

2016-03-21 Thread Alexandre Belloni
On 21/03/2016 at 01:06:10 +0100, Emil Bartczak wrote : > Add device tree support to the rtc-mcp795 driver. > > Signed-off-by: Emil Bartczak > --- > Documentation/devicetree/bindings/rtc/maxim,mcp795.txt | 11 +++ > drivers/rtc/rtc-mcp795.c | 10 ++ >

Re: [rtc-linux] Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral

2016-03-19 Thread Krzysztof Kozlowski
On Fri, Mar 18, 2016 at 9:07 PM, Alexandre Belloni wrote: > On 18/03/2016 at 08:57:57 -0300, Javier Martinez Canillas wrote : >> >>> But yes, we can at least get rid of the else statement. I don't have a >> >>> strong opinion about the debug information, I left it to avoid someone >> >>> to tell m

Re: [rtc-linux] Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral

2016-03-19 Thread Javier Martinez Canillas
Hello Krzysztof, On 03/18/2016 09:20 AM, Krzysztof Kozlowski wrote: > On Fri, Mar 18, 2016 at 9:07 PM, Alexandre Belloni >> On 18/03/2016 at 08:57:57 -0300, Javier Martinez Canillas wrote : [snip] >>> >>> Just to make sure that I understood correctly, there's no action I >>> should take in order

Re: [rtc-linux] Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 21:40:23 Krzysztof Kozlowski wrote: > >> select MFD_SYSCON > >> diff --git a/drivers/media/platform/exynos4-is/Kconfig > >> b/drivers/media/platform/exynos4-is/Kconfig > >> index 57d42c6172c5..c4317b99d257 100644 > >> --- a/drivers/media/platform/exynos4-is/Kconfi

Re: [rtc-linux] [RFC 06/15] pinctrl: rockchip: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 17:03 GMT+09:00 Krzysztof Kozlowski : > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet > direct dependencies. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/pinctrl/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/Kconfig b/

Re: [rtc-linux] [RFC 07/15] pinctrl: mvebu: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 17:03 GMT+09:00 Krzysztof Kozlowski : > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet > direct dependencies. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/pinctrl/mvebu/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pinctrl/mveb

Re: [rtc-linux] [RFC 12/15] soc: qcom: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 17:03 GMT+09:00 Krzysztof Kozlowski : > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet > direct dependencies. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/soc/qcom/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/soc/qcom/Kconfig

Re: [rtc-linux] [RFC 13/15] staging: media: omap4iss: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 17:03 GMT+09:00 Krzysztof Kozlowski : > The MFD_SYSCON depends on HAS_IOMEM so when selecting it avoid unmet > direct dependencies. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/staging/media/omap4iss/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/sta

Re: [rtc-linux] Re: [RFC 09/15] media: platform: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 19:57 GMT+09:00 Arnd Bergmann : > On Thursday 03 March 2016 17:03:35 Krzysztof Kozlowski wrote: >> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig >> index 201f5c296a95..e5931e434fa2 100644 >> --- a/drivers/media/platform/Kconfig >> +++ b/drivers/media/platfo

Re: [rtc-linux] Re: [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 21:33 GMT+09:00 Sebastian Reichel : > Hi, > > On Thu, Mar 03, 2016 at 12:00:14PM +0100, Arnd Bergmann wrote: >> On Thursday 03 March 2016 17:03:37 Krzysztof Kozlowski wrote: >> > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig >> > index 0a6408a39c66..0f34846ae80d

Re: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozłowski
2016-03-03 21:28 GMT+09:00 Arnd Bergmann : > On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote: >> > >> > Not user visible. >> >> Hmmm... you are right (here and in other patches) but why am I getting >> all these errors: >> warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_I

Re: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Arnd Bergmann
On Thursday 03 March 2016 21:00:57 Krzysztof Kozlowski wrote: > > > > Not user visible. > > Hmmm... you are right (here and in other patches) but why am I getting > all these errors: > warning: (ST_IRQCHIP && HIP04_ETH && STMMAC_PLATFORM && DWMAC_IPQ806X > && DWMAC_LPC18XX && DWMAC_ROCKCHIP && DWM

Re: [rtc-linux] Re: [RFC 15/15] mfd: syscon: Fix build of missing ioremap on UM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 19:50 GMT+09:00 Arnd Bergmann : > On Thursday 03 March 2016 17:03:41 Krzysztof Kozlowski wrote: >> Since commit c89c0114955a ("mfd: syscon: Set regmap max_register in >> of_syscon_register") the syscon uses ioremap so it fails on COMPILE_TEST >> without HAS_IOMEM: >> >> drivers/mfd/sysco

Re: [rtc-linux] Re: [RFC 04/15] irqchip: st: Add missing MFD_SYSCON dependency on HAS_IOMEM

2016-03-03 Thread Krzysztof Kozlowski
2016-03-03 19:53 GMT+09:00 Arnd Bergmann : > On Thursday 03 March 2016 17:03:30 Krzysztof Kozlowski wrote: >> config ST_IRQCHIP >> bool >> select REGMAP >> + depends on HAS_IOMEM# For MFD_SYSCON >> select MFD_SYSCON >> help >> Enables SysCfg Cont

Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding

2016-02-15 Thread Alexandre Belloni
On 15/02/2016 at 09:49:34 -0300, Javier Martinez Canillas wrote : > >No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks > >but rest of compatible devices need only rtc clock. > > > > Right, sorry for missing that. I noticed that this patch has already > been picked by Rob Herri

Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding

2016-02-15 Thread Javier Martinez Canillas
Hello Krzysztof, Thanks a lot for your feedback. On 02/14/2016 03:34 AM, Krzysztof Kozlowski wrote: W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze: The S3C Real Time Clock driver requires the clock and source clock to be defined in the device node but that requirement is not documen

Re: [rtc-linux] [PATCH] rtc: s3c: Document required clocks in the DT binding

2016-02-13 Thread Krzysztof Kozlowski
W dniu 10.02.2016 o 02:23, Javier Martinez Canillas pisze: > The S3C Real Time Clock driver requires the clock and source clock to > be defined in the device node but that requirement is not documented. +Cc: Alessandro Zummo No, not entirely. The samsung,s3c6410-rtc needs rtc and rtc_src clocks b

Re: [rtc-linux] [PATCH V7 5/8] gpio: add DT binding doc for gpio of PMIC max77620/max20024

2016-02-09 Thread Lee Jones
On Fri, 05 Feb 2016, Linus Walleij wrote: > On Sat, Jan 30, 2016 at 5:38 PM, Laxman Dewangan wrote: > > > Maxim Semiconductor's PMIC MAX77620/MAX20024 has 8 GPIO pins > > which act as GPIO as well as special function mode. > > > > Add DT binding document to support these pins in GPIO > > mode vi

Re: [rtc-linux] [PATCH V7 5/8] gpio: add DT binding doc for gpio of PMIC max77620/max20024

2016-02-05 Thread Linus Walleij
On Sat, Jan 30, 2016 at 5:38 PM, Laxman Dewangan wrote: > Maxim Semiconductor's PMIC MAX77620/MAX20024 has 8 GPIO pins > which act as GPIO as well as special function mode. > > Add DT binding document to support these pins in GPIO > mode via GPIO framework. > > Signed-off-by: Laxman Dewangan > A

Re: [rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

2016-02-04 Thread Krzysztof Kozlowski
On 05.02.2016 07:56, Alexandre Belloni wrote: > On 31/01/2016 at 21:11:00 +0900, Krzysztof Kozlowski wrote : >> W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze: >>> Hi, >>> >>> On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote : Hello, On a recent disussion [0] with

Re: [rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

2016-02-04 Thread Alexandre Belloni
On 31/01/2016 at 21:11:00 +0900, Krzysztof Kozlowski wrote : > W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze: > > Hi, > > > > On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote : > >> Hello, > >> > >> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan, > >> we

Re: [rtc-linux] Re: [PATCH v4 00/10] rtc: max77686: Extend driver and add max77802 support

2016-01-31 Thread Krzysztof Kozlowski
W dniu 31.01.2016 o 21:05, Alexandre Belloni pisze: > Hi, > > On 27/01/2016 at 00:36:36 -0300, Javier Martinez Canillas wrote : >> Hello, >> >> On a recent disussion [0] with Krzysztof Kozlowski and Laxman Dewangan, >> we came to the conclusion that the max77686 and max77802 RTC are almost >> the

Re: rtc-palmas: correct for bcd year

2016-01-05 Thread Mark Salyzyn
On 01/04/2016 04:00 PM, Alexandre Belloni wrote: I'd say that the proper course of action is to refuse to set dates before 2000 and after 2100. See http://patchwork.ozlabs.org/patch/541037/ Got it. We have an issue though, Android (or rather any embedded) devices must continue to function whe

Re: rtc-palmas: correct for bcd year

2016-01-04 Thread Alexandre Belloni
On 04/01/2016 at 08:45:54 -0800, Mark Salyzyn wrote : > On 01/04/2016 08:18 AM, Alexandre Belloni wrote: > >Hi, > > > >On 30/12/2015 at 12:51:45 -0800, Mark Salyzyn wrote : > >>Replace bcd2bin and bin2bcd with one that maps years 1970 to 2129 > >>in a pattern that works with the underlying hardware

Re: rtc-palmas: correct for bcd year

2016-01-04 Thread Mark Salyzyn
On 01/04/2016 08:18 AM, Alexandre Belloni wrote: Hi, On 30/12/2015 at 12:51:45 -0800, Mark Salyzyn wrote : Replace bcd2bin and bin2bcd with one that maps years 1970 to 2129 in a pattern that works with the underlying hardware. The only transition that does not work correctly for this rtc clock

Re: rtc-palmas: correct for bcd year

2016-01-04 Thread Alexandre Belloni
Hi, On 30/12/2015 at 12:51:45 -0800, Mark Salyzyn wrote : > Replace bcd2bin and bin2bcd with one that maps years 1970 to 2129 > in a pattern that works with the underlying hardware. > > The only transition that does not work correctly for this rtc clock > is the transition from 2099 to 2100, it p

Re: [rtc-linux] Re: [PATCH v2 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

2015-12-30 Thread Krzysztof Kozlowski
2015-12-30 19:14 GMT+09:00 Alim Akhtar : > > Hi Krzysztof, > > On 12/30/2015 10:17 AM, Krzysztof Kozlowski wrote: >> >> Before updating time and alarm the driver must set appropriate mask in >> UDR register. For that purpose the driver uses common register >> configuration and a lot of exceptions p

Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st

2015-12-03 Thread Julius Werner
> I would have liked to be in copy of that mail. Maybe you used > get_maintainers on an old tree? Oops, yes, sorry, I ran it on a 3.14 backport and then just added people I found in older patches for that file. > I hope reading the time properly fails thanks to the rtc_valid_tm(tm) in > __rtc_rea

Re: [rtc-linux] [PATCH] RTC: RK808: Work around hardware bug on November 31st

2015-12-03 Thread Alexandre Belloni
Hi, I would have liked to be in copy of that mail. Maybe you used get_maintainers on an old tree? On 02/12/2015 at 17:53:04 -0800, Julius Werner wrote : > In Fuzhou, China, the month of November seems to be having 31 days. > That's nice and all (I'm sure you can get a lot more done in a year that

Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-11-08 Thread Krzysztof Kozlowski
On 09.11.2015 14:54, Alim Akhtar wrote: > Hi Krzysztof, > > On 11/07/2015 08:39 AM, Krzysztof Kozlowski wrote: >> W dniu 07.11.2015 o 07:33, Rob Herring pisze: >>> On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: From: Thomas Abraham Add dt-binding documentation for s2m

Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-11-08 Thread Alim Akhtar
Hi Krzysztof, On 11/07/2015 08:39 AM, Krzysztof Kozlowski wrote: W dniu 07.11.2015 o 07:33, Rob Herring pisze: On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: From: Thomas Abraham Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device is similar to s2mps11/14 P

Re: [rtc-linux] Re: [PATCH v5 1/4] dt-bindings: mfd: s2mps11: add documentation for s2mps15 PMIC

2015-11-06 Thread Krzysztof Kozlowski
W dniu 07.11.2015 o 07:33, Rob Herring pisze: > On Fri, Oct 30, 2015 at 11:55:31AM +0530, Alim Akhtar wrote: >> From: Thomas Abraham >> >> Add dt-binding documentation for s2mps15 PMIC device. The s2mps15 device >> is similar to s2mps11/14 PMIC device and has 27 LDO and 10 buck regulators. >> This

Re: [rtc-linux] Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Alim Akhtar
Hi Krzysztof, On Thu, Oct 29, 2015 at 5:05 PM, Krzysztof Kozlowski wrote: > 2015-10-29 20:20 GMT+09:00 Alim Akhtar : I am testing this patch before sending them, what I have found is if you don't update WUDR the time does not changes in rtc. e.g. if you don't do above changes

Re: [rtc-linux] Re: [PATCH v4 4/4] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-29 Thread Krzysztof Kozlowski
2015-10-29 20:20 GMT+09:00 Alim Akhtar : >>> I am testing this patch before sending them, what I have found is if you >>> don't update WUDR the time does not changes in rtc. >>> e.g. >>> if you don't do above changes then you will see below: >>> - >>> # date --set="Oct 29 14:10:40 2015" >>> Th

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-28 Thread Alexandre Belloni
On 28/10/2015 at 22:31:48 +0900, Krzysztof Kozlowski wrote : > > So you don't care about DT backward compatibility because when a > > workaround will be needed for one of the IPs, then you will have to > > update the old dtb to use it. > > Nope, DTB does not contain the name for RTC driver (s2mps1

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-28 Thread Krzysztof Kozlowski
W dniu 28.10.2015 o 19:30, Alim Akhtar pisze: > Hi Alexandre, > > On 10/28/2015 03:18 PM, Alexandre Belloni wrote: >> On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >>> The s2mps13 clock driver added new name and compatible... which was >>> probably totally unneeded (I missed that du

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-28 Thread Krzysztof Kozlowski
W dniu 28.10.2015 o 18:48, Alexandre Belloni pisze: > On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : >> The s2mps13 clock driver added new name and compatible... which was >> probably totally unneeded (I missed that during review). We don't have >> to make this as a rule... >> >> Sinc

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-28 Thread Alim Akhtar
Hi Alexandre, On 10/28/2015 03:18 PM, Alexandre Belloni wrote: On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : The s2mps13 clock driver added new name and compatible... which was probably totally unneeded (I missed that during review). We don't have to make this as a rule... Since

Re: [rtc-linux] Re: [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-28 Thread Alexandre Belloni
On 28/10/2015 at 12:31:43 +0900, Krzysztof Kozlowski wrote : > The s2mps13 clock driver added new name and compatible... which was > probably totally unneeded (I missed that during review). We don't have > to make this as a rule... > > Since we do not have any data about future workarounds and the

Re: [rtc-linux] [PATCH v3 5/5] drivers/rtc/rtc-s5m.c: add support for S2MPS15 RTC

2015-10-27 Thread Alexandre Belloni
On 26/10/2015 at 18:21:22 +0530, Alim Akhtar wrote : > RTC found in s2mps15 is almost same as one found in s2mps14. > This patch add required changes to enable s2mps15 rtc timer. > > Signed-off-by: Alim Akhtar One really small nitpick below else you can add my Acked-by: Alexandre Belloni > ---

Re: [rtc-linux] [PATCH v3 1/2] Fixed ds1390_get_reg returned value

2015-09-18 Thread Alexandre Belloni
Hi, You've sent that series so many times that I'm not sure which one I should look at... Also, please include a changelog when submitting a new version of a patch. On 18/09/2015 at 17:27:56 +0200, Ivan Grimaldi wrote : > spi_write_then_read puts in rx_buf the received data starting from > the f

Re: [rtc-linux] [PATCH] Fixed ds1390_get_reg returned value

2015-09-16 Thread Alexandre Belloni
Hi, Your patch is not properly fomatted, it as probably been mangled by your mailer can you resend it properly? Thanks, On 16/09/2015 at 17:51:17 +0200, Ivan Grimaldi wrote : > spi_write_then_read puts in rx_buf the received data starting from the > first byte of the rx_buf for n_rx bytes. > >

Re: [rtc-linux] RE: [PATCH v2] rtc/ds3232: fix ds3232 get a WARNING trace in resume function

2015-08-17 Thread Krzysztof Kozlowski
2015-08-17 16:10 GMT+09:00 Wang Dongsheng : > Hi Alexandre, > > Could you apply this patch? Give some time before pinging. > > Regards, > -Dongsheng > >> -Original Message- >> From: Dongsheng Wang [mailto:dongsheng.w...@freescale.com] >> Sent: Wednesday, August 12, 2015 5:14 PM >> To: ale

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Krzysztof Kozlowski
On 17.08.2015 11:28, Joonyoung Shim wrote: > On 08/17/2015 11:00 AM, Krzysztof Kozlowski wrote: >> On 17.08.2015 10:47, Joonyoung Shim wrote: >>> Hi, >>> >>> On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: > According to datasheet, the S2

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
On 08/17/2015 11:00 AM, Krzysztof Kozlowski wrote: > On 17.08.2015 10:47, Joonyoung Shim wrote: >> Hi, >> >> On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: >>> W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: According to datasheet, the S2MPS13X and S2MPS14X should update write buffer

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Krzysztof Kozlowski
On 17.08.2015 10:47, Joonyoung Shim wrote: > Hi, > > On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: >> W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >>> According to datasheet, the S2MPS13X and S2MPS14X should update write >>> buffer via setting WUDR bit to high after ctrl register is updat

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
Hi, On 08/13/2015 07:02 PM, Krzysztof Kozlowski wrote: > W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. > > Hi, > > I cannot find this information in

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-16 Thread Joonyoung Shim
On 08/13/2015 07:42 PM, Krzysztof Kozlowski wrote: > W dniu 13.08.2015 o 19:02, Krzysztof Kozlowski pisze: >> W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >>> According to datasheet, the S2MPS13X and S2MPS14X should update write >>> buffer via setting WUDR bit to high after ctrl register is upd

Re: [rtc-linux] [PATCH] rtc: s5m: fix to update ctrl register

2015-08-13 Thread Krzysztof Kozlowski
W dniu 13.08.2015 o 19:02, Krzysztof Kozlowski pisze: > W dniu 13.08.2015 o 17:49, Joonyoung Shim pisze: >> According to datasheet, the S2MPS13X and S2MPS14X should update write >> buffer via setting WUDR bit to high after ctrl register is updated. > > Hi, > > I cannot find this information in S2

  1   2   3   4   5   >