-Original Message-
From: Randy Dunlap [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 11, 2007 4:02 PM
To: Agarwal, Lomesh
Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
Subject: Re: TPM driver changes to support multiple locality
On Thu, 11 Oct 2007 15:46:03 -0700 Agarwal
On Thu, 11 Oct 2007 15:46:03 -0700 Agarwal, Lomesh wrote:
> Attached is the patch which resolves all the comments.
Inline patches are preferred so that reviewers can comment on them
more easily.
What mail client are you using?
The patch has trailing CRs on each line ("DOS mode").
~
Attached is the patch which resolves all the comments.
tpm_tis.c.patch
Description: tpm_tis.c.patch
-Original Message-
From: Arjan van de Ven [mailto:[EMAIL PROTECTED]
Sent: Thursday, October 11, 2007 2:41 PM
To: Agarwal, Lomesh
Cc: [EMAIL PROTECTED]; linux-kernel@vger.kernel.org
Subject: Re: TPM driver changes to support multiple locality
On Thu, 11 Oct 2007 11:33:35 -0700
"Ag
On Thu, 11 Oct 2007 11:33:35 -0700
"Agarwal, Lomesh" <[EMAIL PROTECTED]> wrote:
> Below is the patch for TPM driver.
> Comments/suggestions?
please don't top post
>
> --- pristine-linux-2.6.18/drivers/char/tpm/tpm_tis.c 2006-09-19
> 20:42:06.0 -0700
> +++ linux-2.6.18-xen/drivers/char/
On Thu, 11 Oct 2007 14:08:17 -0700 Agarwal, Lomesh wrote:
> Here is info. -
>
> This patch adds multiple locality support in tpm_tis driver.
whatever that means. I guess anyone who is familiar with TPM
knows what it means, and others can do research to find out.
Or the patch description could
functions. That's why it is global. Locality
parameter is initialized with 0 just to be safe. Are all the global
variables in driver is guaranteed to be init 0? Even if it is it doesn't
hurt to init it.
-Original Message-
From: Randy Dunlap [mailto:[EMAIL PROTECTED]
Sent: Thursda
On Oct 11 2007 11:54, Randy Dunlap wrote:
>On Thu, 11 Oct 2007 11:33:35 -0700 Agarwal, Lomesh wrote:
>
>> Below is the patch for TPM driver.
>> Comments/suggestions?
>
>Observe/use kernel coding style.
>Run the patch thru scripts/checkpatch.pl and check its suggestions.
>Use "diffstat -p1 -w70" an
On Thu, 11 Oct 2007 11:33:35 -0700 Agarwal, Lomesh wrote:
> Below is the patch for TPM driver.
> Comments/suggestions?
Observe/use kernel coding style.
Run the patch thru scripts/checkpatch.pl and check its suggestions.
Use "diffstat -p1 -w70" and put that summary near the top of the
patch (after
- } else
+ kfree(devname);
+ }
+ else
pnp_unregister_driver(&tis_pnp_driver);
}
-Original Message-
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]
Sent: Wednesday, October 10, 2007 12:46 PM
To: Agarwal, Lomesh
Cc: linux-kernel@v
lto:[EMAIL PROTECTED]
Sent: Wednesday, October 10, 2007 12:46 PM
To: Agarwal, Lomesh
Cc: linux-kernel@vger.kernel.org
Subject: Re: TPM driver changes to support multiple locality
On Tue, 09 Oct 2007 15:51:11 PDT, "Agarwal, Lomesh" said:
> Current TPM driver supports only locality
On Tue, 09 Oct 2007 15:51:11 PDT, "Agarwal, Lomesh" said:
> Current TPM driver supports only locality 0. I am planning to add
> support so that it can access any locality. Locality parameter will be
> passed as parameter. Will this change be acceptable? If yes then I will
> modify the driver and se
12 matches
Mail list logo
