Re: [PATCH v4 6/7] modpost: Add modname to mod_device_table alias

2025-06-21 Thread Miguel Ojeda
On Sat, Jun 21, 2025 at 3:57 PM Alexey Gladkov wrote: > > +/* Format: __mod_device_table__kmod_ */ Should we mention that `__kmod_` and `__` will be the search strings, or otherwise the Rust formatting (i.e. that is carries a line etc.)? Cc'ing Tomo: do we need an update on `rust/kernel/net/

Re: [PATCH v4 6/7] modpost: Add modname to mod_device_table alias

2025-06-21 Thread Miguel Ojeda
On Sat, Jun 21, 2025 at 3:57 PM Alexey Gladkov wrote: > > rust/kernel/device_id.rs | 8 Cc'ing maintainers and list. Cheers, Miguel

Re: [PATCH 3/4] ARM: dts: qcom: msm8974: Sort header includes alphabetically

2025-06-21 Thread Konrad Dybcio
On 6/21/25 3:19 PM, Luca Weiss wrote: > Before adding more headers in a random order, let's sort the includes > once so that's done. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Konrad Dybcio Konrad

Re: [PATCH 1/2] LICENSES: refresh FSF GFDL/GPL licences

2025-06-21 Thread Xose Vazquez Perez
On 6/21/25 9:20 AM, Greg Kroah-Hartman wrote: You also changed whitespace and some terms, and did not describe that here, why? This license text comes from the SPDX repo, why not use that instead? Or better yet, _JUST_ change the address, if that is correct with what the FSF has published, and

Re: [PATCH 3/4] selftests/nolibc: rename Makefile

2025-06-21 Thread Thomas Weißschuh
On 2025-06-21 06:14:21+0200, Willy Tarreau wrote: > Hi Thomas, > > On Fri, Jun 20, 2025 at 11:39:32PM +0200, Thomas Weißschuh wrote: > > The nolibc tests are not real kselftests, they work differently and > > provide a different interface. Users trying to use them like real > > selftests may be co

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-21 Thread Konrad Dybcio
On 6/20/25 11:51 PM, Cristian Cozzolino via B4 Relay wrote: > From: Cristian Cozzolino > > Billion Capture+ (flipkart,rimob) is a smartphone released in 2017, based > on Snapdragon 625 (MSM8953) SoC. > > Add a device tree with initial support for: > > - GPIO keys > - SDHCI (internal and externa

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-21 Thread Konrad Dybcio
m,qseecom"; >>     reg = <0x84a0 0x190>; >> ... >> >> If you confirm what you suggest, 'qseecom' reserved-memory node will look >> like the following: >> >>     qseecom_mem: qseecom@84a0 { &g

Re: [PATCH v2] ARM: dts: qcom: msm8974-samsung-hlte: Add touchkey support

2025-06-21 Thread Konrad Dybcio
On 6/18/25 11:45 PM, Luca Weiss wrote: > From: Adam Honse > > Add support for the touchkeys on the Samsung Galaxy Note 3 (hlte). > > Signed-off-by: Adam Honse > Signed-off-by: Luca Weiss > --- > Changes in v2: > - Fix schema validation failure, adjust i2c-gpio node name > - Fix misplaced S-o-b

Re: [PATCH 3/4] selftests/nolibc: rename Makefile

2025-06-21 Thread Willy Tarreau
On Sat, Jun 21, 2025 at 10:34:38AM +0200, Thomas Weißschuh wrote: > On 2025-06-21 06:14:21+0200, Willy Tarreau wrote: > > Hi Thomas, > > > > On Fri, Jun 20, 2025 at 11:39:32PM +0200, Thomas Weißschuh wrote: > > > The nolibc tests are not real kselftests, they work differently and > > > provide a d

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-21 Thread Luca Weiss
no-map; }; [1] https://www.kernel.org/doc/Documentation/devicetree/bindings/reserved-memory/reserved-memory.yaml The name (qseecom@84a0) mostly does not matter at runtime, it's just a nice label we give it. The reg is the important bit that gets used

Re: [PATCH 1/2] LICENSES: refresh FSF GFDL/GPL licences

2025-06-21 Thread Greg Kroah-Hartman
On Sat, Jun 21, 2025 at 03:21:13AM +0200, Xose Vazquez Perez wrote: > Old licences have been modified, because FSF postal address was changed: > https://lists.gnu.org/archive/html/info-gnu/2024-09/msg0.html > https://www.fsf.org/blogs/community/fsf-office-closing-party > https://www.fsf.org/abo

Re: [PATCH 2/2] LICENSES: refresh FSF LGPL licences

2025-06-21 Thread Greg Kroah-Hartman
On Sat, Jun 21, 2025 at 03:21:14AM +0200, Xose Vazquez Perez wrote: > Old licences have been modified, because FSF postal address was changed: > https://lists.gnu.org/archive/html/info-gnu/2024-09/msg0.html > https://www.fsf.org/blogs/community/fsf-office-closing-party > https://www.fsf.org/abo

Re: [PATCH 3/4] selftests/nolibc: rename Makefile

2025-06-20 Thread Willy Tarreau
Hi Thomas, On Fri, Jun 20, 2025 at 11:39:32PM +0200, Thomas Weißschuh wrote: > The nolibc tests are not real kselftests, they work differently and > provide a different interface. Users trying to use them like real > selftests may be confused and the tests are not executed by CI systems. > > To m

Re: [PATCH 3/3] arm64: dts: qcom: msm8953: Add device tree for Billion Capture+

2025-06-20 Thread Luca Weiss
Hi Cristian, On 20-06-2025 11:51 p.m., Cristian Cozzolino via B4 Relay wrote: From: Cristian Cozzolino Billion Capture+ (flipkart,rimob) is a smartphone released in 2017, based on Snapdragon 625 (MSM8953) SoC. Add a device tree with initial support for: - GPIO keys - SDHCI (internal and exte

Re: [PATCH net 1/3] vsock: Fix transport_{h2g,g2h} TOCTOU

2025-06-20 Thread Michal Luczaj
On 6/20/25 16:43, Stefano Garzarella wrote: > On Fri, 20 Jun 2025 at 16:23, Michal Luczaj wrote: >> >> On 6/20/25 15:20, Stefano Garzarella wrote: >>> On Fri, Jun 20, 2025 at 02:58:49PM +0200, Michal Luczaj wrote: On 6/20/25 10:32, Stefano Garzarella wrote: > On Wed, Jun 18, 2025 at 02:34

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-20 Thread Chen Linxuan
On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum wrote: > > On 6/20/25 8:50 AM, Chen Linxuan wrote: > > When running `make kselftest`, the following compilation warning was > > encountered: > > > > mount-notify_test.c: In function ‘fanotify_rmdir’: > > mount-notify_test.c:490:17: warning: ig

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-20 Thread Dev Jain
On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wrote: On 18/06/25 7:37 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:28:16PM +0530, Dev Jai

Re: [PATCH bpf-next v4 1/2] bpftool: Use appropriate permissions for map access

2025-06-20 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Alexei Starovoitov : On Sat, 21 Jun 2025 01:18:11 +1000 you wrote: > Modify several functions in tools/bpf/bpftool/common.c to allow > specification of requested access for file descriptors, such as > read-only access. > > Update bpf

Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

2025-06-20 Thread Matthew Wilcox
On Fri, Jun 20, 2025 at 08:22:49PM +0530, Shivank Garg wrote: > > > On 6/20/2025 8:04 PM, Matthew Wilcox wrote: > > On Fri, Jun 20, 2025 at 11:29:20AM +0530, Shivank Garg wrote: > >> filemap_grab_folio_mpol() is used in [Patch 6/7] in > >> kvm_gmem_prepare_folio(). > >> > >> filemap_alloc_folio_

Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

2025-06-20 Thread Shivank Garg
On 6/20/2025 8:04 PM, Matthew Wilcox wrote: > On Fri, Jun 20, 2025 at 11:29:20AM +0530, Shivank Garg wrote: >> filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio(). >> >> filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally >> used >> to support the

Re: [PATCH RFC 03/14] mm: compare pfns only if the entry is present when inserting pfns/pages

2025-06-20 Thread Pedro Falcato
On Tue, Jun 17, 2025 at 05:43:34PM +0200, David Hildenbrand wrote: > Doing a pte_pfn() etc. of something that is not a present page table > entry is wrong. Let's check in all relevant cases where we want to > upgrade write permissions when inserting pfns/pages whether the entry > is actually presen

Re: [PATCH v3] media: add virtio-media driver

2025-06-20 Thread Alexandre Courbot
Hi Mauro, Really appreciating the time you are spending reviewing and testing this! m(__)m Thanks also for sharing your script, I've learned a few things I didn't know about crosvm. :P On Thu Jun 19, 2025 at 12:05 AM JST, Mauro Carvalho Chehab wrote: >> > Found how to setup cpus and memory, but

Re: [PATCH RFC 03/14] mm: compare pfns only if the entry is present when inserting pfns/pages

2025-06-20 Thread Oscar Salvador
On Tue, Jun 17, 2025 at 05:43:34PM +0200, David Hildenbrand wrote: > Doing a pte_pfn() etc. of something that is not a present page table > entry is wrong. Let's check in all relevant cases where we want to > upgrade write permissions when inserting pfns/pages whether the entry > is actually presen

Re: [PATCH v3 1/6] mm: userfaultfd: generic continue for non hugetlbfs

2025-06-20 Thread Nikita Kalyazin
On 20/06/2025 16:21, Peter Xu wrote: Hi, Nikita, On Fri, Jun 20, 2025 at 01:00:24PM +0100, Nikita Kalyazin wrote: Thanks for explaining that. I played a bit with it myself and it appears to be working for the MISSING mode for both shmem and guest_memfd. Attaching [1] my sketch below.

Re: [PATCH RFC 02/14] mm: drop highest_memmap_pfn

2025-06-20 Thread Pedro Falcato
On Tue, Jun 17, 2025 at 05:43:33PM +0200, David Hildenbrand wrote: > Now unused, so let's drop it. > > Signed-off-by: David Hildenbrand Reviewed-by: Pedro Falcato -- Pedro

Re: [PATCH 2/2] filemap: Add __filemap_get_folio_mpol()

2025-06-20 Thread Matthew Wilcox
On Fri, Jun 20, 2025 at 03:34:47PM +0100, Matthew Wilcox (Oracle) wrote: > +struct folio *__filemap_get_folio_mpol(struct address_space *mapping, > + pgoff_t index, fgf_t fgp_flags, gfp_t gfp, > + struct mempolicy *policy) > { > struct folio *folio; > > @@ -1982,7 +

Re: [PATCH net-next RFC] selftests: net: add netpoll basic functionality test

2025-06-20 Thread Breno Leitao
On Fri, Jun 13, 2025 at 05:42:33PM -0700, Jakub Kicinski wrote: > On Fri, 13 Jun 2025 05:47:50 -0700 Breno Leitao wrote: > > > Or is there another way that the packets could be observed, e.g., > > > counters. > > > > Unfortunately netpoll doesn't expose any data, thus, it is hard to get > > it.

Re: [PATCH net 1/3] vsock: Fix transport_{h2g,g2h} TOCTOU

2025-06-20 Thread Stefano Garzarella
On Fri, Jun 20, 2025 at 02:58:49PM +0200, Michal Luczaj wrote: On 6/20/25 10:32, Stefano Garzarella wrote: On Wed, Jun 18, 2025 at 02:34:00PM +0200, Michal Luczaj wrote: Checking transport_{h2g,g2h} != NULL may race with vsock_core_unregister(). Make sure pointers remain valid. KASAN: null-ptr

Re: [RESEND PATCH v13 3/3] selftests/rseq: Add test for mm_cid compaction

2025-06-20 Thread Mathieu Desnoyers
On 2025-06-20 13:20, Gabriele Monaco wrote: 2025-06-18T21:04:30Z Shuah Khan : On 6/13/25 03:12, Gabriele Monaco wrote: A task in the kernel (task_mm_cid_work) runs somewhat periodically to compact the mm_cid for each process. Add a test to validate that it runs correctly and timely. The test s

Re: [RESEND PATCH v13 3/3] selftests/rseq: Add test for mm_cid compaction

2025-06-20 Thread Gabriele Monaco
2025-06-18T21:04:30Z Shuah Khan : > On 6/13/25 03:12, Gabriele Monaco wrote: >> A task in the kernel (task_mm_cid_work) runs somewhat periodically to >> compact the mm_cid for each process. Add a test to validate that it runs >> correctly and timely. >> The test spawns 1 thread pinned to each CPU,

Re: [RFC PATCH 01/20] nvdimm/label: Introduce NDD_CXL_LABEL flag to set cxl label format

2025-06-20 Thread Jonathan Cameron
On Tue, 17 Jun 2025 18:09:25 +0530 Neeraj Kumar wrote: > NDD_CXL_LABEL is introduced to set cxl LSA 2.1 label format > Accordingly updated label index version > > Signed-off-by: Neeraj Kumar A few local comments. I'll need to read on to figure out how this fits in generally. > --- > drivers/

Re: [PATCH bpf-next v4 2/2] selftests/bpf: Add test for bpftool access to read-only protected maps

2025-06-20 Thread Quentin Monnet
2025-06-21 01:18 UTC+1000 ~ Slava Imameev > Add selftest cases that validate bpftool's expected behavior when > accessing maps protected from modification via security_bpf_map. > > The test includes a BPF program attached to security_bpf_map with two maps: > - A protected map that only allows rea

Re: [PATCH bpf-next v4 1/2] bpftool: Use appropriate permissions for map access

2025-06-20 Thread Quentin Monnet
2025-06-21 01:18 UTC+1000 ~ Slava Imameev > Modify several functions in tools/bpf/bpftool/common.c to allow > specification of requested access for file descriptors, such as > read-only access. > > Update bpftool to request only read access for maps when write > access is not required. This fixes

Re: [PATCH v3 1/6] mm: userfaultfd: generic continue for non hugetlbfs

2025-06-20 Thread Peter Xu
Hi, Nikita, On Fri, Jun 20, 2025 at 01:00:24PM +0100, Nikita Kalyazin wrote: > Thanks for explaining that. I played a bit with it myself and it appears to > be working for the MISSING mode for both shmem and guest_memfd. Attaching [1] > my sketch below. Please let me know if this is how you s

Re: [PATCH net-next v5] page_pool: import Jesper's page_pool benchmark

2025-06-20 Thread Toke Høiland-Jørgensen
Mina Almasry writes: > From: Jesper Dangaard Brouer > > We frequently consult with Jesper's out-of-tree page_pool benchmark to > evaluate page_pool changes. > > Import the benchmark into the upstream linux kernel tree so that (a) > we're all running the same version, (b) pave the way for shared

Re: [PATCH] selftests/mm: Fix validate_addr helper

2025-06-20 Thread Donet Tom
On 6/20/25 4:41 PM, Dev Jain wrote: validate_addr() function checks whether the address returned by mmap() lies in the low or high VA space, according to whether a high addr hint was passed or not. The fix commit mentioned below changed the code in such a way that this function will always retu

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-20 Thread Muhammad Usama Anjum
On 6/20/25 8:50 AM, Chen Linxuan wrote: > When running `make kselftest`, the following compilation warning was > encountered: > > mount-notify_test.c: In function ‘fanotify_rmdir’: > mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ > declared with attribute ‘warn_unused_resu

Re: [PATCH] selftests/filesystems/mount-notify: remove __kernel_fsid_t

2025-06-20 Thread Muhammad Usama Anjum
On 6/20/25 8:43 AM, Chen Linxuan wrote: > When build kernel selftests on Ubuntu 24.04, I got a compiler error: > > mount-notify_test.c:22:3: error: conflicting types for ‘__kernel_fsid_t’; > have ‘struct ’ >22 | } __kernel_fsid_t; > | ^~~ > In file included from .../linux/

Re: [PATCH net 1/3] vsock: Fix transport_{h2g,g2h} TOCTOU

2025-06-20 Thread Stefano Garzarella
On Fri, 20 Jun 2025 at 16:23, Michal Luczaj wrote: > > On 6/20/25 15:20, Stefano Garzarella wrote: > > On Fri, Jun 20, 2025 at 02:58:49PM +0200, Michal Luczaj wrote: > >> On 6/20/25 10:32, Stefano Garzarella wrote: > >>> On Wed, Jun 18, 2025 at 02:34:00PM +0200, Michal Luczaj wrote: > Checkin

Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

2025-06-20 Thread Matthew Wilcox
On Fri, Jun 20, 2025 at 11:29:20AM +0530, Shivank Garg wrote: > filemap_grab_folio_mpol() is used in [Patch 6/7] in kvm_gmem_prepare_folio(). > > filemap_alloc_folio_mpol() and __filemap_get_folio_mpol()) are internally used > to support the filemap_grab_folio_mpol(). That's not better. We don't

Re: [PATCH net 1/3] vsock: Fix transport_{h2g,g2h} TOCTOU

2025-06-20 Thread Michal Luczaj
On 6/20/25 15:20, Stefano Garzarella wrote: > On Fri, Jun 20, 2025 at 02:58:49PM +0200, Michal Luczaj wrote: >> On 6/20/25 10:32, Stefano Garzarella wrote: >>> On Wed, Jun 18, 2025 at 02:34:00PM +0200, Michal Luczaj wrote: Checking transport_{h2g,g2h} != NULL may race with vsock_core_unregiste

Re: [PATCH RFC 04/14] mm/huge_memory: move more common code into insert_pmd()

2025-06-20 Thread Oscar Salvador
On Tue, Jun 17, 2025 at 05:43:35PM +0200, David Hildenbrand wrote: > Let's clean it all further up. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador I was thinking maybe we want to pass 'struct vm_fault' directly to insert_pmd(), and retrieve the fields in there, but since you

Re: [PATCH net 1/3] vsock: Fix transport_{h2g,g2h} TOCTOU

2025-06-20 Thread Michal Luczaj
On 6/20/25 10:32, Stefano Garzarella wrote: > On Wed, Jun 18, 2025 at 02:34:00PM +0200, Michal Luczaj wrote: >> Checking transport_{h2g,g2h} != NULL may race with vsock_core_unregister(). >> Make sure pointers remain valid. >> >> KASAN: null-ptr-deref in range [0x0118-0x011f

Re: [PATCH RFC 05/14] mm/huge_memory: move more common code into insert_pud()

2025-06-20 Thread Oscar Salvador
On Tue, Jun 17, 2025 at 05:43:36PM +0200, David Hildenbrand wrote: > Let's clean it all further up. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs

Re: [PATCH 2/3] selftests/nolibc: use file driver for QEMU serial

2025-06-20 Thread Willy Tarreau
rd initramfs.cpio -serial stdio $(QEMU_ARGS) > > "$(CURDIR)/run.out" > + $(Q)qemu-system-$(QEMU_ARCH) -display none -no-reboot -kernel > "$(IMAGE)" -initrd initramfs.cpio -serial file:/dev/stdout $(QEMU_ARGS) > > "$(CURDIR)/run.out" > $(Q)$

Re: [PATCH RFC 02/14] mm: drop highest_memmap_pfn

2025-06-20 Thread Oscar Salvador
On Tue, Jun 17, 2025 at 05:43:33PM +0200, David Hildenbrand wrote: > Now unused, so let's drop it. > > Signed-off-by: David Hildenbrand Reviewed-by: Oscar Salvador -- Oscar Salvador SUSE Labs

Re: [PATCH net 3/3] vsock: Fix transport_* TOCTOU

2025-06-20 Thread Michal Luczaj
On 6/20/25 10:37, Stefano Garzarella wrote: >> -if (!new_transport || !try_module_get(new_transport->module)) >> -return -ENODEV; >> +if (!new_transport || !try_module_get(new_transport->module)) { >> +ret = -ENODEV; >> +goto unlock; >> +} >> + > > I

Re: [PATCH RFC 01/14] mm/memory: drop highest_memmap_pfn sanity check in vm_normal_page()

2025-06-20 Thread Oscar Salvador
On Tue, Jun 17, 2025 at 05:43:32PM +0200, David Hildenbrand wrote: > In 2009, we converted a VM_BUG_ON(!pfn_valid(pfn)) to the current > highest_memmap_pfn sanity check in commit 22b31eec63e5 ("badpage: > vm_normal_page use print_bad_pte"), because highest_memmap_pfn was > readily available. > > N

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-20 Thread Benno Lossin
On Fri Jun 20, 2025 at 1:29 PM CEST, Andreas Hindborg wrote: > "Benno Lossin" writes: >> On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: >>> +/// A wrapper for kernel parameters. >>> +/// >>> +/// This type is instantiated by the [`module!`] macro when module >>> parameters are >>> +

Re: [PATCH net 3/3] vsock: Fix transport_* TOCTOU

2025-06-20 Thread Stefano Garzarella
On Wed, Jun 18, 2025 at 02:34:02PM +0200, Michal Luczaj wrote: Transport assignment may race with module unload. Protect new_transport from becoming a stale pointer. This also takes care of an insecure call in vsock_use_local_transport(); add a lockdep assert. BUG: unable to handle page fault f

Re: [PATCH] selftests/mm: Fix validate_addr helper

2025-06-20 Thread Dev Jain
On 20/06/25 4:41 pm, Dev Jain wrote: validate_addr() function checks whether the address returned by mmap() lies in the low or high VA space, according to whether a high addr hint was passed or not. The fix commit mentioned below changed the code in such a way that this function will always ret

Re: [PATCH v3 1/6] mm: userfaultfd: generic continue for non hugetlbfs

2025-06-20 Thread Nikita Kalyazin
On 11/06/2025 13:56, Peter Xu wrote: On Wed, Jun 11, 2025 at 01:09:32PM +0100, Nikita Kalyazin wrote: On 10/06/2025 23:22, Peter Xu wrote: On Fri, Apr 04, 2025 at 03:43:47PM +, Nikita Kalyazin wrote: Remove shmem-specific code from UFFDIO_CONTINUE implementation for non-huge pages by cal

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-20 Thread Andreas Hindborg
Andreas Hindborg writes: > "Benno Lossin" writes: > >> On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: >>> +/// A wrapper for kernel parameters. >>> +/// >>> +/// This type is instantiated by the [`module!`] macro when module >>> parameters are >>> +/// defined. You should never ne

Re: [PATCH v4 0/3] rpmsg: Introduce RPMSG_CREATE_EPT_FD_IOCTL uAPI

2025-06-20 Thread Arnaud POULIQUEN
On 6/19/25 16:43, Dawei Li wrote: > Hi Arnaud, > Thanks for review. > > On Wed, Jun 18, 2025 at 03:07:36PM +0200, Arnaud POULIQUEN wrote: >> Hello Dawei, >> >> >> Please find a few comments below. It is not clear to me which parts of your >> implementation are mandatory and which are optional

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-20 Thread Andreas Hindborg
"Benno Lossin" writes: > On Thu Jun 19, 2025 at 2:20 PM CEST, Andreas Hindborg wrote: >> "Benno Lossin" writes: >>> On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: [...] +crate::error::from_result(|| { +let new_value = T::try_from_param_arg(arg)?; +

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-20 Thread Andreas Hindborg
"Benno Lossin" writes: > On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: >> +/// A wrapper for kernel parameters. >> +/// >> +/// This type is instantiated by the [`module!`] macro when module >> parameters are >> +/// defined. You should never need to instantiate this type directly

Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

2025-06-20 Thread Vlastimil Babka
On 6/20/25 07:59, Shivank Garg wrote: > > > On 6/19/2025 9:33 PM, Matthew Wilcox wrote: >> On Wed, Jun 18, 2025 at 11:29:31AM +, Shivank Garg wrote: >>> From: Shivansh Dhiman >>> >>> Add NUMA mempolicy support to the filemap allocation path by introducing >>> new APIs that take a mempolicy a

Re: [PATCH 3/3] kunit: test: Drop CONFIG_MODULE ifdeffery

2025-06-20 Thread David Gow
On Thu, 12 Jun 2025 at 22:54, Thomas Weißschuh wrote: > > The function stubs exposed by module.h allow the code to compile properly > without the ifdeffery. The generated object code stays the same, as the > compiler can optimize away all the dead code. > As the code is still typechecked developer

Re: [PATCH net 1/3] vsock: Fix transport_{h2g,g2h} TOCTOU

2025-06-20 Thread Stefano Garzarella
On Wed, Jun 18, 2025 at 02:34:00PM +0200, Michal Luczaj wrote: Checking transport_{h2g,g2h} != NULL may race with vsock_core_unregister(). Make sure pointers remain valid. KASAN: null-ptr-deref in range [0x0118-0x011f] RIP: 0010:vsock_dev_do_ioctl.isra.0+0x58/0xf0 Call Tr

Re: [PATCH] selftests/nolibc: make stackprotector probing more robust

2025-06-20 Thread Willy Tarreau
On Mon, Jun 09, 2025 at 09:39:16AM +0200, Thomas Weißschuh wrote: > nolibc only supports symbol-based stackprotectors, based on the global > variable __stack_chk_guard. Support for this differs between > architectures and toolchains. Some use the symbol mode by default, some > require a flag to ena

Re: [RFC 0/6] Add multiple address spaces support to VDUSE

2025-06-19 Thread Eugenio Perez Martin
On Mon, Jun 9, 2025 at 7:51 AM Christoph Hellwig wrote: > > Before you add new features to vduse, please remove the broken abuse of > the DMA API first. Without that no new feature work should go into > this code. > Hi Christoph, This code does not touch the DMA API at all. Actually, we could e

Re: [PATCH 1/2] selftests: khugepaged: fix the shmem collapse failure

2025-06-19 Thread Mario Casquero
This patch has been successfully tested. All the khugepaged shmem tests passed. # ./khugepaged khugepaged:shmem Save THP and khugepaged settings... OK Allocate huge page on fault... OK Split huge PMD on MADV_DONTNEED... OK Run test: collapse_full (khugepaged:shmem) Collapse multiple fully populat

Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

2025-06-19 Thread Shivank Garg
On 6/19/2025 9:33 PM, Matthew Wilcox wrote: > On Wed, Jun 18, 2025 at 11:29:31AM +, Shivank Garg wrote: >> From: Shivansh Dhiman >> >> Add NUMA mempolicy support to the filemap allocation path by introducing >> new APIs that take a mempolicy argument: >> - filemap_grab_folio_mpol() >> - fil

Re: [PATCH v2] refscale: Add tests for local_irq_disable() vs local_interrupt_disable()

2025-06-19 Thread kernel test robot
Hi Joel, kernel test robot noticed the following build errors: [auto build test ERROR on rcu/rcu/dev] [also build test ERROR on linus/master v6.16-rc2 next-20250619] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as do

Re: [PATCH RESEND] selftests/memfd: clean Makefile

2025-06-19 Thread Chen Linxuan
On Fri, Jun 20, 2025 at 1:02 AM Shuah Khan wrote: > > On 6/19/25 01:43, Chen Linxuan wrote: > > On Thu, Jun 19, 2025 at 5:21 AM Shuah Khan > > wrote: > >> > >> On 6/9/25 20:05, Chen Linxuan wrote: > >>> When writing a test for fusectl, I referred to this Makefile as a > >>> reference for creatin

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Chen Linxuan
On Fri, Jun 20, 2025 at 5:41 AM Shuah Khan wrote: > > On 6/19/25 13:00, John Hubbard wrote: > > On 6/19/25 10:00 AM, Shuah Khan wrote: > >> On 6/19/25 01:46, Chen Linxuan wrote: > >>> On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan > >>> wrote: > On 6/9/25 20:07, Chen Linxuan wrote: > > ... > >>

Re: [PATCH net-next v4 0/4] netdevsim: implement RX statistics using NETDEV_PCPU_STAT_DSTATS

2025-06-19 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 18 Jun 2025 01:32:41 -0700 you wrote: > The netdevsim driver previously lacked RX statistics support, which > prevented its use with the GenerateTraffic() test framework, as this > framework verifies traffic

Re: [PATCH v2 2/2] selftests/bpf: Add testcases for BPF_ADD and BPF_SUB

2025-06-19 Thread Harishankar Vishwanathan
On Thu, Jun 19, 2025 at 5:55 PM Eduard Zingerman wrote: > > On Thu, 2025-06-19 at 17:13 -0400, Harishankar Vishwanathan wrote: > > On Wed, Jun 18, 2025 at 5:22 PM Eduard Zingerman wrote: > > > > > > On Tue, 2025-06-17 at 19:17 -0400, Harishankar Vishwanathan wrote: [...] > Hm, I see, that's an in

Re: [PATCH v2 2/2] selftests/bpf: Add testcases for BPF_ADD and BPF_SUB

2025-06-19 Thread Eduard Zingerman
On Thu, 2025-06-19 at 17:13 -0400, Harishankar Vishwanathan wrote: > On Wed, Jun 18, 2025 at 5:22 PM Eduard Zingerman wrote: > > > > On Tue, 2025-06-17 at 19:17 -0400, Harishankar Vishwanathan wrote: > > > The previous commit improves the precision in scalar(32)_min_max_add, > > > and scalar(32)_

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 15:40, Shuah Khan wrote: On 6/19/25 13:00, John Hubbard wrote: On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests/filesystems

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 13:00, John Hubbard wrote: On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests/filesystems/mount-notify/mount- notify_test.c b

Re: [PATCH v2 2/2] selftests/bpf: Add testcases for BPF_ADD and BPF_SUB

2025-06-19 Thread Harishankar Vishwanathan
On Wed, Jun 18, 2025 at 5:22 PM Eduard Zingerman wrote: > > On Tue, 2025-06-17 at 19:17 -0400, Harishankar Vishwanathan wrote: > > The previous commit improves the precision in scalar(32)_min_max_add, > > and scalar(32)_min_max_sub. The improvement in precision occurs in > > cases when all outcome

Re: [PATCH] remoteproc: debugfs: Replace scnprintf() with sysfs_emit()

2025-06-19 Thread Christophe JAILLET
Le 19/06/2025 à 21:04, Abhinav Ananthu a écrit : I apologize for the mistake in the signed-off email address in the previous patch. Convert the debugfs show() functions in remoteproc_debugfs.c to use sysfs_emit() instead of scnprintf(). The sysfs_emit() helper is the preferred way to format sys

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread John Hubbard
On 6/19/25 10:00 AM, Shuah Khan wrote: On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: ... diff --git a/tools/testing/selftests/filesystems/mount-notify/mount- notify_test.c b/tools/testing/selftests/filesystems/mou

Re: [PATCH RESEND] selftests: Suppress unused variable warning

2025-06-19 Thread Shuah Khan
On 6/19/25 01:46, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:23 AM Shuah Khan wrote: On 6/9/25 20:07, Chen Linxuan wrote: When running `make kselftest`, the following compilation warning was encountered: mount-notify_test.c: In function ‘fanotify_rmdir’: mount-notify_test.c:490:17: warni

Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark

2025-06-19 Thread Mina Almasry
On Thu, Jun 19, 2025 at 9:58 AM Jakub Kicinski wrote: > > On Thu, 19 Jun 2025 08:37:05 -0700 Mina Almasry wrote: > > Jakub, this patch was marked 'changes requested' for good reason, but > > after investigation we found the patch itself is good and the issues > > were elsewhere. What do I do here?

Re: [PATCH RESEND] selftests/memfd: clean Makefile

2025-06-19 Thread Shuah Khan
On 6/19/25 01:43, Chen Linxuan wrote: On Thu, Jun 19, 2025 at 5:21 AM Shuah Khan wrote: On 6/9/25 20:05, Chen Linxuan wrote: When writing a test for fusectl, I referred to this Makefile as a reference for creating a FUSE daemon in the selftests. While doing so, I noticed that there is a minor

Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark

2025-06-19 Thread Jakub Kicinski
On Thu, 19 Jun 2025 08:37:05 -0700 Mina Almasry wrote: > Jakub, this patch was marked 'changes requested' for good reason, but > after investigation we found the patch itself is good and the issues > were elsewhere. What do I do here? A resend of v4? Or does this un > 'changes requested' as-is? Do

Re: [RFC PATCH v8 4/7] mm/mempolicy: Export memory policy symbols

2025-06-19 Thread Vlastimil Babka
On 6/19/25 13:13, Shivank Garg wrote: > > > On 6/18/2025 8:42 PM, Gregory Price wrote: >> On Wed, Jun 18, 2025 at 11:29:32AM +, Shivank Garg wrote: >>> KVM guest_memfd wants to implement support for NUMA policies just like >>> shmem already does using the shared policy infrastructure. As >>>

Re: [PATCH 1/3] module: move 'struct module_use' to internal.h

2025-06-19 Thread Daniel Gomez
On 12/06/2025 16.53, Thomas WeiÃschuh wrote: > The struct was moved to the public header file in > commit c8e21ced08b3 ("module: fix kdb's illicit use of struct module_use."). > Back then the structure was used outside of the module core. > Nowadays this is not true anymore, so the structure can be

Re: [PATCH v2 3/4] scripts/misc-check: check missing #include when W=1

2025-06-19 Thread Jakub Kicinski
On Fri, 20 Jun 2025 01:13:28 +0900 Masahiro Yamada wrote: > > IIUC you made the kernel spew nearly 5000 warnings on every W=1 build > > to "encourage" others to help fix a fairly innocuous problem. > > I appreciate the work that goes into separating the headers but it's > > hardly urgent enough to

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-19 Thread Dev Jain
On 19/06/25 9:01 pm, Donet Tom wrote: eOn Thu, Jun 19, 2025 at 02:32:19PM +0530, Dev Jain wrote: On 19/06/25 1:53 pm, Donet Tom wrote: On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wro

Re: [PATCH v2 3/4] scripts/misc-check: check missing #include when W=1

2025-06-19 Thread Masahiro Yamada
On Fri, Jun 20, 2025 at 1:01 AM Jakub Kicinski wrote: > > On Sun, 1 Jun 2025 22:31:29 +0900 Masahiro Yamada wrote: > > The problem was described in commit 5b20755b7780 ("init: move THIS_MODULE > > from to "). > > > > To summarize it again here: is included by most C files, > > even though only

Re: [PATCH v2 3/4] scripts/misc-check: check missing #include when W=1

2025-06-19 Thread Jakub Kicinski
On Sun, 1 Jun 2025 22:31:29 +0900 Masahiro Yamada wrote: > The problem was described in commit 5b20755b7780 ("init: move THIS_MODULE > from to "). > > To summarize it again here: is included by most C files, > even though only some of them actually export symbols. This is because > some headers

Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

2025-06-19 Thread Matthew Wilcox
On Wed, Jun 18, 2025 at 11:29:31AM +, Shivank Garg wrote: > From: Shivansh Dhiman > > Add NUMA mempolicy support to the filemap allocation path by introducing > new APIs that take a mempolicy argument: > - filemap_grab_folio_mpol() > - filemap_alloc_folio_mpol() > - __filemap_get_folio_mpol()

Re: [PATCH net-next v4] page_pool: import Jesper's page_pool benchmark

2025-06-19 Thread Mina Almasry
On Thu, Jun 19, 2025 at 3:24 AM Jesper Dangaard Brouer wrote: > > Does this alleviate your concern? Or do you still see an issue here? > > There is still a delta between our results, on different > > hardware/configs but results are in a sane range now. > > Now the results a sane and in range :-)

Re: [PATCH 1/6] mm/selftests: Fix virtual_address_range test issues.

2025-06-19 Thread Donet Tom
eOn Thu, Jun 19, 2025 at 02:32:19PM +0530, Dev Jain wrote: > > On 19/06/25 1:53 pm, Donet Tom wrote: > > On Wed, Jun 18, 2025 at 08:13:54PM +0530, Dev Jain wrote: > > > On 18/06/25 8:05 pm, Lorenzo Stoakes wrote: > > > > On Wed, Jun 18, 2025 at 07:47:18PM +0530, Dev Jain wrote: > > > > > On 18/06/

Re: [PATCH net 1/2] virtio-net: xsk: rx: fix the frame's length check

2025-06-19 Thread Jakub Kicinski
On Thu, 19 Jun 2025 21:17:03 +0700 Bui Quang Minh wrote: > > I think Michael mention he's AFK so while we wait could you fix this > > kdoc? I'm not sure whether the kdoc is really necessary here, but if > > you want to keep it you have to document the return value: > > > > Warning: drivers/net/virt

Re: [RFC PATCH v8 3/7] mm/filemap: Add mempolicy support to the filemap layer

2025-06-19 Thread Vlastimil Babka
On 6/18/25 13:29, Shivank Garg wrote: > From: Shivansh Dhiman > > Add NUMA mempolicy support to the filemap allocation path by introducing > new APIs that take a mempolicy argument: > - filemap_grab_folio_mpol() > - filemap_alloc_folio_mpol() > - __filemap_get_folio_mpol() > > These APIs allow c

Re: [PATCH v4 0/3] rpmsg: Introduce RPMSG_CREATE_EPT_FD_IOCTL uAPI

2025-06-19 Thread Dawei Li
Hi Arnaud, Thanks for review. On Wed, Jun 18, 2025 at 03:07:36PM +0200, Arnaud POULIQUEN wrote: > Hello Dawei, > > > Please find a few comments below. It is not clear to me which parts of your > implementation are mandatory and which are optional "nice-to-have" > optimizations. It's more like

Re: [PATCH net 1/2] virtio-net: xsk: rx: fix the frame's length check

2025-06-19 Thread Bui Quang Minh
On 6/19/25 09:11, Jakub Kicinski wrote: On Sun, 15 Jun 2025 22:13:32 +0700 Bui Quang Minh wrote: +/** + * buf_to_xdp() - convert the @buf context to xdp_buff + * @vi: virtnet_info struct + * @rq: the receive queue struct + * @buf: the xdp_buff pointer that is passed to virtqueue_add_inbuf_premap

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-19 Thread Benno Lossin
On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: > +/// A wrapper for kernel parameters. > +/// > +/// This type is instantiated by the [`module!`] macro when module > parameters are > +/// defined. You should never need to instantiate this type directly. > +/// > +/// Note: This type

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-19 Thread Benno Lossin
On Thu Jun 19, 2025 at 2:20 PM CEST, Andreas Hindborg wrote: > "Benno Lossin" writes: >> On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: >>> + >>> +// SAFETY: C kernel handles serializing access to this type. We never >>> access it >>> +// from Rust module. >>> +unsafe impl Sync for

Re: [PATCH v13 1/6] rust: str: add radix prefixed integer parsing functions

2025-06-19 Thread Andreas Hindborg
"Benno Lossin" writes: > On Thu Jun 19, 2025 at 1:12 PM CEST, Andreas Hindborg wrote: >> I'm having a difficult time parsing. Are you suggesting that we guard >> against implementations of `TryInto` that misbehave? > > Let me try a different explanation: > > The safety requirement for implementin

Re: [PATCH v13 4/6] rust: module: update the module macro with module parameter support

2025-06-19 Thread Andreas Hindborg
"Benno Lossin" writes: > On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: >> + >> +fn emit_params(&mut self, info: &ModuleInfo) { >> +let Some(params) = &info.params else { >> +return; >> +}; >> + >> +for param in params { >> +let op

Re: [PATCH v13 1/6] rust: str: add radix prefixed integer parsing functions

2025-06-19 Thread Benno Lossin
On Thu Jun 19, 2025 at 1:12 PM CEST, Andreas Hindborg wrote: > I'm having a difficult time parsing. Are you suggesting that we guard > against implementations of `TryInto` that misbehave? Let me try a different explanation: The safety requirement for implementing the `FromStrRadix`: /// The

Re: [PATCH v13 2/6] rust: introduce module_param module

2025-06-19 Thread Andreas Hindborg
the `Copy` bound. What would be the benefit of using `ptr::write`? They should be equivalent for `Copy` types, right. I was using `ptr::replace`, but Alice suggested the pace expression assignment instead, since I was not using the old value. > >> +Ok(0) >> +}) >> +} >

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-06-19 Thread Marc Zyngier
On Thu, 19 Jun 2025 10:40:15 +0100, Ganapatrao Kulkarni wrote: > > > [Sorry for late reply] > > On 5/29/2025 5:18 PM, Marc Zyngier wrote: > > On Thu, 29 May 2025 11:29:58 +0100, > > Ganapatrao Kulkarni wrote: > >> > >> > >> Hi Eric, > >> > >> On 5/28/2025 6:58 PM, Eric Auger wrote: > >>> Hi

Re: [RFC PATCH v8 4/7] mm/mempolicy: Export memory policy symbols

2025-06-19 Thread Shivank Garg
On 6/18/2025 8:42 PM, Gregory Price wrote: > On Wed, Jun 18, 2025 at 11:29:32AM +, Shivank Garg wrote: >> KVM guest_memfd wants to implement support for NUMA policies just like >> shmem already does using the shared policy infrastructure. As >> guest_memfd currently resides in KVM module cod

Re: [PATCH v13 1/6] rust: str: add radix prefixed integer parsing functions

2025-06-19 Thread Andreas Hindborg
"Benno Lossin" writes: > On Thu Jun 12, 2025 at 3:40 PM CEST, Andreas Hindborg wrote: >> +pub trait ParseInt: private::FromStrRadix + TryFrom { >> +/// Parse a string according to the description in [`Self`]. >> +fn from_str(src: &BStr) -> Result { >> +match src.deref() { >> +

  1   2   3   4   5   6   7   8   9   10   >