Re: [ patch 3/5] drivers/serial/jsm: new serial device driver

2005-03-30 Thread Russell King
On Fri, Mar 11, 2005 at 05:34:18PM -0500, Wen Xiong wrote: > diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c > linux-2.6.11.new/drivers/serial/jsm/jsm_neo.c > --- linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c 1969-12-31 > 18:00:00.0 -0600 > +++ linux-2.6.11.new/drivers/serial

Re: [ patch 3/5] drivers/serial/jsm: new serial device driver

2005-03-11 Thread Wen Xiong
Arjan van de Ven wrote: Jeff pointed out several PCI posting errors last time. Before we used udelay and now we changed to readb/readl instead of udelay this time. But we only used PCI posting when we think maybe delay there. So we have to do PCI posting on every writeb? not every Do you

Re: [ patch 3/5] drivers/serial/jsm: new serial device driver

2005-03-11 Thread Arjan van de Ven
> Jeff pointed out several PCI posting errors last time. Before we used > udelay and now we changed to readb/readl instead of udelay this time. > But we only used PCI posting when we think maybe delay there. > So we have to do PCI posting on every writeb? not every > Do you have some rules for

Re: [ patch 3/5] drivers/serial/jsm: new serial device driver

2005-03-11 Thread Wen Xiong
Arjan van de Ven wrote: On Fri, 2005-03-11 at 10:38 -0500, Wen Xiong wrote: +static void neo_set_cts_flow_control(struct jsm_channel *ch) +{ + u8 ier = readb(&ch->ch_neo_uart->ier); + u8 efr = readb(&ch->ch_neo_uart->efr); + ... + + writeb(ier, &ch->ch_neo_uart->ier); +} Hi, have y

Re: [ patch 3/5] drivers/serial/jsm: new serial device driver

2005-03-11 Thread Arjan van de Ven
On Fri, 2005-03-11 at 10:38 -0500, Wen Xiong wrote: > +static void neo_set_cts_flow_control(struct jsm_channel *ch) > +{ > + u8 ier = readb(&ch->ch_neo_uart->ier); > + u8 efr = readb(&ch->ch_neo_uart->efr); > + ... > + > + writeb(ier, &ch->ch_neo_uart->ier); > +} Hi, have you ever a

Re: [ patch 3/5] drivers/serial/jsm: new serial device driver

2005-03-11 Thread Wen Xiong
The third patch for jsm device driver. Signed-off-by: Wen Xiong <[EMAIL PROTECTED]> diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c linux-2.6.11.new/drivers/serial/jsm/jsm_neo.c --- linux-2.6.11.org/drivers/serial/jsm/jsm_neo.c 1969-12-31 18:00:00.0 -0600 +++ linux-2.6.11.n