Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-22 Thread Muhammad Usama Anjum
On 6/20/25 7:55 PM, Chen Linxuan wrote: > On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum > wrote: >> >> On 6/20/25 8:50 AM, Chen Linxuan wrote: >>> When running `make kselftest`, the following compilation warning was >>> encountered: >>> >>> mount-notify_test.c: In function ‘fanotify_rmdir

Re: [PATCH v2] ARM: dts: qcom: msm8974-samsung-hlte: Add touchkey support

2025-06-21 Thread Konrad Dybcio
On 6/18/25 11:45 PM, Luca Weiss wrote: > From: Adam Honse > > Add support for the touchkeys on the Samsung Galaxy Note 3 (hlte). > > Signed-off-by: Adam Honse > Signed-off-by: Luca Weiss > --- > Changes in v2: > - Fix schema validation failure, adjust i2c-gpio node name > - Fix misplaced S-o-b

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-20 Thread Chen Linxuan
On Fri, Jun 20, 2025 at 10:46 PM Muhammad Usama Anjum wrote: > > On 6/20/25 8:50 AM, Chen Linxuan wrote: > > When running `make kselftest`, the following compilation warning was > > encountered: > > > > mount-notify_test.c: In function ‘fanotify_rmdir’: > > mount-notify_test.c:490:17: warning: ig

Re: [PATCH v2] selftests/filesystems/mount-notify: fix unused unused result warning

2025-06-20 Thread Muhammad Usama Anjum
On 6/20/25 8:50 AM, Chen Linxuan wrote: > When running `make kselftest`, the following compilation warning was > encountered: > > mount-notify_test.c: In function ‘fanotify_rmdir’: > mount-notify_test.c:490:17: warning: ignoring return value of ‘chdir’ > declared with attribute ‘warn_unused_resu

Re: [PATCH v2] refscale: Add tests for local_irq_disable() vs local_interrupt_disable()

2025-06-19 Thread kernel test robot
Hi Joel, kernel test robot noticed the following build errors: [auto build test ERROR on rcu/rcu/dev] [also build test ERROR on linus/master v6.16-rc2 next-20250619] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as do

Re: [PATCH v2 2/2] selftests/bpf: Add testcases for BPF_ADD and BPF_SUB

2025-06-19 Thread Harishankar Vishwanathan
On Thu, Jun 19, 2025 at 5:55 PM Eduard Zingerman wrote: > > On Thu, 2025-06-19 at 17:13 -0400, Harishankar Vishwanathan wrote: > > On Wed, Jun 18, 2025 at 5:22 PM Eduard Zingerman wrote: > > > > > > On Tue, 2025-06-17 at 19:17 -0400, Harishankar Vishwanathan wrote: [...] > Hm, I see, that's an in

Re: [PATCH v2 2/2] selftests/bpf: Add testcases for BPF_ADD and BPF_SUB

2025-06-19 Thread Eduard Zingerman
On Thu, 2025-06-19 at 17:13 -0400, Harishankar Vishwanathan wrote: > On Wed, Jun 18, 2025 at 5:22 PM Eduard Zingerman wrote: > > > > On Tue, 2025-06-17 at 19:17 -0400, Harishankar Vishwanathan wrote: > > > The previous commit improves the precision in scalar(32)_min_max_add, > > > and scalar(32)_

Re: [PATCH v2 2/2] selftests/bpf: Add testcases for BPF_ADD and BPF_SUB

2025-06-19 Thread Harishankar Vishwanathan
On Wed, Jun 18, 2025 at 5:22 PM Eduard Zingerman wrote: > > On Tue, 2025-06-17 at 19:17 -0400, Harishankar Vishwanathan wrote: > > The previous commit improves the precision in scalar(32)_min_max_add, > > and scalar(32)_min_max_sub. The improvement in precision occurs in > > cases when all outcome

Re: [PATCH v2 3/4] scripts/misc-check: check missing #include when W=1

2025-06-19 Thread Jakub Kicinski
On Fri, 20 Jun 2025 01:13:28 +0900 Masahiro Yamada wrote: > > IIUC you made the kernel spew nearly 5000 warnings on every W=1 build > > to "encourage" others to help fix a fairly innocuous problem. > > I appreciate the work that goes into separating the headers but it's > > hardly urgent enough to

Re: [PATCH v2 3/4] scripts/misc-check: check missing #include when W=1

2025-06-19 Thread Masahiro Yamada
On Fri, Jun 20, 2025 at 1:01 AM Jakub Kicinski wrote: > > On Sun, 1 Jun 2025 22:31:29 +0900 Masahiro Yamada wrote: > > The problem was described in commit 5b20755b7780 ("init: move THIS_MODULE > > from to "). > > > > To summarize it again here: is included by most C files, > > even though only

Re: [PATCH v2 3/4] scripts/misc-check: check missing #include when W=1

2025-06-19 Thread Jakub Kicinski
On Sun, 1 Jun 2025 22:31:29 +0900 Masahiro Yamada wrote: > The problem was described in commit 5b20755b7780 ("init: move THIS_MODULE > from to "). > > To summarize it again here: is included by most C files, > even though only some of them actually export symbols. This is because > some headers

Re: [PATCH v2 0/3] remoteproc: imx_rproc: Support i.MX95

2025-06-19 Thread Peng Fan
On Fri, Jun 06, 2025 at 09:55:11AM +0800, Peng Fan (OSS) wrote: >i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and >one Cortex-M7 core. The System Control Management Interface(SCMI) >firmware runs on the M33 core. The i.MX95 SCMI firmware named System >Manager(SM) includes vendor extensi

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-18 Thread Dylan Hatch
On Fri, May 9, 2025 at 1:30 PM Josh Poimboeuf wrote: > > + > +# Make sure git re-stats the changed files > +git_refresh() { > + local patch="$1" > + local files=() > + > + [[ ! -d "$SRC/.git" ]] && return As a user of git worktrees, my $SRC/.git is a file containing a key: value

Re: [PATCH v2 2/2] selftests/bpf: Add testcases for BPF_ADD and BPF_SUB

2025-06-18 Thread Eduard Zingerman
On Tue, 2025-06-17 at 19:17 -0400, Harishankar Vishwanathan wrote: > The previous commit improves the precision in scalar(32)_min_max_add, > and scalar(32)_min_max_sub. The improvement in precision occurs in > cases when all outcomes overflow or underflow, respectively. This > commit adds selftests

Re: [PATCH v2 0/4] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-18 Thread Bjorn Andersson
On Sun, 15 Jun 2025 22:35:02 +0200, André Apitzsch wrote: > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) released > in 2016. > > Add a device tree with initial support for: > > - GPIO keys > - NFC > - SDHCI > - Status LED > - Touchscreen > > [...] Applied, thanks! [1/4] arm

Re: [PATCH v2 1/2] module: Fix memory deallocation on error path in move_module()

2025-06-18 Thread Daniel Gomez
On 18/06/2025 14.26, Petr Pavlu wrote: > The function move_module() uses the variable t to track how many memory > types it has allocated and consequently how many should be freed if an > error occurs. > > The variable is initially set to 0 and is updated when a call to > module_memory_alloc() fai

Re: [PATCH v2 2/2] module: Avoid unnecessary return value initialization in move_module()

2025-06-18 Thread Daniel Gomez
On 18/06/2025 14.26, Petr Pavlu wrote: > All error conditions in move_module() set the return value by updating the > ret variable. Therefore, it is not necessary to the initialize the variable > when declaring it. > > Remove the unnecessary initialization. > > Signed-off-by: Petr Pavlu > Review

Re: [PATCH v2] selftests: nettest: Fix typo in log and error messages for clarity

2025-06-17 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Sun, 15 Jun 2025 01:48:12 -0700 you wrote: > This patch corrects several logging and error message in nettest.c: > - Corrects function name in log messages "setsockopt" -> "getsockopt". > - Closes missing parenthes

Re: [PATCH v2 0/3] soc: qcom: mdt_loader: Validation and cleanup fixes

2025-06-17 Thread Bjorn Andersson
On Tue, 10 Jun 2025 21:58:27 -0500, Bjorn Andersson wrote: > Applied, thanks! [1/3] soc: qcom: mdt_loader: Ensure we don't read past the ELF header commit: 9f9967fed9d066ed3dae9372b45ffa4f6fccfeef [2/3] soc: qcom: mdt_loader: Rename mdt_phdr_valid() commit: cd840362b0a7b3da59740c1

Re: [PATCH v2 3/4] arm64: dts: qcom: msm8976: Add sdc2 GPIOs

2025-06-17 Thread Konrad Dybcio
On 6/15/25 10:35 PM, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > Downstream vendor code for reference: > > https://git.codelinaro.org/clo/la/kernel/msm-3.10/-/blob/LA.BR.1.3.7.c26/arch/arm/boot/dts/qcom/msm8976-pinctrl.dtsi#L223-263 > > Signed-off-by: André Apitzsch > --- >

Re: [PATCH v2 0/2] vringh small unused functions

2025-06-17 Thread Eugenio Perez Martin
On Tue, Jun 17, 2025 at 2:18 AM wrote: > > From: "Dr. David Alan Gilbert" > > Hi, > The following pair of patches remove a bunch of small functions > that have been unused for a long time. > Acked-by: Eugenio Pérez Thanks!

Re: [PATCH v2 2/2] vhost: vringh: Remove unused functions

2025-06-17 Thread Simon Horman
On Tue, Jun 17, 2025 at 01:18:37AM +0100, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The functions: > vringh_abandon_kern() > vringh_abandon_user() > vringh_iov_pull_kern() and > vringh_iov_push_kern() > were all added in 2013 by > commit f87d0fbb5798 ("vringh: host-sid

Re: [PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-16 Thread Peng Fan
Hi Daniel, On Mon, Jun 16, 2025 at 04:07:02PM +0300, Daniel Baluta wrote: >On Fri, Jun 6, 2025 at 4:57???AM Peng Fan (OSS) wrote: >> >> From: Peng Fan >> >> i.MX95 has a System Manager(SM) core runs the System Control Management >> Interface(SCMI) firmware. Vendor extenions are implemented in th

Re: [PATCH v2 0/4] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-16 Thread Rob Herring (Arm)
On Sun, 15 Jun 2025 22:35:02 +0200, André Apitzsch wrote: > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) released > in 2016. > > Add a device tree with initial support for: > > - GPIO keys > - NFC > - SDHCI > - Status LED > - Touchscreen > > Signed-off-by: André Apitzsch > -

Re: [PATCH v2 0/4] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-16 Thread André Apitzsch
Am Montag, dem 16.06.2025 um 13:46 +0200 schrieb Konrad Dybcio: > On 6/15/25 10:35 PM, André Apitzsch via B4 Relay wrote: > > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) > > released > > in 2016. > > > > Add a device tree with initial support for: > > > > - GPIO keys > > - NFC

Re: [PATCH v2] selftests: nettest: Fix typo in log and error messages for clarity

2025-06-16 Thread Simon Horman
On Sun, Jun 15, 2025 at 01:48:12AM -0700, Alok Tiwari wrote: > This patch corrects several logging and error message in nettest.c: > - Corrects function name in log messages "setsockopt" -> "getsockopt". > - Closes missing parentheses in "setsockopt(IPV6_FREEBIND)". > - Replaces misleading error te

Re: [PATCH v2 1/3] soc: qcom: mdt_loader: Ensure we don't read past the ELF header

2025-06-16 Thread Dmitry Baryshkov
On Tue, Jun 10, 2025 at 09:58:28PM -0500, Bjorn Andersson wrote: > When the MDT loader is used in remoteproc, the ELF header is sanitized > beforehand, but that's not necessary the case for other clients. > > Validate the size of the firmware buffer to ensure that we don't read > past the end as w

Re: [PATCH v2 2/3] remoteproc: imx_rproc: Add support for System Manager API

2025-06-16 Thread Daniel Baluta
On Fri, Jun 6, 2025 at 4:57 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > i.MX95 features a Cortex-M33 core, six Cortex-A55 cores, and > one Cortex-M7 core. The System Control Management Interface(SCMI) > firmware runs on the M33 core. The i.MX95 SCMI firmware named System > Manager(SM) include

Re: [PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-16 Thread Daniel Baluta
On Fri, Jun 6, 2025 at 4:57 AM Peng Fan (OSS) wrote: > > From: Peng Fan > > i.MX95 has a System Manager(SM) core runs the System Control Management > Interface(SCMI) firmware. Vendor extenions are implemented in the > firmware, Logical Machine Management(LMM) protocol to manage > Logical Machines

Re: [PATCH v2 0/4] arm64: dts: qcom: msm8976-longcheer-l9360: Add initial device tree

2025-06-16 Thread Konrad Dybcio
On 6/15/25 10:35 PM, André Apitzsch via B4 Relay wrote: > This dts adds support for BQ Aquaris X5 Plus (Longcheer L9360) released > in 2016. > > Add a device tree with initial support for: > > - GPIO keys > - NFC > - SDHCI > - Status LED > - Touchscreen > > Signed-off-by: André Apitzsch > --- >

Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add MSM8976 BQ Aquaris X5 Plus

2025-06-16 Thread Krzysztof Kozlowski
On 15/06/2025 22:35, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > BQ Aquaris X5 Plus (Longcheer L9360) is a smartphone based on MSM8976 > SoC. > > Signed-off-by: André Apitzsch > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH][v2] virtio_fs: Remove redundant spinlock in virtio_fs_request_complete()

2025-06-15 Thread Stefan Hajnoczi
On Sun, Jun 15, 2025 at 9:21 AM lirongqing wrote: > > From: Li RongQing > > Since clear_bit is an atomic operation, the spinlock is redundant and > can be removed, reducing lock contention is good for performance. > > Signed-off-by: Li RongQing > --- > Diff with v1: remove unused variable "fpq"

Re: [PATCH v2] remoteproc: xlnx: allow single core use in split mode

2025-06-13 Thread Tanmay Shah
On 6/13/25 12:18 PM, Mathieu Poirier wrote: Good day, On Tue, Jun 10, 2025 at 12:27:38PM -0700, Tanmay Shah wrote: It's a valid use case to have only one core enabled in cluster in split mode. Remove exact core count expecatation from the driver. I suggest: "When operating in split mode,

Re: [PATCH v2] remoteproc: xlnx: allow single core use in split mode

2025-06-13 Thread Mathieu Poirier
Good day, On Tue, Jun 10, 2025 at 12:27:38PM -0700, Tanmay Shah wrote: > It's a valid use case to have only one core enabled in cluster in split > mode. Remove exact core count expecatation from the driver. I suggest: "When operating in split mode, it is a valid usecase to have only one core ena

Re: [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-13 Thread David Hildenbrand
On 12.06.25 18:10, Lorenzo Stoakes wrote: On Wed, Jun 11, 2025 at 02:06:53PM +0200, David Hildenbrand wrote: Marking PMDs that map a "normal" refcounted folios as special is against our rules documented for vm_normal_page(). Fortunately, there are not that many pmd_special() check that can be m

Re: [PATCH v2 1/2] selftests: khugepaged: fix the shmem collapse failure

2025-06-13 Thread David Hildenbrand
On 13.06.25 03:49, Baolin Wang wrote: When running the khugepaged selftest for shmem (./khugepaged all:shmem), I encountered the following test failures: " Run test: collapse_full (khugepaged:shmem) Collapse multiple fully populated PTE table Fail ... Run test: collapse_single_pte_entry (khug

Re: [PATCH v2 1/2] selftests: khugepaged: fix the shmem collapse failure

2025-06-12 Thread Dev Jain
On 13/06/25 7:19 am, Baolin Wang wrote: When running the khugepaged selftest for shmem (./khugepaged all:shmem), I encountered the following test failures: " Run test: collapse_full (khugepaged:shmem) Collapse multiple fully populated PTE table Fail ... Run test: collapse_single_pte_entry (

Re: [PATCH v2 1/3] virtio: Fix typo in register_virtio_device() doc comment

2025-06-12 Thread Xuan Zhuo
On Thu, 29 May 2025 01:42:39 -0700, Alok Tiwari wrote: > Corrected "suceess" to "success" in the function documentation > for clarity. > > Signed-off-by: Alok Tiwari > Acked-by: Jason Wang Reviewed-by: Xuan Zhuo > --- > v1 -> v2 > No changes; only added Acked-by: Jason Wang. > --- > drivers

Re: [PATCH v2 00/62] objtool,livepatch: klp-build livepatch module generation

2025-06-12 Thread Josh Poimboeuf
On Fri, May 09, 2025 at 01:16:24PM -0700, Josh Poimboeuf wrote: > I've tested with a variety of patches on defconfig and Fedora-config > kernels with both GCC and Clang. > > These patches can also be found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git > klp-build-v2

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-12 Thread Joe Lawrence
On 6/11/25 7:12 PM, Josh Poimboeuf wrote: > > Hm, revert_patch() already has a call to git_refresh(), so there doesn't > appear to be any point to that extra refresh in revert_patches(). > > Does this fix? > > diff --git a/scripts/livepatch/klp-build b/scripts/livepatch/klp-build > index 7ec07c4

Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()

2025-06-12 Thread Jason Gunthorpe
On Wed, Jun 11, 2025 at 02:06:54PM +0200, David Hildenbrand wrote: > Marking PUDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pud_special() check that can be > mislead and are right now rather har

Re: [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-12 Thread Jason Gunthorpe
On Wed, Jun 11, 2025 at 02:06:53PM +0200, David Hildenbrand wrote: > Marking PMDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pmd_special() check that can be > mislead, and most vm_normal_page_pmd

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-12 Thread Jason Gunthorpe
On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: > We setup the cache mode but ... don't forward the updated pgprot to > insert_pfn_pud(). > > Only a problem on x86-64 PAT when mapping PFNs using PUDs that > require a special cachemode. > > Fix it by using the proper pgprot wher

Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()

2025-06-12 Thread David Hildenbrand
On 12.06.25 19:08, Lorenzo Stoakes wrote: On Thu, Jun 12, 2025 at 07:00:01PM +0200, David Hildenbrand wrote: On 12.06.25 18:49, Lorenzo Stoakes wrote: On Wed, Jun 11, 2025 at 02:06:54PM +0200, David Hildenbrand wrote: Marking PUDs that map a "normal" refcounted folios as special is against our

Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()

2025-06-12 Thread Lorenzo Stoakes
On Thu, Jun 12, 2025 at 07:00:01PM +0200, David Hildenbrand wrote: > On 12.06.25 18:49, Lorenzo Stoakes wrote: > > On Wed, Jun 11, 2025 at 02:06:54PM +0200, David Hildenbrand wrote: > > > Marking PUDs that map a "normal" refcounted folios as special is > > > against our rules documented for vm_norm

Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()

2025-06-12 Thread David Hildenbrand
On 12.06.25 18:49, Lorenzo Stoakes wrote: On Wed, Jun 11, 2025 at 02:06:54PM +0200, David Hildenbrand wrote: Marking PUDs that map a "normal" refcounted folios as special is against our rules documented for vm_normal_page(). Might be worth referring to specifically which rule. I'm guessing it'

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread Marc Herbert
> I spent too much time trying to get the ndctl tests mentioned by Dan > running (.config tweaks, memmap= setup, ... ), without getting them to > pass even without these patches. Some SKIP, some FAIL, some sometimes > suddenly SKIP on first invocation, ... instructions unclear or

Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()

2025-06-12 Thread Lorenzo Stoakes
On Wed, Jun 11, 2025 at 02:06:54PM +0200, David Hildenbrand wrote: > Marking PUDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). Might be worth referring to specifically which rule. I'm guessing it's the general one of special == don't touc

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread Lorenzo Stoakes
On Thu, Jun 12, 2025 at 06:22:32PM +0200, David Hildenbrand wrote: > On 12.06.25 18:19, Lorenzo Stoakes wrote: > > FWIW I did a basic build/mm self tests run locally and all looking good! > > Thanks! I have another series based on this series coming up ... but > struggling to get !CONFIG_ARCH_HAS_P

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread David Hildenbrand
On 12.06.25 18:19, Lorenzo Stoakes wrote: FWIW I did a basic build/mm self tests run locally and all looking good! Thanks! I have another series based on this series coming up ... but struggling to get !CONFIG_ARCH_HAS_PTE_SPECIAL tested "easily" :) -- Cheers, David / dhildenb

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread Lorenzo Stoakes
FWIW I did a basic build/mm self tests run locally and all looking good! On Wed, Jun 11, 2025 at 02:06:51PM +0200, David Hildenbrand wrote: > This is v2 of > "[PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special >in vmf_insert_folio_*()" > Now with one additional fix, b

Re: [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-12 Thread Lorenzo Stoakes
On Wed, Jun 11, 2025 at 02:06:53PM +0200, David Hildenbrand wrote: > Marking PMDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pmd_special() check that can be > mislead, and most vm_normal_page_pmd(

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-12 Thread Lorenzo Stoakes
On Thu, Jun 12, 2025 at 05:36:35PM +0200, David Hildenbrand wrote: > On 12.06.25 17:28, Lorenzo Stoakes wrote: > > On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: > > > We setup the cache mode but ... don't forward the updated pgprot to > > > insert_pfn_pud(). > > > > > > Only a

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-12 Thread David Hildenbrand
On 12.06.25 17:59, Lorenzo Stoakes wrote: On Thu, Jun 12, 2025 at 05:36:35PM +0200, David Hildenbrand wrote: On 12.06.25 17:28, Lorenzo Stoakes wrote: On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: We setup the cache mode but ... don't forward the updated pgprot to insert_p

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-12 Thread Lorenzo Stoakes
On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: > We setup the cache mode but ... don't forward the updated pgprot to > insert_pfn_pud(). > > Only a problem on x86-64 PAT when mapping PFNs using PUDs that > require a special cachemode. > > Fix it by using the proper pgprot where

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-12 Thread David Hildenbrand
On 12.06.25 17:28, Lorenzo Stoakes wrote: On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: We setup the cache mode but ... don't forward the updated pgprot to insert_pfn_pud(). Only a problem on x86-64 PAT when mapping PFNs using PUDs that require a special cachemode. Fix it

Re: [PATCH v2 2/2] Documentation/kernel-parameters: Update rcu_normal_wake_from_gp doc

2025-06-12 Thread Uladzislau Rezki
On Wed, Jun 11, 2025 at 05:49:14PM -0400, Joel Fernandes wrote: > > > On 6/11/2025 1:56 PM, Uladzislau Rezki (Sony) wrote: > > Update the documentation about rcu_normal_wake_from_gp parameter. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > Reviewed-by: Joel Fernandes > Thanks! -- Uladzi

Re: [PATCH v2 1/2] rcu: Enable rcu_normal_wake_from_gp on small systems

2025-06-12 Thread Uladzislau Rezki
On Wed, Jun 11, 2025 at 05:48:57PM -0400, Joel Fernandes wrote: > > > On 6/11/2025 1:56 PM, Uladzislau Rezki (Sony) wrote: > > Automatically enable the rcu_normal_wake_from_gp parameter on > > systems with a small number of CPUs. The activation threshold > > is set to 16 CPUs. > > > > This helps

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread David Hildenbrand
On 12.06.25 09:18, David Hildenbrand wrote: On 12.06.25 06:20, Dan Williams wrote: Alistair Popple wrote: On Wed, Jun 11, 2025 at 02:06:51PM +0200, David Hildenbrand wrote: This is v2 of "[PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_*(

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread David Hildenbrand
On 12.06.25 01:08, Andrew Morton wrote: On Wed, 11 Jun 2025 14:06:51 +0200 David Hildenbrand wrote: While working on improving vm_normal_page() and friends, I stumbled over this issues: refcounted "normal" pages must not be marked using pmd_special() / pud_special(). Why is this? The two p

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread David Hildenbrand
On 12.06.25 06:20, Dan Williams wrote: Alistair Popple wrote: On Wed, Jun 11, 2025 at 02:06:51PM +0200, David Hildenbrand wrote: This is v2 of "[PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special in vmf_insert_folio_*()" Now with one additional fix, based on mm/m

Re: [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-12 Thread David Hildenbrand
On 12.06.25 04:17, Alistair Popple wrote: On Wed, Jun 11, 2025 at 02:06:53PM +0200, David Hildenbrand wrote: Marking PMDs that map a "normal" refcounted folios as special is against our rules documented for vm_normal_page(). Fortunately, there are not that many pmd_special() check that can be m

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-11 Thread David Hildenbrand
On 12.06.25 03:56, Alistair Popple wrote: On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: We setup the cache mode but ... don't forward the updated pgprot to insert_pfn_pud(). Only a problem on x86-64 PAT when mapping PFNs using PUDs that require a special cachemode. Fix it

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-11 Thread David Hildenbrand
On 12.06.25 06:34, Dan Williams wrote: David Hildenbrand wrote: We setup the cache mode but ... don't forward the updated pgprot to insert_pfn_pud(). Only a problem on x86-64 PAT when mapping PFNs using PUDs that require a special cachemode. This is only a problem if the kernel mapped the pud

Re: [PATCH v2 3/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pud()

2025-06-11 Thread Dan Williams
David Hildenbrand wrote: > Marking PUDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pud_special() check that can be > mislead and are right now rather harmless: e.g., none so far > bases decisions

Re: [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-11 Thread Dan Williams
David Hildenbrand wrote: > Marking PMDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pmd_special() check that can be > mislead, and most vm_normal_page_pmd()/vm_normal_folio_pmd() users that > woul

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-11 Thread Dan Williams
David Hildenbrand wrote: > We setup the cache mode but ... don't forward the updated pgprot to > insert_pfn_pud(). > > Only a problem on x86-64 PAT when mapping PFNs using PUDs that > require a special cachemode. This is only a problem if the kernel mapped the pud in advance of userspace mapping

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-11 Thread Dan Williams
Alistair Popple wrote: > On Wed, Jun 11, 2025 at 02:06:51PM +0200, David Hildenbrand wrote: > > This is v2 of > > "[PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special > > in vmf_insert_folio_*()" > > Now with one additional fix, based on mm/mm-unstable. > > > > While workin

Re: [PATCH v2 0/4] Add support for Sony Xperia Z Ultra (togari)

2025-06-11 Thread Bjorn Andersson
On Tue, 10 Jun 2025 20:34:51 +0200, Luca Weiss wrote: > Do some tweaks to the common file for the devices in the 'rhine' family > of Sony devices, and add a dts for togari. > > Applied, thanks! [1/4] ARM: dts: qcom: msm8974-sony-xperia-rhine: Enable USB charging commit: 702639bc50515c97

Re: [PATCH v2 0/3] Add devicetree aliases for mmc on multiple MSM8974 devices

2025-06-11 Thread Bjorn Andersson
On Tue, 10 Jun 2025 19:03:48 +0200, Luca Weiss wrote: > Add an alias for the internal storage so it always becomes mmcblk0 and > - where applicable - SD card becomes mmcblk1. > > This avoids issues with internal storage becoming mmcblk1 unexpectedly > and aligns this board with other boards that

Re: [PATCH v2 2/3] mm/huge_memory: don't mark refcounted folios special in vmf_insert_folio_pmd()

2025-06-11 Thread Alistair Popple
On Wed, Jun 11, 2025 at 02:06:53PM +0200, David Hildenbrand wrote: > Marking PMDs that map a "normal" refcounted folios as special is > against our rules documented for vm_normal_page(). > > Fortunately, there are not that many pmd_special() check that can be > mislead, and most vm_normal_page_pmd

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-11 Thread Alistair Popple
On Wed, Jun 11, 2025 at 02:06:51PM +0200, David Hildenbrand wrote: > This is v2 of > "[PATCH v1 0/2] mm/huge_memory: don't mark refcounted pages special >in vmf_insert_folio_*()" > Now with one additional fix, based on mm/mm-unstable. > > While working on improving vm_normal_page() a

Re: [PATCH v2 1/3] mm/huge_memory: don't ignore queried cachemode in vmf_insert_pfn_pud()

2025-06-11 Thread Alistair Popple
On Wed, Jun 11, 2025 at 02:06:52PM +0200, David Hildenbrand wrote: > We setup the cache mode but ... don't forward the updated pgprot to > insert_pfn_pud(). > > Only a problem on x86-64 PAT when mapping PFNs using PUDs that > require a special cachemode. > > Fix it by using the proper pgprot wher

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-11 Thread Josh Poimboeuf
On Wed, Jun 11, 2025 at 05:44:23PM -0400, Joe Lawrence wrote: > On 5/9/25 4:17 PM, Josh Poimboeuf wrote: > > +revert_patches() { > > + local extra_args=("$@") > > + local patches=("${APPLIED_PATCHES[@]}") > > + > > + for (( i=${#patches[@]}-1 ; i>=0 ; i-- )) ; do > > + revert_patch

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-11 Thread Andrew Morton
On Wed, 11 Jun 2025 14:06:51 +0200 David Hildenbrand wrote: > While working on improving vm_normal_page() and friends, I stumbled > over this issues: refcounted "normal" pages must not be marked > using pmd_special() / pud_special(). Why is this? > > ... > > I spent too much time trying to get

Re: [PATCH v2 2/2] Documentation/kernel-parameters: Update rcu_normal_wake_from_gp doc

2025-06-11 Thread Joel Fernandes
On 6/11/2025 1:56 PM, Uladzislau Rezki (Sony) wrote: > Update the documentation about rcu_normal_wake_from_gp parameter. > > Signed-off-by: Uladzislau Rezki (Sony) Reviewed-by: Joel Fernandes Thanks. > --- > Documentation/admin-guide/kernel-parameters.txt | 3 ++- > 1 file changed, 2 ins

Re: [PATCH v2 1/2] rcu: Enable rcu_normal_wake_from_gp on small systems

2025-06-11 Thread Joel Fernandes
On 6/11/2025 1:56 PM, Uladzislau Rezki (Sony) wrote: > Automatically enable the rcu_normal_wake_from_gp parameter on > systems with a small number of CPUs. The activation threshold > is set to 16 CPUs. > > This helps to reduce a latency of normal synchronize_rcu() API > by waking up GP-waiters

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-11 Thread Joe Lawrence
On 5/9/25 4:17 PM, Josh Poimboeuf wrote: > +revert_patches() { > + local extra_args=("$@") > + local patches=("${APPLIED_PATCHES[@]}") > + > + for (( i=${#patches[@]}-1 ; i>=0 ; i-- )) ; do > + revert_patch "${patches[$i]}" "${extra_args[@]}" > + done > + > + APPLIED

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-11 Thread Josh Poimboeuf
On Wed, Jun 11, 2025 at 02:44:35PM -0400, Joe Lawrence wrote: > > +get_patch_files() { > > + local patch="$1" > > + > > + grep0 -E '^(--- |\+\+\+ )' "$patch" \ > > + | gawk '{print $2}' \ > > If we split the rest of this line on the tab

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-11 Thread Joe Lawrence
On 6/11/25 3:08 PM, Josh Poimboeuf wrote: > On Wed, Jun 11, 2025 at 02:44:35PM -0400, Joe Lawrence wrote: >>> +get_patch_files() { >>> + local patch="$1" >>> + >>> + grep0 -E '^(--- |\+\+\+ )' "$patch" \ >>> + | gawk '{print $2}' \ >> If

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-11 Thread Joe Lawrence
On 5/9/25 4:17 PM, Josh Poimboeuf wrote: > Add a klp-build script which automates the generation of a livepatch > module from a source .patch file by performing the following steps: > > - Builds an original kernel with -function-sections and > -fdata-sections, plus objtool function checksumm

Re: [PATCH v2] remoteproc: xlnx: allow single core use in split mode

2025-06-10 Thread Peng Fan
On Tue, Jun 10, 2025 at 12:27:38PM -0700, Tanmay Shah wrote: >It's a valid use case to have only one core enabled in cluster in split >mode. Remove exact core count expecatation from the driver. > >Signed-off-by: Tanmay Shah Reviewed-by:

Re: [PATCH v2] remoteproc: qcom: pas: Conclude the rename from adsp

2025-06-10 Thread Bjorn Andersson
On Thu, 05 Jun 2025 17:17:47 -0500, Bjorn Andersson wrote: > The change that renamed the driver from "adsp" to "pas" didn't change > any of the implementation. The result is an aesthetic eyesore, and > confusing to many. > > Conclude the rename of the driver, by updating function, structures and

Re: [PATCH v2 1/4] ARM: dts: qcom: msm8974-sony-xperia-rhine: Enable USB charging

2025-06-10 Thread Dmitry Baryshkov
On Tue, Jun 10, 2025 at 08:34:52PM +0200, Luca Weiss wrote: > From: Kevin Widjaja > > Set usb-charge-current-limit to enable charging over USB for all > sony-rhine devices. > > Signed-off-by: Kevin Widjaja > Signed-off-by: Luca Weiss > --- > arch/arm/boot/dts/qcom/qcom-msm8974-sony-xperia-rhi

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-10 Thread Josh Poimboeuf
On Tue, Jun 10, 2025 at 08:39:10AM -0400, Joe Lawrence wrote: > >> Should we check for other data section prefixes here, like: > >> > >>else { > >>snprintf(sec_name, SEC_NAME_LEN, ".rodata.%s", > >> sym->name); > >>if (!st

Re: [PATCH v2 2/4] tools/nolibc: Provide vfork()

2025-06-10 Thread Thomas Weißschuh
On 2025-06-10 13:29:45+0100, Mark Brown wrote: > To allow testing of vfork() support in the arm64 basic-gcs test provide an > implementation for nolibc, using the vfork() syscall if one is available > and otherwise clone3(). We implement in terms of clone3() since the order > of the arguments for c

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-10 Thread Josh Poimboeuf
On Mon, Jun 09, 2025 at 10:34:43PM -0400, Joe Lawrence wrote: > On Fri, May 09, 2025 at 01:17:23PM -0700, Josh Poimboeuf wrote: > > +revert_patch() { > > + local patch="$1" > > + shift > > + local extra_args=("$@") > > + local tmp=() > > + > > + ( cd "$SRC" && git apply --reverse "${extra

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-10 Thread Josh Poimboeuf
On Mon, Jun 09, 2025 at 10:05:53PM -0400, Joe Lawrence wrote: > On Mon, Jun 09, 2025 at 04:59:37PM -0700, Josh Poimboeuf wrote: > > On Mon, Jun 09, 2025 at 05:20:53PM -0400, Joe Lawrence wrote: > > > If you touch sound/soc/sof/intel/, klp-build will error out with: > > > > > > Building patch mod

Re: [PATCH v2] module: Make sure relocations are applied to the per-CPU section

2025-06-10 Thread Sebastian Andrzej Siewior
On 2025-06-05 18:50:27 [+0200], Petr Pavlu wrote: > On 6/5/25 5:54 PM, Sebastian Andrzej Siewior wrote: > > On 2025-06-05 15:44:23 [+0200], Petr Pavlu wrote: > >> Isn't this broken earlier by "Don't relocate non-allocated regions in > >> modules." > >> (pre-Git, [1])? > > > > Looking further back

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-10 Thread Joe Lawrence
On 6/9/25 7:21 PM, Josh Poimboeuf wrote: > On Mon, Jun 09, 2025 at 02:32:19PM -0400, Joe Lawrence wrote: >> On Fri, May 09, 2025 at 01:17:16PM -0700, Josh Poimboeuf wrote: >>> +static int validate_ffunction_fdata_sections(struct elf *elf) >>> +{ >>> + struct symbol *sym; >>> + bool found_text =

Re: [PATCH v2 4/4] arm64: dts: qcom: sm6350: Add video clock controller

2025-06-10 Thread Luca Weiss
Hi Konrad and all, On Tue Apr 15, 2025 at 11:13 AM CEST, Konrad Dybcio wrote: > On 4/15/25 6:05 AM, Taniya Das wrote: >> >> >> On 4/12/2025 12:56 AM, Konrad Dybcio wrote: >>> On 4/11/25 1:37 PM, Jagadeesh Kona wrote: On 4/11/2025 2:42 PM, Konrad Dybcio wrote: > On 4/11/25 9:15

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-09 Thread Joe Lawrence
On Fri, May 09, 2025 at 01:17:23PM -0700, Josh Poimboeuf wrote: > +revert_patch() { > + local patch="$1" > + shift > + local extra_args=("$@") > + local tmp=() > + > + ( cd "$SRC" && git apply --reverse "${extra_args[@]}" "$patch" ) > + git_refresh "$patch" > + > + for p

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-09 Thread Joe Lawrence
On Mon, Jun 09, 2025 at 10:05:53PM -0400, Joe Lawrence wrote: > + # Copy symbol namespace > + readelf -p .modinfo "$ORIG_DIR/$rel_file" | \ > + gawk -F= '/\ namespaces Errr, that is $PATCHED_DIR/$rel_file if we want to pick up the updated list of namespa

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-09 Thread Joe Lawrence
On Mon, Jun 09, 2025 at 04:59:37PM -0700, Josh Poimboeuf wrote: > On Mon, Jun 09, 2025 at 05:20:53PM -0400, Joe Lawrence wrote: > > If you touch sound/soc/sof/intel/, klp-build will error out with: > > > > Building patch module: livepatch-unCVE-2024-58012.ko > > ERROR: modpost: module livepatc

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-09 Thread Josh Poimboeuf
On Mon, Jun 09, 2025 at 05:20:53PM -0400, Joe Lawrence wrote: > If you touch sound/soc/sof/intel/, klp-build will error out with: > > Building patch module: livepatch-unCVE-2024-58012.ko > ERROR: modpost: module livepatch-unCVE-2024-58012 uses symbol > hda_dai_config from namespace SND_SOC_SO

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-09 Thread Josh Poimboeuf
On Mon, Jun 09, 2025 at 02:32:19PM -0400, Joe Lawrence wrote: > On Fri, May 09, 2025 at 01:17:16PM -0700, Josh Poimboeuf wrote: > > +static int validate_ffunction_fdata_sections(struct elf *elf) > > +{ > > + struct symbol *sym; > > + bool found_text = false, found_data = false; > > + > > + fo

Re: [PATCH v2 59/62] livepatch/klp-build: Introduce klp-build script for generating livepatch modules

2025-06-09 Thread Joe Lawrence
On Fri, May 09, 2025 at 01:17:23PM -0700, Josh Poimboeuf wrote: > +# Build and post-process livepatch module in $KMOD_DIR > +build_patch_module() { > + local makefile="$KMOD_DIR/Kbuild" > + local log="$KMOD_DIR/build.log" > + local cflags=() > + local files=() > + local cmd=() >

Re: [PATCH v2 52/62] objtool/klp: Introduce klp diff subcommand for diffing object files

2025-06-09 Thread Joe Lawrence
On Fri, May 09, 2025 at 01:17:16PM -0700, Josh Poimboeuf wrote: > +static int validate_ffunction_fdata_sections(struct elf *elf) > +{ > + struct symbol *sym; > + bool found_text = false, found_data = false; > + > + for_each_sym(elf, sym) { > + char sec_name[SEC_NAME_LEN]; >

Re: [PATCH v2 45/62] x86/extable: Define ELF section entry size for exception tables

2025-06-09 Thread Josh Poimboeuf
On Fri, Jun 06, 2025 at 09:26:30PM -0400, Brian Gerst wrote: > On Fri, Jun 6, 2025 at 3:48 AM Josh Poimboeuf wrote: > > > > On Thu, Jun 05, 2025 at 11:58:23PM -0400, Brian Gerst wrote: > > > On Fri, May 9, 2025 at 4:51 PM Josh Poimboeuf wrote: > > > > > > > > In preparation for the objtool klp di

Re: [PATCH v2] selftests: ir_decoder: Convert header comment to proper multi-line block

2025-06-09 Thread Shuah
On 6/6/25 16:39, Abdelrahman Fekry wrote: So, this is an updated version following the right way of writing change logs while making sure the signed-off-by mismatch is fixed. The above doesn't belong in the change log The test file for the IR decoder used single-line comments at the top to d

  1   2   3   4   5   6   7   8   9   10   >