Re: [PATCH] [net-next] net/mlx5e: xsk: dynamically allocate mlx5e_channel_param

2019-07-23 Thread Arnd Bergmann
On Tue, Jul 23, 2019 at 1:21 PM Maxim Mikityanskiy wrote: > On 2019-07-08 18:16, Maxim Mikityanskiy wrote: > > On 2019-07-08 15:55, Arnd Bergmann wrote: > >> -mlx5e_build_xsk_cparam(priv, params, xsk, &cparam); > >> +cparam = kzalloc(sizeof(*cparam), GFP_KERNEL); > > > > Similar code in ml

Re: [PATCH] [net-next] net/mlx5e: xsk: dynamically allocate mlx5e_channel_param

2019-07-23 Thread Maxim Mikityanskiy
On 2019-07-08 18:16, Maxim Mikityanskiy wrote: > On 2019-07-08 15:55, Arnd Bergmann wrote: >> -mlx5e_build_xsk_cparam(priv, params, xsk, &cparam); >> +cparam = kzalloc(sizeof(*cparam), GFP_KERNEL); > > Similar code in mlx5e_open_channels (en_main.c) uses kvzalloc. Although > the struct is

Re: [PATCH] [net-next] net/mlx5e: xsk: dynamically allocate mlx5e_channel_param

2019-07-08 Thread Maxim Mikityanskiy
On 2019-07-08 15:55, Arnd Bergmann wrote: > The structure is too large to put on the stack, resulting in a > warning on 32-bit ARM: > > drivers/net/ethernet/mellanox/mlx5/core/en/xsk/setup.c:59:5: error: stack > frame size of 1344 bytes in function >'mlx5e_open_xsk' [-Werror,-Wframe-large