Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-28 Thread Marcelo Tosatti
On Wed, Nov 28, 2012 at 01:27:38PM +0800, Xiao Guangrong wrote: > On 11/18/2012 11:00 AM, Marcelo Tosatti wrote: > map gfn 4? See corrected step 7 above. > >> > >> Ah, this is a real bug, and unfortunately, it exists in current > >> code. I will make a separate patchset to fix it. Thank you, Marce

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-27 Thread Xiao Guangrong
On 11/18/2012 11:00 AM, Marcelo Tosatti wrote: map gfn 4? See corrected step 7 above. >> >> Ah, this is a real bug, and unfortunately, it exists in current >> code. I will make a separate patchset to fix it. Thank you, Marcelo! > > Is it? Hum.. > > Anyway, it would be great if you can write a te

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-17 Thread Marcelo Tosatti
On Sat, Nov 17, 2012 at 10:06:18PM +0800, Xiao Guangrong wrote: > On 11/16/2012 05:57 PM, Marcelo Tosatti wrote: > > On Fri, Nov 16, 2012 at 12:46:16PM +0800, Xiao Guangrong wrote: > >> On 11/16/2012 11:56 AM, Marcelo Tosatti wrote: > >>> On Fri, Nov 16, 2012 at 11:39:12AM +0800, Xiao Guangrong wro

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-17 Thread Xiao Guangrong
On 11/16/2012 05:57 PM, Marcelo Tosatti wrote: > On Fri, Nov 16, 2012 at 12:46:16PM +0800, Xiao Guangrong wrote: >> On 11/16/2012 11:56 AM, Marcelo Tosatti wrote: >>> On Fri, Nov 16, 2012 at 11:39:12AM +0800, Xiao Guangrong wrote: On 11/16/2012 11:02 AM, Marcelo Tosatti wrote: > On Thu, No

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-16 Thread Marcelo Tosatti
On Fri, Nov 16, 2012 at 12:46:16PM +0800, Xiao Guangrong wrote: > On 11/16/2012 11:56 AM, Marcelo Tosatti wrote: > > On Fri, Nov 16, 2012 at 11:39:12AM +0800, Xiao Guangrong wrote: > >> On 11/16/2012 11:02 AM, Marcelo Tosatti wrote: > >>> On Thu, Nov 15, 2012 at 07:17:15AM +0800, Xiao Guangrong wro

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-15 Thread Xiao Guangrong
On 11/16/2012 11:56 AM, Marcelo Tosatti wrote: > On Fri, Nov 16, 2012 at 11:39:12AM +0800, Xiao Guangrong wrote: >> On 11/16/2012 11:02 AM, Marcelo Tosatti wrote: >>> On Thu, Nov 15, 2012 at 07:17:15AM +0800, Xiao Guangrong wrote: On 11/14/2012 10:37 PM, Marcelo Tosatti wrote: > On Tue, No

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-15 Thread Marcelo Tosatti
On Fri, Nov 16, 2012 at 11:39:12AM +0800, Xiao Guangrong wrote: > On 11/16/2012 11:02 AM, Marcelo Tosatti wrote: > > On Thu, Nov 15, 2012 at 07:17:15AM +0800, Xiao Guangrong wrote: > >> On 11/14/2012 10:37 PM, Marcelo Tosatti wrote: > >>> On Tue, Nov 13, 2012 at 04:26:16PM +0800, Xiao Guangrong wro

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-15 Thread Xiao Guangrong
On 11/16/2012 11:02 AM, Marcelo Tosatti wrote: > On Thu, Nov 15, 2012 at 07:17:15AM +0800, Xiao Guangrong wrote: >> On 11/14/2012 10:37 PM, Marcelo Tosatti wrote: >>> On Tue, Nov 13, 2012 at 04:26:16PM +0800, Xiao Guangrong wrote: Hi Marcelo, On 11/13/2012 07:10 AM, Marcelo Tosatti w

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-15 Thread Marcelo Tosatti
On Thu, Nov 15, 2012 at 07:17:15AM +0800, Xiao Guangrong wrote: > On 11/14/2012 10:37 PM, Marcelo Tosatti wrote: > > On Tue, Nov 13, 2012 at 04:26:16PM +0800, Xiao Guangrong wrote: > >> Hi Marcelo, > >> > >> On 11/13/2012 07:10 AM, Marcelo Tosatti wrote: > >>> On Mon, Nov 05, 2012 at 05:59:26PM +08

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-14 Thread Xiao Guangrong
On 11/14/2012 10:44 PM, Marcelo Tosatti wrote: > On Wed, Nov 14, 2012 at 12:33:50AM +0900, Takuya Yoshikawa wrote: >> Ccing live migration developers who should be interested in this work, >> >> On Mon, 12 Nov 2012 21:10:32 -0200 >> Marcelo Tosatti wrote: >> >>> On Mon, Nov 05, 2012 at 05:59:26PM

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-14 Thread Xiao Guangrong
On 11/14/2012 10:37 PM, Marcelo Tosatti wrote: > On Tue, Nov 13, 2012 at 04:26:16PM +0800, Xiao Guangrong wrote: >> Hi Marcelo, >> >> On 11/13/2012 07:10 AM, Marcelo Tosatti wrote: >>> On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: Do not drop large spte until it can be instea

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-14 Thread Marcelo Tosatti
On Wed, Nov 14, 2012 at 12:33:50AM +0900, Takuya Yoshikawa wrote: > Ccing live migration developers who should be interested in this work, > > On Mon, 12 Nov 2012 21:10:32 -0200 > Marcelo Tosatti wrote: > > > On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: > > > Do not drop large

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-14 Thread Marcelo Tosatti
On Tue, Nov 13, 2012 at 04:26:16PM +0800, Xiao Guangrong wrote: > Hi Marcelo, > > On 11/13/2012 07:10 AM, Marcelo Tosatti wrote: > > On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: > >> Do not drop large spte until it can be insteaded by small pages so that > >> the guest can happl

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-13 Thread Takuya Yoshikawa
Ccing live migration developers who should be interested in this work, On Mon, 12 Nov 2012 21:10:32 -0200 Marcelo Tosatti wrote: > On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: > > Do not drop large spte until it can be insteaded by small pages so that > > the guest can happliy

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-13 Thread Xiao Guangrong
Hi Marcelo, On 11/13/2012 07:10 AM, Marcelo Tosatti wrote: > On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: >> Do not drop large spte until it can be insteaded by small pages so that >> the guest can happliy read memory through it >> >> The idea is from Avi: >> | As I mentioned be

Re: [PATCH] KVM: MMU: lazily drop large spte

2012-11-12 Thread Marcelo Tosatti
On Mon, Nov 05, 2012 at 05:59:26PM +0800, Xiao Guangrong wrote: > Do not drop large spte until it can be insteaded by small pages so that > the guest can happliy read memory through it > > The idea is from Avi: > | As I mentioned before, write-protecting a large spte is a good idea, > | since it m