Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-09-14 Thread Sean Christopherson
On Thu, Jul 23, 2020 at 12:35:44PM -0600, Alex Williamson wrote: > On Thu, 23 Jul 2020 08:57:11 -0700 > Sean Christopherson wrote: > > > On Tue, Jul 21, 2020 at 10:00:36AM -0600, Alex Williamson wrote: > > > On Mon, 20 Jul 2020 20:03:19 -0700 > > > Sean Christopherson wrote: > > > > > > > +We

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-23 Thread Alex Williamson
On Thu, 23 Jul 2020 08:57:11 -0700 Sean Christopherson wrote: > On Tue, Jul 21, 2020 at 10:00:36AM -0600, Alex Williamson wrote: > > On Mon, 20 Jul 2020 20:03:19 -0700 > > Sean Christopherson wrote: > > > > > +Weijiang > > > > > > On Mon, Jul 13, 2020 at 12:06:50PM -0700, Sean Christopherson

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-23 Thread Sean Christopherson
On Tue, Jul 21, 2020 at 10:00:36AM -0600, Alex Williamson wrote: > On Mon, 20 Jul 2020 20:03:19 -0700 > Sean Christopherson wrote: > > > +Weijiang > > > > On Mon, Jul 13, 2020 at 12:06:50PM -0700, Sean Christopherson wrote: > > > The only ideas I have going forward are to: > > > > > > a) Repr

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-21 Thread Alex Williamson
On Mon, 20 Jul 2020 20:03:19 -0700 Sean Christopherson wrote: > +Weijiang > > On Mon, Jul 13, 2020 at 12:06:50PM -0700, Sean Christopherson wrote: > > The only ideas I have going forward are to: > > > > a) Reproduce the bug outside of your environment and find a resource that > > can go

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-20 Thread Sean Christopherson
+Weijiang On Mon, Jul 13, 2020 at 12:06:50PM -0700, Sean Christopherson wrote: > The only ideas I have going forward are to: > > a) Reproduce the bug outside of your environment and find a resource that > can go through the painful bisection. We're trying to reproduce the original issue i

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-13 Thread Sean Christopherson
On Mon, Jul 13, 2020 at 12:22:26PM -0600, Alex Williamson wrote: > On Thu, 9 Jul 2020 21:29:22 -0700 > Sean Christopherson wrote: > > > +Alex, whom I completely spaced on Cc'ing. > > > > Alex, this is related to the dreaded VFIO memslot zapping issue from last > > year. Start of thread: https:/

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-13 Thread Alex Williamson
On Thu, 9 Jul 2020 21:29:22 -0700 Sean Christopherson wrote: > +Alex, whom I completely spaced on Cc'ing. > > Alex, this is related to the dreaded VFIO memslot zapping issue from last > year. Start of thread: https://patchwork.kernel.org/patch/11640719/. > > The TL;DR of below: can you try the

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-09 Thread Sean Christopherson
+Alex, whom I completely spaced on Cc'ing. Alex, this is related to the dreaded VFIO memslot zapping issue from last year. Start of thread: https://patchwork.kernel.org/patch/11640719/. The TL;DR of below: can you try the attached patch with your reproducer from the original bug[*]? I honestly

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-09 Thread Paolo Bonzini
On 09/07/20 23:12, Sean Christopherson wrote: >> It's bad that we have no clue what's causing the bad behavior, but I >> don't think it's wise to have a bug that is known to happen when you >> enable the capability. :/ (Note that this wasn't a NACK, though subtly so). > I don't necessarily disagr

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-09 Thread Sean Christopherson
On Wed, Jul 08, 2020 at 06:08:24PM +0200, Paolo Bonzini wrote: > On 03/07/20 04:50, Sean Christopherson wrote: > > Introduce a new capability, KVM_CAP_MEMSLOT_ZAP_CONTROL, to allow > > userspace to control the memslot zapping behavior on a per-VM basis. > > x86's default behavior is to zap all SPTE

Re: [PATCH] KVM: x86/mmu: Add capability to zap only sptes for the affected memslot

2020-07-08 Thread Paolo Bonzini
On 03/07/20 04:50, Sean Christopherson wrote: > Introduce a new capability, KVM_CAP_MEMSLOT_ZAP_CONTROL, to allow > userspace to control the memslot zapping behavior on a per-VM basis. > x86's default behavior is to zap all SPTEs, including the root shadow > page, across all memslots. While effect