Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-17 Thread Geert Uytterhoeven
Hi Maciej, On Fri, Sep 12, 2014 at 6:19 PM, Maciej Matraszek wrote: >> > (though 'runtime status' alignment seems odd). >> >> What's wrong with it? > > Nothing big, just for such short device names it doesn't look aesthetic to me > :). In legacy mode, using platform code (without DT), the devic

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-12 Thread Maciej Matraszek
On czw, 2014-09-11 at 19:27 +0200, Geert Uytterhoeven wrote: > Hi Maciej, > > On Thu, Sep 11, 2014 at 6:45 PM, Maciej Matraszek > wrote: > > BTW Can I use your output as example in the commit message for v2? > > It's much more informative > > Sure, no problem. > > > (though 'runtime status' ali

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-11 Thread Geert Uytterhoeven
Hi Maciej, On Thu, Sep 11, 2014 at 6:45 PM, Maciej Matraszek wrote: > BTW Can I use your output as example in the commit message for v2? > It's much more informative Sure, no problem. > (though 'runtime status' alignment seems odd). What's wrong with it? Gr{oetje,eeting}s,

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-11 Thread Maciej Matraszek
On Wed, 2014-09-10 at 11:27 -0700, Greg Kroah-Hartman wrote: > > > > > > > + if (!d) > > > > + return -ENOMEM; > > > > + > > > > + return 0; > > > > +} > > > > +late_initcall(pm_genpd_debug_init); > > > > +#endif /* CONFIG_PM_ADVANCED_DEBUG */ > > > > > > No tear-down of

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-11 Thread Maciej Matraszek
Hi Al! On śro, 2014-09-10 at 20:18 +0100, Al Viro wrote: > On Wed, Sep 10, 2014 at 01:28:56PM +0200, Maciej Matraszek wrote: > > > +static int pm_genpd_summary_open(struct inode *inode, struct file *file) > > +{ > > + return single_open(file, pm_genpd_summary_show, inode->i_private); >

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-11 Thread Maciej Matraszek
Hi Geert! On Thu, 2014-09-11 at 10:51 +0200, Geert Uytterhoeven wrote: > Hi Maciej, > > On Wed, Sep 10, 2014 at 1:28 PM, Maciej Matraszek > wrote: > > Add /sys/kernel/debug/pm_genpd/pm_genpd_summary file, which > > lists power domains in the system, their statuses and attached devices, > > resem

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-11 Thread Geert Uytterhoeven
Hi Maciej, On Wed, Sep 10, 2014 at 1:28 PM, Maciej Matraszek wrote: > Add /sys/kernel/debug/pm_genpd/pm_genpd_summary file, which > lists power domains in the system, their statuses and attached devices, > resembling /sys/kernel/debug/clk/clk_summary. > > Currently it is impossible to inspect (fr

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-10 Thread Al Viro
On Wed, Sep 10, 2014 at 01:28:56PM +0200, Maciej Matraszek wrote: > +static int pm_genpd_summary_open(struct inode *inode, struct file *file) > +{ > + return single_open(file, pm_genpd_summary_show, inode->i_private);

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-10 Thread Greg Kroah-Hartman
On Wed, Sep 10, 2014 at 05:38:13PM +0200, Maciej Matraszek wrote: > Hi Greg, > thanks for your reply! > > > > +static int __init pm_genpd_debug_init(void) > > > +{ > > > + struct dentry *d; > > > + > > > + pm_genpd_debugfs_dir = debugfs_create_dir("pm_genpd", NULL); > > > + > > > + /* No debugfs *

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-10 Thread Maciej Matraszek
Hi Greg, thanks for your reply! > > +static int __init pm_genpd_debug_init(void) > > +{ > > + struct dentry *d; > > + > > + pm_genpd_debugfs_dir = debugfs_create_dir("pm_genpd", NULL); > > + > > + /* No debugfs */ > > + if (IS_ERR(pm_genpd_debugfs_dir)) > > + return PTR_ERR(pm_ge

Re: [PATCH] PM / Domains: add debugfs listing of struct generic_pm_domain-s

2014-09-10 Thread Greg Kroah-Hartman
On Wed, Sep 10, 2014 at 01:28:56PM +0200, Maciej Matraszek wrote: > Add /sys/kernel/debug/pm_genpd/pm_genpd_summary file, which > lists power domains in the system, their statuses and attached devices, > resembling /sys/kernel/debug/clk/clk_summary. > > Currently it is impossible to inspect (from