Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-11-21 Thread Jonathan Cameron
On 21/11/15 18:15, Lars-Peter Clausen wrote: > On 10/09/2015 03:31 PM, Cristina Opriceana wrote: >> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig >> index 6d5b38d..85de198 100644 >> --- a/drivers/staging/iio/Kconfig >> +++ b/drivers/staging/iio/Kconfig >> @@ -17,32 +17,32

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-11-21 Thread Lars-Peter Clausen
On 10/09/2015 03:31 PM, Cristina Opriceana wrote: > diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig > index 6d5b38d..85de198 100644 > --- a/drivers/staging/iio/Kconfig > +++ b/drivers/staging/iio/Kconfig > @@ -17,32 +17,32 @@ source "drivers/staging/iio/meter/Kconfig" >

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-11-21 Thread Lars-Peter Clausen
On 10/09/2015 03:31 PM, Cristina Opriceana wrote: > diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig > index 6d5b38d..85de198 100644 > --- a/drivers/staging/iio/Kconfig > +++ b/drivers/staging/iio/Kconfig > @@ -17,32 +17,32 @@ source "drivers/staging/iio/meter/Kconfig" >

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-11-21 Thread Jonathan Cameron
On 21/11/15 18:15, Lars-Peter Clausen wrote: > On 10/09/2015 03:31 PM, Cristina Opriceana wrote: >> diff --git a/drivers/staging/iio/Kconfig b/drivers/staging/iio/Kconfig >> index 6d5b38d..85de198 100644 >> --- a/drivers/staging/iio/Kconfig >> +++ b/drivers/staging/iio/Kconfig >> @@ -17,32 +17,32

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-25 Thread Jonathan Cameron
On 09/10/15 14:31, Cristina Opriceana wrote: > This patch moves the reference IIO dummy driver from drivers/staging/iio > into a separate folder, drivers/iio/dummy and adds the proper Kconfig > and Makefile for it. > > A new config menu entry called IIO dummy driver has also been added > in the

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-25 Thread Jonathan Cameron
On 09/10/15 14:31, Cristina Opriceana wrote: > This patch moves the reference IIO dummy driver from drivers/staging/iio > into a separate folder, drivers/iio/dummy and adds the proper Kconfig > and Makefile for it. > > A new config menu entry called IIO dummy driver has also been added > in the

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-13 Thread Lars-Peter Clausen
On 10/13/2015 07:44 AM, Jonathan Cameron wrote: > > > On 12 October 2015 18:59:57 BST, Daniel Baluta > wrote: >> >> +static unsigned instances = 1; +module_param(instances, uint, 0); >> >> One concern about this. We will still create a default number of >> 'instances' >> when using

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-13 Thread Lars-Peter Clausen
On 10/13/2015 07:44 AM, Jonathan Cameron wrote: > > > On 12 October 2015 18:59:57 BST, Daniel Baluta > wrote: >> >> +static unsigned instances = 1; +module_param(instances, uint, 0); >> >> One concern about this. We will still create a default number of >>

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-12 Thread Jonathan Cameron
On 12 October 2015 18:59:57 BST, Daniel Baluta wrote: > > >>> +static unsigned instances = 1; >>> +module_param(instances, uint, 0); > >One concern about this. We will still create a default number of >'instances' >when using configuration via configfs? > >I'm not sure we can remove this

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-12 Thread Daniel Baluta
>> +static unsigned instances = 1; >> +module_param(instances, uint, 0); One concern about this. We will still create a default number of 'instances' when using configuration via configfs? I'm not sure we can remove this parameter once the module is moved out of staging, since we break the ABI

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-12 Thread Daniel Baluta
>> +static unsigned instances = 1; >> +module_param(instances, uint, 0); One concern about this. We will still create a default number of 'instances' when using configuration via configfs? I'm not sure we can remove this parameter once the module is moved out of staging, since we break the ABI

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-12 Thread Jonathan Cameron
On 12 October 2015 18:59:57 BST, Daniel Baluta wrote: > > >>> +static unsigned instances = 1; >>> +module_param(instances, uint, 0); > >One concern about this. We will still create a default number of >'instances' >when using configuration via configfs? > >I'm not sure

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-11 Thread Jonathan Cameron
On 09/10/15 14:31, Cristina Opriceana wrote: > This patch moves the reference IIO dummy driver from drivers/staging/iio > into a separate folder, drivers/iio/dummy and adds the proper Kconfig > and Makefile for it. > > A new config menu entry called IIO dummy driver has also been added > in the

Re: [PATCH] iio: Move IIO Dummy Driver out of staging

2015-10-11 Thread Jonathan Cameron
On 09/10/15 14:31, Cristina Opriceana wrote: > This patch moves the reference IIO dummy driver from drivers/staging/iio > into a separate folder, drivers/iio/dummy and adds the proper Kconfig > and Makefile for it. > > A new config menu entry called IIO dummy driver has also been added > in the