Re: [PATCH] kernel:module Fix coding style errors and warnings.

2014-10-19 Thread Rusty Russell
Ionut Alexa writes: > Fixed codin style errors and warnings. Changes printk with > print_debug/warn. Changed seq_printf to seq_puts. > > Signed-off-by: Ionut Alexa Removed the last hunk, and applied. Thanks! Rusty. > --- > kernel/module.c | 58 > ---

Re: [PATCH] kernel:module Fix coding style errors and warnings.

2014-10-16 Thread Rusty Russell
Ionut Alexa writes: > Fixed codin style errors and warnings. Changes printk with > print_debug/warn. Changed seq_printf to seq_puts. > > Signed-off-by: Ionut Alexa Hi Ionut, Please drop the following changes: > @@ -110,7 +110,7 @@ struct list_head *kdb_modules = &modules; /* kdb needs > the li

Re: [PATCH] kernel:module Fix coding style errors and warnings.

2014-10-16 Thread Joe Perches
On Thu, 2014-10-16 at 18:27 +0530, Sudip Mukherjee wrote: > On Thu, Oct 16, 2014 at 02:38:53AM -0700, Joe Perches wrote: > > On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote: > > > Fixed codin style errors and warnings. Changes printk with > > > print_debug/warn. Changed seq_printf to seq_puts.

Re: [PATCH] kernel:module Fix coding style errors and warnings.

2014-10-16 Thread Sudip Mukherjee
On Thu, Oct 16, 2014 at 02:38:53AM -0700, Joe Perches wrote: > On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote: > > Fixed codin style errors and warnings. Changes printk with > > print_debug/warn. Changed seq_printf to seq_puts. > > If you are going to do style cleanups, please make > sure yo

Re: [PATCH] kernel:module Fix coding style errors and warnings.

2014-10-16 Thread Joe Perches
On Thu, 2014-10-16 at 12:36 +0300, Ionut Alexa wrote: > Fixed codin style errors and warnings. Changes printk with > print_debug/warn. Changed seq_printf to seq_puts. If you are going to do style cleanups, please make sure you check your patches with scripts/checkpatch.pl before sending them. WAR