Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

2007-07-09 Thread Pierre Ossman
On Mon, 09 Jul 2007 14:58:16 +0200 Nicolas Ferre <[EMAIL PROTECTED]> wrote: > Fixes hanging using multi block operations (seen during CMD25). > Follows closely the datasheet flowcharts. > > This piece of code handles better big file writing. I had to take > care of the notbusy signal during write

Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

2007-07-09 Thread Nicolas Ferre
Pierre Ossman : Nicolas Ferre wrote: Fixes hanging using multi block operations (seen during CMD25). Follows closely the datasheet flowcharts. This piece of code handles better big file writing. I had to take care of the notbusy signal during write (at91_mci_handle_cmdrdy function) and to rearr

Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

2007-07-09 Thread Pierre Ossman
On Mon, 02 Jul 2007 15:32:00 +0200 Pierre Ossman <[EMAIL PROTECTED]> wrote: > Nicolas Ferre wrote: > > Fixes hanging using multi block operations (seen during CMD25). > > Follows closely the datasheet flowcharts. > > > > This piece of code handles better big file writing. I had to take > > care o

Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

2007-07-02 Thread Mariusz Kozlowski
Hello, > @@ -250,28 +246,27 @@ static void at91_mci_pre_dma_read(struct >  /* >   * Handle after a dma read >   */ > -static void at91_mci_post_dma_read(struct at91mci_host *host) > +static int at91_mci_post_dma_read(struct at91mci_host *host) >  { > struct mmc_command *cmd; > stru

Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

2007-07-02 Thread Pierre Ossman
Nicolas Ferre wrote: > Fixes hanging using multi block operations (seen during CMD25). > Follows closely the datasheet flowcharts. > > This piece of code handles better big file writing. I had to take care > of the notbusy signal during write (at91_mci_handle_cmdrdy function) and > to rearrange th

Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

2007-07-02 Thread Marc Pignat
On Monday 02 July 2007 14:16, Nicolas Ferre wrote: > Fixes hanging using multi block operations (seen during CMD25). > Signed-off-by: Nicolas Ferre <[EMAIL PROTECTED]> Verified working on at91rm9200 using 1 wire mode. A small remark, only for future improvements: > @@ -817,7 +834,11 @@ static int