Re: [PATCH] nohz: Fix local_timer_softirq_pending()

2018-07-31 Thread Frederic Weisbecker
On Tue, Jul 31, 2018 at 06:13:58PM +0200, Anna-Maria Gleixner wrote: > local_timer_softirq_pending() checks whether the timer softirq is > pending with: local_softirq_pending() & TIMER_SOFTIRQ. > > This is wrong because TIMER_SOFTIRQ is the softirq number and not a > bitmask. So the test checks fo

Re: [PATCH] nohz: Fix local_timer_softirq_pending()

2018-07-31 Thread Daniel Bristot de Oliveira
On 07/31/2018 06:13 PM, Anna-Maria Gleixner wrote: > local_timer_softirq_pending() checks whether the timer softirq is > pending with: local_softirq_pending() & TIMER_SOFTIRQ. > > This is wrong because TIMER_SOFTIRQ is the softirq number and not a > bitmask. So the test checks for the wrong bit. >

Re: [PATCH] nohz: Fix local_timer_softirq_pending()

2018-07-31 Thread Paul E. McKenney
On Tue, Jul 31, 2018 at 06:13:58PM +0200, Anna-Maria Gleixner wrote: > local_timer_softirq_pending() checks whether the timer softirq is > pending with: local_softirq_pending() & TIMER_SOFTIRQ. > > This is wrong because TIMER_SOFTIRQ is the softirq number and not a > bitmask. So the test checks fo