Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-02-05 Thread John Garry
that's fixing the issue for me, this was crashing: # perf stat -a -I 1000 -M L1D_Cache_Fill_BW,L2_Cache_Fill_BW To cover this scenario (multiple metrics listed), how about a simple addition like: >8 From bd2ded1b0ef4962a9443cd180eed4e5c5b75ae5f Mon Sep 17 00:00:00 2001 From

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-21 Thread John Garry
On 21/01/2021 20:31, Arnaldo Carvalho de Melo wrote: They are not normally broken like that. Normally we test beforehand, but these cases were missed here by me. However if you were testing them previously, then it would be expected that you had tested them again for the final patchset which was

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-21 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 20, 2021 at 09:15:54AM +, John Garry escreveu: > On 20/01/2021 05:15, Joakim Zhang wrote: > > For this patch: Tested-by: Joakim Zhang > > Hi John, Jolsa, > > Is there any way to avoid breaking exist metric expressions? If not, it > > will always happened after metricgroup change

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-20 Thread Jiri Olsa
On Tue, Jan 19, 2021 at 06:04:15PM +0800, John Garry wrote: > Joakim reports that getting "perf stat" for multiple system PMU metrics > segfaults: > ./perf stat -a -I 1000 -M imx8mm_ddr_write.all,imx8mm_ddr_write.all > Segmentation fault > > While the same works without issue for a single metric.

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-20 Thread Jiri Olsa
On Tue, Jan 19, 2021 at 05:33:13PM +, John Garry wrote: SNIP > Please try this: > > From 2380f1ef0250e6818b3dbc7bff4a868810875e2a Mon Sep 17 00:00:00 2001 > From: John Garry > Date: Tue, 19 Jan 2021 17:29:54 + > Subject: [PATCH] perf metricgroup: Fix metric support for duration_time >

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-20 Thread John Garry
On 20/01/2021 12:56, Jiri Olsa wrote: that's fixing the issue for me, this was crashing: # perf stat -a -I 1000 -M L1D_Cache_Fill_BW,L2_Cache_Fill_BW could you please send it formaly, so it can be merged? I will do it today. But I want to make sure that the logic is correct, so checking i

RE: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-20 Thread Joakim Zhang
; kj...@linux.ibm.com > Cc: linux-kernel@vger.kernel.org; linux...@openeuler.org > Subject: Re: [PATCH] perf metricgroup: Fix system PMU metrics > > On 20/01/2021 05:15, Joakim Zhang wrote: > > > >> -Original Message- > >> From: John Garry > >>

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-20 Thread John Garry
...@google.com; kj...@linux.ibm.com Cc: linux-kernel@vger.kernel.org; linux...@openeuler.org Subject: Re: [PATCH] perf metricgroup: Fix system PMU metrics On 19/01/2021 15:47, John Garry wrote: On 19/01/2021 10:56, Joakim Zhang wrote: It seems have other issue compared to 5.10 kernel after switching to

RE: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread Joakim Zhang
; kj...@linux.ibm.com > Cc: linux-kernel@vger.kernel.org; linux...@openeuler.org > Subject: Re: [PATCH] perf metricgroup: Fix system PMU metrics > > On 19/01/2021 15:47, John Garry wrote: > > On 19/01/2021 10:56, Joakim Zhang wrote: > >> It seems have other issue comp

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread John Garry
On 19/01/2021 15:47, John Garry wrote: On 19/01/2021 10:56, Joakim Zhang wrote: It seems have other issue compared to 5.10 kernel after switching to this framework, below metric can't work. "MetricExpr": "(( imx8_ddr0@read\\-cycles@ + imx8_ddr0@write\\-cycles@ ) * 4 * 4 / duration_time) / (750

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread John Garry
On 19/01/2021 10:56, Joakim Zhang wrote: It seems have other issue compared to 5.10 kernel after switching to this framework, below metric can't work. "MetricExpr": "(( imx8_ddr0@read\\-cycles@ + imx8_ddr0@write\\-cycles@ ) * 4 * 4 / duration_time) / (750 * 100 * 4 * 4)" After change to: "M

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread John Garry
On 19/01/2021 10:56, Joakim Zhang wrote: root@imx8mmevk:~# ./perf stat -a -I 1000 -M imx8mm_ddr_read.all,imx8mm_ddr_write .all # time counts unit events 1.001446500

RE: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread Joakim Zhang
; kj...@linux.ibm.com > Cc: linux-kernel@vger.kernel.org; linux...@openeuler.org > Subject: Re: [PATCH] perf metricgroup: Fix system PMU metrics > > On 19/01/2021 10:56, Joakim Zhang wrote: > >> Joakim reports that getting "perf stat" for multiple system PMU > &g

Re: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread John Garry
On 19/01/2021 10:56, Joakim Zhang wrote: Joakim reports that getting "perf stat" for multiple system PMU metrics segfaults: ./perf stat -a -I 1000 -M imx8mm_ddr_write.all,imx8mm_ddr_write.all Segmentation fault While the same works without issue for a single metric. The logic in metricgroup__ad

RE: [PATCH] perf metricgroup: Fix system PMU metrics

2021-01-19 Thread Joakim Zhang
> -Original Message- > From: John Garry > Sent: 2021年1月19日 18:04 > To: pet...@infradead.org; mi...@redhat.com; a...@kernel.org; > mark.rutl...@arm.com; alexander.shish...@linux.intel.com; > jo...@redhat.com; namhy...@kernel.org; irog...@google.com; > kj...@linux.ibm.com > Cc: linux-kernel